Re: Re: Re: [PATCH 3/3] mwifiex: debugfs: trigger device dump for usb interface

2017-12-01 Thread Brian Norris
On Fri, Dec 01, 2017 at 08:36:01AM +, Xinming Hu wrote: > Thanks for the suggestion, it sounds better than exporting > mwifiex_send_cmd() directly. > In addition to used as debugfs tirgger, the "defined point" > if_ops.device_dump is only used in command timeout context. > For sdio/pcie

Re: [PATCH V2] brcm: add CYW4373 firmwares and Cypress license file

2017-12-01 Thread Arend van Spriel
On 01-12-17 09:43, Chi-Hsien Lin wrote: Add the CYW4373 SDIO and USB firmware files, along with the corresponding Cypress license file. Just wanted to be sure. These firmware files contain a CLM to get the device operational, ie. no separate CLM download is needed. Regards, Arend

Re: Setting TX power on a monitoring interface

2017-12-01 Thread Peter Große
Hi Johannes, On Fri, 01 Dec 2017 15:49:02 +0100 Johannes Berg wrote: > On Mon, 2017-11-27 at 16:07 +0100, Peter Große wrote: > > > > I think if the driver has WANT_MONITOR_VIF, then we can pass that > > > through and let the driver sort it out. > > > > > > But if

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Maxime Bizon
On Fri, 2017-12-01 at 16:53 +0100, Christian Lamparter wrote: > "[PATCH] ath10k: fix recent bandwidth conversion bug" indeed, much better thanks -- Maxime

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Johannes Berg
On Fri, 2017-12-01 at 16:54 +0100, Toke Høiland-Jørgensen wrote: > I guess that once we have an asynchronous scheduler task of some kind, > supporting the callback is easy, but pulling the data out of each packet > needs more work. Right. > But since we'll have to do that for ath9k anyway it >

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Fri, 2017-12-01 at 16:29 +0100, Toke Høiland-Jørgensen wrote: >> >> Yeah, figures. Well, maybe we'll just have to support an asynchronous >> callback into mac80211 to register airtime usage. Will probably have to >> add some asynchronicity

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Christian Lamparter
On Friday, December 1, 2017 4:05:10 PM CET Maxime Bizon wrote: > > On Fri, 2017-12-01 at 19:18 +0530, ako...@codeaurora.org wrote: > > > Hope CONFIG_MAC80211_DEBUGFS is enabled in your build. > > it wasn't and IMHO it's confusing because tx rate is filled by the other > drivers without it. > >

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Johannes Berg
On Fri, 2017-12-01 at 16:29 +0100, Toke Høiland-Jørgensen wrote: > > Yeah, figures. Well, maybe we'll just have to support an asynchronous > callback into mac80211 to register airtime usage. Will probably have to > add some asynchronicity anyway to avoid doing too much work in the fast > path. I

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Kalle Valo
ako...@codeaurora.org writes: >>> Parse peer stats from pktlog packets and update the tx rate >>> information >>> per STA. This way user space can query about transmit rate with iw: >> >> everything works ok, ath10k_update_per_peer_tx_stats() is called and >> ath10k_sta fields are updated

Re: [EXT] Marvell Mwifiex wireless driver: mwifiex_pcie broken on Marvell ESPRESSOBin

2017-12-01 Thread Ellie Reeves
Hi, just a short message to mention I booted the 4.14 kernel and grabbed what was in /sys/class/devcoredump/devcd1/data into a file. I'm not sure if it could be useful, but did it anyways... Let me know if it's useful and I'll post the binary somewhere. Thanks Message original

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
Kalle Valo writes: >>> tx_duration is aggregate time duration of 4 PPDU sent to STA. >>> FW sends these values for retry packets also. >> >> Great, that sounds like just what we need. > > Except mapping to the iee80211_tx_status() might be difficult. I'm not > sure how

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Kalle Valo
Toke Høiland-Jørgensen writes: > ako...@codeaurora.org writes: > >> On 2017-11-30 22:08, Kalle Valo wrote: >>> Toke Høiland-Jørgensen writes: >>> >> +struct ath10k_10_2_peer_tx_stats { >> +u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >> +u8

Re: Setting TX power on a monitoring interface

2017-12-01 Thread Johannes Berg
On Mon, 2017-11-27 at 16:07 +0100, Peter Große wrote: > > I think if the driver has WANT_MONITOR_VIF, then we can pass that > > through and let the driver sort it out. > > > > But if not, we probably just have to reject the configuration? > > With passing through you mean calling

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread akolli
Hello, Thanks for verifying the patch. On 2017-12-01 16:15, Maxime Bizon wrote: On Thu, 2017-11-30 at 18:28 +0530, ako...@qti.qualcomm.com wrote: Hello, Tested on QCA9880 with firmware version 10.2.4.70.48. This should also work with firmware branch 10.2.4-1.0-00029 I tried using your

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Toke Høiland-Jørgensen
ako...@codeaurora.org writes: > On 2017-11-30 22:08, Kalle Valo wrote: >> Toke Høiland-Jørgensen writes: >> > +struct ath10k_10_2_peer_tx_stats { > + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; > + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; > + __le16

Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames

2017-12-01 Thread Luciano Coelho
On Fri, 2017-12-01 at 13:09 +0100, Johannes Berg wrote: > On Fri, 2017-12-01 at 13:48 +0200, Luciano Coelho wrote: > > > > FTR, I'm sending a separate patch with the hwsim fix, as we agreed, > > as > > part of the patchset I'm sending today. > > > > Still need a fix to the test case as well

[PATCH 0/2] iwlwifi: fixes intended for 4.15 2017-12-01

2017-12-01 Thread Luca Coelho
From: Luca Coelho Hi, This is the third batch of fixes intended for 4.15. These are the fixes: * Add 2 new PCI IDs, one for 9000 and one for 22000; * Fix a queue hang due during ROC; As usual, I'm pushing this to a pending branch, for kbuild bot, and will send a

[PATCH 1/2] iwlwifi: add new cards for 9260 and 22000 series

2017-12-01 Thread Luca Coelho
From: Ihab Zhaika add 1 PCI ID for 9260 series and 1 for 22000 series. Cc: sta...@vger.kernel.org Signed-off-by: Ihab Zhaika Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++ 1 file

[PATCH 2/2] iwlwifi: mvm: flush queue before deleting ROC

2017-12-01 Thread Luca Coelho
From: Johannes Berg Before deleting a time event (remain-on-channel instance), flush the queue so that frames cannot get stuck on it. We already flush the AUX STA queues, but a separate station is used for the P2P Device queue. Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames

2017-12-01 Thread Johannes Berg
On Fri, 2017-12-01 at 13:48 +0200, Luciano Coelho wrote: > > FTR, I'm sending a separate patch with the hwsim fix, as we agreed, as > part of the patchset I'm sending today. > Still need a fix to the test case as well though :-) johannes

[PATCH 3/3] mac80211_hwsim: enforce PS_MANUAL_POLL to be set after PS_ENABLED

2017-12-01 Thread Luca Coelho
From: Adiel Aloni Enforce using PS_MANUAL_POLL in ps hwsim debugfs to trigger a poll, only if PS_ENABLED was set before. This is required due to commit c9491367b759 ("mac80211: always update the PM state of a peer on MGMT / DATA frames") that enforces the ap to check only

[PATCH 0/3] cfg80211/mac80211 patches from our internal tree 2017-12-01

2017-12-01 Thread Luca Coelho
From: Luca Coelho Hi, Here are a few patches from our internal tree, including the fix in hwsim to prevent the test failure with Emmanuel's patch from my previous series. Please review. Cheers, Luca. Adiel Aloni (1): mac80211_hwsim: enforce PS_MANUAL_POLL to be

[PATCH 2/3] mac80211: Add MIC space only for TX key option

2017-12-01 Thread Luca Coelho
From: David Spinadel Add a key flag to indicates that the device only needs MIC space and not a real MIC. In such cases, keep the MIC zeroed for ease of debug. Signed-off-by: David Spinadel Signed-off-by: Luca Coelho

[PATCH 1/3] mac80211: don't warn on AID field without top two MSBs set

2017-12-01 Thread Luca Coelho
From: Johannes Berg While the change between 802.11-2012 and 802.11-2016 to move from requiring APs to set the two top bits to now requiring them to be cleared was apparently unintentional and will be fixed, clients should either way assume that the top five bits are

Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames

2017-12-01 Thread Luciano Coelho
On Mon, 2017-10-30 at 09:48 +0100, Johannes Berg wrote: > On Sun, 2017-10-29 at 11:51 +0200, Luca Coelho wrote: > > From: Emmanuel Grumbach > > > > The 2016 version of the spec is more generic about when the > > AP should update the power management state of the

Re: [v3 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

2017-12-01 Thread Marcel Holtmann
Hi Amitkumar, > Redpine bluetooth driver is a thin driver which depends on > 'rsi_91x' driver for transmitting and receiving packets > to/from device. It creates hci interface when attach() is > called from 'rsi_91x' module. > > Signed-off-by: Prameela Rani Garnepudi >

Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4

2017-12-01 Thread Maxime Bizon
On Thu, 2017-11-30 at 18:28 +0530, ako...@qti.qualcomm.com wrote: Hello, > Tested on QCA9880 with firmware version 10.2.4.70.48. This should also > work with firmware branch 10.2.4-1.0-00029 I tried using your patch on 4.14 with firmware 10.2.4-1.0-00029 > Parse peer stats from pktlog packets

RE: Unusual Sign ln Alert!!!

2017-12-01 Thread Salinas Mora, Jose T
Dear Outlook User, We detected something unusual about a recent sign-in to Your Microsoft Outlook Account, To help keep your account safe, we required an Update to avoid Blockage or Account Closure. You have less than 24hrs. Click the button below to continue using this service Verify

[PATCH][V2] wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM

2017-12-01 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error message text. Also remove the error message on an kzalloc failure as this is redundant. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wl1251/init.c | 4 +---

Re: [PATCH] wlcore, wl1251: fix spelling mistake: "Couldnt" -> "Couldn't"

2017-12-01 Thread Joe Perches
On Fri, 2017-12-01 at 09:34 +, Colin King wrote: > Trivial fix to spelling mistake in error message text. [] > diff --git a/drivers/net/wireless/ti/wl1251/init.c > b/drivers/net/wireless/ti/wl1251/init.c [] > @@ -311,7 +311,7 @@ static int wl1251_hw_init_data_path_config(struct wl1251 > *wl)

[PATCH] wlcore, wl1251: fix spelling mistake: "Couldnt" -> "Couldn't"

2017-12-01 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wl1251/init.c | 2 +- drivers/net/wireless/ti/wlcore/acx.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH] brcm: add CYW4373 firmwares and Cypress license file

2017-12-01 Thread Chi-Hsien Lin
On 12/01/2017 4:28, Arend van Spriel wrote: On 12/1/2017 8:33 AM, Chi-Hsien Lin wrote: Add the CYW4373 SDIO and USB firmware files, alone with the corresponding 'alone' should be 'along'. Thanks a lot for catching this. I've submitted V2. Chi-hsien Lin

Re: [PATCH] brcmfmac: Add sg parameters dts parsing

2017-12-01 Thread Arend van Spriel
On 12/1/2017 8:55 AM, Chi-Hsien Lin wrote: broken_sg_support, sd_head_align, and sd_sgentry_align are used in brcmfmac code but not configurable in dts file. Add the parsing logic. Now they can be configured like below in dts: brcm,broken_sg_support; brcm,sd_head_align =/bits/

Re: Re: Re: [PATCH 3/3] mwifiex: debugfs: trigger device dump for usb interface

2017-12-01 Thread Xinming Hu
Hi Brian, > -Original Message- > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: 2017年12月1日 0:33 > To: Xinming Hu > Cc: Xinming Hu ; Linux Wireless > ; Kalle Valo ; Dmitry >