[PATCH] iwlwifi: pcie: fix DMA memory mapping / unmapping

2018-01-03 Thread Emmanuel Grumbach
22000 devices (previously referenced as A000) can support short transmit queues. This means that we have less DMA descriptors (TFD) for those shorter queues. Previous devices must still have 256 TFDs for each queue even if those 256 TFDs point to fewer buffers. When I introduced support for the

Re: [RFC 0/4] EAPoL over NL80211

2018-01-03 Thread Denis Kenzior
Hi Arend, On 01/03/2018 02:24 PM, Arend Van Spriel wrote: On Tue, Jan 2, 2018 at 2:27 PM, Johannes Berg wrote: On Fri, 2017-12-29 at 12:29 -0600, Denis Kenzior wrote: Agreed, requiring both attributes is less than ideal, but I tried to make the initial RFC as

Re: [RFC 4/4] nl80211: Implement TX of control port frames

2018-01-03 Thread Denis Kenzior
Hi Arend, So essentially we'd need a new operation in cfg80211_ops that would accept the control port frame data and some control flags. Do we want to pass in an skb with all the 802.11 headers set or a 802.3 formatted skb (since that is what other data frames look like initially on the

Re: [PATCH] rtlwifi: rtl8723de: Add firmware for new driver/device

2018-01-03 Thread Josh Boyer
On Tue, Jan 2, 2018 at 7:44 PM, Larry Finger wrote: > A driver for the RTL8723DE is nearing submission to staging. This commit > supplies > the firmware for it. > > Signed-off-by: Larry Finger > Cc: Ping-Ke Shih > --- >

[PATCH 1/2] wireless: libertas_tf: Delete an error message for a failed memory allocation in __if_usb_submit_rx_urb()

2018-01-03 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 3 Jan 2018 20:55:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [RFC 4/4] nl80211: Implement TX of control port frames

2018-01-03 Thread Johannes Berg
Hi, > > > If so, can we do something like what ieee80211_process_sa_query_req in > > > net/mac80211/rx.c or ieee80211_tdls_prep_mgmt_packet in > > > net/mac80211/tdls.c do? E.g. use ieee80211_tx_skb or > > > __ieee80211_subif_start_xmit or similar to inject the skb with the > > > DONT_ENCRYPT

[PATCH 2/2] wireless: libertas_tf: Improve a size determination in two functions

2018-01-03 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 3 Jan 2018 21:02:17 +0100 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [RFC 0/4] EAPoL over NL80211

2018-01-03 Thread Arend Van Spriel
On Tue, Jan 2, 2018 at 2:27 PM, Johannes Berg wrote: > On Fri, 2017-12-29 at 12:29 -0600, Denis Kenzior wrote: > >> Agreed, requiring both attributes is less than ideal, but I tried to >> make the initial RFC as minimal as possible. It also helped that iwd >> uses

Re: [RFC 4/4] nl80211: Implement TX of control port frames

2018-01-03 Thread Arend Van Spriel
On Wed, Jan 3, 2018 at 6:17 PM, Denis Kenzior wrote: > Hi Johannes, > > > >>> If so, can we do something like what ieee80211_process_sa_query_req in >>> net/mac80211/rx.c or ieee80211_tdls_prep_mgmt_packet in >>> net/mac80211/tdls.c do? E.g. use ieee80211_tx_skb or >>>

[PATCH 0/2] wireless: libertas_tf: Adjustments for three function implementations

2018-01-03 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 3 Jan 2018 21:06:54 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in __if_usb_submit_rx_urb() Improve a size

Re: [PATCH] rtlwifi: rtl8192cu adds device ids

2018-01-03 Thread Carlos Garces
On Mon, Jan 1, 2018 at 6:32 PM, Larry Finger wrote: > On 12/29/2017 05:38 PM, Carlos Garces wrote: >> >> Hi. >> >> This patch add some device ids from >> https://github.com/pvaret/rtl8192cu-fixes >> That is the repository used by some projects like LibreElec. >> >> Note

Re: iwlwifi: mvm: rx ops with kernel >= 4.14

2018-01-03 Thread Emmanuel Grumbach
Hi, > > hi, > > after updating to kernel >= 4.14 (from 4.13.X) my wifi stops working every > couple hours with the following stacktrace (I've already updated firmware to > latest version): > > jan 03 13:28:17 tmi kernel: iwlwifi :3b:00.0: loaded firmware version > 17.608620.0 op_mode

iwlwifi: mvm: rx ops with kernel >= 4.14

2018-01-03 Thread Dawid Stawiarski
hi, after updating to kernel >= 4.14 (from 4.13.X) my wifi stops working every couple hours with the following stacktrace (I've already updated firmware to latest version): jan 03 13:28:17 tmi kernel: iwlwifi :3b:00.0: loaded firmware version 17.608620.0 op_mode iwlmvm jan 03 13:28:17 tmi

Re: [RFC 4/4] nl80211: Implement TX of control port frames

2018-01-03 Thread Denis Kenzior
Hi Johannes, If so, can we do something like what ieee80211_process_sa_query_req in net/mac80211/rx.c or ieee80211_tdls_prep_mgmt_packet in net/mac80211/tdls.c do? E.g. use ieee80211_tx_skb or __ieee80211_subif_start_xmit or similar to inject the skb with the DONT_ENCRYPT flag? Yes, this

RE: UBSAN: Undefined behaviour in net/wireless/nl80211.c:718:4: -1665903437 * 100 cannot be represented in type 'int'

2018-01-03 Thread Mario.Limonciello
> -Original Message- > From: Paul Menzel [mailto:pmenzel+linux-wirel...@molgen.mpg.de] > Sent: Wednesday, January 3, 2018 10:20 AM > To: Johannes Berg > Cc: linux-wireless@vger.kernel.org; linux-ker...@vger.kernel.org; it+linux- > wirel...@molgen.mpg.de;

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-01-03 Thread Enrico Mioso
I'll apply your patch and let you know. Thank you very very much for your help, patience, and re-posting the patch. Your work is very valuable, sorry for the slowness and not testing this before. Enrico On Wed, 3 Jan 2018, Stanislaw Gruszka wrote: Date: Wed, 3 Jan 2018 12:35:41 From:

Re: [PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

2018-01-03 Thread Stanislaw Gruszka
On Fri, Dec 29, 2017 at 10:18:14PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2017 22:11:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-01-03 Thread Stanislaw Gruszka
On Tue, Dec 26, 2017 at 06:20:22PM +0100, Enrico Mioso wrote: > Ok, observing a stall. Unfortunately, it still happens. > rt2800_wmac 1018.wmac: loaded eeprom from mtd device "factory" > ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 2872, rev 0200 detected > ieee80211 phy0: rt2x00_set_rf:

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-01-03 Thread Stanislaw Gruszka
Hi On Sun, Dec 24, 2017 at 01:19:06PM +0100, Enrico Mioso wrote: > Unfortunately, the error di appear again. Still, I experienced no stalls. > But i am starting to think this doesn't happen necessarily when a device is > going out of range. Now I think I don't know when this triggers. > Sun