Re: [RFC v2 1/4] mac80211: Add TXQ scheduling API

2018-07-30 Thread Rajkumar Manoharan
On 2018-07-30 15:48, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Hmm, the driver really shouldn't need to do any locking apart from using the next_txq() API. But I think you are right that the seqno mechanism doesn't play well with unserialised access to through next_txq() from

Re: [RFC v2 1/4] mac80211: Add TXQ scheduling API

2018-07-30 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: >>> A simple change in argument may break algo. What would be seqno of >>> first packet of txq if queue_skb() isn't reset seqno? >> >> It would be 0, which would be less than the current seqno in all cases >> except just when the seqno counter wraps. >> > > One point

Re: [RFC v2 1/4] mac80211: Add TXQ scheduling API

2018-07-30 Thread Rajkumar Manoharan
On 2018-07-24 04:08, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Sorry for the late reply. I would prefer to keep separate list for each AC ;) Prepared one on top of your earlier merged changes. Now it needs revisit. Fine with me. Only reason I used a single list + the

Re: ath9k and 16 VAP interfaces?

2018-07-30 Thread Tom Psyborg
this is how i enabled it on htc target: https://github.com/torvalds/linux/pull/574 On 30 July 2018 at 16:34, Ben Greear wrote: > > > On 07/30/2018 04:13 AM, Matthias May wrote: > >> On 30/07/18 11:40, michael-...@fami-braun.de wrote: >> >>> Do you mean AP interfaces as required for multiple

Re: [PATCH 4/9] ath9k: fix moredata bit in PS buffered frame release

2018-07-30 Thread Kalle Valo
Felix Fietkau writes: > Signed-off-by: Felix Fietkau No empty commit logs, please. What kind of bug does this fix? I can add that to the commit log. -- Kalle Valo

Re: [PATCH 3/9] ath9k: force rx_clear when disabling rx

2018-07-30 Thread Kalle Valo
Felix Fietkau writes: > From: Felix Fietkau > > This makes stopping Rx more reliable and should reduce the frequency of > Rx related DMA stop warnings. Don't use rx_clear in TX99 mode. > > Signed-off-by: Felix Fietkau > Signed-off-by: Helmut Schaa > --- > drivers/net/wireless/ath/ath9k/mac.c

Re: ath10k SWBA overrun / tx credit starvation

2018-07-30 Thread Ben Greear
On 07/30/2018 01:12 AM, Martin Willi wrote: Hi, We are experiencing some issues when running ath10k in AP mode. Unfortunately, I didn't manage to reproduce the issue in the lab, but in the field we see it roughly once a day on one out of fifty devices. The symptoms are the logged "SWBA

Re: ath9k and 16 VAP interfaces?

2018-07-30 Thread Ben Greear
On 07/30/2018 04:13 AM, Matthias May wrote: On 30/07/18 11:40, michael-...@fami-braun.de wrote: Do you mean AP interfaces as required for multiple BSS/SSIDs? I'm running a patched ath9k to have hostapd run >8 BSS on a single radio. It works fine since years. Yes, I'd love to see any

Re: [PATCH] mt76x2: fix CCK protection control frame rate

2018-07-30 Thread Kalle Valo
Lorenzo Bianconi wrote: > Use 11M as tx rate for CCK protection control frames > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi Patch applied to wireless-drivers-next.git, thanks. d0db2f7a02e4 mt76x2: fix CCK protection control frame rate --

Re: [PATCH] mt76x2: add frame protection support

2018-07-30 Thread Kalle Valo
Lorenzo Bianconi wrote: > Introduce mac80211 rts threshold handler in order to add frame > protection support to mt76x2 driver > > Signed-off-by: Lorenzo Bianconi Patch applied to wireless-drivers-next.git, thanks. f24909ab3943 mt76x2: add frame protection support --

Re: [PATCH 1/2] mt7601u: use sw encryption for hw unsupported ciphers

2018-07-30 Thread Kalle Valo
Lorenzo Bianconi wrote: > Fall back to software encryption for hw unsupported ciphers in order > to enable 802.11w > > Signed-off-by: Lorenzo Bianconi 2 patches applied to wireless-drivers-next.git, thanks. 03d677c50ad7 mt7601u: use sw encryption for hw unsupported ciphers 53c2cb8df327

Re: [PATCH 01/19] mt76: move MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO defs in dma.h

2018-07-30 Thread Kalle Valo
Lorenzo Bianconi wrote: > Since MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO definitions are in > common between mt76x2u, mt76x2 and mt76x0u move them in dma.h in order > to reuse usb code supporting mt76x2u and mt76x0u based devices > > Signed-off-by: Lorenzo Bianconi Dropping as Lorenzo

Re: [PATCH 6/6] qtnfmac: implement basic WoWLAN support

2018-07-30 Thread Kalle Valo
Sergey Matyukevich wrote: > This patch implements core WoWLAN support in qtnfmac driver, including > processing of WoWLAN features reported by firmware and implementation > of cfg80211 suspend/resume/wakeup callbacks. Currently the following > WoWLAN triggers are supported: disconnect, magic

Re: [PATCH 3/6] qtnfmac: implement cfg80211 power management callback

2018-07-30 Thread Kalle Valo
Sergey Matyukevich wrote: > From: Sergei Maksimenko > > Implement set_power_mgmt() callback that forwards power saving > settings to the device firmware. > > Signed-off-by: Sergei Maksimenko 2 patches applied to wireless-drivers-next.git, thanks. 4775ad06b56a qtnfmac: implement cfg80211

Re: [PATCH 5/6] qtnfmac: add support for PTA configuration

2018-07-30 Thread Kalle Valo
Sergey Matyukevich writes: > From: Andrey Shevchenko > > Implement support for PTA (Packet Traffic Arbitration) configuration. > The PTA mechanism is used to coordinate sharing of the medium between > WiFi and other 2.4 wireless networks, e.g. Bluetooth or ZigBee. > > This patch implements core

Re: [PATCH 3/6] qtnfmac: implement cfg80211 power management callback

2018-07-30 Thread Kalle Valo
Sergey Matyukevich writes: > From: Sergei Maksimenko > > Implement set_power_mgmt() callback that forwards power saving > settings to the device firmware. > > Signed-off-by: Sergei Maksimenko [...] > @@ -922,6 +939,9 @@ struct wiphy *qtnf_wiphy_allocate(struct qtnf_bus *bus) > if

Re: pull-request: iwlwifi-next 2018-05-30

2018-07-30 Thread Kalle Valo
Luca Coelho writes: > This is the first batch of patches intended for v4.19. It includes the > two patches sets I sent a few weeks ago, with HE support and new > hardware (22560) support. More details about the contents in the tag > description. > > I have sent this out before and kbuildbot

disconnection regression in 4.17?

2018-07-30 Thread Jason A. Donenfeld
Hello, I'm seeing quite frequent but fairly irregular disconnections in 4.17 that I was not seeing in 4.16, even when sitting directly next to the AP. Below is a debug log; let me know if there's a better way to debug this. (Previously 4.17 was totally borked until I submitted

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

2018-07-30 Thread Dan Carpenter
On Mon, Jul 30, 2018 at 03:40:24PM +0530, Ajay Singh wrote: > Hi Dan, > > On Mon, 30 Jul 2018 11:41:13 +0300 > Dan Carpenter wrote: > > > On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > > > Hi Dan, > > > > > > On Thu, 19 Jul 2018 12:27:44 +0300 > > > Dan Carpenter wrote: > > >

Re: ath9k and 16 VAP interfaces?

2018-07-30 Thread Matthias May
On 30/07/18 11:40, michael-...@fami-braun.de wrote: > Do you mean AP interfaces as required for multiple BSS/SSIDs? > > I'm running a patched ath9k to have hostapd run >8 BSS on a single radio. > It works fine since years. > > Regards, > M. Braun > > > Am 27. Juli 2018 15:35:28 MESZ schrieb

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

2018-07-30 Thread Ajay Singh
Hi Dan, On Mon, 30 Jul 2018 11:41:13 +0300 Dan Carpenter wrote: > On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > > Hi Dan, > > > > On Thu, 19 Jul 2018 12:27:44 +0300 > > Dan Carpenter wrote: > > > > > On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote: > > > > diff

Re: ath9k and 16 VAP interfaces?

2018-07-30 Thread michael-dev
Do you mean AP interfaces as required for multiple BSS/SSIDs? I'm running a patched ath9k to have hostapd run >8 BSS on a single radio. It works fine since years. Regards, M. Braun Am 27. Juli 2018 15:35:28 MESZ schrieb Ben Greear : >Hello, > >Has anyone tried making ath9k able to support 16

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

2018-07-30 Thread Dan Carpenter
On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > Hi Dan, > > On Thu, 19 Jul 2018 12:27:44 +0300 > Dan Carpenter wrote: > > > On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote: > > > diff --git a/drivers/staging/wilc1000/wilc_wlan.c > > >

ath10k SWBA overrun / tx credit starvation

2018-07-30 Thread Martin Willi
Hi, We are experiencing some issues when running ath10k in AP mode. Unfortunately, I didn't manage to reproduce the issue in the lab, but in the field we see it roughly once a day on one out of fifty devices. The symptoms are the logged "SWBA overruns" followed by a kernel WARNING when removing

Re: [PATCH v4] PCI: Add PCI_DEVICE_DATA() macro to fully describe device ID entry

2018-07-30 Thread Kalle Valo
Andy Shevchenko writes: > There are a lot of examples in the kernel where PCI_VDEVICE() is used and > still > looks not so convenient due to additional driver_data field attached. > > Introduce PCI_DEVICE_DATA() macro to fully describe device ID entry in > shortest > possible form. For

[PATCH] mac80211: allow station search on AP/VLANs

2018-07-30 Thread Manikanta Pubbisetty
When mac80211 receives a packet, we interate over the list of active interfaces to find the station(which transmitted the packet). Currently, station search is not allowed on AP/VLAN interface; since stations can also get mapped to AP/VLAN interfaces, they are worth considering for station search.