[PATCH] staging: wilc1000: fix for undefined reference to `__this_module' error

2018-08-12 Thread Ajay Singh
wilc_debugfs.o object file is included for both SDIO and SPI module. When anyone(either SDIO or SPI) module is compiled as loaded module and another as builtin module then below compilation error occurs. "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined reference to

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

2018-08-12 Thread Ajay Singh
Hi Greg, On Sun, 12 Aug 2018 17:24:21 +0200 Greg KH wrote: > On Sun, Aug 12, 2018 at 05:18:29PM +0530, Ajay Singh wrote: > > Hi Greg, > > > > On Sun, 12 Aug 2018 13:29:30 +0200 > > Greg KH wrote: > > > > > On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > > > > Refactor code by

Re: use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue

2018-08-12 Thread Ben Greear
On 08/02/2018 01:20 PM, Toke Høiland-Jørgensen wrote: Ben Greear writes: On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote: Ben Greear writes: This is from my hacked kernel, could be my fault. I thought the fq guys might want to know however... Hmm, nothing obvious comes to mind;

Cpu stall caused by hostapd running two interfaces

2018-08-12 Thread Grzegorz Duszyński
Hello, I'm running into problems while trying to start AP's on 2 interfaces. Devices are: - Compex WLE900VX (QCA9880) - Killer 1535 (QCA6174) The 1535 is a new addition to the system. Compex by itself runs fine, Killer also can run alone. But when running them together all hell breaks lose.

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 05:18:29PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 13:29:30 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > > > Refactor code by removing array of 'wilc_debugfs_info_t' type and > > > use single variable to

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 05:48:52PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 13:35:55 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > > wilc_debug.o object file is included for both SDIO and SPI module. > > > When anyone(either SDIO

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Ajay Singh
Hi Greg, On Sun, 12 Aug 2018 13:35:55 +0200 Greg KH wrote: > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > wilc_debug.o object file is included for both SDIO and SPI module. > > When anyone(either SDIO or SPI) module is compiled as loaded module > > and another as buildin

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

2018-08-12 Thread Ajay Singh
Hi Greg, On Sun, 12 Aug 2018 13:29:30 +0200 Greg KH wrote: > On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > > Refactor code by removing array of 'wilc_debugfs_info_t' type and > > use single variable to store 'wilc_debugfs_info_t' struct value. > > > > Signed-off-by: Ajay Singh

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >

Re: [PATCH 4/5] staging: wilc1000: change permission to 0600 in debugfs_create_file() call

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 10:17:44AM +0530, Ajay Singh wrote: > Cleanup patch to use more restrictive access permission for debugfs > file. Why? What is the harm in writing to a value that is never used? :) thanks, greg k-h

Re: [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote: > Refactor code by removing array of 'wilc_debugfs_info_t' type and use > single variable to store 'wilc_debugfs_info_t' struct value. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_debugfs.c | 26

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 04:52:04PM +0530, Ajay Singh wrote: > Hi Greg, > > On Sun, 12 Aug 2018 08:42:50 +0200 > Greg KH wrote: > > > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > > wilc_debug.o object file is included for both SDIO and SPI module. > > > When anyone(either SDIO

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Ajay Singh
Hi Greg, On Sun, 12 Aug 2018 08:42:50 +0200 Greg KH wrote: > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > > wilc_debug.o object file is included for both SDIO and SPI module. > > When anyone(either SDIO or SPI) module is compiled as loaded module > > and another as buildin

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-12 Thread Greg KH
On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote: > wilc_debug.o object file is included for both SDIO and SPI module. When > anyone(either SDIO or SPI) module is compiled as loaded module and another > as buildin module then below compilation error occurs. > >