Re: [RFC v4 08/13] rtw88: debug files

2018-11-03 Thread Joe Perches
On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > Joe Perches writes: [] > > > It's very unusual to have _all_ the logging under a CONFIG__DEBUG > > > config guard flag. > > > > For wireless drivers that is actually quite typical. >

Re: [RFC v5 08/13] rtw88: debug files

2018-11-03 Thread Joe Perches
On Wed, 2018-10-31 at 18:12 +0800, yhchu...@realtek.com wrote > From: Yan-Hsuan Chuang > debug files for Realtek 802.11ac wireless network chips [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.h > b/drivers/net/wireless/realtek/rtw88/debug.h [] > +#ifdef CONFIG_RTW88_DEBUG [] > +#else