Re: [PATCH 3/3] staging: wilc1000: Remove unnecessary array index check

On Sun, 6 May 2018 00:33:33 -0700 Nathan Chancellor <natechancel...@gmail.com> wrote: > This statment triggers GCC's -Wtype-limit since key_index is an > unsigned integer so it cannot be less than zero. > > Signed-off-by: Nathan Chancellor <natechancel...@gmail.com>

Re: [PATCH 2/3] staging: wilc1000: Remove useless function

ne if statement. > > Signed-off-by: Nathan Chancellor <natechancel...@gmail.com> Reviewed-by: Ajay Singh <ajay.kat...@microchip.com> > --- > drivers/staging/wilc1000/host_interface.c | 12 > drivers/staging/wilc1000/host_interface.h

Re: [PATCH 1/3] staging: wilc1000: Remove unused variables

Thank you for the patch series. On Sun, 6 May 2018 00:33:31 -0700 Nathan Chancellor <natechancel...@gmail.com> wrote: > GCC warns these variables are all set but never used so remove them. > > Signed-off-by: Nathan Chancellor <natechancel...@gmail.com> Reviewed-by:

[PATCH 19/30] staging: wilc1000: fix line over 80 chars in wilc_create_wiphy() declaration

Fix line over 80 characters issue found by checkpatch.pl script in function declaration. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wi

[PATCH 24/30] staging: wilc1000: refactor del_station() to avoid parenthesis misalignment

Refactor the code to fix open parenthesis alignment issue reported by checkpatch.pl script in del_station(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-)

[PATCH 20/30] staging: wilc1000: fix line over 80 characters in add_key()

Fix line over 80 character issue found by checkpatch.pl script in add_key(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/s

[PATCH 22/30] staging: wilc1000: fix line over 80 chars issue in connect()

Fix line over 80 characters in connect() by using temporary variables. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 29 +-- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/s

[PATCH 21/30] staging: wilc1000: fix line over 80 chars in scan()

Fix line over 80 characters issues found by checkpatch.pl script with the help of local variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 07/30] staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()

Split host_int_parse_join_bss_param() to avoid the line over 80 character issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 247 -- 1 file changed, 131 insertions(+

[PATCH 12/30] staging: wilc1000: use kmalloc(sizeof(*mgmt_tx)...) in mgmt_tx()

Fix below checkpatch issue found in mgmt_tx() Prefer kmalloc(sizeof(*mgmt_tx)...) over kmalloc(sizeof(struct p2p_mgmt_data)...) Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Fix line over 80 characters issue reported by checkpatch in add_network_to_shadow() by using temporary variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 52 +++ 1 file changed, 25 insertions(

[PATCH 10/30] staging: wilc1000: fix line over 80 chars in linux_mon

Fix line over 80 char issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_mon.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/s

[PATCH 18/30] staging: wilc1000: fix line over 80 chars in get_station()

Fix line over 80 characters issue in get_station(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/d

[PATCH 03/30] staging: wilc1000: fix line over 80 chars in handle_key()

Fix checkpatch reported issue of line over 80 char in handle_key(). Introduced new functions by spliting existing function to address the checkpatch issue. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 59 +++-

[PATCH 05/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

Fix line over 80 characters issue reported by checkpatch.pl in host_int_parse_assoc_resp_info(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 37 ++- 1 file changed, 21 insertions(+), 16 deletions(-) diff

[PATCH 02/30] staging: wilc1000: remove 'ret' variable in handle_key()

Remove the use of unnecessary 'ret' variable and use existing 'result' variable to hold the status. Also changed type of 'result' from s32 to int to confirm with the function return type. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.

[PATCH 11/30] staging: wilc1000: use sizeof(*wdev) to allocate memory in wilc_wfi_cfg_alloc()

Fix below reported checkpatch issues in wilc_wfi_cfg_alloc(). kzalloc(sizeof(*wdev)...) over kzalloc(sizeof(struct wireless_dev) Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 13/30] staging: wilc1000: rename clear_duringIP() to avoid camelCase issue

Rename clear_duringIP() function to avoid camelCase issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wi

[PATCH 09/30] staging: wilc1000: rename kmalloc with kmemdup() in handle_connect_timeout()

Instead of kmalloc and memcpy use kmemdup in handle_connect_timeout(). Also return -ENOMEM incase of failure to allocate the memory. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 del

[PATCH 08/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

Fix line over 80 characters issue in host_int_parse_assoc_resp_info() by using shorter name for the local variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 16/30] staging: wilc1000: fix line over 80 charas in wilc_wfi_remain_on_channel_expired()

Refactor wilc_wfi_remain_on_channel_expired() to avoid line over 80 character issue reported by checkpatch.pl script. Also assigned value in the variable at the time of declaration. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[PATCH 15/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 17/30] staging: wilc1000: fix line over 80 chars in wilc_wfi_cfg_tx_vendor_spec()

Fix line over 80 characters issues reported by checkpatch.pl script in wilc_wfi_cfg_tx_vendor_spec() by using temporary variable. Simplified 'if else' condition with 'if'. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[PATCH 01/30] staging: wilc1000: added complete() call for error scenario in handle_key()

During memory allocation failure in handle_key() the complete() was not called for comp_test_key_block event. So now added the code to call complete() for event during error scenario. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.

[PATCH 25/30] staging: wilc1000: fix line over 80 chars in wilc_sdio struct

Fix line over 80 chars issue found by checkpatch.pl script by placing the comment message above the macro preprocessor. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_sdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 27/30] staging: wilc1000: remove 'flag' argument from wilc_mac_indicate()

in resolving the line over 80 chars issue found by checkatpch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_wlan.c | 17 +++-- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_

[PATCH 26/30] staging: wilc1000: added #define for setting radiotap header

Added new macro to resolve below checkpatch issues in linux_mon. "Lines should not end with a '('" Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_mon.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a

[PATCH 29/30] staging: wilc1000: remove unused 'lock' varible in 'wilc_priv' structure

Cleanup patch to remove the unused variable from 'wilc_priv' structure. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/s

[PATCH 23/30] staging: wilc1000: rename u8security to avoid datatype in variable name

Cleanup patch to avoid use of datatype in variable name to follow as per linux coding style. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH 30/30] staging: wilc1000: rename s8idxarray to avoid datatype in variable name

Cleanup patch to have variable names as per linux coding style. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/d

[PATCH 28/30] staging: wilc1000: added comments for mutex and spinlock_t

Added comments for mutex and spinlock_t to avoid checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-)

[PATCH 00/30] staging: wilc1000: checkpatch fixes and code cleanup

This patch series contains modification to remove checkpatch related issues, mainly related to 'line over 80 chars'. We are left with around '5' checkpatch warnings in WILC1000. Also code cleanup related change to follow as per linux coding style are included in this patch series. Ajay Singh

[PATCH 04/30] staging: wilc1000: fix line over 80 characters issue in handle_connect()

Fix line over 80 character issue found by checkpatch.pl script by aligning the input argument in function call. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/d

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Hi Claudiu, On Mon, 14 May 2018 11:57:24 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > Hi Ajay, > > On 10.05.2018 08:27, Claudiu Beznea wrote: > > > > > > On 09.05.2018 21:42, Ajay Singh wrote: > >> On Wed, 9 May 2018 16:43

Re: [PATCH 06/30] staging: wilc1000: fix line over 80 chars issue in host_int_handle_disconnect()

On Wed, 9 May 2018 16:44:13 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix line over 80 char issue in host_int_handle_disconnect() by using > > temp variable to hold the 'wilc_connect_result' function pointer

Re: [PATCH 07/30] staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()

On Wed, 9 May 2018 16:43:59 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Split host_int_parse_join_bss_param() to avoid the line over 80 > > character issue reported by checkpatch.pl script. > > > > Si

Re: [PATCH 08/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

On Wed, 9 May 2018 16:43:37 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix line over 80 characters issue in > > host_int_parse_assoc_resp_info() by using shorter name for the > > local variable. > &g

Re: [PATCH 03/30] staging: wilc1000: fix line over 80 chars in handle_key()

On Wed, 9 May 2018 16:44:47 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix checkpatch reported issue of line over 80 char in handle_key(). > > Introduced new functions by spliting existing function to address >

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

On Wed, 9 May 2018 16:43:14 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix line over 80 characters issue reported by checkpatch in > > add_network_to_shadow() by using temporary variable. > > I, pers

Re: [PATCH 17/30] staging: wilc1000: fix line over 80 chars in wilc_wfi_cfg_tx_vendor_spec()

On Wed, 9 May 2018 16:42:45 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix line over 80 characters issues reported by checkpatch.pl script > > in wilc_wfi_cfg_tx_vendor_spec() by using temporary variable. &g

Re: [PATCH 30/30] staging: wilc1000: rename s8idxarray to avoid datatype in variable name

On Wed, 9 May 2018 16:42:20 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Cleanup patch to have variable names as per linux coding style. > > > > Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> >

Re: [PATCH 05/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

On Wed, 9 May 2018 16:44:38 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Fix line over 80 characters issue reported by checkpatch.pl in > > host_int_parse_assoc_resp_info(). > > > > Signed-off-by: Ajay

Re: [PATCH 15/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

On Wed, 9 May 2018 16:42:59 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 07.05.2018 11:43, Ajay Singh wrote: > > Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow(). > > > > Signed-off-by: Ajay Singh <ajay.kat...@microchip

Re: [PATCH 15/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

On Thu, 10 May 2018 08:35:29 +0300 Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > On 09.05.2018 22:17, Ajay Singh wrote: > > On Wed, 9 May 2018 16:42:59 +0300 > > Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > > > >> On 07.05.2018 11

[PATCH v2 20/30] staging: wilc1000: fix line over 80 chars in scan()

Fix line over 80 characters issues found by checkpatch.pl script with the help of local variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH v2 10/30] staging: wilc1000: use sizeof(*wdev) to allocate memory in wilc_wfi_cfg_alloc()

Fix below reported checkpatch issues in wilc_wfi_cfg_alloc(). kzalloc(sizeof(*wdev)...) over kzalloc(sizeof(struct wireless_dev) Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 19/30] staging: wilc1000: fix line over 80 characters in add_key()

Fix line over 80 character issue found by checkpatch.pl script in add_key(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/s

[PATCH v2 28/30] staging: wilc1000: remove unused 'lock' varible in 'wilc_priv' structure

Cleanup patch to remove the unused variable from 'wilc_priv' structure. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/s

[PATCH v2 25/30] staging: wilc1000: added #define for setting radiotap header

Added new macro to resolve below checkpatch issues in linux_mon. "Lines should not end with a '('" Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_mon.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 24/30] staging: wilc1000: fix line over 80 chars in wilc_sdio struct

Fix line over 80 chars issue found by checkpatch.pl script by placing the comment message above the macro preprocessor. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_sdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 23/30] staging: wilc1000: refactor del_station() to avoid parenthesis misalignment

Refactor the code to fix open parenthesis alignment issue reported by checkpatch.pl script in del_station(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-)

[PATCH v2 11/30] staging: wilc1000: use kmalloc(sizeof(*mgmt_tx)...) in mgmt_tx()

Fix below checkpatch issue found in mgmt_tx() Prefer kmalloc(sizeof(*mgmt_tx)...) over kmalloc(sizeof(struct p2p_mgmt_data)...) Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 22/30] staging: wilc1000: rename u8security to avoid datatype in variable name

Cleanup patch to avoid use of datatype in variable name to follow as per linux coding style. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v2 21/30] staging: wilc1000: fix line over 80 chars issue in connect()

Fix line over 80 characters in connect() by using temporary variables. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 29 +-- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/s

[PATCH v2 01/30] staging: wilc1000: added complete() call for error scenario in handle_key()

During memory allocation failure in handle_key() the complete() was not called for comp_test_key_block event. So now added the code to call complete() for event during error scenario. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.

[PATCH v2 05/30] staging: wilc1000: fix line over 80 chars issue in host_int_handle_disconnect()

Fix line over 80 char issue in host_int_handle_disconnect() by using temp variable to hold the 'wilc_connect_result' function pointer. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 del

[PATCH v2 06/30] staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()

Split host_int_parse_join_bss_param() to avoid the line over 80 character issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 247 -- 1 file changed, 131 insertions(+

[PATCH v2 00/30] staging: wilc1000: checkpatch fixes and code cleanup

review comments. - Included changes for patch# 13, 15, 28 & 30 based on review comments please refer patch# 12, 14, 27 & 29 in current updates series because one patch is dropped in between. - Corrected commit summary and description for patch#8 & #26 in updates series.

[PATCH v2 07/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

Fix line over 80 characters issue in host_int_parse_assoc_resp_info() by using shorter name for the local variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH v2 02/30] staging: wilc1000: remove 'ret' variable in handle_key()

Remove the use of unnecessary 'ret' variable and use existing 'result' variable to hold the status. Also changed type of 'result' from s32 to int to confirm with the function return type. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.

[PATCH v2 08/30] staging: wilc1000: replace kmalloc with kmemdup() in handle_connect_timeout()

Instead of kmalloc and memcpy use kmemdup in handle_connect_timeout(). Also return -ENOMEM incase of failure to allocate the memory. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 del

[PATCH v2 04/30] staging: wilc1000: fix line over 80 characters issue in handle_connect()

Fix line over 80 character issue found by checkpatch.pl script by aligning the input argument in function call. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/d

[PATCH v2 09/30] staging: wilc1000: fix line over 80 chars in linux_mon

Fix line over 80 char issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_mon.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/s

[PATCH v2 03/30] staging: wilc1000: fix line over 80 chars in handle_key()

Fix checkpatch reported issue of line over 80 char in handle_key(). Introduced new functions by spliting existing function to address the checkpatch issue. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 59 +++-

[PATCH v2 26/30] staging: wilc1000: remove 'flag' argument from wilc_mac_indicate()

. WILC_MAC_INDICATE_STATUS0x1 WILC_MAC_INDICATE_SCAN 0x2 This changes also helped in resolving the line over 80 chars issue found by checkatpch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_wlan.c | 17 +++-- drivers/s

[PATCH v2 30/30] staging: wilc1000: refactor host_int_parse_assoc_resp_info() to remove unused code

its not used anymore. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/coreconfigurator.c | 51 + drivers/staging/wilc1000/coreconfigurator.h | 10 +- drivers/staging/wilc1000/host_interface.c | 20 ++- 3 files c

[PATCH v2 15/30] staging: wilc1000: fix line over 80 charas in wilc_wfi_remain_on_channel_expired()

Refactor wilc_wfi_remain_on_channel_expired() to avoid line over 80 character issue reported by checkpatch.pl script. Also assigned value in the variable at the time of declaration. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[PATCH v2 29/30] staging: wilc1000: remove s8idxarray to avoid datatype in variable name

Cleanup patch to have variable names as per linux coding style. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/s

[PATCH v2 27/30] staging: wilc1000: added comments for mutex and spinlock_t

Added comments for mutex and spinlock_t to avoid checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH 24/30] staging: wilc1000: refactor del_station() to avoid parenthesis misalignment

Hi Dan, On Tue, 15 May 2018 12:01:12 +0300 Dan Carpenter <dan.carpen...@oracle.com> wrote: > I feel sort of bad complaining about this patchset when your > co-workers already nit picked it to death... :P > > On Mon, May 07, 2018 at 02:13:28PM +0530, Ajay Singh wrote: >

[PATCH 2/4] staging: wilc1000: use list_head to maintain 'rxq_entry_t elements in rx queue

Make use of 'list_head' data structure to maintain the rx buffer queue. Modified wilc_wlan_rxq_add() to add the element at the tail by using list_head API and wilc_wlan_rxq_remove() to remove the element from head. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1

[PATCH 0/4] staging: wilc1000: modification to use list_head data structure

Instead of having own linked list implementation to maintain buffer queue change to use list_head. Also removed the few elements from 'wilc' struct as it's not required to be part of 'wilc' struct. Ajay Singh (4): staging: wilc1000: use list_head to maintain 'txq_entry_t' elements of tx

[PATCH 3/4] staging: wilc1000: remove 'rxq_entries' from 'wilc' struct

Removed unnecessary 'rxq_entries' element from 'wilc' struct, as its value is not used. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/staging/wilc1000/wilc_wlan.c | 7 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 1/4] staging: wilc1000: use list_head to maintain 'txq_entry_t' elements of tx queue

() wilc_wlan_txq_add_to_tail() wilc_wlan_txq_add_to_head() wilc_wlan_txq_get_first() wilc_wlan_txq_get_next() Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 3 +- drivers/staging/wilc1000/wilc_wlan.c | 61

[PATCH 4/4] staging: wilc1000: move 'txq_spinlock_flags' from 'wilc' structure to local variable

Cleanup patch to remove 'txq_spinlock_flags' element in 'wilc' and used local variable 'flag' in wilc_wlan_txq_filter_dup_tcp_ack(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 -- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 2 files changed, 3

[PATCH 03/12] staging: wilc1000: move the allocation of cmd out of wilc_enqueue_cmd()

Instead of allocating the host_if_cmd in wilc_enqueue_cmd() now moved the allocation of cmd in the caller. Added the NULL check for 'hif_workqueue' before posting the work queue in wilc_enqueue_cmd(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 943

[PATCH 04/12] staging: wilc1000: added 'work_comp' completion as part of host_if_msg

adding completion as part of host_if_msg now below completion are not required comp_test_key_block; comp_test_disconn_block comp_get_rssi comp_inactive_time hif_wait_response Modified wilc_get_statistics() API to handle get statistic in sync & async way. Signed-off-by: Ajay S

[PATCH 02/12] staging: wilc1000: remove unused marco related to HIF commands

After removing the multiplexing of hif commands in hif_if_work() macros prefix with 'HOST_IF_MSG_' are not required. Also 'id' field in host_if_msg is not required anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 36 --- 1 file

[PATCH 06/12] staging: wilc1000: rename wilc_enqueue_cmd() to wilc_enqueue_work()

Rename wilc_enqueue_cmd() to wilc_enqueue_work() because its used to enqueue the work queue. Also removed the function header comment for wilc_enqueue_cmd() as its not correct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 90 +++ 1 file

[PATCH 00/12] staging: wilc1000: address TODO item to remove host_if_work()

of the implementation of each message handler into the callsite of the function that currently queues the 'host_if_msg'. Ajay Singh (12): staging: wilc1000: remove host_if_work() to handle TODO list issue staging: wilc1000: remove unused marco related to HIF commands staging: wilc1000: move the allocation

[PATCH 01/12] staging: wilc1000: remove host_if_work() to handle TODO list issue

is same work_struct i.e. 'void (*fun)(struct struct *)' to register with work_queue. Removed host_if_work() because its not required now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 574 +++--- 1 file changed, 278 insertions(+), 296 deletions

[PATCH 05/12] staging: wilc1000: remove 'hif_thread_comp' completions

Remove 'hif_thread_comp' completions as its not required after adding completion event as part work data to handle each sync call. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers

[PATCH 07/12] staging: wilc1000: handle freeing of key data in wep add key

Modified the code to free the allocated memory, used to store the key in wilc_add_wep_key_bss_sta() and wilc_add_wep_key_bss_ap(). After work completion notification is received, free the memory allocated to avoid missing of free in work function. Signed-off-by: Ajay Singh --- drivers/staging

[PATCH 12/12] staging: wilc1000: updated TODO file

of the implementation of each message handler into the callsite of the function that currently queues the 'host_if_msg'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO index

[PATCH 11/12] staging: wilc1000: avoid use of static variable 'rssi'

Instead of static variable now allocating the data and passing to handle_get_rssi() to fill the rssi information. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 10/12] staging: wilc1000: avoid use of static variable 'inactive_time'

Avoided the use of static variable 'inactive_time' and move it as part of 'sta_inactive_t' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 09/12] staging: wilc1000: handle freeing of 'key' & 'seq' data in wilc_add_rx_gtk()

Handle freeing of memory allocated to keep 'key' & 'seq' in wilc_add_rx_gtk(). Once completion event is received, free the memory allocated for to avoid missing of free in work function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 1 file change

[PATCH 08/12] staging: wilc1000: handle freeing of key data in wilc_add_ptk()

Handle freeing of memory allocated to store the 'key' in wilc_add_ptk() function. Once work completion notification is received, free the memory allocated to avoid missing of free in work function sepecially for error scenario. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000

[PATCH 14/21] staging: wilc1000: remove the use of cur_byte variable in functions

Instead of using the intermediate variable to hold the value, now directly using the allocated variable. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/s

[PATCH 00/21] staging: wilc1000: code cleanup & checkpatch fixes

This patch series contains fixes to remove unused code and changes for checkpatch.pl script reported issues. Ajay Singh (21): staging: wilc1000: remove inner block in wilc_netdev_init() staging: wilc1000: remove unnecessary 'out of memory' message in handle_key() staging: wilc1000

[PATCH 15/21] staging: wilc1000: remove unused macros in host_interface

Cleanup patch to remove the unused macro mentioned below. Also move macro up along with other macro declaration. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 03/21] staging: wilc1000: modified NULL check used for 'if' condition in delete_key()

Fix below issue reported by checkpatch.pl script. 'Comparison to NULL could be written "priv->wilc_gtk[key_index]"' 'Comparison to NULL could be written "priv->wilc_ptk[key_index]"' Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1

[PATCH 02/21] staging: wilc1000: remove unnecessary 'out of memory' message in handle_key()

Fix "Possible unnecessary 'out of memory' message" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interf

[PATCH 04/21] staging: wilc1000: remove unnecessary bracket used in switch in wilc_mgmt_frame_register()

Cleanup patch to remove the curly braces used in 'case' statement to follow as per linux standard. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/d

[PATCH 01/21] staging: wilc1000: remove inner block in wilc_netdev_init()

Cleanup patch to remove unnecessary inner block ( {/**/} ) in wilc_netdev_init(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_wlan.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/d

Re: [PATCH] staging: wilc1000: fix infinite loop and out-of-bounds access

On Mon, 30 Apr 2018 18:23:21 +0300 Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Mon, Apr 30, 2018 at 07:59:16PM +0530, Ajay Singh wrote: > > Reviewed-by: Ajay Singh <ajay.kat...@microchip.com> > > > > On Mon, 30 Apr 2018 07:50:40 -0500 > > "

[PATCH 20/21] staging: wilc1000: rename 'during_ip_time' macro to have uppercase name for macro

Rename 'during_ip_time' to 'DURING_IP_TIME_OUT' to have uppercase letter for macros(#define). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 18/21] staging: wilc1000: move macro after the #include file in wilc_wfi_netdevice

Cleanup patch to organize macro in a file together after #include statements. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wi

[PATCH 08/21] staging: wilc1000: rename WILC_WFI_monitor_rx to avoid uppercase for function name

Cleanup patch to follow names as per linux coding style. Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +- 3

[PATCH 05/21] staging: wilc1000: fix line over 80 chars in remove_network_from_shadow()

Added changes to avoid line over 80 character issue in remove_network_from_shadow(). Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/s

  1   2   3   4   5   6   7   8   >