[PATCH v2 04/30] staging: wilc1000: fix line over 80 characters issue in handle_connect()

Fix line over 80 character issue found by checkpatch.pl script by aligning the input argument in function call. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 09/30] staging: wilc1000: fix line over 80 chars in linux_mon

Fix line over 80 char issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index

[PATCH v2 07/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

Fix line over 80 characters issue in host_int_parse_assoc_resp_info() by using shorter name for the local variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 17/30] staging: wilc1000: fix line over 80 chars in get_station()

Fix line over 80 characters issue in get_station(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000

[PATCH v2 14/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow(). Also added code to set 'ies_len' to zero in case of memory allocation failure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 ++--- 1 file changed, 6 insertions(+

[PATCH v2 11/30] staging: wilc1000: use kmalloc(sizeof(*mgmt_tx)...) in mgmt_tx()

Fix below checkpatch issue found in mgmt_tx() Prefer kmalloc(sizeof(*mgmt_tx)...) over kmalloc(sizeof(struct p2p_mgmt_data)...) Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 10/30] staging: wilc1000: use sizeof(*wdev) to allocate memory in wilc_wfi_cfg_alloc()

Fix below reported checkpatch issues in wilc_wfi_cfg_alloc(). kzalloc(sizeof(*wdev)...) over kzalloc(sizeof(struct wireless_dev) Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 16/30] staging: wilc1000: fix line over 80 chars in wilc_wfi_cfg_tx_vendor_spec()

Fix line over 80 characters issues reported by checkpatch.pl script in wilc_wfi_cfg_tx_vendor_spec() by using temporary variable. Simplified 'if else' condition with 'if'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--

[PATCH v2 18/30] staging: wilc1000: fix line over 80 chars in wilc_create_wiphy() declaration

Fix line over 80 characters issue found by checkpatch.pl script in function declaration. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h b

[PATCH v2 19/30] staging: wilc1000: fix line over 80 characters in add_key()

Fix line over 80 character issue found by checkpatch.pl script in add_key(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH v2 25/30] staging: wilc1000: added #define for setting radiotap header

Added new macro to resolve below checkpatch issues in linux_mon. "Lines should not end with a '('" Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/li

[PATCH v2 24/30] staging: wilc1000: fix line over 80 chars in wilc_sdio struct

Fix line over 80 chars issue found by checkpatch.pl script by placing the comment message above the macro preprocessor. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c

[PATCH v2 13/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Fix line over 80 characters issue reported by checkpatch in add_network_to_shadow() by using temporary variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 52 +++ 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers

[PATCH v2 23/30] staging: wilc1000: refactor del_station() to avoid parenthesis misalignment

Refactor the code to fix open parenthesis alignment issue reported by checkpatch.pl script in del_station(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH v2 20/30] staging: wilc1000: fix line over 80 chars in scan()

Fix line over 80 characters issues found by checkpatch.pl script with the help of local variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 22/30] staging: wilc1000: rename u8security to avoid datatype in variable name

Cleanup patch to avoid use of datatype in variable name to follow as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH v2 21/30] staging: wilc1000: fix line over 80 chars issue in connect()

Fix line over 80 characters in connect() by using temporary variables. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 29 +-- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH v2 28/30] staging: wilc1000: remove unused 'lock' varible in 'wilc_priv' structure

Cleanup patch to remove the unused variable from 'wilc_priv' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000/wilc_wfi_n

[PATCH v2 26/30] staging: wilc1000: remove 'flag' argument from wilc_mac_indicate()

ed anymore. WILC_MAC_INDICATE_STATUS0x1 WILC_MAC_INDICATE_SCAN 0x2 This changes also helped in resolving the line over 80 chars issue found by checkatpch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 17 +++-- drivers/staging/wilc1000/wilc_wfi_n

[PATCH v2 12/30] staging: wilc1000: rename clear_duringIP() to avoid camelCase issue

Rename clear_duringIP() function to avoid camelCase issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH v2 30/30] staging: wilc1000: refactor host_int_parse_assoc_resp_info() to remove unused code

ns are remove as its not used anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 51 + drivers/staging/wilc1000/coreconfigurator.h | 10 +- drivers/staging/wilc1000/host_interface.c | 20 ++- 3 files changed, 11 ins

[PATCH v2 15/30] staging: wilc1000: fix line over 80 charas in wilc_wfi_remain_on_channel_expired()

Refactor wilc_wfi_remain_on_channel_expired() to avoid line over 80 character issue reported by checkpatch.pl script. Also assigned value in the variable at the time of declaration. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +++- 1 file

[PATCH v2 29/30] staging: wilc1000: remove s8idxarray to avoid datatype in variable name

Cleanup patch to have variable names as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c

[PATCH v2 27/30] staging: wilc1000: added comments for mutex and spinlock_t

Added comments for mutex and spinlock_t to avoid checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Hi Claudiu, On Mon, 14 May 2018 11:57:24 +0300 Claudiu Beznea wrote: > Hi Ajay, > > On 10.05.2018 08:27, Claudiu Beznea wrote: > > > > > > On 09.05.2018 21:42, Ajay Singh wrote: > >> On Wed, 9 May 2018 16:43:14 +0300 > >> Claudiu Beznea wrote:

Re: [PATCH 24/30] staging: wilc1000: refactor del_station() to avoid parenthesis misalignment

Hi Dan, On Tue, 15 May 2018 12:01:12 +0300 Dan Carpenter wrote: > I feel sort of bad complaining about this patchset when your > co-workers already nit picked it to death... :P > > On Mon, May 07, 2018 at 02:13:28PM +0530, Ajay Singh wrote: > > Refactor the code to fi

[PATCH 2/4] staging: wilc1000: use list_head to maintain 'rxq_entry_t elements in rx queue

Make use of 'list_head' data structure to maintain the rx buffer queue. Modified wilc_wlan_rxq_add() to add the element at the tail by using list_head API and wilc_wlan_rxq_remove() to remove the element from head. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c

[PATCH 0/4] staging: wilc1000: modification to use list_head data structure

Instead of having own linked list implementation to maintain buffer queue change to use list_head. Also removed the few elements from 'wilc' struct as it's not required to be part of 'wilc' struct. Ajay Singh (4): staging: wilc1000: use list_head to maintain 't

[PATCH 3/4] staging: wilc1000: remove 'rxq_entries' from 'wilc' struct

Removed unnecessary 'rxq_entries' element from 'wilc' struct, as its value is not used. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/staging/wilc1000/wilc_wlan.c | 7 ++- 2 files changed, 2 insertions(+), 6 deleti

[PATCH 1/4] staging: wilc1000: use list_head to maintain 'txq_entry_t' elements of tx queue

wlan_txq_remove_from_head() wilc_wlan_txq_add_to_tail() wilc_wlan_txq_add_to_head() wilc_wlan_txq_get_first() wilc_wlan_txq_get_next() Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 3 +- drivers/staging/wilc1000/

[PATCH 4/4] staging: wilc1000: move 'txq_spinlock_flags' from 'wilc' structure to local variable

Cleanup patch to remove 'txq_spinlock_flags' element in 'wilc' and used local variable 'flag' in wilc_wlan_txq_filter_dup_tcp_ack(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 -- drivers/staging/wilc1000/wilc_wlan.c

[PATCH 03/12] staging: wilc1000: move the allocation of cmd out of wilc_enqueue_cmd()

Instead of allocating the host_if_cmd in wilc_enqueue_cmd() now moved the allocation of cmd in the caller. Added the NULL check for 'hif_workqueue' before posting the work queue in wilc_enqueue_cmd(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interfa

[PATCH 04/12] staging: wilc1000: added 'work_comp' completion as part of host_if_msg

st interface. After adding completion as part of host_if_msg now below completion are not required comp_test_key_block; comp_test_disconn_block comp_get_rssi comp_inactive_time hif_wait_response Modified wilc_get_statistics() API to handle get statistic in sync & async way. S

[PATCH 02/12] staging: wilc1000: remove unused marco related to HIF commands

After removing the multiplexing of hif commands in hif_if_work() macros prefix with 'HOST_IF_MSG_' are not required. Also 'id' field in host_if_msg is not required anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 36 ---

[PATCH 06/12] staging: wilc1000: rename wilc_enqueue_cmd() to wilc_enqueue_work()

Rename wilc_enqueue_cmd() to wilc_enqueue_work() because its used to enqueue the work queue. Also removed the function header comment for wilc_enqueue_cmd() as its not correct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 90 +++ 1 file

[PATCH 00/12] staging: wilc1000: address TODO item to remove host_if_work()

wing movement of the implementation of each message handler into the callsite of the function that currently queues the 'host_if_msg'. Ajay Singh (12): staging: wilc1000: remove host_if_work() to handle TODO list issue staging: wilc1000: remove unused marco related to HIF commands staging: wi

[PATCH 10/12] staging: wilc1000: avoid use of static variable 'inactive_time'

Avoided the use of static variable 'inactive_time' and move it as part of 'sta_inactive_t' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 09/12] staging: wilc1000: handle freeing of 'key' & 'seq' data in wilc_add_rx_gtk()

Handle freeing of memory allocated to keep 'key' & 'seq' in wilc_add_rx_gtk(). Once completion event is received, free the memory allocated for to avoid missing of free in work function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4

[PATCH 08/12] staging: wilc1000: handle freeing of key data in wilc_add_ptk()

Handle freeing of memory allocated to store the 'key' in wilc_add_ptk() function. Once work completion notification is received, free the memory allocated to avoid missing of free in work function sepecially for error scenario. Signed-off-by: Ajay Singh --- drivers/stagin

[PATCH 07/12] staging: wilc1000: handle freeing of key data in wep add key

Modified the code to free the allocated memory, used to store the key in wilc_add_wep_key_bss_sta() and wilc_add_wep_key_bss_ap(). After work completion notification is received, free the memory allocated to avoid missing of free in work function. Signed-off-by: Ajay Singh --- drivers/staging

[PATCH 01/12] staging: wilc1000: remove host_if_work() to handle TODO list issue

unction is same work_struct i.e. 'void (*fun)(struct struct *)' to register with work_queue. Removed host_if_work() because its not required now. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 574 +++--- 1 file changed, 278 insertio

[PATCH 05/12] staging: wilc1000: remove 'hif_thread_comp' completions

Remove 'hif_thread_comp' completions as its not required after adding completion event as part work data to handle each sync call. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 35 --- 1 file changed, 35 deletions(-) diff --git

[PATCH 11/12] staging: wilc1000: avoid use of static variable 'rssi'

Instead of static variable now allocating the data and passing to handle_get_rssi() to fill the rssi information. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 12/12] staging: wilc1000: updated TODO file

wing movement of the implementation of each message handler into the callsite of the function that currently queues the 'host_if_msg'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/TODO b/drive

[PATCH] staging: wilc1000: fix static checker warning to unlock mutex in wilc_deinit()

: move the allocation of cmd out of wilc_enqueue_cmd()". [1]. https://www.spinics.net/lists/linux-driver-devel/msg114216.html Reported-by: Dan Carpenter Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 de

Re: [PATCH] staging: wilc1000: fix static checker warning to unlock mutex in wilc_deinit()

Hi Dan, On Thu, 5 Jul 2018 11:41:26 +0300 Dan Carpenter wrote: > On Thu, Jul 05, 2018 at 09:18:53AM +0530, Ajay Singh wrote: > > Fix for static checker warning inconsistent returns of > > 'hif_deinit_lock'(more details [1]). > > > > "drivers/staging/

[PATCH v2] staging: wilc1000: fix static checker warning to unlock mutex in wilc_deinit()

: move the allocation of cmd out of wilc_enqueue_cmd()") [1]. https://www.spinics.net/lists/linux-driver-devel/msg114216.html Reported-by: Dan Carpenter Signed-off-by: Ajay Singh --- Change since v1: - added 'Fixes' tag in commit description. drivers/staging/wilc1000/host_inte

[PATCH 00/23] staging: wilc1000: cleanup patch to follow linux coding style

This patch series contains modification to follow Linux coding style & cleanup change to remove unused variables and enums. Few patches also contain changes to remove unnecessary typecast. Ajay Singh (23): staging: wilc1000: remove unused enum declaration staging: wilc1000: remove

[PATCH 01/23] staging: wilc1000: remove unused enum declaration

Cleanup patch to remove unused enums. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 8 drivers/staging/wilc1000/host_interface.h | 6 -- drivers/staging/wilc1000/wilc_wlan_if.h | 26 -- 3 files changed, 40 deletions

[PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

Cleanup patch to avoid use of leading '_' in goto label name. Also used proper string for lable names. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 drivers/staging/wilc1000/wilc_wlan.c | 4 ++-- 2 files changed, 6 insert

[PATCH 02/23] staging: wilc1000: remove enum connect_status instead use ieee80211_statuscode

Cleanup patch to remove the use of enum 'connect_status' and instead use predefined 'ieee80211_statuscode' for error code values. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 4 +++- drivers/staging/wilc1000/coreconfi

[PATCH 04/23] staging: wilc1000: remove extra enums defined for ieee80211_eid

x27; as its same as 'ieee80211_eid', below the mapping of elements of enums which are used. ITIM -> WLAN_EID_TIM IDSPARMS -> WLAN_EID_DS_PARAMS Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 47 ++--- drivers/staging/wilc1000/

[PATCH 03/23] staging: wilc1000: remove extra enum defined for data rates

Cleanup patch to remove extra enum defined to handle data rates. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 16 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 11/23] staging: wilc1000: removed unused element from wilc_cfg_frame struct

Cleanup up patch to remove the unused structure elements in 'wilc_cfg_frame' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wl

[PATCH 06/23] staging: wilc1000: rename enum CURRENT_TXRATE to use lowercase

Cleanup patch to rename enums in lowercase to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 17/23] staging: wilc1000: avoid forward declaration for handle_scan_done()

Reorder the function position in host interface to avoid forward declaration of handle_scan_done(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 77 +++ 1 file changed, 38 insertions(+), 39 deletions(-) diff --git a/drivers/staging

[PATCH 13/23] staging: wilc1000: use lowercase for 'IFC_UP' struct element name

Cleanup patch to use lowercase for structure element name to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4

[PATCH 09/23] staging: wilc1000: remove unused elements in 'wilc' struct

Cleanup patch to remove unused elements from 'wilc' struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 drivers/staging/wilc1000/wilc_wlan.c | 6 -- 2 files changed, 10 deletions(-) diff --git a/drivers/stagin

[PATCH 08/23] staging: wilc1000: rename enum AUTHTYPE to use lowercase

Cleanup patch to rename enum AUTHTYPE to lowercase. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- drivers/staging/wilc1000

[PATCH 10/23] staging: wilc1000: remove unnecessary elements from 'wilc_priv' struct

Remove unused elements from 'wilc_priv' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 7 --- 2 files changed, 11 deletions(-) diff --git a/drivers/stagin

[PATCH 12/23] staging: wilc1000: remove the mutliple #define used for same macro

Moved the same #define in common header file instead of having their declartion in different files. Below macros are moved to header file: TCP_ACK_FILTER_LINK_SPEED_THRESH DEFAULT_LINK_SPEED GET_PKT_OFFSET Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3

[PATCH 07/23] staging: wilc1000: rename enum SITESURVEY to use lowercase

Cleanup patch to have enum in lowercase as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions

[PATCH 20/23] staging: wilc1000: avoid setting default value for variable at declaration

Cleanup patch to avoid setting default value for local variables and also clubbed similar variables together. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 25 ++--- drivers/staging/wilc1000/host_interface.c | 122 +++--- drivers

[PATCH 15/23] staging: wilc1000: use single space before opening brances '{'

Cleanup patch to use single space instead of multiple space before the '{'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +

[PATCH 18/23] staging: wilc1000: avoid host_int_get_assoc_res_info() forward declaration

Reorder the function position in host interface to avoid forward declaration of host_int_get_assoc_res_info(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 47 ++- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/drivers

[PATCH 16/23] staging: wilc1000: remove unnecessary type used for wid id

Cleanup patch to remove unnecessary typecast used while assigning the WID ID. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 84 +++ 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 21/23] staging: wilc1000: use 'int' inplace of 's32' date type

Cleanup patch to use 'int' instead of 's32' to have the same data type based on its usage. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 48 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 28 ++---

[PATCH 22/23] staging: wilc1000: remove unnecessary 'NULL' check from cfg80211_ops callbacks

Cleanup patch to remove the unnecessary 'NULL' check used in 'cfg80211_ops' callback functions. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/wilc

[PATCH 19/23] staging: wilc1000: avoid forward declaration of host_int_parse_join_bss_param()

Reorder the functions position in host interface to avoid forward declaration of host_int_parse_join_bss_param(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 333 +++--- 1 file changed, 166 insertions(+), 167 deletions(-) diff --git a

[PATCH 14/23] staging: wilc1000: remove unnecessary blank line between variable declaration

Cleanup patch to remove the unnecessary blank line between variables declaration inside the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 1 - drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 23/23] staging: wilc1000: move variable assignment along with its declaration

Cleanup patch to club the variable assignment along with the variable declaration especially for private data. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 7 +- drivers/staging/wilc1000/linux_wlan.c | 113 +++ drivers/staging/wilc1000

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

Hi Dan, On Thu, 19 Jul 2018 12:27:44 +0300 Dan Carpenter wrote: > On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote: > > diff --git a/drivers/staging/wilc1000/wilc_wlan.c > > b/drivers/staging/wilc1000/wilc_wlan.c index 85af365..8e71c28 100644 > > --- a/dri

[PATCH 1/4] staging: wilc1000: remove gpio parameter from wilc_netdev_init()

Instead of passing the gpio as parameter to wilc_netdev_init() now setting its value after finishing wilc_netdev_init() call. Avoided passing of extra parameter to wilc_netdev_init(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000

[PATCH 0/4] staging: wilc1000: make use of descriptor-based interface for GPIO

on top of [1] patch series. [1]. https://www.spinics.net/lists/linux-wireless/msg175360.html Ajay Singh (4): staging: wilc1000: remove gpio parameter from wilc_netdev_init() staging: wilc1000: rename variable from 'gpio' to 'gpio_irq' staging: wilc1000: change c

[PATCH 3/4] staging: wilc1000: change compatible string from atmel to microchip

Use 'microchip' in compatible string instead of 'atmel', also replace '_' with '-' before the module. Remove 'wilc1000' prefix from device table name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 11 +-- drivers/s

[PATCH 2/4] staging: wilc1000: rename variable from 'gpio' to 'gpio_irq'

Rename from 'gpio' to 'gpio_irq', so its inlcude the information about the purpose of GPIO. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 17 + drivers/staging/wilc1000/wilc_sdio.c | 2 +- drivers/staging

[PATCH 4/4] staging: wilc1000: use descriptor-based interface for GPIO

file Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/TODO | 4 --- drivers/staging/wilc1000/linux_wlan.c | 40 +- .../staging/wilc1000/microchip,wilc1000,sdio.txt | 32 + .../staging/wilc1000/microchip,wilc1000,spi.txt

[PATCH 0/8] staging: wilc1000: changes to address TODO items

-sdio.ko & wilc1000-spi.ko module. Ajay Singh (8): staging: wilc1000: fix TODO to compile spi and sdio components in single module staging: wilc1000: remove unnecessary comments and comments description staging: wilc1000: remove unnecessary copyright information in file stag

[PATCH 1/8] staging: wilc1000: fix TODO to compile spi and sdio components in single module

s are done to address below TODO item. - make SPI and SDIO components coexist in one build Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/Makefile | 3 ++- drivers/staging/wilc1000/TODO | 1 - drivers/staging/wilc1000/linux_wlan.c | 6 ++ drivers/staging/wilc1000/wilc

[PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file

Cleanup patch to remove the unnecessary copyright information in the file, as it already has SPDX License Identifier. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_debugfs.c | 10 -- drivers/staging/wilc1000/wilc_sdio.c | 5 - drivers/staging/wilc1000/wilc_spi.c

[PATCH 6/8] staging: wilc1000: rename 'rcvd_ch_cnt' element in 'user_scan_req' struct

Cleanup patch to use shorter name for 'rcvd_ch_cnt' to 'ch_cnt' to avoid line over 80 character issue reported by checkpatch. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 12 ++-- drivers/staging/wilc1000/host_interface.h | 2 +-

[PATCH 4/8] staging: wilc1000: modified debug log messages description

Cleanup patch to update the debug logs message to provide correct information. Also added the function name tag for same description log to help identify the place from where log was captured. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 134

[PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

Cleanup patch to avoid the below checkpatch reported issue. "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 5/8] staging: wilc1000: added comments for 'hif_cs' mutex lock

Added comments for 'hif_cs' mutex to avoid checkpatch.pl reported issues. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/stagin

[PATCH 2/8] staging: wilc1000: remove unnecessary comments and comments description

Cleanup patch to remove the unnecessary comments and commented code. Also updated description for few of comments. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/linux_mon.c | 15 --- drivers/staging/wilc1000

[PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

Cleanup patch to fix below checkpatch reported issue: Macro argument 'id' may be better as '(id)' to avoid precedence issues Also updated the TODO file to remove the below item 'rework comments and function headers(also coding style)' Signed-off-by: Ajay Singh

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

Hi Dan, On Mon, 30 Jul 2018 11:41:13 +0300 Dan Carpenter wrote: > On Fri, Jul 20, 2018 at 04:35:24AM +0530, Ajay Singh wrote: > > Hi Dan, > > > > On Thu, 19 Jul 2018 12:27:44 +0300 > > Dan Carpenter wrote: > > > > > On Thu, Jul 19, 2018 at 04:15:01

[PATCH] staging: wilc1000: refactor wilc_wlan_handle_isr_ext to avoid goto statement

. [1]. https://patchwork.kernel.org/patch/10533601/ Signed-off-by: Ajay Singh Suggested-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wlan.c | 45 +--- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/sta

Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name

Hi Dan, On Mon, 30 Jul 2018 14:32:31 +0300 Dan Carpenter wrote: > On Mon, Jul 30, 2018 at 03:40:24PM +0530, Ajay Singh wrote: > > Hi Dan, > > > > On Mon, 30 Jul 2018 11:41:13 +0300 > > Dan Carpenter wrote: > > > > > On Fri, Jul 20, 2018 at 04:35:

[PATCH 0/2] staging: wilc1000: fix endianness issues identified by sparse

This patch series has changes to fix the sparse warnings & use correct byte-order conversion. It also includes changes to use correct datatype for 'wid' in cfg struct. Ajay Singh (2): staging: wilc1000: use 'u16' data type for config id parameter staging: wilc1000:

[PATCH 1/2] staging: wilc1000: use 'u16' data type for config id parameter

Cleanup patch to use the correct data type 'u16' for keeping the WID value in 'wilc_cfg_word' & 'wilc_cfg_str' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_cfg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[PATCH 2/2] staging: wilc1000: fix endianness warnings reported by sparse

x27;header' in wilc_wfi_monitor_rx() & wilc_wfi_p2p_rx() as received in LE byte-order. The link [1] contains the details of discussion related to this patch. [1]. https://patchwork.kernel.org/patch/10436791/ Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c

Re: [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file

Hi Greg, On Thu, 2 Aug 2018 09:33:17 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote: > > Cleanup patch to remove the unnecessary copyright information in > > the file, as it already has SPDX License Identifier. > > > > diff --git

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

Hi Greg, On Thu, 2 Aug 2018 09:34:54 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > > Cleanup patch to fix below checkpatch reported issue: > > -#define ISWILC1000(id) ((id & 0xf000) > > == 0x10 ? 1 :

[PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

orted by sparse") Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c index 8bda550..1

Re: [PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

Hi Greg, On Thu, 2 Aug 2018 21:31:16 +0200 Greg KH wrote: > On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote: > > Fix below warning reported for PowerPC arch compilation > > > > include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing > > argu

Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

Hi Greg, On Thu, 2 Aug 2018 09:34:15 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote: > > Cleanup patch to avoid the below checkpatch reported issue. > > > > "usleep_range is preferred over udelay; see > > Docum

[PATCH 2/3] staging: wilc1000: replace ISWILC1000() macro with inline function

Cleanup patch to avoid below checkpatch issue by replacing the macro with inline function. Macro argument 'id' may be better as '(id)' to avoid precedence issues. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 9 +++-- drivers/staging/wilc1000/w

[PATCH 0/3] staging: wilc1000: updated copyright header and TODO list

,wilc1000-spi" appears un-documented ./drivers/staging/wilc1000/wilc_wlan.c:438: CHECK: usleep_range is preferred over udelay; [1]. https://www.spinics.net/lists/linux-driver-devel/msg115571.html Ajay Singh (3): staging: wilc1000: added Microchip copyright notice header staging: wilc10

[PATCH 3/3] staging: wilc1000: remove TODO item for comments and code style

Remove below item from TODO as these changes were included as part of previous submitted patch series. 'rework comments and function headers(also coding style)' Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

<    1   2   3   4   5   6   7   8   >