Re: [PATCH 1/2] net wireless wcn36xx add wcnss platform code

2015-02-09 Thread Bjorn Andersson
On Sat, Jan 17, 2015 at 9:16 PM, Andy Green andy.gr...@linaro.org wrote: From: Eugene Krasnikov k.eugen...@gmail.com AG modified to remove regulator handling not needed on msm8916-qrd Signed-off-by: Eugene Krasnikov k.eugen...@gmail.com Signed-off-by: Andy Green andy.gr...@linaro.org ---

Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620

2015-02-09 Thread Bjorn Andersson
On Sat, Jan 17, 2015 at 9:11 PM, Andy Green andy.gr...@linaro.org wrote: WCN3620 powersaving mode is not stable. Disable it if we're on a wcn3620 chip type. Signed-off-by: Andy Green andy.gr...@linaro.org --- drivers/net/wireless/ath/wcn36xx/main.c |4 1 file changed, 4

Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620

2015-02-09 Thread Bjorn Andersson
On Mon, Feb 9, 2015 at 1:28 PM, Andy Green andy.gr...@linaro.org wrote: On 10 February 2015 at 05:11, Bjorn Andersson bj...@kryo.se wrote: On Feb 9, 2015 1:07 PM, Andy Green andy.gr...@linaro.org wrote: On 10 February 2015 at 01:54, Bjorn Andersson bj...@kryo.se wrote: On Sat, Jan 17, 2015

Re: [PATCH] wcn36xx: Remove warning message when dev is NULL for arm64 dma_alloc.

2015-10-26 Thread Bjorn Andersson
[] ieee80211_do_open+0x1b0/0x9a4 > [] ieee80211_open+0x58/0x68 > [] __dev_open+0xb0/0x120 > [] __dev_change_flags+0x88/0x150 > [] dev_change_flags+0x1c/0x5c > [] devinet_ioctl+0x644/0x6f0 > > Signed-off-by: Yin, Fengwei <fengwei@linaro.org> Acked-by: Bjorn Andersson <bj

Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Bjorn Andersson
On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara wrote: Hi Punit, > Remove empty line suggested by Sergei > A commit message is here to, in the future, help us all understand what and why this change was made, so you should not include comments about what you changed since a

Re: [PATCH 4/5] wcn3620: use new response format for wcn3620 trigger_ba

2015-11-11 Thread Bjorn Andersson
On Mon, Nov 9, 2015 at 7:40 AM, Bob Copeland wrote: > On Mon, Nov 09, 2015 at 05:02:41AM -0500, Yin, Fengwei wrote: >> From: Andy Green >> >> From: Andy Green >> >> On wcn3620, firmware response to trigger_ba uses the new,

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

2015-12-14 Thread Bjorn Andersson
On Mon 14 Dec 02:06 PST 2015, Fengwei Yin wrote: > Lawrence reported that git clone could make system crash on a > Qualcomm ARM soc based device (DragonBoard, 1G memory without > swap) running 64bit Debian. > > It's turned out the crash is related with rx skb allocation > failure. git could

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-29 Thread Bjorn Andersson
On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> > > --- > >

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Bjorn Andersson
On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > > HI Bjorn, > > On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson <bj...@kryo.se> wrote: > > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > > clients from h

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Bjorn Andersson
On Wed, Dec 30, 2015 at 10:30 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson <bj...@kryo.se> wrote: >> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >>> >>

[PATCH 2/4] wcn36xx: Change indication list lock to spinlock

2015-12-27 Thread Bjorn Andersson
In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 2

[PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-27 Thread Bjorn Andersson
Add binding representing the Qualcomm wcn3620/60/80 WiFi block. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- .../bindings/net/wireless/qcom,wcn36xx-wifi.txt| 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devi

[PATCH 1/4] wcn36xx: Fold indication payload into message header

2015-12-27 Thread Bjorn Andersson
Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 15 ++- drivers/net/wireless/ath/wcn36xx/smd.h | 2 +- 2 files chan

[PATCH 3/4] wcn36xx: Transition driver to SMD client

2015-12-27 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wirele

[PATCH 0/4] WCN36xx convert to mainline SMD interface

2015-12-27 Thread Bjorn Andersson
during boot of the WCNSS core. This is being worked on separately. [1] https://lkml.org/lkml/2015/12/27/185 Bjorn Andersson (4): wcn36xx: Fold indication payload into message header wcn36xx: Change indication list lock to spinlock wcn36xx: Transition driver to SMD client dt: binding: Add

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

2015-12-28 Thread Bjorn Andersson
On Mon 28 Dec 15:06 PST 2015, Stephen Hemminger wrote: > On Sun, 27 Dec 2015 17:34:25 -0800 > Bjorn Andersson <bj...@kryo.se> wrote: > > > In preparation for handling incoming messages from IRQ context, change > > the indication list lock to a spinlock > > &

[PATCH 4/6] wcn36xx: Correct DXE chip version differentiation

2016-06-20 Thread Bjorn Andersson
The CCU block in WCNSS is configured for appropriate routing of interrupts from the DXE to the application cpu, this is not dependant on the iris version (wcn3660 vs wcn3680), but rather if the SoC has a riva or pronto built in. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.

[PATCH 3/6] wcn36xx: Split mmio space into explicit regions

2016-06-20 Thread Bjorn Andersson
Split the wcnss mmio space into explicit regions for ccu and dxe and acquire these from the node referenced by the qcom,mmio phandle. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/dxe.c | 26 --- drivers/net/wireless/ath/w

[PATCH 6/6] wcn36xx: Fix up wcn36xx_smd_update_scan_params()

2016-06-20 Thread Bjorn Andersson
Fix up the wcn36xx_smd_update_scan_params() to work with non-ancient versions of the firmware and support actually specifying the list of channels. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 4 ++-- drivers/net/wireless/ath/w

[PATCH 2/6] wcn36xx: Change indication list lock to spinlock

2016-06-20 Thread Bjorn Andersson
From: Bjorn Andersson <bjorn.anders...@sonymobile.com> In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.ander

[PATCH 5/6] wcn36xx: Transition driver to SMD client

2016-06-20 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- This patch d

[PATCH 1/6] wcn36xx: Fold indication payload into message header

2016-06-20 Thread Bjorn Andersson
From: Bjorn Andersson <bjorn.anders...@sonymobile.com> Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- dr

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2016-01-25 Thread Bjorn Andersson
On Tue, Dec 29, 2015 at 11:03 AM, Bjorn Andersson <bj...@kryo.se> wrote: > On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > >> On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: >> > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. >>

[PATCH v2 08/15] wcn36xx: Remove sta pointer in private vif struct

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH v2 12/15] wcn36xx: Clear encrypt_type when deleting bss key

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH v2 14/15] wcn36xx: Implement multicast filtering

2016-04-03 Thread Bjorn Andersson
OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 51

[PATCH v2 13/15] wcn36xx: Track association state

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH v2 15/15] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH v2 07/15] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 06/15] wcn36xx: Add helper macros to cast sta to priv

2016-04-03 Thread Bjorn Andersson
; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

[PATCH v2 03/15] wcn36xx: Add helper macros to cast vif to private vif and vice versa

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH v2 04/15] wcn36xx: Use consistent name for private vif

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 09/15] wcn36xx: Parse trigger_ba response properly

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 11/15] wcn36xx: Use allocated self sta index instead of hard coded

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

[PATCH v2 10/15] wcn36xx: Copy all members in config_sta v1 conversion

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH v2 05/15] wcn36xx: Use define for invalid index and fix typo

2016-04-03 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH v2 02/15] wcn36xx: Pad TIM PVM if needed

2016-04-03 Thread Bjorn Andersson
d-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Jason Mobarak <j...@cozybit.com> [bjorn: squashed in Jason's fixup] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 3 +++ drivers/net/wireless/ath/wcn36xx/smd.c |

[PATCH 10/16] wcn36xx: Copy all members in config_sta v1 conversion

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH 11/16] wcn36xx: Use allocated self sta index instead of hard coded

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 08/16] wcn36xx: Remove sta pointer in private vif struct

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH 09/16] wcn36xx: Parse trigger_ba response properly

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 12/16] wcn36xx: Clear encrypt_type when deleting bss key

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 14/16] wcn36xx: Implement multicast filtering

2016-03-29 Thread Bjorn Andersson
OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wi

[PATCH 04/16] wcn36xx: Use consistent name for private vif

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 00/16] Misc wcn36xx fixes

2016-03-29 Thread Bjorn Andersson
As I was debugging some issues with the wcn36xx driver I found a series of patches that exists in Eugene's github tree but not in mainline. Noteworthy is the long requested feature of having working ARP support. Please apply these rebased and relocated patches. Jason Mobarak (1): wcn36xx:

[PATCH 03/16] wcn36xx: Add helper macros to cast vif to private vif and vice versa

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH 05/16] wcn36xx: Use define for invalid index and fix typo

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH 01/16] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

Re: [PATCH 3/4] wcn36xx: Transition driver to SMD client

2016-03-28 Thread Bjorn Andersson
this depends on changes to the wcnss_ctrl driver, which are being reviewed right now. Regards, Bjorn > 2015-12-28 1:34 GMT+00:00 Bjorn Andersson <bj...@kryo.se>: >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. Th

[PATCH 16/16] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH 02/16] wcn36xx: Pad TIM PVM if needed

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> The wcn36xx FW expects a fixed size TIM PVM in the beacon template. If supplied with a shorter than expected PVM it will overwrite the IE following the TIM. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjo

[PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 5 +

[PATCH 13/16] wcn36xx: Track association state

2016-03-29 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH 07/16] wcn36xx: Add helper macros to cast sta to priv

2016-03-29 Thread Bjorn Andersson
; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

[RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Fixes: 8ad99a4e3ee5 ("wcn36xx: Pad TIM PVM if needed") Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@

Re: [RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

2016-03-29 Thread Bjorn Andersson
On Tue 29 Mar 14:41 PDT 2016, Bjorn Andersson wrote: > From: Jason Mobarak <j...@cozybit.com> > > Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh > beaconing. The field tim_off is always 0 for mesh mode, and thus > pvm_len (referring t

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-03-29 Thread Bjorn Andersson
e system] > > url: > https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Misc-wcn36xx-fixes/20160329-141847 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > master > config: sparc64-allyesconfig (attached as .config) > reproduce

[PATCH] wcn36xx: Set SMD timeout to 10 seconds

2016-04-21 Thread Bjorn Andersson
seconds for the communication layer. By extending the wcn36xx timeout to match this we follows the same flow for the boot procedure and can successfully configure WiFi as wlan0 is registered. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd

[RFC] wcn36xx: Implement firmware assisted scan

2016-05-12 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- With this implementation I see a red

[PATCH v3 05/18] wcn36xx: Use define for invalid index and fix typo

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH v3 11/18] wcn36xx: Use allocated self sta index instead of hard coded

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v3 10/18] wcn36xx: Copy all members in config_sta v1 conversion

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH v3 09/18] wcn36xx: Parse trigger_ba response properly

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v3 12/18] wcn36xx: Clear encrypt_type when deleting bss key

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH v3 16/18] wcn36xx: Delete BSS before idling link

2016-04-18 Thread Bjorn Andersson
When disabling the beacon we must delete the bss before idling the link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Added this patch to the series drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 17/18] wcn36xx: Correct remove bss key response encoding

2016-04-18 Thread Bjorn Andersson
The WCN36XX_HAL_RMV_BSSKEY_RSP carries a single u32 with "status", so we can use the standard status check function for decoding the result. This is the last user of the v2 status checker, so remove the struct and helper function. Signed-off-by: Bjorn Andersson <bjorn.anders.

[PATCH v3 14/18] wcn36xx: Implement multicast filtering

2016-04-18 Thread Bjorn Andersson
OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 51

[PATCH v3 18/18] wcn36xx: Fill in capability list

2016-04-18 Thread Bjorn Andersson
Fill in the capability list with more values from the downstream driver. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Added this patch to the series drivers/net/wireless/ath/wcn36xx/hal.h | 39 drivers/net/wirele

[PATCH v3 13/18] wcn36xx: Track association state

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH v3 02/18] wcn36xx: Pad TIM PVM if needed

2016-04-18 Thread Bjorn Andersson
d-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Jason Mobarak <j...@cozybit.com> [bjorn: squashed in Jason's fixup] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - Merged in Jason's patch for skipping the padding in mesh mode. dri

[PATCH v3 15/18] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv

2016-04-18 Thread Bjorn Andersson
; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

[PATCH v3 01/18] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> [bjorn: restored BEACON_TEMPLATE_SIZE define to 0x180] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> ---

[PATCH v3 07/18] wcn36xx: Fetch private sta data from sta entry instead of from vif

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - Reordered after the now previous patch, to make wcn36xx_sta_to_

[PATCH v3 04/18] wcn36xx: Use consistent name for private vif

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v3 08/18] wcn36xx: Remove sta pointer in private vif struct

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH v3 03/18] wcn36xx: Add helper macros to cast vif to private vif and vice versa

2016-04-18 Thread Bjorn Andersson
From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH v3 00/18] wcn36xx fixes

2016-04-18 Thread Bjorn Andersson
rect WCN36XX_HAL_RMV_BSSKEY_RSP decoder - Added patch with missing capabilities from downstream Changes since v1: - Reorder patch 6 and 7 to not break the build temporarily - Inline fix from Jason Mobarak in the TIM PVM padding Bjorn Andersson (3): wcn36xx: Delete BSS before idling link wcn36xx: Cor

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-04-13 Thread Bjorn Andersson
On Sun 03 Apr 15:16 PDT 2016, Bjorn Andersson wrote: > From: Pontus Fuchs <pontus.fu...@gmail.com> > > Needed for coming improvements. No functional changes. > Kalle, Eugene, Have you picked up these patches yet? As I was debugging a firmware crash when tryi

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-01 Thread Bjorn Andersson
On Sat 30 Jul 09:58 PDT 2016, Luis R. Rodriguez wrote: > On Sat, Jul 30, 2016 at 02:42:41PM +0200, Arend van Spriel wrote: > > + Luis (again) ;-) > > > > On 29-07-16 08:13, Daniel Wagner wrote: > > > On 07/28/2016 09:01 PM, Bjorn Andersson wrote: > > >

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-03 Thread Bjorn Andersson
On Tue 02 Aug 00:41 PDT 2016, Luis R. Rodriguez wrote: > On Tue, Aug 02, 2016 at 08:53:55AM +0200, Daniel Wagner wrote: > > On 08/02/2016 08:34 AM, Luis R. Rodriguez wrote: > > >On Tue, Aug 02, 2016 at 07:49:19AM +0200, Daniel Wagner wrote: > > >>>The sysdata API's main goal rather is to provide

[PATCH v2 1/2] wcn36xx: Transition driver to SMD client

2016-08-12 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Res

[PATCH v2 2/2] wcn36xx: Implement firmware assisted scan

2016-08-12 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- It's been a while since I posted this as an

[PATCH] wcn36xx: Silence error about unsupported smd event 188

2016-07-07 Thread Bjorn Andersson
Sometimes the firmware sends a HAL_DEL_BA_IND, the prima driver silently ignore this message so let's do the same to silence the error message. Cc: Nicolas Dechesne <nicolas.deche...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-07-28 Thread Bjorn Andersson
On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > > [..] > > Do not quite like it... I'd rather asynchronous request give out a > firmware status pointer that could be used

Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion

2016-08-03 Thread Bjorn Andersson
On Wed 03 Aug 08:55 PDT 2016, Luis R. Rodriguez wrote: > On Wed, Aug 03, 2016 at 08:57:09AM +0200, Daniel Wagner wrote: > > On 08/02/2016 09:41 AM, Luis R. Rodriguez wrote: [..] > > Not sure if I get you here correctly. Is the 'system configurable > > deterministic file' is a knob which

[PATCH] wcn36xx: Implement print_reg indication

2016-06-30 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 16 dr

[PATCH] wcn36xx: Implement cancel_hw_scan

2017-02-01 Thread Bjorn Andersson
In the even that the wcn36xx interface is brought down while a hw_scan is active we must abort and wait for the ongoing scan to signal completion to mac80211. Reported-by: Mart Raudsepp <l...@gentoo.org> Fixes: 886039036c20 ("wcn36xx: Implement firmware assisted scan") Sign

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-02 Thread Bjorn Andersson
On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > > channel, as such it should be a SMD client. This patch makes this > > transition,

[PATCH v4 3/4] wcn36xx: Implement firmware assisted scan

2016-09-06 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - None Changes since v2: -

[PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Bjorn Andersson
Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. Cc: Marcel Holtmann <mar...@holtmann.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- There are no other pending changes colliding with this, so if Andy is okay with this it could be me

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

2016-09-06 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - Rebased separate patch onto this series dr

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-06 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3:

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Bjorn Andersson
On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. This patch makes t

[PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-01 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - C

[PATCH v3 2/2] wcn36xx: Implement firmware assisted scan

2016-09-01 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - None drivers/net/wirele

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Bjorn Andersson
On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo <kv...@codeaurora.org> wrote: > >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: > >>

Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency

2016-11-09 Thread Bjorn Andersson
case either of > > those are =n, for compile testing reasons. > > > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > > --- > > drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --

  1   2   >