[PATCH 2/2] staging: wilc1000: remove unnecessary typecast in #define macro

Remove unnecessary typecast in #define macro. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 78 +++ 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b

[PATCH 1/4] staging: wilc1000: wilc_wfi_netdevice.c: remove commented codes

Remove commented codes. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c b/drivers/staging/wilc1000/wilc_wfi_netdevice.c

[PATCH 2/4] staging: wilc1000: wilc_wfi_netdevice.c: remove unused codes

Remove if statement that has no any codes. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c b/drivers/staging/wilc1000/wilc_wfi_netdevice.c

[PATCH 4/4] staging: wilc1000: wilc_wfi_netdevice.c: remove blank lines

Remove multiple blank lines. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c b/drivers/staging/wilc1000/wilc_wfi_netdevice.c

[PATCH 3/4] staging: wilc1000: wilc_wfi_netdevice.c: remove unused variable

Remove variable that is defined but never used. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c b/drivers/staging/wilc1000/wilc_wfi_netdevice.c

[PATCH 1/5] staging: wilc1000: wilc_wfi_netdevice.c: remove prohibited space before semicolon

Fix checkpatch warning found by checkpatch.pl WARNING: space prohibited before semicolon Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

[PATCH 2/5] staging: wilc1000: wilc_wfi_netdevice.c: remove prohibited space

Fix checkpatch warning found by checkpatch.pl WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 5/5] staging: wilc1000: wilc_wfi_netdevice.c: move statement after declarations

Fix checkpatch warning found by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

[PATCH 3/5] staging: wilc1000: wilc_wfi_netdevice.c: remove braces for single statement block

Fix checkpatch warning found by checkpatch.pl WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH 4/5] staging: wilc1000: wilc_wfi_netdevice.c: Insert blank line after declarations

Fix checkpatch warning found by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c

[PATCH V2] staging: wilc1000: remove commented code

Remove the commented codes using #if 0. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: revert commented code using typedef and rebase latest staging-testing. drivers/staging/wilc1000/coreconfigurator.c | 30 --- drivers/staging/wilc1000/coreconfigurator.h | 300

[PATCH 2/2] staging: wilc1000: remove itypes.h

Remove itypes.h that is not needed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 1 - drivers/staging/wilc1000/host_interface.c | 1 - drivers/staging/wilc1000/itypes.h | 39 - 3 files changed, 41

[PATCH 1/2] staging: wilc1000: remove BOOL_T typedef

Remove BOOL_T typedef. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/itypes.h | 9 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 3/4] staging: wilc1000: remove WILC_ErrNo

WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_errorsupport.h | 2 -- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h | 8

[PATCH 4/4] staging: wilc1000: return -EINVAL for invalid argument checking

This patch uses -EINVAL for invalid argument checking instead of using WILC_ERRORREPORT with WILC_INVALID_ARGUMENT. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 2/4] staging: wilc1000: delete wilc_osconfig.h

The macros inside wilc_osconfig.h are not referenced anywhere, so just delete it. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_osconfig.h | 9 - drivers/staging/wilc1000/wilc_oswrapper.h | 1 - 2 files changed, 10 deletions(-) delete mode 100644

[PATCH 1/4] staging: wilc1000: delete wilc_log.h

The macros in wilc_log.h are not referenced anywhere, so just delete it. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_log.h | 47 --- drivers/staging/wilc1000/wilc_oswrapper.h | 2 -- 2 files changed, 49 deletions

[PATCH 03/13] staging: wilc1000: wilc_msgqueue.c: remove multiple blank lines

This patch removes multiple blank lines. CHECK: Please don't use multiple blank lines Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging

[PATCH 11/13] staging: wilc1000: rename WILC_MsgQueueSend to wilc_mq_send

This patch replaces WILC_MsgQueueSend with wilc_mq_send to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 98 +++ drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers

[PATCH 04/13] staging: wilc1000: wilc_msgqueue.c: remove blank line before a close brace

This patch removes blank line before a close brace } CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000

[PATCH 09/13] staging: wilc1000: replace WILC_ErrNo by int type

This patch replaces WILC_ErrNo with int type. WILC_ErrNo typedef is also removed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_errorsupport.h | 2 -- drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++-- drivers/staging/wilc1000/wilc_msgqueue.h

[PATCH 05/13] staging: wilc1000: wilc_msgqueue.c: remove unnecessary parentheses

This patch remove unnecessary parentheses found by checkpatch.pl CHECK: Unnecessary parentheses around pHandle-hSem Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 07/13] staging: wilc1000: wilc_msgqueue.c: remove kfree NULL check

This patch removes kfree NULL check. WARNING: kfree(NULL) is safe and this check is probably not required. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 08/13] staging: wilc1000: wilc_msgqueue.c: fix bool comparison style

This patch changes bool comparison style found by checkpatch.pl CHECK: Using comparison to true is error prone Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 06/13] staging: wilc1000: wilc_msgqueue.c: use ! operator instead of NULL comparison

This patch uses ! operator instead of NULL comparison. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers

[PATCH 01/13] staging: wilc1000: wilc_msgqueue.c: remove braces for single statement

This patch removes braces for single statement blocks. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 12/13] staging: wilc1000: rename WILC_MsgQueueRecv to wilc_mq_recv

This patch replaces WILC_MsgQueueRecv with wilc_mq_recv to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000

[PATCH 13/13] staging: wilc1000: rename WILC_MsgQueueDestroy to wilc_mq_destroy

This patch replaces WILC_MsgQueueDestroy to wilc_mq_destroy to shorten function name and avoid CamelCase. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- drivers/staging/wilc1000

[PATCH 02/13] staging: wilc1000: wilc_msgqueue.c: remove blank line after open brace

This patch removes a blank line for open brace { CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH] staging: wilc1000: add a blank line after declaration

This patch adds a blank line after declaration found by checkpatch.pl WARNING: Missing a blank line after declarations. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 8 drivers/staging/wilc1000/linux_wlan.c | 18

[PATCH 2/6] staging: wilc1000: remove WILC_NEW and WILC_NEW_EX

This patch removes WILC_NEW and WILC_NEW_EX defines that are not used anywhere. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_memory.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_memory.h b/drivers

[PATCH 6/6] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

It is added and fixed error check when kmalloc is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b

[PATCH 3/6] staging: wilc1000: remove unnecessary void pointer cast

This patch removes unnecessary void pointer cast of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 12 ++-- drivers/staging/wilc1000/host_interface.c | 78 +++ drivers/staging/wilc1000

[PATCH 4/6] staging: wilc1000: remove unused codes of gps8ConfigPacket

This patch removes unused codes of gps8ConfigPacket declared by global variable. It is allocated and freed memory within CoreConfiguratorInit and CoreConfiguratorDeInit. There is no used anywhere except within two functions. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging

[PATCH 1/6] staging: wilc1000: use kmalloc instead of WILC_NEW

WILC_NEW is replaced by kmallo with GFP_ATOMIC. This kmalloc is inside a spin_lock_irqsave region. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

[PATCH 5/6] staging: wilc1000: coreconfigurator.c: use kmalloc instead of WILC_MALLOC

The kmalloc is used to handle host interface message within kernel thread. The manipulation of host interface message is not called on IRQ context and I could not find any spinlock inside function. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c

[RESEND V2 3/3] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

Return -ENOMEM if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging

[RESEND V2 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check

Add error check if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[RESEND V2 0/3] cover letter of wilc1000 patches

is not called on IRQ context and I could not find any spin lock inside function. If this patches are accepted, I will try to continue to change WILC_MALLOC macro as kmalloc. I always appreciate your comment and advice. Thanks Chaehyun Lim Chaehyun Lim (3): staging: wilc1000: coreconfigurator.c

[RESEND V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers

Re: [RESEND V2 0/3] cover letter of wilc1000 patches

I'm sorry that I have mistake the number of kmalloc changes. The total change is 6, not 4. On Thu, Jul 30, 2015 at 8:41 PM, Chaehyun Lim chaehyun@gmail.com wrote: Hi, Greg I'm sorry that I did not say whether GFP_ATOMIC should be used or not. This is my review on it. If it's not correct

[PATCH 3/4] staging: wilc1000: use memcmp instead of WILC_memcmp

Use memcmp instead of WILC_memcmp. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 20 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 32 +++ 2 files changed, 26 insertions(+), 26 deletions

[PATCH 1/4] staging: wilc1000: use memset instead of WILC_memset

Use memset instead of WILC_memset. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 16 +-- drivers/staging/wilc1000/host_interface.c | 134 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16 +-- 3

[PATCH 2/4] staging: wilc1000: remove WILC_memset function

Remove WILC_memset function because it is changed to memset. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_strutils.c | 9 - drivers/staging/wilc1000/wilc_strutils.h | 12 2 files changed, 21 deletions(-) diff --git a/drivers/staging

[PATCH 4/4] staging: wilc1000: remove WILC_memcmp function

Remove WILC_memcmp function because it is changed to memcmp. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_strutils.c | 9 - drivers/staging/wilc1000/wilc_strutils.h | 13 - 2 files changed, 22 deletions(-) diff --git a/drivers/staging

[PATCH 4/4] staging: wilc1000: remove WILC_FREE

Remove WILC_FREE that is replaced by kfree. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_memory.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_memory.h b/drivers/staging/wilc1000/wilc_memory.h index 1c0cb82

[PATCH 3/4] staging: wilc1000: use kfree instead of WILC_FREE

Use kfree instead of WILC_FREE. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 12 +-- drivers/staging/wilc1000/host_interface.c | 112 +++--- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers

[PATCH 1/4] staging: wilc1000: wilc_memory.h: remove unused define

Remove unused define macro that is never used. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_memory.h | 51 -- 1 file changed, 51 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_memory.h b/drivers/staging/wilc1000

[PATCH 2/4] staging: wilc1000: remove unused memory functions

This patch remove unused memory functions because some macros with this memory function are deleted. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_memory.c | 28 --- drivers/staging/wilc1000/wilc_memory.h | 50

[PATCH 11/11] staging: wilc1000: remove wilc_strutils.c and wilc_strutils.h

Remove wilc_strutils.c and wilc_strutils.h that are not needed. wilc_strutils.o is also removed in Makefile. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/wilc_msgqueue.h | 1 - drivers/staging/wilc1000

[PATCH 09/11] staging: wilc1000: remove WILC_memcpy function

Remove WILC_memcpy function that is changed to memcpy. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_strutils.h | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_strutils.h b/drivers/staging

[PATCH V3 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check

Add error check if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: use ! operator instead of NULL comparison V3: this patch is rebased by previous modification drivers/staging/wilc1000/coreconfigurator.c | 12 1 file changed, 12 insertions

[PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: Use GFP_KERNEL flag instead of GFP_ATOMIC drivers/staging/wilc1000/coreconfigurator.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH V3 3/3] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

Return -ENOMEM if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: Use ! operator instead of NULL comparison V3: this patch is rebased by previous modification drivers/staging/wilc1000/coreconfigurator.c | 13 - 1 file changed, 4 insertions

[PATCH 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check

Add error check if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 3/3] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

Return -ENOMEM if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging

[PATCH 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers

[PATCH V2 3/3] staging: wilc1000: coreconfigurator.c: fix kmalloc error check

Return -ENOMEM if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: use ! operator instead of NULL comparison. drivers/staging/wilc1000/coreconfigurator.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH V2 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check

Add error check if memory allocation is failed. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: use ! operator instead of NULL comparison drivers/staging/wilc1000/coreconfigurator.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/wilc1000

Re: [PATCH 2/2] staging: wilc1000: fix memory allocation error check

On Wed, Jul 15, 2015 at 6:16 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jul 14, 2015 at 10:48:41AM +0900, Chaehyun Lim wrote: Remove WILC_ERRORREPORT macro. If memory allocation is failed, jump to a label to return this function with WILC_NO_MEM. Signed-off-by: Chaehyun Lim

[PATCH 2/2] staging: wilc1000: fix memory allocation error check

Remove WILC_ERRORREPORT macro. If memory allocation is failed, jump to a label to return this function with WILC_NO_MEM. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] staging: wilc1000: fix uninitialized variablie warning

When building this driver, I got a warning as below: host_interface.c: In function ‘host_int_add_beacon’: host_interface.c:7116:16: warning: ‘*((void *)strHostIFmsg+8).pu8Head’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Chaehyun Lim chaehyun@gmail.com

[PATCH 4/4] staging: wilc1000: rename host_int_set_WEPDefaultKeyID

This patch replaces host_int_set_WEPDefaultKeyID with host_int_set_wep_default_key to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/s

[PATCH 3/4] staging: wilc1000: rename u8Index in host_int_set_WEPDefaultKeyID

This patch changes second parameter of host_int_set_WEPDefaultKeyID from u8Index to index to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files chan

[PATCH 2/4] staging: wilc1000: fix parameter name of function declaration

This patch changes struct host_if_drv of host_int_set_WEPDefaultKeyID function declaration from hWFIDrv to hif_drv in host_interface.h With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.

[PATCH 1/4] staging: wilc1000: fix return type of host_int_set_WEPDefaultKeyID

This patch changes return type of host_int_set_WEPDefaultKeyID from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type int as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaehyun@gmail.

[PATCH 1/8] staging: wilc1000: fix return type of host_int_add_wep_key_bss_sta

This patch changes return type of host_int_add_wep_key_bss_sta from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH 4/8] staging: wilc1000: rename u8WepKeylen in host_int_add_wep_key_bss_sta

This patch changes u8WepKeylen to len that is third argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/host_interface.h | 2 +- 2 files chan

[PATCH 2/8] staging: wilc1000: fix parameter name of function declaration

This patch changes struct host_if_drv of host_int_add_wep_key_bss_sta function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- d

[PATCH 5/8] staging: wilc1000: rename u8Keyidx in host_int_add_wep_key_bss_sta

This patch changes u8Keyidx to index that is fourth argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files chan

[PATCH 7/8] staging: wilc1000: fix line over 80 characters

This patch fixes line over 80 characters found by checkpatch. WARNING: line over 80 characters FILE: drivers/staging/wilc1000/host_interface.h:408: Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.h | 3 ++- 1 file changed, 2 insertions

[PATCH 8/8] staging: wilc1000: remove multiple blank lines

This patch removes multiple blank lines found by checkpatch. CHECK: Please don't use multiple blank lines FILE: drivers/staging/wilc1000/host_interface.c:3175: Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 de

[PATCH 6/8] staging: wilc1000: replace kmalloc/memcpy with kmemdup

This patch replaces kmalloc followed by memcpy with kmemdup. It is also added error checking of kmemdup. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 3/8] staging: wilc1000: rename pu8WepKey in host_int_add_wep_key_bss_sta

This patch changes pu8WepKey to key that is second argument of host_int_add_wep_key_bss_sta to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files chan

[PATCH 05/12] staging: wilc1000: rename pu8MacAddr in host_int_del_station

This patch changes pu8MacAddr to mac_addr that is second argument of this function to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 inse

[PATCH 02/12] staging: wilc1000: fix parameter name of host_int_del_beacon

This patch changes struct host_if_drv of host_int_del_beacon function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/s

[PATCH 04/12] staging: wilc1000: fix parameter name of host_int_del_station

This patch changes struct host_if_drv of host_int_del_station function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/s

[PATCH 01/12] staging: wilc1000: fix return type of host_int_del_beacon

This patch changes return type of host_int_del_beacon from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH 09/12] staging: wilc1000: rename pstrStaParams in host_int_add_station

This patch renames pstrStaParams to sta_param to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 08/12] staging: wilc1000: fix parameter name of host_int_add_station

This patch changes struct host_if_drv of host_int_add_station function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/s

[PATCH 06/12] staging: wilc1000: rename pstrDelStationMsg in host_int_del_station

This patch renames pstrDelStationMsg to del_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interfac

[PATCH 07/12] staging: wilc1000: fix return type of host_int_add_station

This patch changes return type of host_int_add_station from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH 12/12] staging: wilc1000: remove rates in host_int_add_station

Instead of using rates variable, it is used as add_sta_info->pu8Rates directly. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH 10/12] staging: wilc1000: rename pstrAddStationMsg in host_int_add_station

This patch renames pstrAddStationMsg to add_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_inter

[PATCH 11/12] staging: use kmemdup in host_int_add_station

This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/s

[PATCH V2 07/12] staging: wilc1000: fix return type of host_int_add_station

This patch changes return type of host_int_add_station from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH V2 02/12] staging: wilc1000: fix parameter name of host_int_del_beacon

This patch changes struct host_if_drv of host_int_del_beacon function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because

[PATCH V2 04/12] staging: wilc1000: fix parameter name of host_int_del_station

This patch changes struct host_if_drv of host_int_del_station function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend beca

[PATCH V2 06/12] staging: wilc1000: rename pstrDelStationMsg in host_int_del_station

This patch renames pstrDelStationMsg to del_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because 11/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH V2 11/12] staging: wilc1000: use kmemdup in host_int_add_station

This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: add wilc1000 driver name in commit title because driver name is not included at V1. drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 inse

[PATCH V2 01/12] staging: wilc1000: fix return type of host_int_del_beacon

This patch changes return type of host_int_del_beacon from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH V2 10/12] staging: wilc1000: rename pstrAddStationMsg in host_int_add_station

This patch renames pstrAddStationMsg to add_sta_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because 11/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH V2 08/12] staging: wilc1000: fix parameter name of host_int_add_station

This patch changes struct host_if_drv of host_int_add_station function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend beca

[PATCH V2 03/12] staging: wilc1000: fix return type of host_int_del_station

This patch changes return type of host_int_del_station from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH V2 05/12] staging: wilc1000: rename pu8MacAddr in host_int_del_station

This patch changes pu8MacAddr to mac_addr that is second argument of this function to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because 11/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wi

[PATCH V2 09/12] staging: wilc1000: rename pstrStaParams in host_int_add_station

This patch renames pstrStaParams to sta_param to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because 11/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files chan

[PATCH V2 12/12] staging: wilc1000: remove rates in host_int_add_station

Instead of using rates variable, it is used as add_sta_info->pu8Rates directly. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- V2: resend because 11/12 patch is changed. drivers/staging/wilc1000/host_interface.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions

[PATCH 01/10] staging: wilc1000: fix return type of host_int_add_wep_key_bss_ap

This patch changes return type of host_int_add_wep_key_bss_ap from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type of this function as well as data type of result variable. Signed-off-by: Chaehyun Lim <chaeh

[PATCH 03/10] staging: wilc1000: replace u8 with int.

This patch changes data type of variable i from u8 to int. It is used as index of an array to print its content. It's better to use as data type of int. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion

[PATCH 02/10] staging: wilc1000: fix parameter name of function declaration

This patch changes struct host_if_drv of host_int_add_wep_key_bss_ap function declaration from hWFIDrv to hif_drv. With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim <chaehyun@gmail.com> --- drivers/s

  1   2   3   4   5   6   7   8   >