are writing u16 but the for loop limit is in terms of bytes so this
loop will corrupt memory past the end of the buffer.
943 }
944
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
iwl_mvm_power_update_mac(mvm);
2779 out:
2780 if (ret)
2781 mvmvif-phy_ctxt = NULL;
2782 return ret;
2783 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
}
291 else {
292 netdev_dbg(dev-net, Correct package length
#%i, i
293 + 1);
294
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message
GFP_ATOMIC);
1306 if (!network-ibss_dfs)
1307 return 1;
1308 network-flags |= NETWORK_HAS_IBSS_DFS;
1309 break;
regards,
dan carpenter
On Fri, Oct 03, 2014 at 03:11:01PM +0300, Dan Carpenter wrote:
Hello Sujith Manoharan,
This is a semi-automatic email about new static checker warnings.
The patch e6664dff0608: ath: Add support for tracing from Sep 27,
2014, leads to the following Smatch complaint:
drivers/net/wireless
The return from myid() isn't aligned correctly for ether_addr_copy().
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 3eb77de..c8f7890 100644
--- a/drivers/staging/rtl8723au
it is a real problem.
Well... You would be better off using Smatch than pahole. And
obviously I did try something like this, but it's fairly tricky.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
. This patch deletes it along with all the related code. In
particular the entire libipw_network_reset() function can be removed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/ipw2x00/libipw.h
b/drivers/net/wireless/ipw2x00/libipw.h
index 5ce2f59
The -parent_tsf[] array holds u8 values. It type promoted to int for
the shift operation so the 24 shift operation can wrap. The cast
needs to be done before the shift instead of after.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker work. Untested.
diff --git
The right shift operation has higher precedence than the mask so we
left shift by (i * 3) and then immediately right shift by (i * 3)
then we mask. It should be left shift, mask, and then right shift.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/ath
the static checker warning.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/iwlwifi/dvm/lib.c
b/drivers/net/wireless/iwlwifi/dvm/lib.c
index 2191621..065d3d5 100644
--- a/drivers/net/wireless/iwlwifi/dvm/lib.c
+++ b/drivers/net/wireless/iwlwifi/dvm/lib.c
On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
The right shift operation has higher precedence than the mask so we
left shift by (i * 3) and then immediately right shift by (i * 3)
then we mask. It should be left shift
On Wed, Oct 29, 2014 at 09:13:24AM -0700, Joe Perches wrote:
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote:
On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
The right shift operation has higher precedence than
= brcmf_update_pmklist(ndev, cfg-pmk_list, err);
2984
2985 brcmf_dbg(TRACE, Exit\n);
2986 return err;
2987 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info
warnings are a pain.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 31, 2014 at 03:37:36PM +0100, Arend van Spriel wrote:
On 10/31/14 15:26, Dan Carpenter wrote:
On Fri, Oct 31, 2014 at 03:18:27PM +0100, Arend van Spriel wrote:
Understood. Not sure what the motivation is to mistrust endian more.
Endian data tends to come from suspicious places
wl1271_warning(CONFIGURE command NOK);
903 return ret;
904 }
905
906 return ret;
907 }
See also:
drivers/net/wireless/ti/wl1251/cmd.c:29 wl1251_cmd_send()
warn: is 'buf' large enough for 'struct wl1251_cmd_header'?
regards,
dan carpenter
The brcms_c_attach_malloc() function can call this with a NULL
wlc-corestate or wlc-hw.
Also I threw in a bonus cleanup by deleting an obvious comment and a
no-op NULL assignment. :)
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/brcm80211/brcmsmac
This will make Kees Cook happy if we specify a format string and, who
knows, maybe someday there will be a firmware version with a percent
character and we'll be glad for this.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c
b/drivers
st21nfca_dep_event_received(hdev, event, skb);
845 default:
846 return 1;
847 }
848 kfree_skb(skb);
^^
Not reached. Confusing.
849 return 0;
850 }
regards,
dan carpenter
--
To unsubscribe from this list: send
away, but I think it
introduces new bugs.
This kind of change, doesn't change the compiled code only how Sparse
sees it. It can't introduce bugs.
But it may well be that the calls to le16_to_cpu() should be removed. I
looked at it a bit but I don't know.
regards,
dan carpenter
/drivers/staging/rtl8723au/os_dep/usb_intf.c
@@ -351,10 +351,11 @@ error_exit:
int rtw_hw_resume23a(struct rtw_adapter *padapter)
That's weird. Is this function even called?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body
We recently introduced a new error path which needs an unlock.
Fixes: 6d5a748d4836 ('wlcore: add ability to reduce FW interrupts during
suspend')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker fix. It's possible that wl1271_ps_elp_wakeup() unlocks
on error but I didn't
have comments like:
net/nfc/hci/core.c:218 nfc_hci_cmd_received()
error: buffer overflow 'hdev-pipes' 127 = 255
But this one doesn't have a comment so it's hard for me as an outsider
to say if this is a bug or not.
322
regards,
dan carpenter
--
To unsubscribe from this list
It's clear from the indenting that curly braces were intended here.
Fixes: e35000ead491 ('mwifiex: preprocess packets from TX queue')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/mwifiex/txrx.c
b/drivers/net/wireless/mwifiex/txrx.c
index 4d43371
adapter-sleep_cfm is always non-NULL at this point. Static checkers
complain that we already dereference it at the start of the function
when we do:
skb_put(adapter-sleep_cfm, sizeof(struct mwifiex_opt_sleep_confirm));
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
not sure I can release it.
3) This code is just confusing. The error and the success paths are
twisted together. After the first allocation then the exclusive
parts of the success path move from indent level 1 to indent level 2.
Confusing code is more likely to have bugs.
regards,
dan
This code is written using an anti-pattern called success handling
which makes it hard to read, especially if you are used to normal kernel
style. It should instead be written as a list of directives in a row
with branches for error handling.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
be inside the while loop.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
index 3f6c59c..a2bb02c 100644
;
6389 }
6390 il4965_init_hw_rates(il, il-ieee_rates);
^^
This will lead to a NULL dereference inside the il4965_init_hw_rates()
function.
6391
6392 return 0;
regards,
dan carpenter
--
To unsubscribe from
This doesn't look right and it doesn't have a changelog explainly the
weirdness.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
+L: de...@driverdev.osuosl.org
You don't need to add this. It's automatic for everything in
drivers/staging.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I never got a response on this. Is this remote exploitable or from the
firmware?
regards,
dan carpenter
On Tue, Feb 10, 2015 at 12:00:51PM +0300, Dan Carpenter wrote:
Hello Christophe Ricard,
The patch 26fc6c7f02cb: NFC: st21nfca: Add HCI transaction event
support from Feb 1, 2015, leads
Thanks. These look nice.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
then we can think about 64 bit bugs (like this patch
and the next).
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-wid_header[0], total_len))
And I don't know what we do with it after this.
1898 return -1;
1899
1900 return 0;
1901 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
This silences the warning but really the warnings indicate real bugs
which need to be fixed. Silencing these warnings makes the bugs harder
to find so it is a step in the wrong direction.
Change SendConfigPkt() so that drvHandler is a pointer.
regards,
dan carpenter
--
To unsubscribe from
);
^
Patch introduces unchecked dereference.
476
477 if (priv-bss_role == MWIFIEX_BSS_ROLE_UAP)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message
false is
correct here.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 30, 2015 at 05:58:13PM +0900, Dean.lee wrote:
On 2015년 06월 30일 17:50, Dan Carpenter wrote:
On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote:
this function needs more arguments.
Sudip sent a patch for this but he passed false instead of true.
We are disconnecting
functions now return the return value of FillH2CCmd.
If they are never checked then why do we need to return some value?
why not make them void?
They probably *should* be checked eventually?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body
;
+ param_le = cpu_to_le32(*(param));
We shouldn't be passing param as a pointer anyway. It should just be
u32 cmd.
__le32 cmd_le = cpu_to_le32(cmd);
FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (u8 *)cmd_le);
Fold it together with patch 1.
regards,
dan carpenter
is too generic. Use a meaningful name.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is not described in the patch description.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
through the normal review process. The intern process is over
this year. The lack of normal review introduced a number of bugs this
year. I always complain to Greg about it and he says that I should join
the intern mailing list if I care so much.
regards,
dan carpenter
--
To unsubscribe from this list
I'm annoyed already since
we have been dealing with the fallout for months and I always make sure
to complain whenever I have a chance. /me shakes a fist! Grrr :P
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message
as a favour to us.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is easy to delete. Or even just
apply them first, and we tell people to send follow on patches or revert
as needed. My whole setup revolves around email so finding and
reviewing patches using git log is awkward.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
,
it never went through the list.
I'm fine with 5 bugs per 900 patches or whatever. I wish that the
patches came to the list, but I get that that would double your review
workload to review 900 patches on the outreachy list and again on the
normal dev list.
regards,
dan carpenter
--
To unsubscribe
;
return wfidrv_list[id];
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote:
Hello Dan.
On 2015년 08월 13일 23:49, Dan Carpenter wrote:
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler)
+{
+ u32 id;
+
+ if (!handler)
+ return 0
;\
+ }
+ } while (0)
Pull it in one indent level... But actually this macro has a return in
the middle of it, so it just introduces bugs all over the place like
eating cookies in bed. We should just delete it instead.
regards,
dan carpenter
--
To unsubscribe from this list: send
On Mon, Aug 17, 2015 at 12:08:36PM -0400, Raphaël Beamonte wrote:
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8 +++
drivers/staging/wilc1000/linux_wlan_common.h |
On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
2015-08-17 13:47 GMT-04:00 Dan Carpenter dan.carpen...@oracle.com:
- printk([Sendconfigpkt]Get Timed out\n);
+ pr_debug([Sendconfigpkt]Get Timed out\n);
Possibly
if (sdata-rc_has_mcs_mask[i]
2524 sdata-rc_has_vht_mcs_mask[i])
2525 break;
Maybe we always break out before we get to the last two iterations?
2526 }
regards,
dan carpenter
--
To unsubscribe from
To be honest, I have lost track of this patchset. If you are planning
to redo the other patches can you send it in a new thread?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo
at the start of the function, because
I thought it made the code a little more clear.
Fixes: 5e6e3a92b9a4 ('wireless: mwifiex: initial commit for Marvell mwifiex
driver')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/mwifiex/debugfs.c
b/drivers/net
My static checker complains that we don't check for underflows in
iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a
sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make
this unsigned and silence the underflow warning.
Signed-off-by: Dan Carpenter dan.carpen
Real ID value means the value mapped to an alive NIC handler.
Who is mapping it? It's all within the driver so it is not real
unless there external requirements.
And when the driver transmits and receives some data frame with chipset,
the ID is used to distinguish the data frame's owner.
, 4,
0, drvHandler))
goto _fail_;
We are changing from 0 to drvHandler. That is not described in the
patch description. Do it in a different patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
)) {
int size;
char Firmware_ver[20];
size = g_linux_wlan-oup.wlan_cfg_get_value(
This change is not in the patch description.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body
Looks good. :)
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
allowed far
worse things in that series of 150 unisys patches which was probably
a mistake in retrospect.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Got it, thanks.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
on IRQ context and
I could not
find any spin lock inside function.
This information is good information and it should be in the patch
description.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
The current code returns success if kmalloc fails.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/net/wireless/mwifiex/usb.c
b/drivers/net/wireless/mwifiex/usb.c
index fbad99c..f866d5d 100644
--- a/drivers/net/wireless/mwifiex/usb.c
+++ b/drivers/net/wireless/mwifiex
are just silencing warnings or cleaning up code. It's not clear from
the patch description what is happening here, is it a bug or a warning
only?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
to a read past the end of the array later. In
the original code, we just looked at the first char and didn't use
kstrtoint() so we didn't care about NUL termination.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord
= u32HeadLen + u32TailLen + 16;
printf(Allocating %d bytes.\n, s32ValueSize);
printf(Copying %u bytes into a %d byte buffer will corrupt memory.\n,
u32HeadLen, s32ValueSize);
return 0;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line
to leave the code as-is that is absolutely fine with me, but
don't remove the warning until someone can look at this a bit carefully.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More
it
is doesn't just corrupt everything (DoS attack instead of privilege
escalation).
I have just looked at the code so I don't know if this is true, but this
is how I read that warning.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body
array, ints instead of u32s and added some error handling.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
:
if (!pstrNetworkInfo)
return -ENOMEM;
These patches are nice otherwise.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
holding a spin_lock or in IRQ context?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015년 07월 24일 09:44, Dan Carpenter wrote:
On Fri, Jul 24, 2015 at 08:55:53AM +0900, Chaehyun Lim wrote:
Use kmalloc and kmalloc_array instead of WILC_MALLOC.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
V2: Use GFP_KERNEL flag instead of GFP_ATOMIC
This is probably
The outside if statement checks that IEEE80211_TX_INTFL_MLME_CONN_TX is
set so this condition is always true. Checking twice upsets the static
checkers.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index 45628f3..8ba5832 100644
, ETH_ALEN) ||
> + !memcmp(Bssid, g_linux_wlan->vif[i].aBSSID, ETH_ALEN))
> + return g_linux_wlan->vif[i].wilc_netdev;
> +
Removing the curly braces was wrong. Multi-line indents get curly
braces for readability even though the compiler does not insist
Don't resend the series though. Please fix it in a later patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
dn't handle WPARxGtk while
> enuHostIFstate is not HOST_IF_CONNECTED\n");
> + PRINT_ER("Couldn't handle WPARxGtk while \
> + state is not HOST_IF_CONNECTED\n");
This line break is not correct. It adds unwanted indenting
strHostIfBASessionInfo->u16BufferSize,
> strHostIfBASessionInfo->u16SessionTimeout,
> strHostIfBASessionInfo->u8Ted);
This should be a bunch of printks so that we have the correct debug
level at the start of each line.
regards,
dan carpenter
--
On Fri, Oct 23, 2015 at 02:28:21PM +0900, Glen Lee wrote:
> This patch add new argument wilc to wilc_handle_isr and pass wilc to
> the function.
It's not important enough to redo the patch but why are we sometimes
using "wl" and sometimes "wilc"?
regards,
dan carpent
s wl? That seems like an arbitrary meaningless distinction. It just
makes searching harder and complicates things for no reason.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.
use it? Just declare move it to
wilc_netdev_init(). Also there are too many ifdefs in this code.
regards,
dan carpenter
On Mon, Nov 09, 2015 at 03:01:50AM +0530, Punit Vara wrote:
> This patch is to the linux_wlan.c file that fixes up break found during
> make drivers/staging/wilc1000/linux_
d configuration?
>
> static int __init init_wilc_driver(void)
> {
> #ifdef WILC_SPI
This should be #ifndef WILC_SDIO
> struct wilc *wilc;
> #endif
But the large question remains of why do we have this variable here any
way?
regards,
dan carpenter
--
To unsubscribe
h.pl warning. The prefered style is:
wl = kzalloc(sizeof(*wl), GFP_KERNEL);
But the larger point is that please use checkpatch.pl.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.o
| irq != phy->i2c_dev->irq) {
Check.
217 WARN_ON_ONCE(1);
218 return IRQ_NONE;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More
Why are you resending these?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
nit_wilc_driver(void)
> {
> + struct wilc *wilc;
> #ifdef WILC_SPI
> struct wilc *wilc;
> #endif
This patch still has the same problems as before.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless&
I haven't looked at it, sorry. You'll have to figure it out or if you
complain to the original person who broken the build he can figure it
out. You are still missing a Fixes tag.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" i
I've moved the check for "number_destination_params" forward a few lines
to avoid leaking "cmd".
Fixes: caa575a86ec1 ('NFC: nci: fix possible crash in nci_core_conn_create')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/net/nfc/nci/core.c b/net/nf
quot;);
> - goto _fail_;
> + return ret;
> }
> PRINT_D(INIT_DBG, "Firmware successfully started\n");
>
> -_fail_:
> return ret;
In a later patch, could you change this from "return ret;" to
"return 0;"
rega
We check for overflow here, but we don't check for underflow so it
causes a static checker warning.
Fixes: fb9987d0f748 ('ath9k_htc: Support for AR9271 chipset.')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c
b/drivers/net/wi
d breakage. Sending this patch is a sign that something is wrong in
your test infrastructure.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
struct wilc *wilc;
> > #endif
The problem is that now if WILC_SPI is defined it's declared twice so
this patch is definitely wrong. I haven't looked at it further than
that, sorry.
CC the atmel people with these patches. Use ./scripts/get_maintainer.pl
to find the right maintai
3 }
684
685 open_pipe:
686 r = nci_hci_open_pipe(ndev, pipe);
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
064 nfc_put_device(dev);
It should not call nfc_put_device() because that happens after goto
exit.
1065 rc = -ENODEV;
1066 goto exit;
1067 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscri
c and null check if-statement.
>
I said that that patch was fine. I was intending that you change all of
them in a later patch. I really try to not delay progress with small
review comments.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2g->index_bw40_base[path][group] =
0x2D;
1806 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 344 matches
Mail list logo
