Hello Tony,
On Tue, Mar 10, 2015 at 6:35 PM, Tony Lindgren t...@atomide.com wrote:
we do have to make sure these wl18xx bindings are future-compatible
with the wl12xx ones, but i think the current bindings are pretty much
standard (and are actually a subset of the bindings needed by wl12xx),
Hello Eliad,
On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas
jav...@dowhile0.org wrote:
On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote:
--- a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
+++ b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
@@ -42,4 +42,13
Hello Arnd,
On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote:
On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas wrote:
What do you mean by parsing here? IIUC there isn't a clock driver for
these clocks and are setup directly in the
drivers/net/wireless/ti/wl12xx
Hello Eliad,
On Wed, Mar 11, 2015 at 12:59 PM, Eliad Peller el...@wizery.com wrote:
On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas
jav...@dowhile0.org wrote:
But there wasn't a DT binding to describe that so most boards use the
same hack which is to define a fake fixed-regulator
, your patch looks good to me so for the
arch/arm/boot/dts/omap3-igep00* changes:
Acked-by: Javier Martinez Canillas jav...@dowhile0.org
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More
Hello Eliad,
On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote:
Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and
omap3-igep0020-rev-f dts files, instead of defining the
platform data through the pdata-quirks.
The patch was compile-tested only.
You should look at
Hello Eliad,
On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote:
When running with device-tree, we no longer have a board file
that can set up the platform data for wlcore.
Allow this data to be passed from DT.
For now, parse only the irq used. Other (optional) properties
patches in this series, will break
module autoloading for the drivers of devices registered using OF but
that lacks an of_match_table. I'll repost patch #18 once all the patches
in this series have landed.
[0]: https://lkml.org/lkml/2015/7/30/519
Best regards,
Javier
Javier Martinez Canillas (18
Hello Brian,
On 08/20/2015 11:11 PM, Brian Norris wrote:
On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches
^^^ I'm dying to know how this sentence ends :)
Sigh, I did some last minute restructuring
Hello,
On 10/13/2015 05:25 PM, kbuild test robot wrote:
> Hi Javier,
>
> [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please
> suggest rules for selecting the more suitable base]
>
> url:
> https://github.com/0day-ci/linux/commits/Javier-Martin
Hello Kalle,
On 10/14/2015 12:52 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> Hello,
>>
>> On 10/13/2015 05:25 PM, kbuild test robot wrote:
>>> Hi Javier,
>>>
>>> [auto build test ERROR on v4.3-rc5
Hello Kale,
On 10/14/2015 01:04 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> On 10/14/2015 12:52 PM, Kalle Valo wrote:
>>> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>>>
>>>> Thank
-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/bcma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 023d448ed3fa..22114995dfbf 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -63,7
The Documentation/devicetree/bindings/net/nfc/trf7970a.txt DT binding doc
lists "ti,trf7970a" as a compatible string but the corresponding driver
does not have an OF match table. Add the table to the driver so the SPI
core can do an OF style match.
Signed-off-by: Javier Martinez Can
to avoid leaking the buffer memory.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Changes in v2:
- Change also the #ifdef MEMORY_DYNAMIC to #ifndef MEMORY_STATIC since buffer
i
. This not only causes a
dereference to a pointer already freed but also leaks the memory in the
struct rxq_entry_t buffer.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/
The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression
and coccicheck complains with:
wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or |
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.
Hello Sudip,
Thanks a lot for your feedback.
On 09/22/2015 02:16 PM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote:
>> The wilc_wlan_cleanup() function iterates over the list of transmission
>> buffers freeing all of them and the
Hello Uri,
On Thu, Dec 24, 2015 at 12:35 PM, Uri Mashiach
wrote:
> Add DT support for the wl1271 SPI WiFi.
>
> Add documentation file for the wl1271 SPI WiFi.
>
> Signed-off-by: Uri Mashiach
> Acked-by: Igor Grinberg
Hello Uri,
On Thu, Dec 24, 2015 at 12:35 PM, Uri Mashiach
wrote:
> Device tree modifications:
> - Pinmux for SPI0 and WiFi GPIOs.
> - SPI0 node with wlcore as a child node.
>
> Cc: Tony Lindgren
> Signed-off-by: Uri Mashiach
0x1 RX 0x1
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Hello,
Even though this approach prevents the warning and allows to reports the
antenna values, it would be better if instead of caching the set values,
these are asked to the firmware for each .get_
by someone with access to the docs, if this is supported.
Best regards,
Javier
Javier Martinez Canillas (2):
mwifiex: add a cfg80211 .get_tx_power operation callback
mwifiex: add a cfg80211 .get_antenna operation callback
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 50
)
[] (request_firmware_work_func) from []
(process_one_work+0x124/0x338)
[] (process_one_work) from [] (worker_thread+0x38/0x4d4)
[] (worker_thread) from [] (kthread+0xdc/0xf4)
[] (kthread) from [] (ret_from_fork+0x14/0x3c)
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/m
ta_ioctl.c file.
[0]: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1160119.html
Best regards,
Javier
Javier Martinez Canillas (1):
mwifiex: add a cfg80211 .get_tx_power operation callback
Shengzhen Li (2):
mwifiex: move .get_tx_power logic to station ioctl file
mwifiex: add g
not warn anymore and:
$ iw phy phy0 info | grep Antennas
Available Antennas: TX 0x3 RX 0x3
Configured Antennas: TX 0x3 RX 0x3
Signed-off-by: Shengzhen Li <s...@marvell.com>
Signed-off-by: Amitkumar Karwar <akar...@marvell.com>
[javier: expand the commit message]
Signed-off-
Hello Amitkumar,
On 06/10/2016 12:26 PM, Amitkumar Karwar wrote:
> Hi Kalle/Javier,
>
>> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com]
>> Sent: Friday, June 10, 2016 8:07 PM
>> To: Kalle Valo
>> Cc: linux-ker...@vger.kernel.org; Julian Calaby; She
Hello Kalle,
On 06/10/2016 10:30 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> From: Shengzhen Li <s...@marvell.com>
>>
>> Most cfg80211 operations are just a wrappers to functions defined in the
>>
was not the case for
the mwifiex_add_card() error path.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/
It's better to have the device name prefixed in the error message.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/
that makes clear what the error really is. Also, returning a -1
as errno code is not correct since that's -EPERM. A -EINVAL seems to be
a more appropriate one.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
The function can fail so the returned value should be checked
and the error propagated to the caller in case of a failure.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++--
1 file changed, 7 insertions(+), 2 del
The Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT
binding document say that the "interrupts" property in the child node is
optional. So the property being missed shouldn't be treated as an error.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com&g
was returned by sdio_enable_func() at fail.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
b/drivers/net/wireless/m
also removes the assignment of sdio_disable_func() returned value
since it was overwritten anyways and what matters is to know the error
value returned by the first function that failed.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/m
in platforms that don't have a child
node defined.
So this series fixes this issue and others I found in the .probe function
(mostly related to error handling and the error path) while looking at it.
Best regards,
Javier
Javier Martinez Canillas (8):
mwifiex: only call mwifiex_sdio_probe_of
esn't have a node for a SDIO dev,
the following misleading error message will be printed:
[ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++---
1
Hello Julian,
Thanks a lot for your feedback and reviews.
On 06/01/2016 12:20 AM, Julian Calaby wrote:
> Hi All,
>
> On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
> <jav...@osg.samsung.com> wrote:
>> The Documentation/devicetree/bindings/net/wirele
Hello Kalle,
On 06/22/2016 02:17 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>>>> Patch 3/3 applies cleanly even after dropping patch 2/3.
>>>> Is that Ok for you or do you want me to re-resend a v3
>>>> w
Hello Kalle,
On 06/10/2016 03:54 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>>> This patch (2/3) is only for code rearrangement and adds an
>>> unnecessary wrapper function. We can simply drop the patch.
>>
>> Ag
Hello Kalle,
On 01/28/2016 10:05 AM, Kalle Valo wrote:
Kalle Valo <kv...@codeaurora.org> writes:
Javier Martinez Canillas <jav...@osg.samsung.com> writes:
On 10/14/2015 12:52 PM, Kalle Valo wrote:
Javier Martinez Canillas <jav...@osg.samsung.com> writes:
Thanks for re
Hello Kalle,
On 07/05/2016 09:09 AM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> writes:
>
>> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
>> interface") attempted to fix an issue when a new AP interface is
idn't fail.
This prevents the network device to be registered properly, so fix it.
Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
interface")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c
If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
is printed but the actual error is not propagated to the caller function.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 1 +
1 file changed, 1 ins
Hello Arend,
Thanks a lot for your feedback.
On 08/18/2016 03:14 PM, Arend van Spriel wrote:
> On 18-08-16 16:17, Javier Martinez Canillas wrote:
>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
>> is printed but the actual error is not propagate
Hello Arend,
On 08/18/2016 03:49 PM, Arend van Spriel wrote:
>
>
> On 18-08-16 21:29, Javier Martinez Canillas wrote:
>> Hello Arend,
>>
>> Thanks a lot for your feedback.
>>
>> On 08/18/2016 03:14 PM, Arend van Spriel wrote:
>>> O
Hello Kalle,
On 09/03/2016 12:35 PM, Kalle Valo wrote:
> Javier Martinez Canillas <jav...@osg.samsung.com> wrote:
>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
>> is printed but the actual error is not propagated to the caller function.
>&g
Hello Amitkumar,
On 09/08/2016 11:55 AM, Amitkumar Karwar wrote:
> Hi Javier,
>
>> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com]
>> Sent: Tuesday, September 06, 2016 5:43 PM
>> To: Kalle Valo
>> Cc: linux-ker...@vger.kernel.org; Amitkumar Karwar;
&g
Martinez Canillas <jav...@osg.samsung.com>
---
drivers/net/wireless/intel/iwlegacy/common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/common.h
b/drivers/net/wireless/intel/iwlegacy/common.h
index 726ede391cb9..3bba521d2cd9
by helping abstract away some
of the Kconfig built-in and module enable details.
[0]: https://lkml.org/lkml/2016/9/9/323
Best regards,
Javier
Javier Martinez Canillas (15):
3c59x: use IS_ENABLED() instead of checking for built-in or module
starfire: use IS_ENABLED() instead of checking for built
Hello Matt,
On Thu, Nov 17, 2016 at 10:55 PM, Matt Ranostay
wrote:
> Allow power sequencing for the Marvell SD8787 Wifi/BT chip.
> This can be abstracted to other chipsets if needed in the future.
>
> Cc: Tony Lindgren
> Cc: Ulf Hansson
Hello Matt,
On Tue, Nov 29, 2016 at 10:20 PM, Matt Ranostay
<matt@ranostay.consulting> wrote:
> On Tue, Nov 29, 2016 at 9:13 AM, Javier Martinez Canillas
[snip]
>
>
>>> +- pwndn-gpio: contains a power down GPIO specifier.
>>> +- reset-gpio: contains a reset GPI
51 matches
Mail list logo