On Wed, 2015-10-14 at 10:49 -0700, Eric Caruso wrote:
> This is a new Broadcom chip and we should be able to recognize it.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
[]
> @@ -1456,6 +1460,9 @@ static int
On Tue, 2015-09-01 at 15:09 +, David Laight wrote:
> From: Joe Perches
> > Sent: 31 August 2015 18:47
> >
> > The mwifiex_dbg macro has two tests that could be consolidated
> > into a function reducing overall object size ~10KB (~4%).
> >
> &g
4809 246539 3c30b
drivers/net/wireless/mwifiex/built-in.o.new
24394986284809 257386 3ed6a
drivers/net/wireless/mwifiex/built-in.o.old
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/net/wireless/mwifiex/main.c | 20
drivers/net/wireless/mwifiex/
On Sun, 2015-08-30 at 14:41 -0400, Jes Sorensen wrote:
Larry Finger larry.fin...@lwfinger.net writes:
[]
+ dev_info(priv-udev-dev, %s: dumping efuse (0x%02lx bytes):\n,
+ __func__, sizeof(struct rtl8192cu_efuse));
On a 32-bit PowerPC, the above line outputs the following:
On Mon, 2015-08-24 at 12:01 -0400, João Paulo Rechi Vita wrote:
When switching the state of all RFKill switches of type all we need to
replicate the RFKILL_TYPE_ALL global state to all the other types global
state, so it is used to initialize persistent RFKill switches on
register.
[]
diff
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/wilc1000/coreconfigurator.h | 30 +++
drivers/staging/wilc1000/linux_wlan_common.h | 4 +--
drivers/staging
trivial neatening of prototypes
Joe Perches (19):
staging: android: Remove unnecessary externs
staging: dgnc: Remove unnecessary externs
staging: fbtft: Remove unnecessary externs
staging: ft1000: Remove unnecessary externs
staging: iio: Remove unnecessary externs
staging: lustre
On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote:
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke shraddha.6...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1
On Thu, 2015-07-23 at 20:19 +0900, Chaehyun Lim wrote:
Add error check if memory allocation is failed.
trivia:
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/coreconfigurator.c
[]
@@ -812,6 +812,9 @@ s32 ParseNetworkInfo(u8 *pu8MsgBuffer, tstrNetworkInfo
On Tue, 2015-06-30 at 01:49 +, David Lin wrote:
The Linux driver for WRT1900AC. The work was initially developed as part of
openwrt effort and maintained on https://github.com/kaloz/mwlwifi.
trivia:
Please add terminating newlines to logging messages.
This prevents interleaving output from
On Fri, 2015-06-26 at 17:11 +0200, Luis de Bethencourt wrote:
On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote:
On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
Fix all checkpatch.pl warnings:
WARNING: unnecessary whitespace before a quoted newline
On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
Fix all checkpatch.pl warnings:
WARNING: unnecessary whitespace before a quoted newline
Unassociated but:
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
[]
@@ -740,7 +740,7 @@
On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote:
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
[]
diff --git a/drivers/net/wireless/ath/ath5k/phy.c
b/drivers/net/wireless/ath/ath5k/phy.c
[]
@@ -1566,17 +1566,13 @@ static s16
On Tue, 2015-06-02 at 21:39 +0200, Johannes Berg wrote:
From: Johannes Berg johannes.b...@intel.com
As we're running out of hardware capability flags pretty quickly,
convert them to use the regular test_bit() style unsigned long
bitmaps.
I think this is nice, thanks.
diff --git
On Mon, 2015-06-01 at 23:31 +0530, Avinash Patil wrote:
This patch adds more detailed information about association failures
- reason and states.
Signed-off-by: Avinash Patil pat...@marvell.com
Signed-off-by: Cathy Luo c...@marvell.com
Reviewed-by: Joe Perches j...@perches.com
Hello
On Thu, 2015-05-28 at 18:27 +0530, Avinash Patil wrote:
This patch adds more logging support for association failure -
reason and states.
[]
diff --git a/drivers/net/wireless/mwifiex/fw.h
b/drivers/net/wireless/mwifiex/fw.h
[]
@@ -419,8 +419,12 @@ enum P2P_MODES {
#define
On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote:
On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote:
The main point is that patches shouldn't be applied without
being submitted to a more widely read list.
I take the blame for any problems with Outreachy patches
On Mon, 2015-05-25 at 07:37 +, Rahul Jain wrote:
diff --git a/net/wireless/util.c b/net/wireless/util.c
[]
@@ -1340,10 +1340,7 @@ bool ieee80211_operating_class_to_band(u8
operating_class,
case 128 ... 130:
*band = IEEE80211_BAND_5GHZ;
return true;
-
On Mon, 2015-05-25 at 12:17 +0300, Dan Carpenter wrote:
These are special intern patches that
dont' go through the normal review process. The intern process is over
this year. The lack of normal review introduced a number of bugs this
year. I always complain to Greg about it and he says
On Mon, 2015-05-25 at 23:25 +0530, Shailendra Verma wrote:
The variable translate is bool type.So assigning true instead of 1.
There are a lot these in the kernel.
$ git grep -P ^[ \t]*(?:static[ \t]+)?(?:const\s+)?bool\s+\w+\s*=\s*[01]\s*;
* | wc -l
161
Are you going to submit patches for
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from the intern list
(no idea what that is) were sent to lkml/devel@driverdev lists
for review before actually being applied.
Its
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from
Add missing terminating newlines to nfc_info and nfc_err
to avoid possible interleaving from other messages.
Miscellanea:
o typo fix of unknonwn in message
o remove unnecessary OOM messages as there's a generic dump_stack()
o realign arguments
Signed-off-by: Joe Perches j...@perches.com
On Tue, 2015-04-07 at 12:07 +0200, Samuel Ortiz wrote:
Hi Joe,
Hi Samuel.
Resending after 8 weeks with no reply/review.
[]
Sorry for the lag. Patch applied to nfc-next now.
Oh, no worries, these were all just minor details,
thanks, Joe
--
To unsubscribe from this list: send the line
On Fri, 2015-04-03 at 14:13 -0700, gree...@candelatech.com wrote:
This message just fills up dmesg and/or kernel logs and does
not provide any useful information.
[]
diff --git a/drivers/net/wireless/mac80211_hwsim.c
b/drivers/net/wireless/mac80211_hwsim.c
[]
@@ -1696,7 +1696,7 @@ static int
On Mon, 2015-03-30 at 16:36 +0200, Johannes Berg wrote:
In order to speed up mac80211's TX path, add the fast-xmit cache
that will cache the data frame 802.11 header and other data to be
able to build the frame more quickly. This cache is rebuilt when
external triggers imply changes, but a lot
Use a #define constant instead of a hardcoded value
and use bool for an int used as a bool to reduce
structure size.
Miscellanea:
Neaten comments in structure definition.
Add #include of ieee80211.h
Signed-off-by: Joe Perches j...@perches.com
---
net/mac80211/ieee80211_i.h | 7 ---
net
On Mon, 2015-03-30 at 17:07 +0200, Johannes Berg wrote:
On Mon, 2015-03-30 at 08:03 -0700, Joe Perches wrote:
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
[]
+void ieee80211_check_fast_xmit(struct sta_info *sta, gfp_t gfp)
+{
+ struct ieee80211_fast_tx build = {}, *fast_tx
On Mon, 2015-03-30 at 22:01 +0200, Johannes Berg wrote:
On Mon, 2015-03-30 at 09:37 -0700, Joe Perches wrote:
@@ -89,11 +90,11 @@ struct ieee80211_fragment_entry {
unsigned int last_frag;
unsigned int extra_len;
struct sk_buff_head skb_list;
- int ccmp; /* Whether
Use bool constants as the return values instead of 1 and 0.
Signed-off-by: Joe Perches j...@perches.com
---
To be honest I'd might rather get bunches of these, there has to be a ton
of them, than a slow trickle of one every few weeks/days.
There aren't too many here either...
drivers/net
On Sun, 2015-03-29 at 20:46 -0500, Larry Finger wrote:
On 03/29/2015 08:29 PM, Joe Perches wrote:
Use bool constants as the return values instead of 1 and 0.
Signed-off-by: Joe Perches j...@perches.com
---
To be honest I'd might rather get bunches of these, there has to be a ton
On Sat, 2015-03-28 at 08:52 -0400, M. Vefa Bicakci wrote:
These commits address a number of checkpatch.pl warnings and errors
in rtl8723au's rtw_security.c.
Hello.
This is one of those patchsets that should be
done against Greg's staging-testing branch.
There are some commits against
Use the standard vsprintf kernel extension to format
mac addresses.
This reduces object code size a bit.
Miscellanea:
o Coalesce formats
o Realign arguments
o Remove the now unused MAC_FMT and MAC_ARG #defines
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/rtl8723au/core
On Mon, 2015-03-23 at 16:25 -0400, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
This is an alternate driver for the Realtek 8723AU (rtl8723au) written
from scratch utilizing the mac80211 stack.
trivia:
diff --git a/drivers/net/wireless/rtl8xxxu.c
On Wed, 2015-03-18 at 07:44 +0100, Nicholas Mc Guire wrote:
On Tue, 17 Mar 2015, Joe Perches wrote:
On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote:
Converting milliseconds to jiffies by val * HZ / 1000 is technically
OK but msecs_to_jiffies(val) is the cleaner solution
On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote:
Converting milliseconds to jiffies by val * HZ / 1000 is technically
OK but msecs_to_jiffies(val) is the cleaner solution and handles all
corner cases correctly. This is a minor API consolidation only and
should make things more
On Mon, 2015-03-16 at 18:07 +0100, Greg KH wrote:
On Mon, Mar 16, 2015 at 09:55:27AM -0700, Joe Perches wrote:
On Mon, 2015-03-16 at 12:01 -0400, Jes Sorensen wrote:
For staging patches, you should always post patches against the
staging-next tree. Please rebase them and repost them
On Fri, 2015-03-13 at 10:44 -0500, Larry Finger wrote:
On 03/12/2015 10:15 PM, M. Vefa Bicakci wrote:
Improve the readability of an if statement and its very long trace
output line in rtl8723au's rtw_security.c.
[]
diff --git a/drivers/staging/rtl8723au/core/rtw_security.c
On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote:
This is an alternate driver for the Realtek 8723AU (rtl8723au) written
from scratch utilizing the mac80211 stack.
Mostly trivial comments:
diff --git a/MAINTAINERS b/MAINTAINERS
[]
+RTL8XXXU WIRELESS DRIVER (rtl8xxxu)
+M:
On Mon, 2015-03-09 at 15:02 -0400, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote:
This is an alternate driver
On Mon, 2015-03-09 at 14:43 -0400, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Mon, 2015-03-09 at 13:00 -0400, jes.soren...@redhat.com wrote:
This is an alternate driver for the Realtek 8723AU (rtl8723au) written
from scratch utilizing the mac80211 stack.
Mostly trivial
On Fri, 2015-03-06 at 17:15 -0500, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
This is an alternate driver for the Realtek 8723AU (rtl8723au) written
from scratch utilizing the mac80211 stack.
After spending months cleaning up the vendor provided rtl8723au
On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote:
Julia Lawall julia.law...@lip6.fr writes:
On Fri, 6 Mar 2015, Jes Sorensen wrote:
Quentin Lambert lambert.quen...@gmail.com writes:
This patch reduces the kernel size by removing error messages that
duplicate
the normal OOM
On Fri, 2015-03-06 at 14:43 -0500, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote:
Julia Lawall julia.law...@lip6.fr writes:
On Fri, 6 Mar 2015, Jes Sorensen wrote:
Quentin Lambert lambert.quen...@gmail.com writes
On Sat, 2015-03-07 at 00:37 -0500, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Sat, 2015-03-07 at 00:23 -0500, Jes Sorense wrote:
Larry Finger larry.fin...@lwfinger.net writes:
I also
think that this code should be placed in a separate sub directory
under drivers/net
On Sat, 2015-03-07 at 00:23 -0500, Jes Sorensen wrote:
Larry Finger larry.fin...@lwfinger.net writes:
I also
think that this code should be placed in a separate sub directory
under drivers/net/wireless.
[]
If the code grows substantially, we can
move it into a sub directory, but for now
On Sat, 2015-03-07 at 00:18 -0500, Jes Sorensen wrote:
The long strings are an outright nack.
Pity. There's a specific exclusion in CodingStyle.
Chapter 2: Breaking long lines and strings
never break user-visible strings such as
printk messages, because that breaks the ability to grep
On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote:
From: Johannes Berg johan...@sipsolutions.net
Date: Tue, 03 Mar 2015 09:16:57 +0100
Other than that, I guess I'll apply this, but I really wish there was a
way to distinguish more easily which of these require alignment and
which
On Tue, 2015-03-03 at 10:00 +0100, Johannes Berg wrote:
On Tue, 2015-03-03 at 00:52 -0800, Joe Perches wrote:
My guess is the eth_zero_addr and eth_broadcast functions
are always taking aligned(2) arguments, just like all the
is_foo_ether_addr functions.
Err, are you serious
On Tue, 2015-03-03 at 09:44 +0100, Johannes Berg wrote:
Other than that, I guess I'll apply this, but I really wish there was a
way to distinguish more easily which of these require alignment and
which don't.
My guess is the eth_zero_addr and eth_broadcast functions
are always
On Tue, 2015-03-03 at 09:16 +0100, Johannes Berg wrote:
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote:
Use the built-in function instead of memset.
Please don't use foo in the title, especially not if the patch only
introduces usage of eth_zero_addr(). It's easier to look
Joe Perches (14):
etherdevice: Add eth_foo_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code
ethernet: Use eth_foo_addr instead of memset
net: usb: Use eth_foo_addr instead of memset
wireless: Use eth_foo_addr instead of memset
netconsole: Use eth_foo_addr instead of memset
xen: Use
Use the built-in function instead of memset.
Miscellanea:
Add #include linux/etherdevice.h where appropriate
Use ETH_ALEN instead of 6
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/wireless/airo.c| 4 +--
drivers/net/wireless/at76c50x-usb.c
Use the built-in function instead of memset.
Signed-off-by: Joe Perches j...@perches.com
---
net/mac80211/cfg.c | 2 +-
net/mac80211/ibss.c | 2 +-
net/mac80211/mesh.c | 2 +-
net/mac80211/mlme.c | 10 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/mac80211
Use the built-in function instead of memset.
Signed-off-by: Joe Perches j...@perches.com
---
net/wireless/ibss.c | 2 +-
net/wireless/nl80211.c | 4 ++--
net/wireless/trace.h| 9 +
net/wireless/wext-sme.c | 2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/net
On Sun, 2015-03-01 at 21:31 +0200, Emmanuel Grumbach wrote:
From: Eyal Shapira e...@wizery.com
Add this to the info printed when reading rate_scale_table.
Useful for debugging.
[]
diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c
b/drivers/net/wireless/iwlwifi/mvm/rs.c
[]
@@ -3369,6
On Fri, 2015-02-27 at 10:35 +, David Laight wrote:
From: Joe Perches
At some point, it'd be good to make sscanf use __must_check
so make sure the net/ uses of sscanf use the return value.
Isn't it much safer to avoid sscanf() completely and use
a different function for converting
At some point, it'd be good to make sscanf use __must_check
so make sure the net/ uses of sscanf use the return value.
Signed-off-by: Joe Perches j...@perches.com
---
Compiled, untested.
net/mac80211/debugfs.c | 4 ++--
net/wireless/core.c| 4 ++--
2 files changed, 4 insertions(+), 4
Add missing terminating newlines to nfc_info and nfc_err
to avoid possible interleaving from other messages.
Miscellanea:
o typo fix of unknonwn in message
o remove unnecessary OOM messages as there's a generic dump_stack()
o realign arguments
Signed-off-by: Joe Perches j...@perches.com
On Fri, 2015-01-30 at 10:42 +0100, Helmut Schaa wrote:
diff --git a/event.c b/event.c
[]
@@ -565,6 +565,31 @@ static int print_event(struct nl_msg *msg, void *arg)
nla_data(tb[NL80211_ATTR_VENDOR_DATA]),
On Sat, 2014-12-27 at 03:42 -0500, Matthew Emerson wrote:
Fixed multiple space issues found by checkpatch.pl in
drivers/staging/rtl8723au/core/rtw_ap.c
Hello.
Please strive for more than simple robotic like
adherence to checkpatch messages.
A lot of the time, there is a better way.
diff
On Wed, 2014-12-24 at 00:46 +0100, Rafał Miłecki wrote:
On 24 December 2014 at 00:55, Oscar Forner Martinez
oscar.forner.marti...@gmail.com wrote:
Three lines with more than 80 characters per line have been split in
several lines.
Signed-off-by: Oscar Forner Martinez
On Sun, 2014-12-21 at 12:43 +0100, Arend van Spriel wrote:
The physical addresses being used by pcie and msgbuf were using
a cast to long, which incorrectly caused it to limit the address
to 32bit. Now explicit u64 is used where needed.
Maybe these should be phys_addr_t instead?
diff --git
On Wed, 2014-12-17 at 19:27 +0530, Avinash Patil wrote:
From: Xinming Hu h...@marvell.com
[]
diff --git a/drivers/net/wireless/mwifiex/11n_aggr.c
b/drivers/net/wireless/mwifiex/11n_aggr.c
[]
@@ -101,6 +101,13 @@ mwifiex_11n_form_amsdu_txpd(struct mwifiex_private *priv,
{
struct txpd
On Fri, 2014-12-12 at 23:58 +0100, Krzysztof Konopko wrote:
This patch changes the types of the struct fields involved to be
little-endian which is what is received over the air and consistent with
relevant structs in include/linux/ieee80211.h.
[]
diff --git
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote:
These patches replace what appears to be a reference to the name of the
current function but is misspelled in some way by either the name of the
function itself, or by %s and then __func__ in an argument list.
At least a few of these seem
On Tue, 2014-12-02 at 11:46 +0200, Vladimir Kondratiev wrote:
Add rate-limited flavor of wil_err(); in some cases,
specially in IRQ and data path, if something went wrong,
error message may be printed at very high rate, rendering
whole system unresponsive or unstable.
Need to do real function
On Tue, 2014-12-02 at 18:07 +0200, Vladimir Kondratiev wrote:
On Tuesday, December 02, 2014 07:07:47 AM Joe Perches wrote:
net_foo_ratelimited uses the same form.
include/linux/net.h:#define net_ratelimited_function(function, ...)
include/linux/net.h-do
On Mon, 2014-12-01 at 21:23 +0530, Anjana Sasindran wrote:
This patch fix the checkpatch.pl warning:
WARNING: please, no spaces at the start of a line
[]
diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
b/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c
[]
@@ -20,7 +20,7 @@
On Mon, 2014-12-01 at 15:33 +0200, Vladimir Kondratiev wrote:
In addition there's a rate limitted warning message.
limited.
I think this _ratelimited bit should be a separate patch.
(and a suggestion / comment below too)
diff --git a/drivers/net/wireless/ath/wil6210/debug.c
On Wed, 2014-11-05 at 17:05 +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes
Error reported by checkpatch.
Please run your patches through checkpatch before
sending them.
WARNING: suspect code indent for conditional statements (24, 24)
#178: FILE:
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
The right shift operation has higher precedence than the mask so we
left shift by (i * 3) and then immediately right shift by (i * 3)
then we mask. It should be left shift, mask, and then right shift.
Hey Dan.
My grep pattern doesn't
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote:
On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote:
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote:
The right shift operation has higher precedence than the mask so we
left shift by (i * 3) and then immediately right
On Tue, 2014-10-28 at 14:56 +0100, Arend van Spriel wrote:
This series has a couple of wowl patches that were too late to make
the 3.18 merge window. Apart from those there are a number of rename
and rework patches that get rid of the terms dhd and wl.
The series is intended for 3.19 and
On Mon, 2014-10-27 at 07:16 +0100, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Mon, 2014-10-27 at 06:45 +0100, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote:
ERROR: spaces required around that ':' (ctx:VxE
Precedence of and is not the same and is not left to right.
shift has higher precedence and should be done after the mask.
Add parentheses around the mask.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/net/wireless/iwlwifi/dvm/lib.c | 4 ++--
1 file changed, 2 insertions(+), 2
logical mask has lower precedence than shift but should be
done before the shift so parentheses are generally required.
And when masking with a fixed value after a shift, normal kernel
style has the shift on the left, then the shift on the right so
convert a few non-conforming uses.
Joe Perches
On Mon, 2014-10-27 at 06:45 +0100, Jes Sorensen wrote:
Joe Perches j...@perches.com writes:
On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote:
ERROR: spaces required around that ':' (ctx:VxE)
[]
diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c
b/drivers/staging/rtl8723au
On Fri, 2014-10-24 at 11:15 +0300, Dan Carpenter wrote:
The -parent_tsf[] array holds u8 values. It type promoted to int for
the shift operation so the 24 shift operation can wrap. The cast
needs to be done before the shift instead of after.
Signed-off-by: Dan Carpenter
On Tue, 2014-10-14 at 18:40 +0200, Fabian Frederick wrote:
Signed-off-by: Fabian Frederick f...@skynet.be
It might be clearer to use a structure for this 16 byte thing.
There's a comment bit in the code:
/* cmdreq message:
u32 type
u16 cmd
u16 parm0
u16 parm1
On Sat, 2014-10-11 at 12:59 -0500, Larry Finger wrote:
The driver logs a message when the default branch of switch statements are
taken. Such information is useful when debugging, but these log items should
not be seen for standard usage.
Hey Larry.
At some point, it'd be good to make
On Sat, 2014-10-11 at 12:19 +0800, Matthew Tyler wrote:
Signed-off-by: Matthew Tyler matt.ty...@flashics.com
[]
diff --git a/drivers/staging/rtl8723au/include/ieee80211.h
b/drivers/staging/rtl8723au/include/ieee80211.h
[]
-#define IsSupported24G(NetType) (NetType SUPPORTED_24G_NETTYPE_MSK ?
On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
The return from myid() isn't aligned correctly for ether_addr_copy().
Hey Dan.
Actual evidence showing ether_addr_copy conversions
may not always be wise.
How did you find them?
Is there a new alignment capability in smatch?
--
To
On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
The return from myid() isn't aligned correctly for ether_addr_copy().
Hey Dan.
Actual evidence showing
with the `else` to me though.
Yay Michal.
Always use your taste over any mindless style tool.
Ignore any checkpatch complaint you want.
btw: checkpatch shouldn't warn about this as of:
commit adefeef310ee8bd3923d41b67bc53c398bc53621
Author: Joe Perches j...@perches.com
Date: Fri Sep 26 10:19:29 2014 +1000
201 - 285 of 285 matches
Mail list logo
