[PATCH 7/9] iwlwifi: mvm: add missing lq_color

2017-10-13 Thread Luca Coelho
24bfe9 ("iwlwifi: mvm: support new BA notification response") Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/tx.h | 4 ++-- drivers/net/wireless/intel/iwlwifi/mvm/tx.c

Re: iwlwifi: ToF usage

2017-10-11 Thread Luca Coelho
On Wed, 2017-10-04 at 07:52 +0300, Luciano Coelho wrote: > Hi Joel, > > Unfortunately we don't have full support for ToF on the mainline > kernel > yet. But you can try to use one of our Core releases (which is a > backports-based tree) that you can find here: > > You could try the

Re: 4.14.0-rc3 iwlwifi: Hardware became unavailable during restart

2017-10-11 Thread Luca Coelho
On Tue, 2017-10-10 at 09:44 +0200, Seraphime Kirkovski wrote: > Hello, Hi Seraphime, > I've got this splat after a couple of suspend-resume cycles on my > HP-laptop. I haven't had the time to bisect or test other rcs for now. > Pasting some logs before the actual WARN_ON, as they may be

[PATCH 09/10] iwlwifi: mvm: set status before calling iwl_mvm_send_cmd_status()

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always must set the status to what we consider success before calling iwl_mvm_send_cmd_status() (also iwl_mvm_send_cmd_pdu_status() which calls it). Fix a few places where initialization is missing. Signed-off-by: Luca Coelho <lu

[PATCH 04/10] iwlwifi: mvm: change state when queueing agg start work

2017-09-08 Thread Luca Coelho
se criteria of a BA session") Signed-off-by: Naftali Goldstein <naftali.goldst...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 3 ++- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 6 -- drivers/net/wireless

[PATCH 10/10] iwlwifi: mvm: fix reorder buffer for 9000 devices

2017-09-08 Thread Luca Coelho
elease packets out of order in some scenarios. Fixes: b915c10174fb ("iwlwifi: mvm: add reorder buffer per queue") Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |

[PATCH 01/10] iwlwifi: mvm: fix wowlan resume failed to load INIT ucode

2017-09-08 Thread Luca Coelho
: Matt Chen <matt.c...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlw

[PATCH 00/10] iwlwifi: fixes intended for 4.14 2017-09-08

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here is my first batch of fixes intended for 4.14. Since it is very early in the release process, I was a bit liberal with the fixes I'm sending, but they all fix real issues. These are the fixes: * A couple of bugzilla bugs r

[PATCH 08/10] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common()

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always need to initialize the status argument to the success case before calling iwl_mvm_send_cmd_status() or iwl_mvm_send_cmd_pdu_status() (which calls the former) otherwise we may get an uninitialized value back. In this case,

[PATCH 07/10] iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We were ignoring the FIF_ALLMULTI flag when setting the multicast addresses with MCAST_FILTER_CMD. Check if this flag is set and enable pass_all accordingly. We also need to set the count to 0 if pass_all is enable so we don't pass add

[PATCH 06/10] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The MCAST_FILTER_CMD can get quite large when we have many mcast addresses to set (we support up to 255). So the command should be send as NOCOPY to prevent a warning caused by too-long commands: WARNING: CPU: 0 PID: 9700 at /root/iwlwifi/sta

[PATCH 05/10] iwlwifi: mvm: wake the correct mac80211 queue

2017-09-08 Thread Luca Coelho
are purged") Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/m

[PATCH 03/10] iwlwifi: mvm: send all non-bufferable frames on the probe queue

2017-09-08 Thread Luca Coelho
y: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wir

[PATCH 02/10] iwlwifi: mvm: Flush non STA TX queues

2017-09-08 Thread Luca Coelho
ed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 44 ++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi

Re: [PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames

2017-08-30 Thread Luca Coelho
On Tue, 2017-08-29 at 11:22 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > From: David Spinadel <david.spina...@intel.com> > > > > Use bcast station for all non bufferable frames on AP and AD-HOC. > > > > The host is no

[PATCH] iwlwifi: mvm: bump API to 34 for 8000 and up

2017-08-30 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> These devices support -34.ucode, so load it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/8000.c | 4

pull-request: iwlwifi-next 2017-08-30

2017-08-30 Thread Luca Coelho
Hi Kalle, Here's my fourth and final pull-request intended for v4.14.  It contains just a couple of small fixes and a FW API number bump.  More details in the tag description. I have fixed the subject of one of the patches for the typo you reported during review. I have sent this out before,

Re: Bug Report for iwlwifi kernel module

2017-09-05 Thread Luca Coelho
On Tue, 2017-09-05 at 09:51 -0700, Carl Myers wrote: > Hi Luca, > > On Mon, Sep 04, 2017 at 10:34:37AM +0300, Luca Coelho wrote: > > Date: Mon, 04 Sep 2017 10:34:37 +0300 > > From: Luca Coelho <l...@coelho.fi> > > To: Carl Myers <cmy...@cmyers.org>, linux-

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > Hi Jens, > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > Hi, > > > > I have no wifi in current git (8fac2f96ab8), it simply fails with: > > > > [4.363481] iwlwifi :04:00.0: Direct firmware load for > >

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > On 09/12/2017 10:36 AM, Luca Coelho wrote: > > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > > > Hi Jens, > > > > > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > > >

Re: [GIT] Networking

2017-09-06 Thread Luca Coelho
re it still works with version 27. Okay, I found the offending patch: commit 7089ae634c50544b29b31faf1a751e8765c8de3b Author: Johannes Berg <johannes.b...@intel.com> AuthorDate: Wed Jun 28 16:19:49 2017 +0200 Commit: Luca Coelho <luciano.coe...@intel.com> CommitDate: Wed Aug 9

[PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The LEDS_CMD command is only supported in some newer FW versions (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions (such as iwlwifi-8000C-27.ucode). To fix this, check for a new bit in the FW capabilities TLV that tell

Re: [PATCH 09/10] mac80211_hwsim: Add command to control rx status RSSI

2017-09-29 Thread Luca Coelho
On Wed, 2017-09-06 at 12:33 +0200, Johannes Berg wrote: > On Sat, 2017-08-05 at 11:44 +0300, Luca Coelho wrote: > > > > +static int hwsim_fops_rx_rssi_write(void *dat, u64 val) > > +{ > > + struct mac80211_hwsim_data *data = dat; > > + int rssi = (int)val; >

[PATCH 0/5] iwlwifi: fixes intended for 4.14 2017-09-29

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Another batch of fixes intended for 4.14. This one is a bit smaller than the previous one. These are the fixes: * Fix support for 3168 device series; * Fix a potential crash when using FW debugging recording; * Improve channel flags p

[PATCH 1/5] iwlwifi: mvm: do not print security error in monitor mode

2017-09-29 Thread Luca Coelho
Signed-off-by: Shaul Triebitz <shaul.trieb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 7 +++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 3 +++ drivers/net/wireless/intel/iwlwifi/mvm/rx.c

[PATCH 5/5] iwlwifi: nvm: set the correct offsets to 3168 series

2017-09-29 Thread Luca Coelho
Fixes: c4836b056d83 ("iwlwifi: Add PCI IDs for the new 3168 series") Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/7000.c | 1 + drivers/net/wireless/intel/

[PATCH 3/5] iwlwifi: mvm: return -ENODATA when reading the temperature with the FW down

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> It seems that libsensors treats -EIO as a special non-recoverable failure when it tries to read the temperature while the firmware is not running. To solve that, change the error code to a milder -ENODATA. This fixes https://bugzilla.kern

[PATCH 2/5] iwlwifi: stop dbgc recording before stopping DMA

2017-09-29 Thread Luca Coelho
golan.ben@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 7 ++- drivers/net/wireless/intel/iwlwifi/fw/dbg.h | 15 +++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireles

[PATCH 4/5] iwlwifi: nvm-parse: unify channel flags printing

2017-09-29 Thread Luca Coelho
ertain channels with certain flag combinations. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 98 +- 1 file changed, 39 insertions(+), 59 deleti

[PATCH 05/18] iwlwifi: pcie: dump registers when HW becomes inaccessible

2017-09-29 Thread Luca Coelho
087096] Timeout waiting for hardware access (CSR_GP_CNTRL 0x) Signed-off-by: Rajat Jain <raja...@google.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 1 + drivers/net/wireless/intel/iwlwifi/pc

[PATCH 10/18] iwlwifi: acpi: generalize iwl_mvm_sar_find_wifi_pkg()

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Move this function to acpi.c, renaming it to iwl_acpi_get_wifi_pkg(), because it can also be used with other methods (i.e. SPLC and WRDD). Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw

[PATCH 08/18] iwlwifi: acpi: move ACPI method definitions to acpi.h

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Instead of defining each method where they are used and re-defining WIFI_DOMAIN in each one of them, move all the definitions to a central place and define the domain only a single time. Signed-off-by: Luca Coelho <luciano.coe...@

[PATCH 02/18] iwlwifi: fw: api: remove excess enum value documentation

2017-09-29 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> These enum values don't exist, so remove their documentation as well. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/sta.

[PATCH 07/18] iwlwifi: acpi: add common code to read from ACPI

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There are many places where the same process of invoking a method from ACPI is used, causing a lot of duplicate code. To improve this, introduce a new function to get an ACPI object by invoking an ACPI method that can be reused. Additionally,

[PATCH 09/18] iwlwifi: acpi: move ACPI-related definitions to acpi.h

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The ACPI table size definitions were spread around the different files that used them. Move them all to a common place. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/acpi

[PATCH 01/18] iwlwifi: mvm: don't send identical PHY_CTXT_CMD

2017-09-29 Thread Luca Coelho
ed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 14 ++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt

[PATCH 03/18] iwlwifi: mvm: add marker cmd response struct.

2017-09-29 Thread Luca Coelho
From: Mordechay Goodstein <mordechay.goodst...@intel.com> This helps for documentation and clarifies the code by defining the exact response struct for the marker command. Signed-off-by: Mordechay Goodstein <mordechay.goodst...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 06/18] iwlwifi: mvm: change warning to warn_once()

2017-09-29 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> In case there is a FW bug where the BAID value in the metadata is not properly initialized we hit the warning for every RX packet. Change it to warn once and add elaborate message. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-

[PATCH 11/18] iwlwifi: acpi: use iwl_acpi_get_wifi_pkg when reading reading SPLC

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Instead of finding the wifi package with its own code, we can reuse the new iwl_acpi_get_wifi_pkg() function when reading the default power limit from SPLC. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/i

[PATCH 13/18] iwlwifi: acpi: remove a couple of unnecessary ifdefs

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Some of the #ifdef CONFIG_ACPI are not needed anymore, so they can be removed. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 -- drivers/net/wireless/intel/iwlwifi/pcie/drv.c |

[PATCH 16/18] iwlwifi: acpi: move code that reads SPLC to acpi

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Move most of the set_dflt_pwr_limit() function to acpi.c and make it return the pwr_limit value instead of setting directly. Also rename it to iwl_acpi_get_pwr_limit(). Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 14/18] iwlwifi: acpi: move function to get mcc into acpi code

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The iwl_get_bios_mcc() function was in the iwl-nvm-parse.c file, but it has nothing to do with the NVM. Move it to fw/acpi.c and rename it to iwl_acpi_get_mcc(). Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wi

[PATCH 15/18] iwlwifi: fix indentation in a000 family configuration

2017-09-29 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Fix the double indentation in the configuration structs for a000 family devices. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwif

[PATCH 17/18] iwlwifi: mvm: warn on invalid statistics size

2017-09-29 Thread Luca Coelho
s Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c b/drivers/net/wireless/intel/iwlw

[PATCH 12/18] iwlwifi: acpi: make iwl_get_bios_mcc() use the common acpi functions

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The way iwl_get_bios_mcc() gets the WiFi package and checks for its integrity is almost identical to the new iwl_acpi_get_wifi_pkg() function. Instead of having duplicate code, convert it to use the common code. Signed-off-by: Luca

[PATCH 00/18] iwlwifi: updates intended for v4.15 2017-09-29

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's the second set of patches intended for 4.15. Nothing major, mostly just cleanups. These are the changes: * ACPI code refactoring; * Some coding-style fixes; * Avoid redundant command to the firmware; * Add a struct with the format

[PATCH 18/18] iwlwifi: remove dflt_pwr_limit from the transport

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The default power limit read from the SPLC method in ACPI doesn't have anything to do with the transport and is only used in the opmode, so we can remove it from the trans. Additionally, this value is only user when the opmode is starting, so we

[PATCH v2] ieee80211: Add WFA TPC report element OUI type

2017-09-29 Thread Luca Coelho
From: Avraham Stern <avraham.st...@intel.com> Add Transmit Power Control OUI type definition for WLAN_OUI_MICROSOFT. Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/linux/ieee80211.h | 1 + 1 file ch

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-24 Thread Luca Coelho
On Thu, 2017-08-24 at 21:56 +0200, Jiri Kosina wrote: > On Thu, 24 Aug 2017, Luca Coelho wrote: > > > > Work queues cannot be allocated when a mutex is held because the mutex > > > may be in use and that would make it sleep. Doing so generates the > &g

[PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Work queues cannot be allocated when a mutex is held because the mutex may be in use and that would make it sleep. Doing so generates the following splat with 4.13+: [ 19.513298] == [ 19.

[PATCH] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Work queues cannot be allocated in when a mutex is held because the mutex may be in use and that would make it sleep. Doing so generates the following splat with 4.13+: [ 19.

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-24 Thread Luca Coelho
On Tue, 2017-08-22 at 10:37 +0300, Luca Coelho wrote: > From: Luca Coelho <luciano.coe...@intel.com> > > Work queues cannot be allocated when a mutex is held because the mutex > may be in use and that would make it sleep. Doing so generates the > following splat with 4.13

[PATCH] mac80211: Complete ampdu work schedule during session tear down

2017-08-25 Thread Luca Coelho
r the BA session cancellation and properly clean the session. Fixes: 7a7c0a6438b8 ("mac80211: fix TX aggregation start/stop callback race") Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/ht.c | 15

[PATCH 0/2] iwlwifi: updates intended for v4.14 2017-08-25

2017-08-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, A very tiny set of patches for v4.14. :) Nothing is backlogged in our internal tree anymore and this has been a very slow week due to vacations in our team. These are the changes: * Fix a queue hang problem due to 11w behavior * Fix a w

[PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames

2017-08-25 Thread Luca Coelho
Fixes: 3e56eadfb6a1 ("iwlwifi: mvm: implement AP/GO uAPSD support") Signed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 9 + 1 file changed, 5 insertions(+)

[PATCH 1/2] iwlwifi: fix long debug print

2017-08-25 Thread Luca Coelho
ags require it") Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwif

[PATCH 19/24] iwlwifi: mvm: change open and close criteria of a BA session

2017-08-18 Thread Luca Coelho
ter-op issues with some APs. We'll not close a BA session until we receive an explicit del BA from the peer. Signed-off-by: Gregory Greenman <gregory.green...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/constants.h | 1 + dr

[PATCH 20/24] iwlwifi: add workaround to disable wide channels in 5GHz

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The OTP in some SKUs have erroneously allowed 40MHz and 80MHz channels in the 5.2GHz band. The firmware has been modified to not allow this in those SKUs, so the driver needs to do the same otherwise the firmware will assert when we try to use i

[PATCH 11/24] iwlwifi: mvm: remove session protection to allow channel switch

2017-08-18 Thread Luca Coelho
Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 3 +- .../net/wireless/intel/iwlwifi/mvm/time-event.c| 34 -- 2 files changed, 33 insertions(+), 4 deletions(-) diff -

[PATCH 23/24] iwlwifi: mvm: remove useless check for mvm->cfg in iwl_parse_nvm_section()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> At this point we have already copied the cfg pointer to mvm and we have been dereferencing this pointer many times before, so it will never be NULL or we would have crashed. Remove the useless check. Signed-off-by: Luca Coelho <lu

[PATCH 21/24] iwlwifi: fw: fix lar_enabled endian problem in iwl_fw_get_nvm

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We read the regulatory.lar_enabled field in iwl_fw_get_nvm() and store it in nvm->lar_enabled, taking care of endianness. But then later we read it again to pass the value to iwl_init_sbands() without handling endianness. To solve this, sim

[PATCH 16/24] iwlwifi: distinguish different RF modules in A000 devices

2017-08-18 Thread Luca Coelho
rmware. Signed-off-by: Tzipi Peres <tzipi.pe...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/a000.c | 34 ++--- drivers/net/wireless/intel/iwlwifi/iwl-config.h | 4 ++- drivers/net/wireless/intel

[PATCH 15/24] iwlwifi: mvm: Fix channel switch in case of count <= 1

2017-08-18 Thread Luca Coelho
ime after the reception the frame, and for counter == 1 the switch would happens before the next TBTT, schedule the time event immediately. Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

[PATCH 24/24] iwlwifi: use big-endian for the hw section of the nvm

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Unlike the other sections of the NVM, the hw section is in big-endian. To read a value from it, we had to cast it to __be16. Fix that by using __be16 * for the entire section. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 13/24] iwlwifi: move BT_MBOX_PRINT macro to common header

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Move the BT_MBOX_PRINT() macro from mvm/debugfs.c to fw/api/coex.h so it can be reused and remove duplicate definition of BT_MBOX_MSG(), keeping only the one already in coex.h. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 18/24] iwlwifi: update channel flags parser

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There are some new flags in the channel flags that we don't know about. Also, the "WIDE" flag is very confusing, because it actually means 20MHz bandwidth, which is not very wide. Add the new flags and rename the confusing one. Sig

[PATCH 22/24] iwlwifi: mvm: remove useless argument in iwl_nvm_init()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always call iwl_nvm_init() with read_nvm_from_nic == true, so this argument is useless. Remove it. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 5 +- drivers/net/wireless/i

[PATCH 17/24] iwlwifi: pci: add new PCI ID for 7265D

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We have a new PCI subsystem ID for 7265D. Add it to the list. Cc: sta...@vger.kernel.org Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 14/24] iwlwifi: Demote messages about fw flags size to info

2017-08-18 Thread Luca Coelho
ooting the kernel with "quiet". Demoting it to the warn level helps having a clean boot process. Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 +++

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-09-04 Thread Luca Coelho
On Mon, 2017-09-04 at 13:43 +0200, Jiri Kosina wrote: > On Thu, 24 Aug 2017, Luca Coelho wrote: > > > > looks like a correct fix to me, so feel free to add > > > > > > Acked-by: Jiri Kosina <jkos...@suse.cz> > > > > > > I'll be

Re: Bug Report for iwlwifi kernel module

2017-09-04 Thread Luca Coelho
Hi Carl, On Sun, 2017-09-03 at 12:15 -0700, Carl Myers wrote: > Greetings all, > > Apologies if any of this is wrong, this is my first attempt to report a bug in > the linux kernel =) > > I got here by running the get_maintainer script on the iwlwifi directory of a > linux kernel checkout. > >

[PATCH] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common()

2017-09-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always need to initialize the status argument to the success case before calling iwl_mvm_send_cmd_status() or iwl_mvm_send_cmd_pdu_status() (which calls the former) otherwise we may get an uninitialized value back. In this case,

Re: [PATCH 1/2] iwlwifi: fix long debug print

2017-08-31 Thread Luca Coelho
On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: > > From: Liad Kaufman <liad.kauf...@intel.com> > > > > There is a debug print that sometimes reaches over > > 110 chars, thus generating a warnin

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-31 Thread Luca Coelho
On Wed, 2017-08-30 at 17:57 +0300, David Weinehall wrote: > On Tue, Aug 22, 2017 at 10:37:29AM +0300, Luca Coelho wrote: > > From: Luca Coelho <luciano.coe...@intel.com> > > > > Work queues cannot be allocated when a mutex is held because the mutex > > may be in

pull-request: iwlwifi-next 2017-10-06-2

2017-10-06 Thread Luca Coelho
dbgfs entry for fw info Luca Coelho (11): iwlwifi: trans: move ref/unref code to the common part of the transport iwlwifi: acpi: add common code to read from ACPI iwlwifi: acpi: move ACPI method definitions to acpi.h iwlwifi: acpi: move ACPI-related definitions to acpi.h

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-10-18 Thread Luca Coelho
On Wed, 2017-10-18 at 12:50 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > On Wed, 2017-10-18 at 07:59 +0300, Kalle Valo wrote: > > > Luca Coelho <l...@coelho.fi> writes: > > > > > > > On Tue, 2017-10-17 at 14:23 -07

pull-request: iwlwifi-next 2017-10-18

2017-10-18 Thread Luca Coelho
but not used variable tcph Liad Kaufman (1): iwlwifi: mvm: add missing lq_color Luca Coelho (3): iwlwifi: mvm: move umac_error_event_table validity check to where it's set iwlwifi: define minimum valid address for umac_error_event_table in cfg iwlwifi: pcie: sort IDs

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-10-17 Thread Luca Coelho
On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: > On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: > > Hi, > > > > On Tue, 2017-10-17 at 02:44 -0700, Marc MERLIN wrote: > > > Was broken in 4.11, still broken in 4.12. This is crippling, I'm > >

Re: After upgrading to 4.11.1, wifi driver refuses to load after being unloaded once.

2017-10-18 Thread Luca Coelho
On Wed, 2017-10-18 at 07:59 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > On Tue, 2017-10-17 at 14:23 -0700, Marc MERLIN wrote: > > > On Tue, Oct 17, 2017 at 05:05:57PM +0300, Luca Coelho wrote: > > > > Hi, > > > > >

[PATCH v2 7/9] iwlwifi: mvm: add missing lq_color

2017-10-18 Thread Luca Coelho
24bfe9 ("iwlwifi: mvm: support new BA notification response") Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- In v2: a fix by Sari to properly initialize the tid_data lq_color field to avoid a double usage of the

Re: pull-request: iwlwifi firmwares update 2017-11-15

2017-11-15 Thread Luca Coelho
Hi Ben, I'm adding you here explicitly since you've been pushing stuff to the linux-firmware.git tree more recently. ;) -- Luca. On Wed, 2017-11-15 at 19:46 +0200, Luca Coelho wrote: > Hi Kyle, > > This pull-request supersedes my previous one. > > I have updated the firmwar

pull-request: iwlwifi firmwares update 2017-11-15

2017-11-15 Thread Luca Coelho
version 34 for 8000, 8265 and 9000 series; * Update FW version 17 for 3160, 7260 and 7265; * Update FW version 29 for 3168 and 7265D; Luca Coelho (5): iwlwifi: update firmwares for 3160, 3168, 7265D, 8000C and 8265 iwlwifi

Re: pull-request: iwlwifi firmwares update 2017-10-13

2017-11-15 Thread Luca Coelho
On Fri, 2017-11-03 at 12:19 +0200, Luca Coelho wrote: > Hi Kyle, > > I have updated the firmwares for the 3160, 3168, 7260, 7265D, 8000C > and > 8265 devices and added new FW versions for 8000C, 8265 and the new > 9000 > series. > > Please pull or let me know if th

pull-request: iwlwifi 2017-11-28

2017-11-28 Thread Luca Coelho
Hi Kalle, Here is my second set of fixes for 4.15. More details in the tag description. I have sent this out before and kbuildbot didn't find any issues. Please let me know if there are any issues. Cheers, Luca. The following changes since commit ed59b7d53c95548d83d4e7e1bc5edafcdcad09c9:

Re: [linuxwifi] Need support for Intel new wifi module 9462NGW

2017-11-26 Thread Luca Coelho
On Wed, 2017-11-22 at 21:48 +0800, Chris Chiu wrote: > On Fri, Nov 17, 2017 at 3:38 PM, Chris Chiu <c...@endlessm.com> > wrote: > > On Fri, Nov 17, 2017 at 2:46 PM, Luca Coelho <l...@coelho.fi> > > wrote: > > > On Fri, 2017-11-17 at 14:39 +0800, Chris Chiu w

[PATCH 0/6] iwlwifi: fixes intended for 4.15 2017-11-25

2017-11-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, This is the second batch of fixes intended for 4.15. These are the fixes: * One fix in rate-scaling; * One fix for the TX queue hang detection for AP/GO modes; * Fix the TX queue hang timeout used in monitor interfaces; * Fix packet inj

[PATCH 4/6] iwlwifi: mvm: fix packet injection

2017-11-25 Thread Luca Coelho
or vif. Allocate a new queue, link it to the monitor vif's station and make that queue use the BE fifo. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=196715 Cc: sta...@vger.kernel.org Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 1/6] iwlwifi: mvm: set correct chains in Rx status

2017-11-25 Thread Luca Coelho
aul.trieb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

[PATCH 2/6] iwlwifi: mvm: don't use transmit queue hang detection when it is not possible

2017-11-25 Thread Luca Coelho
manuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c b/drivers/

[PATCH 5/6] iwlwifi: pcie: fix erroneous "Read failed message"

2017-11-25 Thread Luca Coelho
quot;) Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wir

[PATCH 6/6] iwlwifi: fix access to prph when transport is stopped

2017-11-25 Thread Luca Coelho
stopping device even when the stop is initiated from the transport. Fixes: 1efc3843a4ee ("iwlwifi: stop dbgc recording before stopping DMA") Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/inte

[PATCH 3/6] iwlwifi: mvm: fix the TX queue hang timeout for MONITOR vif type

2017-11-25 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> The MONITOR type is missing in the interface type switch. Add it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwi

[PATCH 10/11] iwlwifi: mvm: remove superfluous flush_work()

2017-11-25 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 drivers/net/wireless/intel/iwlwifi/mvm/time-event.c | 6 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi

[PATCH 11/11] iwlwifi: rename the temporary name of A000 to the official 22000

2017-11-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The family name A000 was just a place-holder when we didn't know what the official name would be yet. Now we know that the family name is 22000, so rename all occurrences accordingly. Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 06/11] iwlwifi: print the version number of the firmware in hex

2017-11-25 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Starting from a version 35, the minor version should be printed in hexa. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel

[PATCH 04/11] iwlwifi: mvm: revert support new Coex firmware API

2017-11-25 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> This new API will not be used, remove the code that supports it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/

[PATCH 08/11] iwlwifi: mvm: Add debugfs support for FTM initiator fields

2017-11-25 Thread Luca Coelho
From: Adiel Aloni <adiel.al...@intel.com> Add support to override common_calib and specific_calib FTM initatior fields in debugfs. Signed-off-by: Adiel Aloni <adiel.al...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/mvm/de

[PATCH 07/11] iwlwifi: dbg: allow wrt collection before ALIVE

2017-11-25 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> Even if no ALIVE was received, the WRT data can still be collected. Add this. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwl

[PATCH 03/11] iwlwifi: mvm: rs: don't override the rate history in the search cycle

2017-11-25 Thread Luca Coelho
since it causes a change in the behavior only when we can't find any rate in the new column which should really not happen. In the case we do find a suitable we reset the rate statistics a few lines later anyway. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 09/11] iwlwifi: fix the ALIVE notification layout

2017-11-25 Thread Luca Coelho
umbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/alive.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/alive.h b/drivers/net/wireles

<    7   8   9   10   11   12   13   14   15   16   >