[PATCH 14/16] iwlwifi: drop packets with bad status in CD

2018-08-18 Thread Luca Coelho
From: Sara Sharon We need to drop packets with errors (such as replay, MIC, ICV, conversion, duplicate and so on). Drop invalid packets, put the status bits in the metadata and move the enum definition to the correct place (FW API header). Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho

[PATCH 07/16] iwlwifi: mvm: support new WoWLAN status FW API

2018-08-18 Thread Luca Coelho
From: Luca Coelho A new FW API has been added for WOWLAN_GET_STATUSES to support multiple GTK keys and IGTK keys. Check the respective TLV and use the new API when it is set. Let most of the code use the new version (v7) and convert the old version (v6) to the new one when needed. Also

[PATCH 11/16] iwlwifi: mvm: add support for RX_AMPDU_EOF bit for HE SU

2018-08-18 Thread Luca Coelho
From: Liad Kaufman Current implementation turns this bit on only for HE MU. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 01/16] iwlwifi: turn timestamp marker cmd off by default

2018-08-18 Thread Luca Coelho
From: Mordechay Goodstein Don't enable debugging timestamps by default, so we save power by not waking up the FW with timestamp commands. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 3 --- 1 file changed, 3 deletions

[PATCH 00/16] iwlwifi: updates intended for v4.20 2018-08-18

2018-08-18 Thread Luca Coelho
From: Luca Coelho Hi, Here's the first set of patches intended for v4.20. It's the usual developments, with some small new feauters, cleanups and bugfixes. The changes are: * One fix for channel-switch handling; * Some improvements in the HE code; * New FW API handling; * Improvements

[PATCH 02/16] iwlwifi: remove unused TLC debugging commands

2018-08-18 Thread Luca Coelho
From: Luca Coelho The iwl_dhc_tlc_cmd struct is not used, so remove it, including the iwl_tcl_debug_flags enumeration. Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/fw/api/rs.h| 60 --- 1 file changed, 60 deletions(-) diff --git a/drivers/net/wireless

[PATCH 04/16] iwlwifi: set the tid for non-QOS frames to zero

2018-08-18 Thread Luca Coelho
for non-QOS data frames to zero, which is a valid value for data frames in the FW. This also fixes a bug in sending multicast frames, where the queues are allocated with tid == 0, but are sent with tid == 8, which may lead to unexpected behavior. Signed-off-by: Avraham Stern Signed-off-by: Luca Coelho

[PATCH 06/16] iwlwifi: mvm: remove duplicate if in iwl_mvm_setup_connection_keep()

2018-08-18 Thread Luca Coelho
From: Luca Coelho We repeated the same if twice in a row. Remove the second one and move the code block into the previous one. Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH 03/16] iwlwifi: runtime: avoid calling debugfs read functions more than once

2018-08-18 Thread Luca Coelho
t m-n characters of the second invocation will be printed to screen. Signed-off-by: Naftali Goldstein Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/fw/debugfs.c | 111 ++ 1 file changed, 87 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/in

[PATCH v3 13/17] iwlwifi: mvm: move he RX handling to a separate function

2018-08-27 Thread Luca Coelho
From: Sara Sharon The HE code is bloating the RX handling, and makes it too big. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- In v3: remove smatch warning reported by Dan Carpenter. Just removed the "if (he)" because it must be set at this point. drivers/net/wire

Re: [PATCH v2 05/17] iwlwifi: add d3 debug data support

2018-08-22 Thread Luca Coelho
On Wed, 2018-08-22 at 14:37 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Shahar S Matityahu > > > > During d3, the firmware records debug data into internal buffer > > if debug data collection occurs, collect the data that was written > > t

Re: [PATCH 07/15] iwlwifi: add 80211 hdr offset to trace data

2018-08-22 Thread Luca Coelho
On Wed, 2018-08-22 at 14:45 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Mordechay Goodstein > > > > Every rx mpdu cmd is built from cmd_hdr | 80211_hdr. The problem > > is > > that the size of cmd_hdr changes with API changes and we don't

Re: [PATCH 07/15] iwlwifi: add 80211 hdr offset to trace data

2018-08-23 Thread Luca Coelho
On Thu, 2018-08-23 at 14:13 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > > > - * You should have received a copy of the GNU General Public > > > > License along with > > > > - * this program; if not, write to the Free Software > > >

[PATCH 11/16] iwlwifi: rs-fw: enable STBC in he correctly

2018-08-24 Thread Luca Coelho
From: Naftali Goldstein In the HE phy capabilities IE there are 2 bits to signal support for STBC in bandwidths of 80Mhz or less, and of 160Mhz. Use these bits to determine STBC support if this IE exists. Signed-off-by: Naftali Goldstein Signed-off-by: Luca Coelho --- .../net/wireless/intel

[PATCH 16/16] Revert "iwlwifi: allow memory debug TLV to specify the memory type"

2018-08-24 Thread Luca Coelho
From: Johannes Berg This reverts the addition of memory type in the memory debug TLV as the firmware never ended up implementing it, and now the PRPH dump is added as a different TLV. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c

[PATCH 13/16] iwlwifi: mvm: decode HE TB PPDU data

2018-08-24 Thread Luca Coelho
From: Johannes Berg Decode the HE TB PPDU data that we get in sniffer mode and use it to populate the HE radiotap information. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/fw/api/rx.h| 21 ++ drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 02/16] iwlwifi: mvm: put LTF symbol size into HE radiotap

2018-08-24 Thread Luca Coelho
nes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c index fd66ea7c4b66..f644bcf7e048

[PATCH 07/16] iwlwifi: mvm: send BCAST management frames to the right station

2018-08-24 Thread Luca Coelho
' is not mapped to 'station'. Fixes: 7c305de2b954 ("iwlwifi: mvm: Direct multicast frames to the correct station") Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/16] iwlwifi: mvm: always init rs_fw with 20MHz bandwidth rates

2018-08-24 Thread Luca Coelho
authorization succeeds. Fixes: 6b7a5aea71b3 ("iwlwifi: mvm: always init rs with 20mhz bandwidth rates") Signed-off-by: Naftali Goldstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 5 +++-- drivers/net/wireless/intel/iwlwifi/mvm/rs.c| 2 +- drivers/ne

[PATCH 03/16] iwlwifi: mvm: properly decode HE GI duration

2018-08-24 Thread Luca Coelho
From: Johannes Berg The GI duration depends on the frame type in some cases, take that into account when decoding for radiotap. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 22 ++- 1 file changed, 16 insertions

[PATCH 04/16] iwlwifi: mvm: report # of LTF symbols for extended range SU PPDUs

2018-08-24 Thread Luca Coelho
From: Johannes Berg This is the same as for SU PPDUs, so it's easy to do. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 01/16] iwlwifi: mvm: implement extended HE-MU sniffer API

2018-08-24 Thread Luca Coelho
anyway, move the bits around in the following way: SIG-B common 0: DW 4 -> DW 7 SIG-B common 1: DW 7 -> DW 8 SIG-B common 2: DW 8 -> DW 4 (upper half) Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/fw/api/rx.h| 117 +++ dr

[PATCH 12/16] iwlwifi: rs-fw: support dcm

2018-08-24 Thread Luca Coelho
From: Naftali Goldstein Add flags to the tlc_cfg_cmd for signaling peer support for receiving Dual Carrier Modulation at BPSK (MCS 0), and set them according to peer capabilities. Signed-off-by: Naftali Goldstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/api/rs.h

[PATCH 15/16] iwlwifi: mvm: activate fragmented EBS in case of fragmented scan

2018-08-24 Thread Luca Coelho
From: Ayala Beker In case of fragmented scan on the HB channels, configure EBS to be fragmented as well. Signed-off-by: Ayala Beker Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/api/scan.h | 1 + drivers/net/wireless/intel/iwlwifi/mvm/scan.c| 12 +++- 2

[PATCH 00/16] iwlwifi: updates intended for v4.20 2018-08-24

2018-08-24 Thread Luca Coelho
From: Luca Coelho Hi, Here's the third set of patches intended for v4.20. It's the usual development, with some small new feauters, cleanups and bugfixes. The changes are: * Enable a new scanning feature; * Continued work on HE (mostly radiotap); * Some fixes in the FW rate-scaling

[PATCH 06/16] iwlwifi: Add missing 11n disable module parameter check

2018-08-24 Thread Luca Coelho
From: Ido Yariv In the new method of parsing the NVM the disable_11n module parameter isn't consulted when setting up HT capabilities. Fix this. Signed-off-by: Ido Yariv Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 4 +++- 1 file changed, 3

[PATCH 05/16] iwlwifi: mvm: remove channel 2 from HE radiotap if not applicable

2018-08-24 Thread Luca Coelho
From: Johannes Berg If the bandwidth is only 20 MHz, then the second channel doesn't exist, but the hardware reports the CRC was OK. Suppress the data of the second channel in the HE radiotap in this case, by marking it as not known. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 14/16] iwlwifi: refactor txq_alloc for supporting more command type

2018-08-24 Thread Luca Coelho
From: Golan Ben Ami Support more txq_alloc command types by moving the command declaration to the gen specific area. While at it, move some of the code segments to a common place for re-use. Signed-off-by: Golan Ben Ami Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/iwl

[PATCH 10/16] iwlwifi: avoid code duplication in stopping fw debug data recording

2018-08-24 Thread Luca Coelho
From: Shahar S Matityahu Make all FW debug data stop recording flows to use iwl_fw_dbg_stop_recording function instead of writing to FW registers directly. Signed-off-by: Shahar S Matityahu Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++-- drivers

[PATCH 09/16] iwlwifi: change monitor DMA to be coherent

2018-08-24 Thread Luca Coelho
From: Shahar S Matityahu Allow access to the memory by the host and the device simultaneously. This will be needed in some future patches. Signed-off-by: Shahar S Matityahu Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/pcie/internal.h| 4 +- .../net/wireless/intel/iwlwifi

Re: [PATCH 28/28] mac80211: Don't wake up from PS for offchannel TX

2018-08-31 Thread Luca Coelho
On Fri, 2018-08-31 at 11:21 -0700, Peter Oh wrote: > > On 08/31/2018 01:31 AM, Luca Coelho wrote: > > ) > > > > From: Andrei Otcheretianski > > > > Otherwise the offchannel frame might be queued due to > > IEEE80211_QUEUE_STOP_REASON_PS and later drop

Re: [PATCH 21/28] wireless: align to draft 11ax D3.0

2018-08-31 Thread Luca Coelho
On Fri, 2018-08-31 at 14:21 +0300, Kalle Valo wrote: > Kalle Valo writes: > > > Luca Coelho writes: > > > > > ) > > > > > > From: Shaul Triebitz > > > > That ')' in the first line doesn't look correct and don't know how > > pat

[RESEND PATCH v2 7/9] cfg80211: reg: Init wiphy_idx in regulatory_hint_core()

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Core regulatory hints didn't set wiphy_idx to WIPHY_IDX_INVALID. Since the regulatory request is zeroed, wiphy_idx was always implicitly set to 0. This resulted in updating only phy #0. Fix that. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[RESEND PATCH v2 1/9] mac80211: support reporting 0-length PSDU in radiotap

2018-09-04 Thread Luca Coelho
Signed-off-by: Luca Coelho --- include/net/ieee80211_radiotap.h | 6 ++ include/net/mac80211.h | 7 +++ net/mac80211/rx.c| 12 +++- 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/include/net/ieee80211_radiotap.h b/include/net

[RESEND PATCH v2 8/9] mac80211: Always report TX status

2018-09-04 Thread Luca Coelho
Otcheretianski Signed-off-by: Luca Coelho --- net/mac80211/status.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 9a6d7208bf4f..001a869c059c 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -479,11

[RESEND PATCH v2 5/9] mac80211: allow AMSDU size limitation per-TID

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some drivers may have AMSDU size limitation per TID, due to HW constrains. Add an option to set this limit. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h | 2 ++ net/mac80211/tx.c | 4 2 files changed, 6 insertions(+) diff --git

[RESEND PATCH v2 0/9] cfg80211/mac80211: reworked patches from our internal tree 2018-08-31

2018-09-04 Thread Luca Coelho
From: Luca Coelho Hi, [I'm resending this set again due to the corrupted X-SA headers in the previous attempts. I have now removed all the X-SA headers and hopefully it will work fine. Please let me know if you still have issues with it.] I'm resending the patches that came out corrupted

[RESEND PATCH v2 3/9] wireless: align to draft 11ax D3.0

2018-09-04 Thread Luca Coelho
From: Shaul Triebitz Align to new 11ax draft D3.0. Change/add new MAC and PHY capabilities and update drivers' 11ax capabilities and mac80211's debugfs accordingly. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/iwl-nvm-parse.c| 51

[RESEND PATCH v2 4/9] mac80211: add an option for station management TXQ

2018-09-04 Thread Luca Coelho
-by: Luca Coelho --- include/net/mac80211.h | 5 + net/mac80211/debugfs.c | 1 + net/mac80211/tx.c | 14 +++--- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 50bf598abdfd..fe71cec8ba42 100644 --- a/include/net

[RESEND PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Otherwise the offchannel frame might be queued due to IEEE80211_QUEUE_STOP_REASON_PS and later dropped (in ieee80211_tx_frags()). Anyway, it doesn't make much sense to wake up the device during ROC. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[RESEND PATCH v2 2/9] mac80211: fix saving a few HE values

2018-09-04 Thread Luca Coelho
2_get_bits()] Signed-off-by: Luca Coelho --- net/mac80211/mlme.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 1bd714376635..3b1b7a77fa7d 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -3173,1

[RESEND PATCH v2 6/9] mac80211: add an option for drivers to check if packets can be aggregated

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some hardwares have limitations on the packets' type in AMSDU. Add an optional driver callback to determine if two skbs can be used in the same AMSDU or not. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h| 7 +++ net/mac80211

[PATCH 03/16] iwlwifi: pcie: tx: pull tracing out of iwl_fill_data_tbs()

2018-09-09 Thread Luca Coelho
From: Johannes Berg This will allow us to reuse the function later for adding fraglist SKBs to the TFD. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 41 ++-- 1 file changed, 21 insertions(+), 20 deletions(-) diff

[PATCH 01/16] iwlwifi: pcie: gen2: build A-MSDU only for GSO

2018-09-09 Thread Luca Coelho
AMSDU to gen2") Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie

[PATCH 02/16] iwlwifi: pcie: tx: unify TFD unmapping

2018-09-09 Thread Luca Coelho
From: Johannes Berg When anything fails, we unmap the whole TFD in three different places scattered throughout the code. Unify this to a single place. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 28 +--- 1 file

[PATCH 05/16] iwlwifi: pcie: fit reclaim msg to MAX_MSG_LEN

2018-09-09 Thread Luca Coelho
a bit so it will fit the allowed MAX_MSG_LEN. Signed-off-by: Golan Ben Ami Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c b/drivers/net/wireless/intel

[PATCH 15/16] iwlwifi: fix LED command capability bit

2018-09-09 Thread Luca Coelho
when the FW supports it") Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/file.h b/drivers/net/wireless/intel/iwlwifi/fw/fi

[PATCH 10/16] iwlwifi: mvm: TLC support for Coex Schema 2

2018-09-09 Thread Luca Coelho
From: Erel Geron The new coex schema requires setting the non-shared antenna for the single_stream_ant_msk field in the TLC command. Signed-off-by: Erel Geron Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/coex.c | 9 + drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 11/16] iwlwifi: mvm: remove support for adjacent channel compensation

2018-09-09 Thread Luca Coelho
From: Emmanuel Grumbach We no longer want to consider the RSSI if the beacon / probe has been heard on an adjacent channel. This was based on a firmware capability that is now unavailable. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 14/16] iwlwifi: configure power scheme to balanced for 22560 devices

2018-09-09 Thread Luca Coelho
-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index d728b854be95..0599d323cbeb 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm

[PATCH 13/16] iwlwifi: pcie: add infrastructure for multiple debug buffers

2018-09-09 Thread Luca Coelho
-off-by: Sara Sharon Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/iwl-trans.h| 17 +++ .../intel/iwlwifi/pcie/ctxt-info-gen3.c | 4 +- .../wireless/intel/iwlwifi/pcie/internal.h| 19 --- .../net/wireless/intel/iwlwifi/pcie/trans.c | 116 +- 4

[PATCH 16/16] iwlwifi: mvm: Allow TKIP for AP mode

2018-09-09 Thread Luca Coelho
From: Ilan Peer Support for setting keys for TKIP cipher suite was mistakenly removed for AP mode. Fix this. Fixes: 85aeb58cec1a ("iwlwifi: mvm: Enable security on new TX API") Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c |

[PATCH 08/16] iwlwifi: mvm: use correct FIFO length

2018-09-09 Thread Luca Coelho
From: Sara Sharon Current FIFO size calculation is wrong for two reasons: - We access lmac 0 by default - We don't take 11ax into consideration. Fix both. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 4 ++ drivers/net/wireless

[PATCH 09/16] iwlwifi: mvm: set wep key for all stations in soft ap mode

2018-09-09 Thread Luca Coelho
going out un-encrypted. Fix it by configuring the key for all the stations as they are added. Signed-off-by: Avraham Stern Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 29 ++- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 1 + drivers/net

[PATCH 06/16] iwlwifi: mvm: do not override amsdu size user settings

2018-09-09 Thread Luca Coelho
From: Shaul Triebitz Since AMSDUs are not de-aggregated by HW in monitor mode, we still need the option for setting large RBs (up to 12K). Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 20 1 file changed, 12

[PATCH 04/16] iwlwifi: pcie: Fail fast if HW is inaccessible at probe

2018-09-09 Thread Luca Coelho
1:00.0: iwlwifi device config registers: Signed-off-by: Rajat Jain Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/t

[PATCH 07/16] iwlwifi: pcie: set RB size according to user settings

2018-09-09 Thread Luca Coelho
From: Shaul Triebitz RB size can be configured by user to be greater than 4K. That's needed for monitor to capture big AMSDUs. The firmware now enables different RB sizes configuration via context info. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi

[PATCH 00/16] iwlwifi: updates intended for v4.20 2018-09-09

2018-09-09 Thread Luca Coelho
From: Luca Coelho Hi, Here's the fifth set of patches intended for v4.20. It's the usual development, with some small new features, cleanups and bugfixes. The changes are: * Fix one FW feature TLV that had a conflict with another value; * A couple of fixes for SoftAP mode; * Work continues

[PATCH 12/16] iwlwifi: pcie: support transmitting SKBs with fraglist

2018-09-09 Thread Luca Coelho
From: Johannes Berg We want to be able to build A-MSDUs in higher layers, e.g. by xmit_more, so support transmitting SKBs with fraglist to use it for such. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 8 1 file changed, 8

Re: [PATCH 14/15] iwlwifi: mvm: Send LQ command as async when necessary

2018-09-06 Thread Luca Coelho
On Thu, 2018-09-06 at 16:22 +0800, Hao Wei Tee wrote: > Hi, Hi Hao Wei, > On 21/8/18 2:36 PM, Luca Coelho wrote: > > From: Avraham Stern > > > > The parameter that indicated whether the LQ command should be sent > > as sync or async was removed, causing the LQ

[PATCH 23/28] mac80211: add an option for station management TXQ

2018-08-31 Thread Luca Coelho
-by: Luca Coelho --- include/net/mac80211.h | 5 + net/mac80211/debugfs.c | 1 + net/mac80211/tx.c | 14 +++--- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index ddfa7f325b34..1d1dbd8123a4 100644 --- a/include/net

[PATCH 21/28] wireless: align to draft 11ax D3.0

2018-08-31 Thread Luca Coelho
) From: Shaul Triebitz Align to new 11ax draft D3.0. Change/add new MAC and PHY capabilities and update drivers' 11ax capabilities and mac80211's debugfs accordingly. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/iwl-nvm-parse.c| 51

[PATCH 16/28] mac80211: add ability to parse CCFS2

2018-08-31 Thread Luca Coelho
From: Johannes Berg With newer VHT implementations, it's necessary to look at the HT operation's CCFS2 field to identify the actual bandwidth used. Signed-off-by: Johannes Berg --- net/mac80211/ibss.c| 4 +++- net/mac80211/ieee80211_i.h | 4 +++- net/mac80211/mesh.c| 5 +++-

[PATCH 28/28] mac80211: Don't wake up from PS for offchannel TX

2018-08-31 Thread Luca Coelho
) From: Andrei Otcheretianski Otherwise the offchannel frame might be queued due to IEEE80211_QUEUE_STOP_REASON_PS and later dropped (in ieee80211_tx_frags()). Anyway, it doesn't make much sense to wake up the device during ROC. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[PATCH 22/28] mac80211: avoid kernel panic when building AMSDU from non-linear SKB

2018-08-31 Thread Luca Coelho
and not have pad at all for the last subframe, both required by the spec. Fixes: 6e0456b54545 ("mac80211: add A-MSDU tx support") Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- net/mac80211/tx.c | 38 +- 1 file changed, 21 insertions(+), 17

[PATCH 07/28] ieee80211: remove redundant leading zeroes

2018-08-31 Thread Luca Coelho
From: Sara Sharon The defines of IEEE80211_HE_OPERATION_VHT_OPER_INFO and IEEE80211_HE_OPERATION_MULTI_BSSID_AP have leading zeroes that makes the number look like it is bigger than 32 bit. This is misleading, remove it. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/linux

[PATCH 00/28] cfg80211/mac80211 patches from our internal tree 2018-08-31

2018-08-31 Thread Luca Coelho
From: Luca Coelho Hi, Some patches with mac80211 and cfg80211 changes from our internal tree. Please review, though you have already reviewed most if not all of them ;) Cheers, Luca. Andrei Otcheretianski (3): cfg80211: reg: Init wiphy_idx in regulatory_hint_core() mac80211: Always

[PATCH 01/28] mac80211: Add he_capa debugfs entry

2018-08-31 Thread Luca Coelho
From: Ido Yariv Export HE capabilities information via debugfs, similar to HT & VHT. Signed-off-by: Ido Yariv Signed-off-by: Luca Coelho --- net/mac80211/debugfs_sta.c | 325 + 1 file changed, 325 insertions(+) diff --git a/net/mac80211/debugfs_sta

[PATCH 05/28] mac80211: use le16_encode_bits() instead of open-coding

2018-08-31 Thread Luca Coelho
From: Johannes Berg Instead of open-coding the equivalent of le16_encode_bits(), just use that. Signed-off-by: Johannes Berg --- net/mac80211/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 134bbbc9cd6e..f988609e1283 100644

[PATCH 03/28] mac80211: remove pointless 'params' NULL checks

2018-08-31 Thread Luca Coelho
From: Johannes Berg These checks aren't necessary, cfg80211 never passes NULL. Some static checkers complain about the missing checks on the next line, but really the NULL checks are unnecessary. Signed-off-by: Johannes Berg --- net/mac80211/cfg.c | 6 ++ 1 file changed, 2 insertions(+),

[PATCH 02/28] mac80211: fix WMM TXOP calculation

2018-08-31 Thread Luca Coelho
2.11 to ETSI to make sure we are not violating both. Fixes: e552af058148 ("mac80211: limit wmm params to comply with ETSI requirements") Signed-off-by: Haim Dreyfuss Signed-off-by: Luca Coelho --- net/mac80211/util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

[PATCH 04/28] mac80211: fix a race between restart and CSA flows

2018-08-31 Thread Luca Coelho
inimum to fix the actual bug that was actually experienced and reproduced. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- net/mac80211/main.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/net/mac80211/main.c b/net/mac80211/main.c

[PATCH 06/28] mac80211: add an optional TXQ for other PS-buffered frames

2018-08-31 Thread Luca Coelho
From: Johannes Berg Some drivers may want to also use the TXQ abstraction with non-data packets that need powersave buffering, so add a hardware flag to allow this. Signed-off-by: Johannes Berg --- include/net/mac80211.h | 17 - net/mac80211/debugfs.c | 2 ++

[PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver

2018-08-31 Thread Luca Coelho
if it supports the feature. Since those bits are present in the HE Cap as well, we can set the capability bits in the Extended Capabilities IE based on what is advertised in the HE Cap IE. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- include/linux/ieee80211.h | 4 include/net

[PATCH 08/28] mac80211: Fix station bandwidth setting after channel switch

2018-08-31 Thread Luca Coelho
the interface channel configuration. Fix this by updating the AP station bandwidth and rate scaling algorithm before the actual channel change in case of a bandwidth downgrade, or after the actual channel change in case of a bandwidth upgrade. Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho

[PATCH 10/28] mac80211: don't Tx a deauth frame if the AP forbade Tx

2018-08-31 Thread Luca Coelho
. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- net/mac80211/mlme.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 4b53bbd10a3a..3dbecae4be73 100644 --- a/net/mac80211/mlme.c +++ b/net

[PATCH 25/28] mac80211: add an option for drivers to check if packets can be aggregated

2018-08-31 Thread Luca Coelho
) From: Sara Sharon Some hardwares have limitations on the packets' type in AMSDU. Add an optional driver callback to determine if two skbs can be used in the same AMSDU or not. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h| 7 +++ net/mac80211

pull-request: iwlwifi-next 2018-08-31

2018-08-31 Thread Luca Coelho
: mvm: add support for RX_AMPDU_EOF bit for HE SU Luca Coelho (6): iwlwifi: remove unused TLC debugging commands iwlwifi: mvm: remove duplicate if in iwl_mvm_setup_connection_keep() iwlwifi: mvm: protect D0i3 code behind CONFIG_PM iwlwifi: mvm: support new WoWLAN sta

[PATCH 19/28] mac80211: support reporting 0-length PSDU in radiotap

2018-08-31 Thread Luca Coelho
Signed-off-by: Luca Coelho --- include/net/ieee80211_radiotap.h | 6 ++ include/net/mac80211.h | 6 ++ net/mac80211/rx.c| 12 +++- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/include/net/ieee80211_radiotap.h b/include/net

[PATCH 20/28] mac80211: fix saving a few HE values

2018-08-31 Thread Luca Coelho
) From: Naftali Goldstein After masking the he_oper_params, to get the requested values as integers one must rshift and not lshift. Fix that. Fixes: 41cbb0f5a295 ("mac80211: add support for HE") Signed-off-by: Naftali Goldstein Signed-off-by: Luca Coelho --- net/mac80211/mlme.c |

[PATCH 13/28] mac80211: in AP mode, set bss_conf::he_supported

2018-08-31 Thread Luca Coelho
From: Shaul Triebitz In AP mode, If AP advertises HE capabilities, set to true bss_conf::he_supported so that the Driver knows about it. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- net/mac80211/cfg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/mac80211/cfg.c b

[PATCH 24/28] mac80211: allow AMSDU size limitation per-TID

2018-08-31 Thread Luca Coelho
) From: Sara Sharon Some drivers may have AMSDU size limitation per TID, due to HW constrains. Add an option to set this limit. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h | 2 ++ net/mac80211/tx.c | 4 2 files changed, 6 insertions(+) diff

[PATCH 18/28] mac80211: support radiotap L-SIG data

2018-08-31 Thread Luca Coelho
From: Shaul Triebitz As before with HE, the data needs to be provided by the driver in the skb head, since there's not enough space in the skb CB. Signed-off-by: Johannes Berg Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- include/net/ieee80211_radiotap.h | 15

[PATCH 11/28] mac80211: shorten the IBSS debug messages

2018-08-31 Thread Luca Coelho
] ieee80211_iface_work+0x21d/0x320 [mac80211] Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- net/mac80211/ibss.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c index 6449a1c2283b..f0f5fedb8caa 100644 --- a/net

[PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-08-31 Thread Luca Coelho
From: Shaul Triebitz Same as for HT and VHT. This helps the lower level to know whether the AP supports HE. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- include/net/cfg80211.h | 2 ++ net/wireless/nl80211.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/net

[PATCH 14/28] ieee80211: add new VHT capability fields/parsing

2018-08-31 Thread Luca Coelho
From: Johannes Berg IEEE 802.11-2016 extended the VHT capability fields to allow indicating the number of spatial streams depending on the actually used bandwidth, add support for decoding this. Signed-off-by: Johannes Berg --- include/linux/ieee80211.h | 35 +++- net/wireless/util.c

[PATCH 15/28] mac80211: introduce capability flags for VHT EXT NSS support

2018-08-31 Thread Luca Coelho
From: Johannes Berg Depending on whether or not rate control supports selecting rates depending on the bandwidth, we can use VHT extended NSS support. In essence, this is dot11VHTExtendedNSSBWCapable from the spec, since depending on that we'll need to parse the bandwidth. If needed, also

[PATCH] iwlwifi: fix devices with PCI Device ID 0x34F0 and 11ac RF modules

2018-08-31 Thread Luca Coelho
From: Luca Coelho The devices with PCI device ID 0x34F0 are part of the SoC and can be combined with some different external RF modules. The configuration for these devices should reflect that, but are currently mixed up. To avoid confusion with discrete devices, add part of the firmware

[PATCH 00/16] iwlwifi: updates intended for v4.20 2018-08-

2018-08-31 Thread Luca Coelho
From: Luca Coelho Hi, Here's the fourth set of patches intended for v4.20. It's the usual development, with some small new features, cleanups and bugfixes. The changes are: * TKIP implementation in new devices; * Fix for the shared antenna setting in 22000 series; * Report that we set the RU

[PATCH 12/16] iwlwifi: mvm: enable sending HE_AIR_SNIFFER command via debugfs

2018-08-31 Thread Luca Coelho
From: Shaul Triebitz In order to receive TB (Trigger Based) PPDU in monitor mode, the Driver must send the HE_AIR_SNIFFER_CONFIG_CMD host command. Enable that via debugfs. Signed-off-by: Liad Kaufman Signed-off-by: Ido Yariv Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho

[PATCH 14/16] iwlwifi: mvm: Support TKIP on gen2 data path

2018-08-31 Thread Luca Coelho
in the set_key() callback so that the key flags would not be incorrectly set. Signed-off-by: David Spinadel Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 11 +-- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 9 - 2

[PATCH 11/16] iwlwifi: mvm: cleanup dead code on resume flow for non unified image.

2018-08-31 Thread Luca Coelho
From: "Dreyfuss, Haim" CDB support has nothing to do with non unified image. Signed-off-by: Haim Dreyfuss Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/ne

[PATCH 13/16] iwlwifi: pcie: read correct prph address for newer devices

2018-08-31 Thread Luca Coelho
From: Sara Sharon For newer devices we have higher range of periphery addresses. Currently it is masked out, so we end up reading another address. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 16 ++-- 1 file changed

[PATCH 10/16] iwlwifi: fix non_shared_ant for 22000 devices

2018-08-31 Thread Luca Coelho
From: Erel Geron The non-shared antenna was wrong for 22000 device series. Fix it to ANT_B for correct antenna preference by coex in MVM driver. Fixes: e34d975e40ff ("iwlwifi: Add a000 HW family support") Signed-off-by: Erel Geron Signed-off-by: Luca Coelho --- drivers/net/wire

[PATCH 16/16] iwlwifi: pcie: gen2: pull adding frags to helper routine

2018-08-31 Thread Luca Coelho
From: Johannes Berg Move the skb fragment loop into a helper routine to be able to reuse it later. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 51 --- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git

[PATCH 26/28] cfg80211: reg: Init wiphy_idx in regulatory_hint_core()

2018-08-31 Thread Luca Coelho
) From: Andrei Otcheretianski Core regulatory hints didn't set wiphy_idx to WIPHY_IDX_INVALID. Since the regulatory request is zeroed, wiphy_idx was always implicitly set to 0. This resulted in updating only phy #0. Fix that. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[PATCH 17/28] mac80211: copy VHT EXT NSS BW Support/Capable data to station

2018-08-31 Thread Luca Coelho
From: Johannes Berg When taking VHT capabilities for a station, copy the new fields if we support them as a transmitter. Also adjust the maximum bandwidth the station supports appropriately. Also, since it was missing, copy tx_highest and rx_highest. Signed-off-by: Johannes Berg ---

[PATCH 27/28] mac80211: Always report TX status

2018-08-31 Thread Luca Coelho
Otcheretianski Signed-off-by: Luca Coelho --- net/mac80211/status.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 9a6d7208bf4f..001a869c059c 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -479,11

[PATCH 02/16] iwlwifi: fw: add a restart FW debug function

2018-08-31 Thread Luca Coelho
From: Sara Sharon Move the restart FW debug code to a function. This avoids code duplication and lays the infra to support the new start and stop host commands in some future devices. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 37

[PATCH 08/16] iwlwifi: remove ucode error tracepoint

2018-08-31 Thread Luca Coelho
turns out that nobody really uses it. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/dvm/main.c | 2 +- .../intel/iwlwifi/iwl-devtrace-iwlwifi.h | 55 --- .../net/wireless/intel/iwlwifi/iwl-devtrace.c | 3 +- .../net/wire

<    11   12   13   14   15   16   17   18   19   >