[PATCH 07/10] mac80211: add api to start ba session timer expired flow

2017-08-05 Thread Luca Coelho
luding sending a delba. Signed-off-by: Naftali Goldstein <naftali.goldst...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/net/mac80211.h | 15 +++ net/mac80211/agg-rx.c | 22 +- 2 files changed, 36 insertions(+), 1 delet

[PATCH 06/10] cfg80211: honor NL80211_RRF_NO_HT40{MINUS,PLUS}

2017-08-05 Thread Luca Coelho
59592b ("cfg80211: allow wiphy specific regdomain management") Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/wireless/reg.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) dif

[PATCH 02/10] mac80211: shorten debug prints using ht_dbg() to avoid warning

2017-08-05 Thread Luca Coelho
From: Sharon Dvir <sharon.d...@intel.com> Invoking ht_dbg() with too long of a string will print a warning. Shorten the messages while retaining the printed patameters. Signed-off-by: Sharon Dvir <sharon.d...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 01/10] mac80211: add MESH IE in the correct order

2017-08-05 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> VHT MESH support was added, but the order of the IEs wasn't enforced. Fix that. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/util.c | 2 +- 1 file ch

[PATCH 15/24] iwlwifi: mvm: support fw reading empty OTP

2017-07-28 Thread Luca Coelho
m data from firmware") Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/nvm-reg.h | 10 +- drivers/net/wireless/intel/iwlwifi/mvm/nvm.c| 7 ++- 2 files

[PATCH 18/24] iwlwifi: pcie: rename iwl_trans_check_hw_rf_kill() to pcie

2017-07-28 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Rename this function to the more appropriate iwl_pcie_check_hw_rf_kill() since it's only a function in the pcie code and cannot be called from any other place. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by:

[PATCH 17/24] iwlwifi: mvm: add compile-time option to disable EBS

2017-07-28 Thread Luca Coelho
From: "Zamir, Roee" <roee.za...@intel.com> For testing purposes, we may want to disable EBS scans at compile time. Signed-off-by: Roee Zamir <roee.za...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/co

[PATCH v2 12/19] iwlwifi: mvm: support new beacon template command

2017-08-09 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/tx.h| 17 +--- drivers/net/wireless/intel/iwlwifi/fw/file.h | 1 + drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 47 --- 3 files changed, 47 insertion

[PATCH 1/2] mac80211: add api to start ba session timer expired flow

2017-08-09 Thread Luca Coelho
luding sending a delba. Signed-off-by: Naftali Goldstein <naftali.goldst...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/net/mac80211.h | 15 +++ net/mac80211/agg-rx.c | 22 +- 2 files changed, 36 insertions(+), 1 delet

[PATCH 2/2] iwlwifi: mvm: send delba upon rx ba session timeout

2017-08-09 Thread Luca Coelho
rivers that offload the addba/delba negotiation, but not the rx reordering, while our driver does the opposite. This patch depends on "mac80211: add api to start ba session timer expired flow". Signed-off-by: Naftali Goldstein <naftali.goldst...@intel.com> Signed-off-by: Lu

[PATCH 0/2] iwlwifi: one more fix intended for 4.13 2017-08-09

2017-08-09 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, This is the mac80211+iwlwifi fix we talked about earlier. As I mentioned, the iwlwifi patch fixes a severe degradation of throughput in the 9000 device series, due to a BA-session getting stuck and the lack of future aggregation. The ma

[PATCH v2 4/19] iwlwifi: mvm: add debugfs to force CT-kill

2017-08-09 Thread Luca Coelho
r without having to physically heat the device up. Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 14 ++ drivers/net/wireless/intel/iwlwifi/mvm/m

pull-request: iwlwifi 2017-08-09

2017-08-09 Thread Luca Coelho
Hi Kalle, Here is the third set of fixes for 4.13. More details in the tag description. This includes both series I sent out, the first one, with v2 of the second patch, with an improved commit message, and the second one, which contains the mac80211 patch as well. I have sent this out before

[PATCH v2 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged

2017-08-09 Thread Luca Coelho
queue will not be transmitted. Fix this by starting the relevant mac queues when the deferred tx frames are purged. Fixes: 24afba7690e4 ("iwlwifi: mvm: support bss dynamic alloc/dealloc of queues") Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Lu

[PATCH v3 12/19] iwlwifi: mvm: support new beacon template command

2017-08-09 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- In v3: * fix a bug in the CCK flag check drivers/net/wireless/intel/iwlwifi/fw/api/tx.h| 17 +--- drivers/net/wireless/intel/iwlwifi/fw/file.h | 1 + drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 47 ++

Re: [PATCH 00/10] mac80211 patches from our internal tree 2017-08-05

2017-08-07 Thread Luca Coelho
On Mon, 2017-08-07 at 12:06 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > Here are some pending mac80211 patches from our internal tree. > > > > The "mac80211: add api to start ba session timer expired flow" patch > > is

Re: [PATCH 04/19] iwlwifi: mvm: add debugfs to force CT-kill

2017-08-07 Thread Luca Coelho
On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > From: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> > > > > In order to test the enter/exit CT-kill flow. > > > > Signed-off-by: Chaya Rachel I

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

2017-08-07 Thread Luca Coelho
On Mon, 2017-08-07 at 16:37 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote: > > > Luca Coelho <l...@coelho.fi> writes: > > > > > > > From: Christophe Jaillet <chris

Re: [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

2017-08-07 Thread Luca Coelho
On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > From: Christophe Jaillet <christophe.jail...@wanadoo.fr> > > > > We should free 'wgds.pointer' here as done a few lines above in another > > error

[PATCH 04/10] mac80211: simplify and clarify IE splitting

2017-08-05 Thread Luca Coelho
From: Johannes Berg There's no need to split off IEs from the ones obtained from userspace, if they were already split off, so for example IEs that went before HT don't have to be listed again to go before VHT. Simplify the code here so it's clearer. While at it, also

[PATCH 05/10] ieee80211: Add WFA TPC report element OUI type

2017-08-05 Thread Luca Coelho
From: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/linux/ieee80211.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/ieee80211.h b/include/linux

[PATCH 10/10] nl80211: return error for invalid center_freq in 40 MHz

2017-08-05 Thread Luca Coelho
ix, we will throw an error instead. Signed-off-by: Tova Mussai <tova.mus...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/wireless/nl80211.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 45ba3d08

[PATCH 09/10] mac80211_hwsim: Add command to control rx status RSSI

2017-08-05 Thread Luca Coelho
From: Beni Lev <beni@intel.com> Set the base RSSI of a TX frame. The final RSSI of the frame will be the base RSSI + the radio's TX power Signed-off-by: Beni Lev <beni@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/mac

[PATCH 00/10] mac80211 patches from our internal tree 2017-08-05

2017-08-05 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here are some pending mac80211 patches from our internal tree. The "mac80211: add api to start ba session timer expired flow" patch is needed by an iwlwifi patch that I want to send for -fixes, so it would have to be applied t

[PATCH 03/10] mac80211: extend ieee80211_ie_split to support EXTENSION

2017-08-05 Thread Luca Coelho
array is a sub-element of the EXTENSION IE. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/net/cfg80211.h | 6 -- net/wireless/util.c| 54 ++ 2 files chan

Re: Cisco's Wi-Fi Direct Client Policy and iwlwifi (8260)

2017-08-18 Thread Luca Coelho
Hi Dariusz, On Fri, 2017-08-18 at 14:48 +0200, Dariusz Gadomski wrote: > Hi, > > There is a “Wi-Fi Direct Client Policy” setting in some Cisco AP hardware [1]. > I am unaware how that works exactly behind the scenes (except for some hints > at > [2]), but I have noticed that with that setting

Re: Cisco's Wi-Fi Direct Client Policy and iwlwifi (8260)

2017-08-18 Thread Luca Coelho
On Fri, 2017-08-18 at 20:16 +0300, Luca Coelho wrote: > Hi Dariusz, > > On Fri, 2017-08-18 at 14:48 +0200, Dariusz Gadomski wrote: > > Hi, > > > > There is a “Wi-Fi Direct Client Policy” setting in some Cisco AP hardware > > [1]. > > I am unaware how that

pull-request: iwlwifi-next 2017-08-18

2017-08-19 Thread Luca Coelho
mvm: Fix channel switch in case of count <= 1 João Paulo Rechi Vita (1): iwlwifi: Demote messages about fw flags size to info Luca Coelho (12): iwlwifi: mvm: consider RFKILL during INIT as success iwlwifi: call iwl_remove_notification from iwl_wait_notification

[PATCH v4 12/19] nl80211: add an option to allow MFP without requiring it

2017-08-18 Thread Luca Coelho
hether to use it or not. Include a feature bit to advertise support for NL80211_MFP_OPTIONAL. This allows new user space to run on old kernels and know that it cannot use the new attribute if it isn't supported. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 1/2] mac80211: add documentation to ieee80211_rx_ba_offl()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Add documentation to ieee80211_rx_ba_offl() function and, while at it, rename the bit argument to tid, for consistency. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/net/mac80211.h | 8 +++- net/mac80211/agg-rx.c

[PATCH 0/2] mac80211 patches from our internal tree 2017-08-18

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Here are two pending mac80211 patches from our internal tree. Please review. Cheers, Luca. Avraham Stern (1): mac80211: flush hw_roc_start work before cancelling the ROC Luca Coelho (1): mac80211: add documentation to ieee80211_rx_b

[PATCH 2/2] mac80211: flush hw_roc_start work before cancelling the ROC

2017-08-18 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/offchannel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c index f8e7a8bbc618..faf4f6055000 100644 --- a/net/mac80211/offchannel.c +++ b/net/mac

[PATCH 09/24] iwlwifi: mvm: use mvmsta consistently in rs.c

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We use mvmsta for the sta->drv_priv in mvm, but in rs.c we have a bunch of instances using sta_priv, which is probably due to it being copied from dvm. Change all occurrences to mvmsta for consistency with the rest of the driver Signed-off

[PATCH 00/24] iwlwifi: updates intended for v4.14 2017-08-18

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's one more set of patches for v4.14. These are the changes: * Work for the upcoming A000 device family continues; * Improvements in debugging; * A couple of improvements in block-ack sessions; * Some fixes for channel switch; * A work

[PATCH 01/24] iwlwifi: mvm: remove the corunning support

2017-08-18 Thread Luca Coelho
er has always been blank. Remove all that code. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/coex.h | 13 - .../net/wireless/intel/iwlwifi/fw/api/commands.h | 12 - dr

[PATCH 03/24] iwlwifi: call iwl_remove_notification from iwl_wait_notification

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The iwl_wait_notification() function removes the wait entry from the list. To make it clearer that it's doing the same thing as iwl_remove_notification(), call the latter instead of having duplicate code. Signed-off-by: Luca Coelho <lu

[PATCH 05/24] iwlwifi: pcie: support short Tx queues for A000 device family

2017-08-18 Thread Luca Coelho
Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/pcie/ctxt-info.c| 2 +- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 13 +++ drivers/net/wireless/intel/iwlwifi/pc

[PATCH 06/24] iwlwifi: mvm: add command name for FRAME_RELEASE

2017-08-18 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> This name was missing in the list. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 + 1 file ch

[PATCH 04/24] iwlwifi: mvm: support new Coex firmware API

2017-08-18 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> The firmware now adds more information about time sharing with the Bluetooth core. Adapt the API structures and add the new fields in the debugfs hooks. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 07/24] iwlwifi: mvm: include more debug data when we get an unexpected baid

2017-08-18 Thread Luca Coelho
manuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/

[PATCH 02/24] iwlwifi: mvm: consider RFKILL during INIT as success

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There's no need to differentiate an INIT that ended early because of RFKILL from one that succeded. Additionally, if INIT fails later, during calibration, due to RFKILL, we can just return success and continue as if we were already in RFKILL to

[PATCH 08/24] iwlwifi: mvm: group all dummy SAR function declarations together

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We have some of the SAR dummy functions when ACPI is not set declared in mvm.h and some declared in fw.c. Group them all together in fw.c for consistency and to avoid static/non-static issues. Signed-off-by: Luca Coelho <luciano.coe...@

[PATCH 10/24] iwlwifi: mvm: update the firmware API in TX

2017-08-18 Thread Luca Coelho
mapped reasons. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/tx.h | 9 +++-- drivers/net/wireless/intel/iwlwifi/mvm/tx.c| 2 +- 2 files changed, 4 insertions(+), 7

[PATCH 12/24] iwlwifi: mvm: don't send BAR on flushed frames

2017-08-18 Thread Luca Coelho
<emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi

pull-request: iwlwifi firmwares update 2017-05-10

2017-05-10 Thread Luca Coelho
Hi Kyle, The last time we pushed new -22 firmwares, we forgot to update the relevant version for 3168 devices. This pull-request contains only this update. Please pull or let me know if there are any issues. Cheers, Luca. The following changes since commit

[PATCH 20/25] iwlwifi: pcie: don't report RF-kill enabled while shutting down

2017-06-22 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 2 +- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 6 +- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 12 ++-- drivers/net/wireless/intel/iwlwifi/pcie/internal.h |

[PATCH 17/25] iwlwifi: pcie: pull out common rfkill IRQ handling code

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> There's no point in duplicating exactly the same code here for legacy and MSI-X interrupts, so pull it out into a new function to call in both places. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho

[PATCH 21/25] iwlwifi: pcie: remove pointless debugfs parsing for csr file

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> We don't actually care about the value at all, just making sure that we can successfully parse a single integer value, but that's entirely pointless - remove it. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by:

[PATCH 22/25] iwlwifi: mvm: document status bits

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/

[PATCH 16/25] iwlwifi: mvm: rs: add logs for the wrong antenna case

2017-06-22 Thread Luca Coelho
From: Gregory Greenman <gregory.green...@intel.com> In case that rate's antenna is wrong at the init stage, it's very hard to say what went wrong. Add debug data to the already existing WARN_ON_ONCE. Signed-off-by: Gregory Greenman <gregory.green...@intel.com> Signed-off-by:

[PATCH 23/25] iwlwifi: mvm: support aggregations on A000 HW

2017-06-22 Thread Luca Coelho
around 0xFF when comparing to the next_reclaimed on A000 HW. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/ops.c |

[PATCH 13/25] iwlwifi: mvm: support D0I3_END_CMD at the start of resume

2017-06-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> New FW versions require the D0I3_END_CMD to be sent as the first command to the FW in the resume flow. If the TLV is set, send that command first, otherwise keep the original behavior (i.e. send last). Signed-off-by: Luca Coelho <lu

[PATCH 07/25] iwlwifi: pcie: fix TVQM queue ID range check

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> The queue ID should never be 512 either, so correct the check to be >= instead of just >. Fixes: 310181ec34e2 ("iwlwifi: move to TVQM mode") Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coel

[PATCH 00/25] iwlwifi: updates intended for v4.13 2017-06-23

2017-06-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Morjens, More patches intended for 4.13. These are the changes: * Johannes' documentation work continues; * Some changes in suspend/resume handling to support new FWs; * A bunch of RF-kill related fixes; * Continued work towards the A000

[PATCH 14/25] iwlwifi: mvm: change the firmware name loading

2017-06-22 Thread Luca Coelho
From: Mordechai Goodstein <mordechay.goodst...@intel.com> The firmware moved the development from a0 MAC to z0. z0 is using the same RFID and device ID as a0 so we only need to switch the name. Signed-off-by: Mordechai Goodstein <mordechay.goodst...@intel.com> Signed-off-by:

[PATCH 04/25] iwlwifi: mvm: Enable security on new TX API

2017-06-22 Thread Luca Coelho
; Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 12 ++- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 108 ++ 2 files changed, 80 insertions(+), 40 deletions(-) diff --git a/drivers/net/wireless/intel/iwlw

[PATCH 08/25] iwlwifi: mvm: avoid variable shadowing

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Avoid one kind of symbol shadowing another in iwl_mvm_flush_sta() by renaming the function parameter. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wire

[PATCH 09/25] iwlwifi: mvm: use scnprintf() instead of snprintf()

2017-06-22 Thread Luca Coelho
s Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/mvm/debugfs-vif.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vi

[PATCH 02/25] iwlwifi: remove resp_pkt NULL checks

2017-06-22 Thread Luca Coelho
.resp_pkt; ... -if (WARN_ON(!pkt)) { ... } | -if (!cmd.resp_pkt) { ... } ) ...> Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 3 +++ drivers/net/wireless/intel/

[PATCH 10/25] iwlwifi: use bitfield.h for some registers

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Letting the preprocessor/compiler generate the shift/mask by itself is a win for readability, so use bitfield.h for some registers. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 15/25] iwlwifi: mvm: make iwl_mvm_update_mcc() easier to follow

2017-06-22 Thread Luca Coelho
moving the NULL check closer to its source. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/nvm.c | 29 ++-- 1 file changed, 14 insertions(+), 15 deleti

[PATCH 12/25] iwlwifi: mvm: make D0I3_END_CMD sync during system resume

2017-06-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There is no need to send D0I3_END_CMD as ASYNC during the system resume flow. Additionally, the other flags used are meaningless in this case (they were just copied from the runtime resume flow), so remove them all. Signed-off-by: Luca

[PATCH 18/25] iwlwifi: pcie: add fake RF-kill to debugfs

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> In order to debug "hardware" RF-kill flows, add a low-level hook to allow changing the "hardware" RF-kill from debugfs. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano

[PATCH 24/25] iwlwifi: pcie: use kstrtou32_from_user()

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Use kstrtou32_from_user() in debugfs instead of open-coding it. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1

[PATCH 01/25] iwlwifi: mvm: remove txq EMPTYING_DELBA state for DQA

2017-06-22 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> In DQA mode, there is no need to wait for the TXQ to clear out after getting a DELBA, since traffic can continue running on the queue. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 03/25] iwlwifi: mvm: disable dbg data collect when fw isn't alive

2017-06-22 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> If FW isn't alive, trying to collect debug data will result in errors both in driver and in the collected data, so just warn and leave the collecting function in this case. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by:

[PATCH 06/25] iwlwifi: mvm: remove pointless num_stored condition

2017-06-22 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Since we exit if buf->num_stored is 0, there's no need to check it again later. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi

[PATCH 05/25] iwlwifi: mvm: avoid unnecessary cache trashing in Tx path

2017-06-22 Thread Luca Coelho
hing 4 cache lines for each packet. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wire

[PATCH v2] nl80211: Don't verify owner_nlportid on NAN commands

2017-06-26 Thread Luca Coelho
or ack may not be received. So, keep unicasting NAN events to the interface creator, but allow using a different socket for commands. Signed-off-by: Andrei Otcheretianski <andrei.otcheretian...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- In v2: * Andrei fixed

[PATCH 17/26] iwlwifi: mvm: set assoc_beacon_arrive_time

2017-06-25 Thread Luca Coelho
Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c b/drivers/net/wire

[PATCH 06/26] iwlwifi: mvm: disentangle union in TX status struct

2017-06-25 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> This improves documentation, since kernel-doc can't deal with the union well. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mv

[PATCH 12/26] iwlwifi: pcie: don't disable bh when handling FW errors

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> When we started using threaded irqs, all the opmode calls were changed to be called with local_bh disabled. The reason for this was it was that mac80211 needs that. When we are handling FW errors, mac80211 is not involved, so we don'

[PATCH 14/26] iwlwifi: mvm: don't mark TIDs that are not idle wrt BA as inactive

2017-06-25 Thread Luca Coelho
ed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c b/drivers/net/wireless/intel/i

[PATCH 11/26] iwlwifi: mvm: fix the recovery flow while connecting

2017-06-25 Thread Luca Coelho
ion flow only) and remove the station we just added. This defeats the recovery flow. Fix this by not removing the AP station in this flow if we are in recovery flow. Cc: sta...@vger.kernel.org Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.

[PATCH 19/26] iwlwifi: mvm: support new flush API

2017-06-25 Thread Luca Coelho
;sara.sha...@intel.com> Signed-off-by: Mordechai Goodstein <mordechay.goodst...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 19 ++-- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h | 14 +- drivers/ne

[PATCH 21/26] iwlwifi: mvm: print base HW address during init

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> It's sometimes hard to find out which HW address the iwlwifi device is using, for instance when reading crouded sniffer logs. To make it easier, print out an info level message with the HW address as soon as we know it. Signed-off-by: Luca

[PATCH 26/26] iwlwifi: mvm: support TX on MONITOR iface

2017-06-25 Thread Luca Coelho
frame is sent through the static-allocated queues anyway, so the problem is in DQA mode only. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 3 +++ 1 file changed, 3 inserti

[PATCH 20/26] iwlwifi: mvm: document assoc_beacon_arrive_time

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Document the assoc_beacon_arrive_time element in the iwl_mac_data_sta struct. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api-mac.h | 1 + 1 file changed, 1 insertion(+) diff --g

[PATCH 15/26] iwlwifi: add a W/A for a scheduler hardware bug

2017-06-25 Thread Luca Coelho
umbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 13 +++--- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 17 ++-- drivers/

[PATCH 22/26] iwlwifi: pcie: reduce unwanted noise in the logs

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The driver prints "L1 Enabled - LTR Enabled" all the time as dev_info, which is just useless noise in most cases. Convert this to IWL_DEBUG_POWER() so we don't pollute the log unnecessarily but still can get this info on demand. Sig

[PATCH 10/26] iwlwifi: mvm: fix nvm_data leak

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We allocate nvm_data in iwl_mvm_nvm_get_from_fw(). If something goes wrong after the allocation (i.e. if no valid MAC address is valid), we should free nvm_data before returning an error. Signed-off-by: Luca Coelho <luciano.coe...@

[PATCH 24/26] iwlwifi: mvm: fix typo in CTDP_CMD_OPERATION_REPORT description

2017-06-25 Thread Luca Coelho
From: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 16/26] iwlwifi: pcie: make iwl_pcie_apm_stop_master() return void

2017-06-25 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Nothing ever checks the return value of iwl_pcie_apm_stop_master(), so there's no point in it having one - make it return void. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.co

[PATCH 09/26] iwlwifi: remove useless iwl_free_nvm_data() function

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> This function just calls kfree(), so it only obscures the code without bringing any benefits. Remove it. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/dvm/main.c | 4 ++-- drivers/

[PATCH 03/26] iwlwifi: pcie: fix command completion name debug

2017-06-25 Thread Luca Coelho
while at it, use it from the same place as the command ID, everything else is just confusing. Fixes: ab02165ccec4 ("iwlwifi: add wide firmware command infrastructure for TX") Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@in

[PATCH 08/26] iwlwifi: document transmit buffer bits better

2017-06-25 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Properly document the transmit buffer bits using an enum and kernel-doc documentation. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwl

[PATCH 00/26] iwlwifi: updates intended for v4.13 2017-06-25

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, More patches intended for 4.13. These are the changes: * Support for a new version of the TX flush FW API; * Some fixes in monitor interfaces; * A few fixes in the recovery flows; * Documentation fixes and FW API struct cleanups; * Remov

[PATCH 04/26] iwlwifi: mvm: docs: fix enum link, provide TX response link

2017-06-25 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Fix the enum link by adding the missing & and provide the link to the TX response documentation. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wire

[PATCH 01/26] iwlwifi: simplify data tracepoint

2017-06-25 Thread Luca Coelho
..@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-devtrace-data.h | 11 ++- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 3 +-- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 3 +-- 3 files change

[PATCH 02/26] iwlwifi: fix TX tracing for non-linear SKBs

2017-06-25 Thread Luca Coelho
t frag SKBs") Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/iwl-devtrace-iwlwifi.h | 19 --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 5 ++--- drivers/net

[PATCH 25/26] iwlwifi: pcie: work around suspend/resume issue

2017-06-25 Thread Luca Coelho
A-step variant. Set the right hardware bit to disable the problematic state. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-csr.h| 4 drivers/net/wireless/intel/iwlwifi

[PATCH 23/26] iwlwifi: pcie: delete the Tx queue timer earlier upon firmware crash

2017-06-25 Thread Luca Coelho
timer of the transmit queues earlier. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH 13/26] iwlwifi: mvm: reset the HW before dumping if HW error is detected

2017-06-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> If the hardware is stuck, we can't read any of the memory we need to dump it, so we end up printing only 0xa5a5a5a5, which is useless. To solve this, poke the hardware by triggering a reset and re-enabling the clocks if we detect a HW error.

Re: [PATCH] nl80211: Don't verify owner_nlportid on NAN commands

2017-06-26 Thread Luca Coelho
On Fri, 2017-06-23 at 23:03 +0200, Arend van Spriel wrote: > On 23-06-17 11:26, Luca Coelho wrote: > > From: Andrei Otcheretianski <andrei.otcheretian...@intel.com> > > > > If NAN interface is created with NL80211_ATTR_SOCKET_OWNER, the socket > > that is use

[PATCH] nl80211: Don't verify owner_nlportid on NAN commands

2017-06-23 Thread Luca Coelho
or ack may not be received. So, keep unicasting NAN events to the interface creator, but allow using a different socket for commands. Signed-off-by: Andrei Otcheretianski <andrei.otcheretian...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/wireless/nl80211.c |

pull-request: iwlwifi firmwares update 2017-06-27

2017-06-27 Thread Luca Coelho
Hi Kyle, We have some updates for our -27 firmware version (on supported devices) and versions -29 and -31 that will be supported by the iwlwifi driver on v4.13. Please pull or let me know if there are any issues. Cheers, Luca. The following changes since commit

Re: [Linux-4.9.28] iwlwifi 6230 AGN: Microcode SW error detected

2017-05-24 Thread Luca Coelho
On Wed, 2017-05-24 at 09:41 +0200, Sedat Dilek wrote: > Hi, Hi Sedat, > I am seeing the below/following in my logs today. > My AP is a Lenovo Moto-Z with LTE support. > > Can you comment on this? > Is this a "buggy" firmware and a new firmware around? Looks like a buggy firmware, but

Re: [Linux-4.9.28] iwlwifi 6230 AGN: Microcode SW error detected

2017-05-24 Thread Luca Coelho
On Wed, 2017-05-24 at 10:15 +0200, Sedat Dilek wrote: > On Wed, May 24, 2017 at 9:57 AM, Luca Coelho <l...@coelho.fi> wrote: > > On Wed, 2017-05-24 at 09:41 +0200, Sedat Dilek wrote: > > > Hi, > > > > Hi Sedat, > > > > > > > I am

[PATCH 02/10] iwlwifi: mvm: Fix command queue number on d0i3 flow

2017-06-02 Thread Luca Coelho
e cmd queue to be #0 in dqa mode") Signed-off-by: Haim Dreyfuss <haim.dreyf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wire

[PATCH 05/10] iwlwifi: mvm: fix firmware debug restart recording

2017-06-02 Thread Luca Coelho
(where the configuration is already compiled in the firmware), we don't need to set those registers after the firmware has been loaded, but only when we want to restart the recording without having restarted the firmware. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

<    5   6   7   8   9   10   11   12   13   14   >