Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

On Fri, 28 Nov 2014 23:40:46 +0100 Rafał Miłecki zaj...@gmail.com wrote: @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw, { struct b43_wl *wl = hw_to_b43_wl(hw); - /* FIXME: add locking */ + mutex_lock(wl-mutex);

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

On Fri, 28 Nov 2014 22:32:30 -0500 nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other locking related to this driver. From the current docs: *

[PATCH] b43: Fix locking FIXME in beacon update top half

b43 has a FIXME about locking in the mac80211 set-beacon-int callback for a long time. As it turns out there actually is a tiny race window that could result in a use-after-free bug of the 'current_beacon' memory. Nobody ever reported this, so it probably never happened. Fix this by adding a

Re: [PATCH] rtlwifi: Fix EFUSE_ANA8M map value

On Fri, 22 May 2015 15:21:48 -0500 Larry Finger larry.fin...@lwfinger.net wrote: What does lsusb say about your device? 7392:7811, which is an Edimax EW-7811Un It is exactly this device. Does yours also fail with vanilla kernel? -- Michael pgpOeLg89H8Ts.pgp Description: OpenPGP digital

Re: [PATCH] rtlwifi: Fix EFUSE_ANA8M map value

On Sat, 23 May 2015 00:15:23 -0500 Larry Finger larry.fin...@lwfinger.net wrote: No, it is able to scan and connect with the vanilla kernel, but it is not terribly reliable with about 25% ping loss. I just got a report of a regression. Kernel 4.0 fails whereas 3.19 works. I have been

Re: [PATCH] b43: Fix typo in function name

On Mon, 29 Jun 2015 20:29:24 -0500 Larry Finger larry.fin...@lwfinger.net wrote: On 06/29/2015 07:45 PM, Nik Nyby wrote: This fixes a typo in the b43_lo_g_maintenance_work function name. Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/net/wireless/b43/lo.c| 4 ++--

Re: [PATCH 1/2] ssb: move functions specific to SoC hosted bus to separated file

On Sun, 25 Oct 2015 19:32:42 +0100 Rafał Miłecki wrote: > This cleans main.c a bit and will allow us to compile SoC related code > conditionally in the future. Looks good. Acked-by: Michael Buesch > +#ifdef CONFIG_SSB_BLOCKIO I wonder whether we should remove

Re: [PATCH 2/2] ssb: add Kconfig entry for compiling SoC related code

On Sun, 25 Oct 2015 19:32:43 +0100 Rafał Miłecki wrote: > This allows saving a little of space when not using ssb on Broadcom SoC. I'm not sure whether it's worth it. But I don't mind having this anyway. Acked-by: Michael Buesch -- Michael pgpEvtCPoQGTU.pgp

Re: [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver

On Wed, 14 Oct 2015 13:17:16 +0200 Rafał Miłecki wrote: > If all PCI-bus-host-specific code is always the same, And that's the point. It's always the same _except_ for the device IDs. Which obviously are PCI-device specific. -- Michael pgpOqekO9MF4R.pgp Description:

Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade wrote: > diff --git a/drivers/net/wireless/b43/phy_lp.c > b/drivers/net/wireless/b43/phy_lp.c > index 058a9f2..086f0ba 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -2502,7

Re: [PATCH v2 2/3] net: wireless: b43: Coding Style

On Mon, 19 Oct 2015 17:02:22 +0100 Paul McQuade wrote: > Fixed Pointer Coding Style > > Signed-off-by: Paul McQuade > --- > drivers/net/wireless/b43/main.c | 6 +++--- > drivers/net/wireless/b43/main.h | 2 +- > drivers/net/wireless/b43/xmit.h | 2

Re: [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver

On Wed, 23 Sep 2015 12:02:48 +0200 Rafał Miłecki <zaj...@gmail.com> wrote: > On 21 September 2015 at 18:20, Michael Büsch <m...@bues.ch> wrote: > > On Mon, 21 Sep 2015 11:04:19 +0200 > > Rafał Miłecki <zaj...@gmail.com> wrote: > >> @@ -1464,6 +146

Re: [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver

On Mon, 21 Sep 2015 11:04:19 +0200 Rafał Miłecki wrote: > ssb bus can be found on various "host" devices like PCI/PCMCIA/SDIO. > Every ssb bus contains cores AKA devices. > The main idea is to have ssb driver scan/initialize bus and register > ready-to-use cores. This way ssb

Re: [PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver

On Mon, 21 Sep 2015 11:14:32 -0500 Larry Finger wrote: > This patch has been tested on PPC architecture with Linksys WPC54G PCMCIA > cards. Are you sure that this really is a 16 bit PCMCIA card and not a PC-Card? If it shows up in lspci, it's not a PCMCIA card. > It

Re: [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register

On Mon, 21 Sep 2015 09:47:18 +0200 Rafał Miłecki wrote: > It isn't used anywhere out of ssb code and we don't (plan to) build > pcihost_wrapper.c as a separated module. > > Signed-off-by: Rafał Miłecki > --- > drivers/ssb/main.c | 1 - > 1 file changed, 1

Re: [PATCH] ssb: make ssb_pcmcia_switch_core static

On Mon, 21 Sep 2015 09:55:26 +0200 Rafał Miłecki wrote: > Signed-off-by: Rafał Miłecki > --- > drivers/ssb/pcmcia.c | 3 +-- > drivers/ssb/ssb_private.h | 7 --- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git

Re: [PATCH 2/3] ssb: make ssb_sdio_switch_core static

On Mon, 21 Sep 2015 09:47:19 +0200 Rafał Miłecki wrote: > It's used locally only. > > Signed-off-by: Rafał Miłecki > --- > drivers/ssb/sdio.c| 2 +- > drivers/ssb/ssb_private.h | 6 -- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff

Re: [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup

On Mon, 21 Sep 2015 09:47:20 +0200 Rafał Miłecki wrote: > Signed-off-by: Rafał Miłecki > --- > drivers/ssb/ssb_private.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h > index

Re: (bug report) b43: impossible conditions in debugfs

On Thu, 26 Nov 2015 14:59:24 +0300 Dan Carpenter wrote: > Hello Michael Buesch, > > The patch 6bbc321a96d4: "b43: Add debugfs files for random SHM > access" from Jun 19, 2008, leads to the following static checker > warning: > >

Re: (bug report) b43: precendence error

On Thu, 26 Nov 2015 14:58:43 +0300 Dan Carpenter wrote: > [ All the old wireless Smatch warnings are showing up as new ones > because of the path reshuffle in linux-next. I'm going through and > reporting the extra suspicious ones. -dan ] > > Hello Rafał Miłecki,

Re: (bug report) b43: impossible conditions in debugfs

On Thu, 26 Nov 2015 16:00:34 +0300 Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Thu, Nov 26, 2015 at 01:32:41PM +0100, Michael Büsch wrote: > > > See also: > > > drivers/net/wireless/broadcom/b43/debugfs.c:346 mmio32write__write_file() > > > warn: impo

Re: [PATCH] b43: only hardcode LED behavior if SPROM doesn't encode any

On Fri, 3 Jun 2016 23:04:03 +0200 Lucas Stach wrote: > Only hardcode the LED behavior if the SROM doesn't provide any for all > LEDs of the card. This avoids instantiating LED triggers for unconnected > LEDs, while (hopefully) keeping things working for old cards with a > blank

Re: [PATCH] b43: Remove unused phy_a code

On Fri, 3 Jun 2016 14:32:46 -0700 Guenter Roeck wrote: > gcc-6 reports the following error with -Werror=unused-const-variable. > > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: > 'b43_phyops_a' defined but not used > > Turns out a lot of code in this file

Re: [PATCH v2 1/2] b43: Remove unused phy_a code

On Fri, 3 Jun 2016 21:11:51 -0700 Guenter Roeck wrote: > +static void __b43_phy_initg(struct b43_wldev *dev) > +{ > + struct b43_phy *phy = >phy; > + > + might_sleep(); > + > + if (phy->rev >= 6) { > + if (b43_phy_read(dev, B43_PHY_ENCORE) &

Re: [PATCH] drivers: ssb: Fix comments to suit coding style

On Sat, 4 Jun 2016 12:32:13 +0100 Hugh Sipière wrote: > I changed it so that these two comments do not end on a line with text. > > Signed-off-by: Hugh Sipière > --- > drivers/ssb/driver_gpio.c | 6 -- > 1 file changed, 4 insertions(+), 2

Re: [PATCH] drivers: ssb: Change bare unsigned to unsigned int to suit coding style

On Sat, 4 Jun 2016 12:50:05 +0100 Hugh Sipière wrote: > These lines just have unsigned gpio rather than unsigned int gpio. > I changed it to suit the coding style. > > Signed-off-by: Hugh Sipière Acked-by: Michael Buesch Please send

Re: BCM4331 reset leads to wl lockup

On Thu, 26 May 2016 14:12:10 +0200 Lukas Wunner wrote: > + mmio = early_ioremap(addr, BCM4331_MMIO_SIZE); > + if (!mmio) { > + pr_err("Cannot iomap Apple AirPort card\n"); > + return; > + } > + pr_info("Resetting Apple AirPort card\n"); >

Re: [v3,1/2] b43: Remove unused phy_a code

r: > > 'b43_phyops_a' defined but not used > > > > Per Michael Büsch: "All a-phy code is usused", so remove it all, > > and move the remaining Type-G initialization code into phy_g.c. > > > > Reported-by: Fengguang Wu <fengguang...@intel.com&g

Re: [v3,1/2] b43: Remove unused phy_a code

On Thu, 16 Jun 2016 18:56:14 +0300 Kalle Valo <kv...@codeaurora.org> wrote: > Michael Büsch <m...@bues.ch> writes: > > > On Thu, 16 Jun 2016 15:23:37 + (UTC) > > Kalle Valo <kv...@codeaurora.org> wrote: > > > >> Guenter Roeck <li...@roe

Re: [PATCH 1/2] b43: Remove unnecessary synchronize_irq() before free_irq()

On Mon, 8 Feb 2016 21:41:12 +0100 Lars-Peter Clausen wrote: > Calling synchronize_irq() right before free_irq() is quite useless. On one > hand the IRQ can easily fire again before free_irq() is entered, Well, that depends on whether the interrupt is shared and whether we

Re: [PATCH] b43: fix memory leak

On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. > > Signed-off-by: Sudip Mukherjee

Re: [v2, resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

On Fri, 11 Mar 2016 21:52:30 +0530 Sudip Mukherjee wrote: > On Sat, Jan 16, 2016 at 09:08:10PM +0800, Jia-Ju Bai wrote: > > The memory allocated by kzalloc in b43_bus_dev_ssb_init and > > b43_bus_dev_bcma_init is not freed. > > This patch fixes the bug by adding kfree

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Tue, 5 Apr 2016 14:40:15 -0500 Bjorn Helgaas wrote: > [+cc Matthew] > > Hi Lukas, > > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Wed, 6 Apr 2016 08:31:51 -0500 Bjorn Helgaas wrote: > Even for interrupts, it's only a 90% solution because we do still get > a few interrupts before the quirk runs. There may not be enough to > trigger the "IRQ nobody cared" check, If no driver requested the shared

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Tue, 29 Mar 2016 19:41:30 +0200 Lukas Wunner wrote: > +static void quirk_apple_b43_reset(struct pci_dev *dev) > +{ > + void __iomem *mmio; > + > + if (!dmi_match(DMI_BOARD_VENDOR, "Apple Inc.") || !dev->bus->self || > + pci_pcie_type(dev->bus->self) !=

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Sat, 2 Apr 2016 00:46:46 +0200 Lukas Wunner wrote: > Hi Chris, > > On Fri, Apr 01, 2016 at 12:13:46AM +0100, Chris Bainbridge wrote: > > On Tue, Mar 29, 2016 at 07:41:30PM +0200, Lukas Wunner wrote: > > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Fri, 1 Apr 2016 00:13:46 +0100 Chris Bainbridge wrote: > Should also fix https://bugzilla.kernel.org/show_bug.cgi?id=111781 ? > Given that this is a serious bug that can corrupt filesystems it would > be good to see the fix in stable too. Wow, this is horrible.

Re: [PATCH RFC] b43: stop hardcoding LED behavior

On Mon, 25 Apr 2016 09:40:51 +0200 Lucas Stach wrote: > On my system the SPROM correctly defines the only wired LED (radio) but > skips all others, leading to the hardcode to register LEDs with RX and TX > triggers. Hm ok. It probably is a good idea to change the condition from

Re: [PATCH RFC] b43: stop hardcoding LED behavior

On Mon, 25 Apr 2016 20:21:36 +0200 Lucas Stach wrote: > > Numbers please. Did you measure that is actually causes more > > _wakeups_? > > How many? > > The led work is placed in the mac80211 workqueue and LED updates only > > happen on behalf of mac80211 activities (by default).

Re: [b43] don't unconditionally fall back to CCK if the rate is 6MB OFDM.

On Sun, 15 May 2016 07:23:25 -0700 Adrian Chadd wrote: > Author: Adrian Chadd > Date: Sun May 15 07:15:54 2016 -0700 > > [b43] don't unconditionally fall back to CCK if the rate is 6MB OFDM. > > Check the current PHY operating mode (gmode) to

Re: [b43] don't unconditionally fall back to CCK if the rate is 6MB OFDM.

On Sun, 15 May 2016 07:23:25 -0700 Adrian Chadd wrote: > @@ -438,7 +446,7 @@ int b43_generate_txhdr(struct b43_wldev *dev, > > rts_rate = rts_cts_rate ? rts_cts_rate->hw_value : > B43_CCK_RATE_1MB; I just noticed that this is incorrect for 5GHz, too. Maybe

Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool

> > @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm) > > default: > > SSB_WARN_ON(1); > > } > > - size = (1 << (size + 1)); > > - > > - return size; > > + return (1 << (size + 1)); > > } > > EXPORT_SYMBOL(ssb_admatch_size); I'm all for

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On Fri, 02 Jun 2017 09:18:14 +0800 Jia-Ju Bai wrote: > On 06/02/2017 12:11 AM, Jonathan Corbet wrote: > > On Thu, 01 Jun 2017 09:05:07 +0800 > > Jia-Ju Bai wrote: > > > >> I admit my patches are not well tested, and they may not well fix the bugs. >

Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL); > if (!devwrap) { > - ssb_err("Could not allocate device\n"); > err = -ENOMEM; > goto error; > } This looks good. Acked-by: Michael Büsch <m...@bues.ch> -- Michael pgpFfsUCp_TBq.pgp Description: OpenPGP digital signature

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On Wed, 31 May 2017 18:29:07 +0800 Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) > b43legacy_radio_set_interference_mitigation >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: > Jia-Ju Bai writes: > > > The driver may sleep under a spin lock, and the function call path is: > > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Wed, 31 May 2017 19:07:15 -0500 Larry Finger <larry.fin...@lwfinger.net> wrote: > On 05/31/2017 10:32 AM, Michael Büsch wrote: > > On Wed, 31 May 2017 13:26:43 +0300 > > Kalle Valo <kv...@codeaurora.org> wrote: > > > >> Jia-Ju Bai <baijiaju1...

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Thu, 01 Jun 2017 07:27:20 +0300 Kalle Valo <kv...@codeaurora.org> wrote: > Michael Büsch <m...@bues.ch> writes: > > >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.

Re: [PATCH 1/2] b43: fix unitialized reads of ret by initializing the array to zero

On Tue, 5 Sep 2017 19:15:50 +0100 Colin King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later

Re: [BUG] ssb: Possible sleep-in-atomic bugs in ssb_pcmcia_read8

On Mon, 9 Oct 2017 09:29:17 +0800 Jia-Ju Bai wrote: > According to pcmcia.c, the driver may sleep under a spinlock. > The function call paths are: > ssb_pcmcia_read8 (acquire the spinlock) >select_core_and_segment > ssb_pcmcia_switch_segment >

Re: Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

On Mon, 14 May 2018 19:55:39 +0200 Michael Büsch <m...@bues.ch> wrote: > On Mon, 14 May 2018 18:49:53 +0100 > Chris Vine <vine35792...@gmail.com> wrote: > > > I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy > > [14e4:4315] (rev 01) wifi device

Re: Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

On Mon, 14 May 2018 18:49:53 +0100 Chris Vine wrote: > I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy > [14e4:4315] (rev 01) wifi device. This works up to and including the > 4.16 kernel, but not with 4.17-rc5. > > The b43, mac80211, cfg80211, ssb and

Re: Regression caused by commit 882164a4a928

On Mon, 07 May 2018 22:03:58 +0300 Kalle Valo <kv...@codeaurora.org> wrote: > Michael Büsch <m...@bues.ch> writes: > > > On Mon, 7 May 2018 10:44:34 -0500 > > Larry Finger <larry.fin...@lwfinger.net> wrote: > > > >> Although commit 882

Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y

On Thu, 10 May 2018 13:14:01 +0200 Rafał Miłecki wrote: > From: Rafał Miłecki > > SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported > symbols pcibios_enable_device and register_pci_controller. This code is > supposed to be compiled

Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y

On Thu, 10 May 2018 13:20:01 +0200 Rafał Miłecki <zaj...@gmail.com> wrote: > On 10 May 2018 at 13:17, Michael Büsch <m...@bues.ch> wrote: > > On Thu, 10 May 2018 13:14:01 +0200 > > Rafał Miłecki <zaj...@gmail.com> wrote: > > >

Re: Regression caused by commit 882164a4a928

On Thu, 10 May 2018 11:24:12 +0100 Matt Redfearn wrote: > > Could you please try this? > > > > config SSB_DRIVER_PCICORE_POSSIBLE > > depends on SSB_PCIHOST > > > > config SSB_PCICORE_HOSTMODE > > depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && (SSB = y) &&

Re: [PATCH v2] drivers/net/wireless/broadcom/b43: fix transmit failure when VT is switched

slot); > - err_out2 = 1; > + b43dbg(dev->wl, > +"Out of order TX status report on DMA ring %d. > Expected %d, but got %d\n", > +ring->index, firstused, slot); > +

Re: Regression caused by commit 882164a4a928

On Wed, 9 May 2018 13:55:43 +0100 Matt Redfearn wrote: > Hi Larry > > On 07/05/18 16:44, Larry Finger wrote: > > Matt, > > > > Although commit 882164a4a928 ("ssb: Prevent build of PCI host features > > in module") appeared to be harmless, it leads to complete failure

Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

On Sat, 12 May 2018 10:50:42 +0300 Kalle Valo wrote: > Larry Finger writes: > > > On 05/11/2018 05:13 AM, Kalle Valo wrote: > >> Rafał Miłecki writes: > >> > >>> On 11 May 2018 at 11:17, Rafał Miłecki

Re: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"

On Sat, 12 May 2018 12:00:07 +0200 Rafał Miłecki wrote: > > Yes, I'm OK with the patch, if we have a third patch that cleans up the > > PCI_DRIVERS_LEGACY dependency by moving it to SSB_PCICORE_HOSTMODE > > where it belongs. (This doesn't need to go into the stable tree.) > >

Re: Regression caused by commit 882164a4a928

On Mon, 7 May 2018 10:44:34 -0500 Larry Finger wrote: > Although commit 882164a4a928 ("ssb: Prevent build of PCI host features in > module") appeared to be harmless, it leads to complete failure of drivers > b43. > config SSB_DRIVER_PCICORE_POSSIBLE >

Re: B43 driver no longer works in Linux 4.15 (bisected)

On Mon, 5 Feb 2018 13:14:28 -0500 Adric Blake wrote: > In the time between Linux 4.15-rc8 and -rc9, my wireless driver, b43, would > no longer load automatically. When I modprobe the b43 (and ssb) modules, > the device still didn't appear in NetworkManager. Comparing the

Re: [PATCH v2] ssb: use put_device() if device_register fail

On Thu, 8 Mar 2018 10:39:49 +0530 Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wed, 7 Mar 2018 22:46:14 +0530 arvindY wrote: > >> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > >> index 65420a9..c4449e0 100644 > >> --- a/drivers/ssb/main.c > >> +++ b/drivers/ssb/main.c > >> @@ -521,6 +521,7 @@ static int ssb_devices_register(struct

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wed, 7 Mar 2018 15:31:30 +0530 Arvind Yadav wrote: > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/ssb/main.c | 1 + > 1 file

Re: [PATCH] net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

On Tue, 10 Apr 2018 21:54:19 +0800 Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of