Re: [PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h
Le 31/01/2017 à 20:18, Russell King a écrit : > drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of > declaration > drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of > struct-union-enum-specifier > drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface > drivers/net/ethernet/cadence/macb.h:877:1: sparse: Expected ; at the end of > type declaration > drivers/net/ethernet/cadence/macb.h:877:1: sparse: got } > In file included from drivers/net/ethernet/cadence/macb_pci.c:29:0: > drivers/net/ethernet/cadence/macb.h:862:2: error: unknown type name > 'phy_interface_t' > phy_interface_t phy_interface; > ^~~ > > Add linux/phy.h to macb.h > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> > --- > drivers/net/ethernet/cadence/macb.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/cadence/macb.h > b/drivers/net/ethernet/cadence/macb.h > index d67adad67be1..383da8cf5f6d 100644 > --- a/drivers/net/ethernet/cadence/macb.h > +++ b/drivers/net/ethernet/cadence/macb.h > @@ -10,6 +10,8 @@ > #ifndef _MACB_H > #define _MACB_H > > +#include > + > #define MACB_GREGS_NBR 16 > #define MACB_GREGS_VERSION 2 > #define MACB_MAX_QUEUES 8 > -- Nicolas Ferre
staging: wilc1000: kernel Oops while opening the device
_SUP_PNAME --startas $WPA_SUP_BIN --pidfile $WPA_SUP_PIDFILE -- $WPA_SUP_OPTIONS $WPA_SUP_CONF -D $IF_WPA_DRIVER --- Best regards, -- Nicolas Ferre
[RESEND PATCH] MAINTAINERS: Update maintainer entry for wilc1000
From: Aditya Shankar <aditya.shan...@microchip.com> Take the maintenance of the Atmel WIFI staging driver wilc1000. Former maintainers are no more with Atmel. Reported-by: Loic Lefort <loic.lef...@atmel.com> Signed-off-by: Aditya Shankar <aditya.shan...@microchip.com> Signed-off-by: Ganesh Krishna <ganesh.kris...@microchip.com> Acked-by: Luis de Bethencourt <lui...@osg.samsung.com> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- Hi all, Just an elaborate "ping" with the Acked-by tag from Luis added. As noted by Luis, previous version of this patch is here: https://lkml.org/lkml/2016/6/27/382 Thanks, bye. MAINTAINERS | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 33d7e2252ceb..b0d5c77c9db2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11202,12 +11202,8 @@ S: Odd Fixes F: drivers/staging/vt665?/ STAGING - WILC1000 WIFI DRIVER -M: Johnny Kim <johnny@atmel.com> -M: Austin Shin <austin.s...@atmel.com> -M: Chris Park <chris.p...@atmel.com> -M: Tony Cho <tony@atmel.com> -M: Glen Lee <glen@atmel.com> -M: Leo Kim <leo@atmel.com> +M: Aditya Shankar <aditya.shan...@microchip.com> +M: Ganesh Krishna <ganesh.kris...@microchip.com> L: linux-wireless@vger.kernel.org S: Supported F: drivers/staging/wilc1000/ -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] MAINTAINERS: Update maintainer entry for wilc1000
From: Aditya Shankar <aditya.shan...@microchip.com> Take the maintenance of the Atmel WIFI staging driver wilc1000. Former maintainers are no more with Atmel. Reported-by: Loic Lefort <loic.lef...@atmel.com> Signed-off-by: Aditya Shankar <aditya.shan...@microchip.com> Signed-off-by: Ganesh Krishna <ganesh.kris...@microchip.com> Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- Hi Luis, Greg, I'd like that we don't delete the entry for this wilc1000 driver but change it with the patch below. After the Microchip - Atmel merger, Aditya and Ganesh will take over the maintenance of this driver and will continue the work that our former colleagues started. Thanks, bye. MAINTAINERS | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 51447a517095..9142e08ba8ae 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10931,12 +10931,8 @@ S: Odd Fixes F: drivers/staging/vt665?/ STAGING - WILC1000 WIFI DRIVER -M: Johnny Kim <johnny@atmel.com> -M: Austin Shin <austin.s...@atmel.com> -M: Chris Park <chris.p...@atmel.com> -M: Tony Cho <tony@atmel.com> -M: Glen Lee <glen@atmel.com> -M: Leo Kim <leo@atmel.com> +M: Aditya Shankar <aditya.shan...@microchip.com> +M: Ganesh Krishna <ganesh.kris...@microchip.com> L: linux-wireless@vger.kernel.org S: Supported F: drivers/staging/wilc1000/ -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] staging: wilc1000: Modify null check routine
Le 17/09/2015 10:50, Tony Cho a écrit :
> From: Leo Kim <leo@atmel.com>
>
> This patch modify null check routine.
> - Null check error non return. (Handle_RcvdGnrlAsyncInfo)
It doesn't parse...
Is it fixing a bug? What were the consequences without the return?
Bye,
> Signed-off-by: Leo Kim <leo@atmel.com>
> Signed-off-by: Tony Cho <tony@atmel.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c
> b/drivers/staging/wilc1000/host_interface.c
> index 6fdf392..a9eaa8f 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2403,8 +2403,10 @@ static s32 Handle_RcvdGnrlAsyncInfo(tstrWILC_WFIDrv
> *drvHandler, tstrRcvdGnrlAsy
> s32 s32Err = 0;
> tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *) drvHandler;
>
> - if (pstrWFIDrv == NULL)
> + if (!pstrWFIDrv) {
> PRINT_ER("Driver handler is NULL\n");
> + return -EFAULT;
> + }
> PRINT_D(GENERIC_DBG, "Current State = %d,Received state = %d\n",
> pstrWFIDrv->enuHostIFstate,
> pstrRcvdGnrlAsyncInfo->pu8Buffer[7]);
>
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
