[PATCH] adm80211: add checks for dma mapping errors

2016-12-02 Thread Alexey Khoroshilov
The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> --- drivers/net/wireless/admtek/adm8211.

Re: [lsb-discuss] Google Summer of Code 2016 - Many new applications

2016-03-26 Thread Alexey Khoroshilov
On 26.03.2016 03:00, Till Kamppeter wrote: On 03/25/2016 08:56 PM, Till Kamppeter wrote: I am taking care of the 5 OpenPrinting proposals, please take care of all the others, mark with IGNORE what you for sure do not want to mentor and mark with a star what you want to mentor and also click

at76c50x-usb: usb_put_dev() if at76_load_internal_fw() succeed

2016-02-20 Thread Alexey Khoroshilov
I do not see any reason to call usb_put_dev() if at76_load_internal_fw() succeed. But it is here from the very beginning. Any suggestions? -- Thank you, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More

[PATCH] at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_probe()

2016-02-20 Thread Alexey Khoroshilov
There is no need in usb_put_dev() if at76_load_internal_fw() succeed. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> --- drivers/net/wireless/atmel/at76c50x-usb.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH] ipw2x00: add checks for dma mapping errors

2016-01-01 Thread Alexey Khoroshilov
ipw2100_alloc_skb() and ipw2100_tx_send_data() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> --- drivers/net/wireless/i

[PATCH] prism54: fix checks for dma mapping errors

2015-12-25 Thread Alexey Khoroshilov
prism54 checks for dma mapping errors by comparison returned address with zero, while pci_dma_mapping_error() should be used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> --- drivers/net/wireless/prism54/islpci

[PATCH v3] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

2015-12-22 Thread Alexey Khoroshilov
If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), it calls release_bus() and continues execution. But it leads to double release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Ale

[PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

2015-12-20 Thread Alexey Khoroshilov
If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), it calls release_bus() and continues execution. But it leads to double release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Ale

Re: [PATCH] rsi: Fix failure to load firmware after memory leak fix and fix the leak

2015-07-27 Thread Alexey Khoroshilov
Reviewed-by: Alexey Khoroshilov khoroshi...@ispras.ru with small suggestion. If we restore kmemdup() call, we have to handle ENOMEM situations: fw = kmemdup(fw_entry-data, fw_entry-size, GFP_KERNEL); if (!fw) return -ENOMEM; On 27.07.2015 12:43, Mike Looijmans

Re: Commit rsi: fix memory leak in rsi_load_ta_instructions() breaks things

2015-07-24 Thread Alexey Khoroshilov
On 24.07.2015 18:02, Mike Looijmans wrote: On 24-07-15 10:39, Alexey Khoroshilov wrote: Dear Mike, On 24.07.2015 14:01, Mike Looijmans wrote: Regarding this commit: https://lkml.org/lkml/2014/12/12/709 rsi: fix memory leak in rsi_load_ta_instructions() Memory allocated

Re: Commit rsi: fix memory leak in rsi_load_ta_instructions() breaks things

2015-07-24 Thread Alexey Khoroshilov
On 24.07.2015 21:12, Kalle Valo wrote: Mike Looijmans mike.looijm...@topic.nl writes: On 24-07-15 13:35, Alexey Khoroshilov wrote: On 24.07.2015 18:02, Mike Looijmans wrote: On 24-07-15 10:39, Alexey Khoroshilov wrote: Dear Mike, On 24.07.2015 14:01, Mike Looijmans wrote: Regarding

[PATCH] rsi: fix memory leak in rsi_load_ta_instructions()

2014-12-12 Thread Alexey Khoroshilov
Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked. But duplication of firmware data here is useless, so the patch removes kmemdup() at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net

[PATCH] ath6kl: remove incorrect reset_resume handler

2014-10-24 Thread Alexey Khoroshilov
(linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/ath/ath6kl/usb.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c index a6a5e40b3e98..9da3594fd010 100644