Re: [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-04-12 Thread Andrea Merello
On Mon, Apr 11, 2016 at 2:11 AM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Andrea, > > On Sat, Apr 9, 2016 at 4:56 AM, Andrea Merello <andrea.mere...@gmail.com> > wrote: >> >> On Fri, Mar 18, 2016 at 3:27 AM, Julian Calaby <julian.cal...@gm

Re: [PATCH resend] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring

2016-01-30 Thread Andrea Merello
Thanks for pointing this out! At a first look I'd propose to merge the two identical pci_fee_consistent() in a single one, and place it in an error exit path at the end of function. BTW, looking at the code, it seems there is another leak here that your patch does not address: we still leaks

Re: [PATCH] rtl818x_pci: Disable pci device in error handling code

2016-01-30 Thread Andrea Merello
Acked-by: Andrea Merello <andrea.mere...@gmail.com> On Sat, Jan 16, 2016 at 2:02 PM, Jia-Ju Bai <baijiaju1...@163.com> wrote: > When pci_request_regions in rtl8180_probe fails, pci_disable_device is not > called to disable the device which is enabled by pci_enbale_device. &g

[PATCH] rtl818x_pci: fix response rate may be incorrect.

2014-10-06 Thread Andrea Merello
to about 20Mbps. Hopefully this patch may help people that faced performance regression wrt the old staging driver. Signed-off-by: Andrea Merello andrea.mere...@gmail.com --- drivers/net/wireless/rtl818x/rtl8180/dev.c | 36 +- 1 file changed, 25 insertions(+), 11 deletions