Re: [PATCH v2 25/26] staging: wilc1000: refactor wilc_netdev_init() to handle memory free in error path

On 04.09.2018 09:39, Ajay Singh wrote: > Refactor the wilc_netdev_init() to cleanup the memory for error > scenario and remove unnecessary 'dev' pointer check. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/linux_wlan.c | 36 > --- >

Re: [PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

On 23.08.2018 13:33, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:12:08 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Cleanup patch to avoid line over 80 chars issue reported by >>> checkpatch.pl script. >>> >>&

Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

On 23.08.2018 12:43, Ajay Singh wrote: > The idea was to keep private data related to 'wiphy priv' > in 'wilc_priv' struct and 'netdev priv' related data in 'wilc_vif' > struct. OK, I see, agree!

Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

On 23.08.2018 13:00, Ajay Singh wrote: > Unless ndo_set_rx_mode() gets called quickly I don't think there is any > issue here. I don't agree with this.

Re: [PATCH 11/24] staging: wilc1000: move hif specific static variables to 'wilc' structure

On 23.08.2018 13:09, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:11:09 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Avoid use of static variable and move it in 'wilc' structure >>> related to hif and added NU

Re: [PATCH 12/24] staging: wilc1000: move static variable 'terminated_handle' to wilc_vif struct

On 23.08.2018 17:36, Ajay Singh wrote: > On Thu, 23 Aug 2018 11:11:18 +0300 > Claudiu Beznea wrote: > >> On 14.08.2018 09:50, Ajay Singh wrote: >>> Remove the use of static variable 'terminated_handle' and instead >>> move in wilc_vif struct. >>> Aft

Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

On 14.08.2018 09:50, Ajay Singh wrote: > Instead of using 'wilc_multicast_mac_addr_list' as global variable move > it part of wilc_vif struct. Rename 'wilc_multicast_mac_addr_list' > variable to 'mc_mac_addr_list' as its now part of 'wilc_vif' struct. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 12/24] staging: wilc1000: move static variable 'terminated_handle' to wilc_vif struct

On 14.08.2018 09:50, Ajay Singh wrote: > Remove the use of static variable 'terminated_handle' and instead move > in wilc_vif struct. > After moving this variable to wilc_vif struct its not required to keep > 'terminated_handle', so changed it to boolean type. You can remove it at all and use

Re: [PATCH 11/24] staging: wilc1000: move hif specific static variables to 'wilc' structure

On 14.08.2018 09:50, Ajay Singh wrote: > Avoid use of static variable and move it in 'wilc' structure related to > hif and added NULL before accessing hif_workqueue in wilc_enqueue_work(). > > Below variables are moved to 'wilc' struct: > struct workqueue_struct *hif_workqueue; > struct

Re: [PATCH 19/24] staging: wilc1000: avoid line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

On 14.08.2018 09:50, Ajay Singh wrote: > Cleanup patch to avoid line over 80 chars checkpatch issue introduced in > previous code refactor commit. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) >

Re: [PATCH 24/24] staging: wilc1000: remove unnecessary static variable 'p2p_listen_state'

On 14.08.2018 09:50, Ajay Singh wrote: > Remove the use of unnecessary static variable 'p2p_listen_state'. > Already 'p2p_listen_state' is present in 'wilc_priv' struct. So making > use of that variable as its getting set in channel ready and > remain on channel expired callback. > >

Re: [PATCH 23/24] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct

On 14.08.2018 09:50, Ajay Singh wrote: > Move static variable 'wilc_connecting' as part of 'wilc_vif' private > struct. Remove "wilc_" prefix from name as its already part of wilc_vif > struct. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 4 ++--

Re: [PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

On 14.08.2018 09:50, Ajay Singh wrote: > Cleanup patch to avoid line over 80 chars issue reported by > checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 09/24] staging: wilc1000: move static variable clients_count to 'wilc' structure

On 14.08.2018 09:50, Ajay Singh wrote: > Avoid use of static variable 'clients_count' and move it part of 'wilc' > structure. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 9 - > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + > 2 files

Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

On 14.08.2018 09:49, Ajay Singh wrote: > Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to > 'wilc_vif' structure. > > Rename these variables like below > > wilc_during_ip_timer -> during_ip_timer > wilc_optaining_ip -> obtaining_ip. Is there any reason you choose to

Re: [PATCH 00/24] staging: wilc1000: avoid use of static and global variable

Hi Ajay, Few comments on this series. See per patch replies. Thank you, Claudiu Beznea On 14.08.2018 09:49, Ajay Singh wrote: > This patch set mainly contains changes to avoid the use of static > and global variables. Also contains few patch to avoid the checkpatch > warning arise du

Re: [PATCH 0/4] staging: wilc1000: make use of descriptor-based interface for GPIO

Reviewed-by: Claudiu Beznea On 20.07.2018 15:01, Ajay Singh wrote: > This patch series contains changes mainly related to make use of > descriptor-based interface instead of integer-based interface for GPIO. > Modified the compatible string to use 'microchip' instead of 'atmel' prefi

Re: [PATCH 00/23] staging: wilc1000: cleanup patch to follow linux coding style

Reviewed-by: Claudiu Beznea On 19.07.2018 01:44, Ajay Singh wrote: > This patch series contains modification to follow Linux coding style & > cleanup change to remove unused variables and enums. > Few patches also contain changes to remove unnecessary typecast. > > Ajay Sing

Re: [PATCH 00/12] staging: wilc1000: address TODO item to remove host_if_work()

For this series: Reviewed-by: Claudiu Beznea On 26.06.2018 09:07, Ajay Singh wrote: > The current patch series contains changes to address TODO item [1]. > > [1]. Move handling for each individual members of 'union message_body' out > into a separate 'struct work_struct' and compl

Re: [PATCH 0/4] staging: wilc1000: modification to use list_head data structure

Reviewed-by: Claudiu Beznea On 04.06.2018 08:29, Ajay Singh wrote: > Instead of having own linked list implementation to maintain buffer queue > change > to use list_head. Also removed the few elements from 'wilc' struct as it's not > required to be part of 'wilc' struct. >

Re: [PATCH] staging: wilc1000: fix spelling mistake: "Preamle" -> "Preamble"

On 22.05.2018 19:49, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in netdev_err error message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Claudiu Beznea <claudiu.bez...@mi

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Hi Ajay, On 10.05.2018 08:27, Claudiu Beznea wrote: > > > On 09.05.2018 21:42, Ajay Singh wrote: >> On Wed, 9 May 2018 16:43:14 +0300 >> Claudiu Beznea <claudiu.bez...@microchip.com> wrote: >> >>> On 07.05.2018 11:43, Ajay Singh wrote: >&

Re: [PATCH 15/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

On 09.05.2018 22:17, Ajay Singh wrote: > On Wed, 9 May 2018 16:42:59 +0300 > Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > >> On 07.05.2018 11:43, Ajay Singh wrote: >>> Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow(). >>&

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

On 09.05.2018 21:42, Ajay Singh wrote: > On Wed, 9 May 2018 16:43:14 +0300 > Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > >> On 07.05.2018 11:43, Ajay Singh wrote: >>> Fix line over 80 characters issue reported by checkpatch in >>> add_network_

Re: [PATCH 03/30] staging: wilc1000: fix line over 80 chars in handle_key()

On 09.05.2018 21:36, Ajay Singh wrote: > On Wed, 9 May 2018 16:44:47 +0300 > Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > >> On 07.05.2018 11:43, Ajay Singh wrote: >>> Fix checkpatch reported issue of line over 80 char in handle_key(). >>> Introd

Re: [PATCH 03/30] staging: wilc1000: fix line over 80 chars in handle_key()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix checkpatch reported issue of line over 80 char in handle_key(). > Introduced new functions by spliting existing function to address the > checkpatch issue. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 05/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix line over 80 characters issue reported by checkpatch.pl in > host_int_parse_assoc_resp_info(). > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 37 > ++- > 1

Re: [PATCH 06/30] staging: wilc1000: fix line over 80 chars issue in host_int_handle_disconnect()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix line over 80 char issue in host_int_handle_disconnect() by using > temp variable to hold the 'wilc_connect_result' function pointer. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 8

Re: [PATCH 07/30] staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()

On 07.05.2018 11:43, Ajay Singh wrote: > Split host_int_parse_join_bss_param() to avoid the line over 80 > character issue reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 247 >

Re: [PATCH 08/30] staging: wilc1000: fix line over 80 chars in host_int_parse_assoc_resp_info()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix line over 80 characters issue in host_int_parse_assoc_resp_info() by > using shorter name for the local variable. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 9 + > 1 file

Re: [PATCH 13/30] staging: wilc1000: rename clear_duringIP() to avoid camelCase issue

On 07.05.2018 11:43, Ajay Singh wrote: > Rename clear_duringIP() function to avoid camelCase issue reported by > checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 15/30] staging: wilc1000: use kmemdup instead of kmalloc in add_network_to_shadow()

On 07.05.2018 11:43, Ajay Singh wrote: > Use kmemdup instead of kmalloc & memcpy in add_network_to_shadow(). > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix line over 80 characters issue reported by checkpatch in > add_network_to_shadow() by using temporary variable. I, personally, don't like this way of fixing line over 80. From my point of view this introduces a new future patch. Maybe, in future,

Re: [PATCH 17/30] staging: wilc1000: fix line over 80 chars in wilc_wfi_cfg_tx_vendor_spec()

On 07.05.2018 11:43, Ajay Singh wrote: > Fix line over 80 characters issues reported by checkpatch.pl script in > wilc_wfi_cfg_tx_vendor_spec() by using temporary variable. Simplified > 'if else' condition with 'if'. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 28/30] staging: wilc1000: added comments for mutex and spinlock_t

On 07.05.2018 11:43, Ajay Singh wrote: > Added comments for mutex and spinlock_t to avoid checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.h | 2 +- > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- > 2

Re: [PATCH 30/30] staging: wilc1000: rename s8idxarray to avoid datatype in variable name

On 07.05.2018 11:43, Ajay Singh wrote: > Cleanup patch to have variable names as per linux coding style. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v2] staging/wilc1000: fix wilc_mac_xmit()'s return type

g/wilc1000: fix wilc_mac_xmit()'s return type" so I will send a new patch with only the "return NETDEV_TX_OK" changes. And you can also add: Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> > { > struct wilc_vif *vif; > struct tx_complet

Re: [PATCH] staging/wilc1000: fix wilc_mac_xmit()'s return type

Hi Luc, I'm resending this since last time I only send it to staging ml. Could you, please, change the "return 0;"s inside wilc_mac_xmit() with "return NETDEV_TX_OK" ? Thank you, Claudiu On 24.04.2018 15:18, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an

Re: [PATCH 0/2] staging: wilc1000: TODO list updates

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 24.04.2018 19:07, Ajay Singh wrote: > Updated the TODO list by removing items, which are already addressed. > Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is > not present in the driver. >

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

Hi Ajay, You can add: Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 23.04.2018 16:01, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH <gre...@linuxfoundation.org> wrote: > >> On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh w

Re: [PATCH] staging: wilc1000: fix NULL pointer exception in host_int_parse_assoc_resp_info()

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 12.04.2018 10:21, Ajay Singh wrote: > Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for general info > message from firmware) introduced a bug by using wrong source address in > kmemdup(). 'conn_info.r

Re: [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block

On 12.04.2018 10:59, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. > > Signed-off-by: Eyal Ilsar <edil...@gmail.com> Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> >

Re: [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block

On 10.04.2018 17:49, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. You should add an empty line before "Signed-off" line as stated in [1]. I would also add a space b/w your name and your email in Signed-off

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

On 27.03.2018 10:22, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. > As I suggested in patch 6, I prefer having the same format for wilc_wfi_cfg_tx_vendor_spec() and wilc_wfi_cfg_parse_rx_vendor_spec(). I

Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

On 26.03.2018 20:16, Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with -ENOMEM. > > Signed-off-by: Colin Ian King

Re: [PATCH 0/9] staging: wilc1000: fix memory leaks and checkpatch reported issues

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 23.03.2018 17:08, Ajay Singh wrote: > This patch series contains changes to fix memory leaks, avoid NULL pointer > exceptions and checkpatch reported issue fixes. > > Ajay Singh (9): > staging: wilc1000:

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

Patch 6 may be reworked a bit. Other than this: Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 21.03.2018 11:20, Ajay Singh wrote: > Hi Dan, > > On Wed, 21 Mar 2018 10:51:16 +0300 > Dan Carpenter <dan.carpen...@oracle.com> wrote: > >> These l

Re: [PATCH 06/11] staging: wilc1000: refactor mgmt_tx to fix line over 80 chars

On 20.03.2018 18:55, Ajay Singh wrote: > Refactor mgmt_tx() to fix line over 80 characters issue. Split the > function to avoid the checkpatch.pl warning. Returning the same error > code in case of memory allocation failure. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Also good for me, only one minor thing mentioned below. On 20.03.2018 18:55, Ajay Singh wrote: > + if (subtype == GO_NEG_REQ || subtype == GO_NEG_RSP || > + subtype == P2P_INV_REQ || subtype == P2P_INV_RSP) { > + for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < size; i++) { > +

Re: [PATCH 00/10] staging: wilc1000: fixes for checkpatch issues & coding style related

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 07.03.2018 04:13, Ajay Singh wrote: > This patch series contains modification to remove the checkpatch warnings > and changes to follow linux coding style. > > Ajay Singh (10): > staging: wilc1000: rename

Re: [PATCH 00/10] staging: wilc1000: fixes related to camelCase & line over 80 chars

Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 07.03.2018 03:32, Ajay Singh wrote: > Patch series contains fixes to remove checkpatch reported warnings. > > Ajay Singh (10): > staging: wilc1000: rename strHiddenNetwork to avoid camelCase > stag

Re: [PATCH 10/10] staging: wilc1000: fix line over 80 char in cfg_scan_result()

On 07.03.2018 03:32, Ajay Singh wrote: > Refactor cfg_scan_result() API to avoid 'line over 80 chars' issue > reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 148 > +++--- >

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

On 22.02.2018 11:23, Claudiu Beznea wrote: > Hi Dan, Sorry, I intended to be address this to Ajay, > > On 22.02.2018 09:37, Dan Carpenter wrote: >> On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: >>> Use existing macro GENMASK to get the bitmask value. M

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

nit_irq(dev)) { ret = -EIO; goto _fail_locks_; } // ... ret = linux_wlan_start_firmware(dev); -> calls linux_wlan_start_firmware which in turn calls wilc->hif_func->hif_sync_ext(wilc, NUM_INT_EX

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

Hi Ajay, Sure, I will take a look. Thank you, Claudiu On 21.02.2018 18:25, Ajay Singh wrote: > Hi Claudiu, > > On Mon, 19 Feb 2018 15:33:09 +0200 > Claudiu Beznea <claudiu.bez...@microchip.com> wrote: > >> Since you re-factor this, as I suggested in patch: >&g

Re: [PATCH 11/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

On 16.02.2018 17:11, Ajay Singh wrote: > Fix "line over 80 characters" issue reported by checkpatch.pl. > Use temporary variable to avoid checkpatch.pl issue. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 16 +--- > 1 file

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

Hi Ajay, On 16.02.2018 17:11, Ajay Singh wrote: > Refactor sdio_clear_int_ext() function to remove "Too many leading tabs" > warning reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_sdio.c | 134 >

Re: [PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor wilc_spi_read_int() to fix the line over 80 char issues reported > by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 57 > +++-- > 1

Re: [PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor wilc_spi_clear_int_ext() to fix the "line over 80 char" issue > reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 113 >

Re: [PATCH 3/6] staging: wilc1000: fix line over 80 characters in spi_cmd_complete()

On 14.02.2018 13:10, Ajay Singh wrote: > Refactor spi_cmd_complete() to fix the line over 80 char issues reported > by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 250 > ++-- > 1

Re: [PATCH 1/6] staging: wilc1000: modified code comments as per linux coding style

Hi Ajay, Even I cannot locate something in Documentation/CodingStyle related to single line comment, I prefer to use: /* comment */ instead of: /* * comment */ Do as you wish! Thank you, Claudiu On 14.02.2018 13:10, Ajay Singh wrote: > diff --git a/drivers/staging/wilc1000/wilc_spi.c >

Re: [PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase

My comments to this series were only notes to be taken into account for future patches. Thank you, Claudiu Beznea On 22.01.2018 12:22, Ajay Singh wrote: > This patch series contains changes to fix issues reported by checkpatch.pl > script. > > Changes since v1: > *

Re: [PATCH v2 02/14] staging: wilc1000: removed unnecessary defined enums typedef

On 22.01.2018 13:22, Dan Carpenter wrote: > On Mon, Jan 22, 2018 at 01:06:59PM +0200, Claudiu Beznea wrote: >> >> >> On 22.01.2018 12:22, Ajay Singh wrote: >>> Fix the "do not add new typedefs" issue found by checkpatch.pl >>> script >>

Re: [PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase

On 22.01.2018 13:10, Claudiu Beznea wrote: > > > On 22.01.2018 12:22, Ajay Singh wrote: >> This patch series contains changes to fix issues reported by checkpatch.pl >> script. >> >> Changes since v1: >> * Patch0004: Used "host_int_parse_join_bss_p

Re: [PATCH v2 04/14] staging: wilc1000: rename host_int_ParseJoinBssParam() and it's variable using camelCase

On 22.01.2018 12:22, Ajay Singh wrote: > Fix "Avoid CamelCase:" issue reported by checkpatch.pl script Forgot a dot here? > Rename host_int_ParseJoinBssParam() & its variables name using > camelCase. > > Signed-off-by: Ajay Singh <ajay.kat...@microchip.co

Re: [PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase

le line instead of using two lines. > * Patch0010: Used "bss_param" for variable name instead of j_bss_param. > * Added "Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com>" for > commit description. > * Modify the commit description to start with cap

Re: [PATCH v2 13/14] staging: wilc1000: rename Handle_Connect() to avoid camelCase

On 22.01.2018 12:22, Ajay Singh wrote: > Fix "Avoid camelcase" issue found by checkpatch.pl > script. > Same here as in patch 02 of this series. > Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> > Reviewed-by: Claudiu Beznea <claudiu.bez...@micro

Re: [PATCH v2 12/14] staging: wilc1000: rename Handle_ScanDone() to avoid camelCase

On 22.01.2018 12:22, Ajay Singh wrote: > Fix "Avoid camelCase" issue reported by checkpatch.pl > script. Same here as in patch 02 of this series. > > Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> > Reviewed-by: Claudiu Beznea <claudiu.bez...@micro

Re: [PATCH v2 02/14] staging: wilc1000: removed unnecessary defined enums typedef

5 columns. > Signed-off-by: Ajay Singh <ajay.kat...@microchip.com> > Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> > --- > drivers/staging/wilc1000/wilc_wlan_if.h | 72 > - > 1 file changed, 36 insertions(+), 36 deletions(-) &g

Re: [PATCH 04/14] staging: wilc1000: rename host_int_ParseJoinBssParam() and it's variable using camelCase

On 19.01.2018 14:44, Dan Carpenter wrote: > On Fri, Jan 19, 2018 at 01:20:00PM +0200, Claudiu Beznea wrote: >> It is hard to review this. Anyway, Reviewed-by: Claudiu Beznea >> <claudiu.bez...@microchip.com> >> > > I have a script I use. It's sort of ha

Re: [PATCH 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase

All series Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> with the inline comments. Ajay, one general remark, please use Capital letters when beginning new sentences (I'm talking about commit descriptions). Thanks, Claudiu Beznea On 18.01.2018 15:16, Ajay Singh wrote: > T

Re: [PATCH 09/14] staging: wilc1000: rename pstrHostIFconnectAttr argument to avoid camelCase

On 18.01.2018 15:17, Ajay Singh wrote: > fix "Avoid camelCase" issue found by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 104 > ++ > 1 file changed, 49 insertions(+), 55

Re: [PATCH 10/14] staging: wilc1000: rename ptstrJoinBssParam variable to avoid camelCase

On 18.01.2018 15:17, Ajay Singh wrote: > fix "Avoid camelCase" issue reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 78 > +++ > 1 file changed, 39 insertions(+), 39

Re: [PATCH 05/14] staging: wilc1000: rename camelCase used in Handle_DelAllSta() and its variable

On 18.01.2018 15:17, Ajay Singh wrote: > fix "Avoid camelCase" issue reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-)

Re: [PATCH 04/14] staging: wilc1000: rename host_int_ParseJoinBssParam() and it's variable using camelCase

It is hard to review this. Anyway, Reviewed-by: Claudiu Beznea <claudiu.bez...@microchip.com> On 18.01.2018 15:17, Ajay Singh wrote: > fix "Avoid CamelCase:" issue reported by checkpatch.pl script > Rename host_int_ParseJoinBssParam() & its variables name using &g

Re: [PATCH v3 0/6] fixes to remove enum typedefs

Hi Ajay, Just a little note for your future patches: all changes history would be good to be kept here, something like this: changes in v3: this, this and this changes in v2: this and this Thanks, Claudiu On 11.01.2018 16:12, Ajay Singh wrote: > Changes since v2: Removed v2 patch number 3,4,5

Re: [PATCH] staging: wilc1000: Fix problems reported by checkpatch

Hi Aditya, On 01.12.2017 22:27, Aditya Shankar wrote: > This commit fixes below style problems in multiple lines > Fix checkpatch WARNING: line over 80 characters > Fix CHECK: Lines should not end with a '(' You should fix only one issue per patch. Would be better to have a patch with "line over

Re: [PATCH] staging: wilc1000: Fix bssid buffer offset in Txq

Hi Aditya, My problem is fixed with this patch. WILC1000 connects to AP, IP is retrieved from DHCP server and ping works. You can add my Tested-by: Claudiu Beznea <claudiu.bez...@microchip.com> Thanks, Claudiu On 03.11.2017 10:56, Aditya Shankar wrote: > Commit 46949b48568b ("sta

[PATCH] Staging: wilc1000: Freed memory in case of error

This patch frees memory allocated inside wilc_wlan_txq_add_cfg_pkt() in case wilc_wlan_txq_add_to_head() fails. Signed-off-by: Claudiu Beznea <claudiu.bez...@gmail.com> --- drivers/staging/wilc1000/wilc_wlan.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/d