Re: [PATCH v2] iwlwifi: mvm: allow monitor mode capture in STA mode

On Tue, 2017-09-26 at 10:29 -0700, Gavin Li wrote: > Hi Luciano, Hi, > Thanks for the update. I was hoping that it would be supported since I > remember that iwldvm had no problem with it in the past. As I said, it *may* work for you as it did with iwldvm, but we cannot guarantee that it will

Re: [PATCH v2] iwlwifi: mvm: allow monitor mode capture in STA mode

Hi Gavin, On Thu, 2017-09-14 at 22:11 -0700, gavi...@thegavinli.com wrote: > From: Gavin Li > > Open up the filter if there is a monitor interface configured; this > allows all packets on the channel to be captured even if the device is > in STA mode and associated to a BSS.

Re: [PATCH] wireless: iwlwifi: fix minor code style issues

On Sat, 2017-09-23 at 12:31 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two > switch/case indentation issues and one alignment issue in a multiline comment. > > Signed-off-by: Christoph Böhmwalder > --- Thanks,

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- Why are you

Re: iwlwifi firmware load broken in current -git

Hi Jens, On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > Hi, > > I have no wifi in current git (8fac2f96ab8), it simply fails with: > > [4.363481] iwlwifi :04:00.0: Direct firmware load for > iwlwifi-8000C-34.ucode failed with error -2 > [4.363733] iwlwifi :04:00.0:

Re: [GIT] Networking

On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote: > On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > This seems to be a problem with backwards-compatibility with FW version > > 27. We are now in version 31[1] a

Re: [GIT] Networking

On Wed, 2017-09-06 at 16:27 -0700, Linus Torvalds wrote: > This pull request completely breaks Intel wireless for me. > > This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a). > > That remains a very standard Intel machine with absolutely zero odd > things going on. > > The

Re: [bug report] iwlwifi: mvm: add station before allocating a queue

On Fri, 2017-09-01 at 11:30 +0300, Dan Carpenter wrote: > Hello Shaul Triebitz, > > The patch 732d06e9d9cf: "iwlwifi: mvm: add station before allocating > a queue" from Jul 10, 2017, leads to the following static checker > warning: > > drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1312 >

Re: [linuxwifi] x86/thermal: AB-BA dependency between mvm->mutex and tz->lock

On Thu, 2017-08-17 at 15:38 +0200, Jiri Kosina wrote: > Hi, > > anything new on this front please? > > The splat (and therefore deadlock potential) is still there with current > Linus' tree. Sorry, haven't had more time to spend on it. I'll do it this evening. But, just to clarify, the

Re: [PATCH v3] iwlwifi: Demote messages about fw flags size to info

On Thu, 2017-08-03 at 07:47 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags than the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the

Re: [linuxwifi] x86/thermal: AB-BA dependency between mvm->mutex and tz->lock

On Thu, 2017-08-03 at 13:02 +0300, Kalle Valo wrote: > "Coelho, Luciano" <luciano.coe...@intel.com> writes: > > > On Thu, 2017-08-03 at 11:10 +0200, Jiri Kosina wrote: > > > On Mon, 31 Jul 2017, Jiri Kosina wrote: > > > > > > > Hi, > &

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > + const char *name, struct device *device, gfp_t gfp, > > > + void

Re: [PATCH 19/24] iwlwifi: mvm: fix TCP CSUM offload with WEP and A000 series

On Fri, 2017-07-28 at 17:23 +0300, Luca Coelho wrote: > From: Emmanuel Grumbach > > When we enabled TCP checksum offload, we need to tell the > firmware where the IP header starts. If we have an IV, then > we need to adapt that value since the IV is placed before >

Re: [PATCH 00/24] iwlwifi: updates intended for v4.13 2017-07-28

As Emmanuel pointed out, the subject is obviously wrong. These are intended for v4.14 as my text correctly says below. Sorry if this caused confusion. -- Luca. On Fri, 2017-07-28 at 17:23 +0300, Luca Coelho wrote: > From: Luca Coelho > > Hi, > > Here's my first set

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags then the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the

Re: [PATCH] iwlwifi: pcie: Fix error code in iwl_trans_pcie_alloc()

On Wed, 2017-07-19 at 11:21 +0300, Dan Carpenter wrote: > Oops, heh, sorry. I switched computers so I first one wasn't in my > outbox. No worries, better safe than sorry. :) -- Luca.

Re: [PATCH] iwlwifi: pcie: Fix error code in iwl_trans_pcie_alloc()

Hi Dan, On Wed, 2017-07-12 at 10:53 +0300, Dan Carpenter wrote: > We accidentally forgot to propogate the error code on this path. It > means we return ERR_PTR(0) which is NULL and it results in a NULL > dereference in the caller. > > Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration

Re: [PATCH 00/31] iwlwifi: updates intended for v4.13 2017-06-28

On Wed, 2017-06-28 at 23:12 +0300, Luca Coelho wrote: > From: Luca Coelho > > Hi Kalle, > > Here is one more batch that I'd like to get into v4.13, hopefully it's > not too late. I'm also going to send some more tomorrow. The changes > are: > > * Some important

Re: [PATCH 21/26] iwlwifi: mvm: print base HW address during init

On Tue, 2017-06-27 at 18:19 +, Coelho, Luciano wrote: > On Tue, 2017-06-27 at 20:36 +0300, Kalle Valo wrote: > > Fabio Estevam <feste...@gmail.com> writes: > > > > > On Tue, Jun 27, 2017 at 2:06 PM, Kalle Valo <kv...@codeaurora.org> wrote: > >

Re: [PATCH 21/26] iwlwifi: mvm: print base HW address during init

On Tue, 2017-06-27 at 20:36 +0300, Kalle Valo wrote: > Fabio Estevam writes: > > > On Tue, Jun 27, 2017 at 2:06 PM, Kalle Valo wrote: > > > > > "crouded sniffer logs", what's that? > > > > I think Luca meant 'crowded'. > > Ah, makes sense. Thanks.

Re: new warning at net/wireless/util.c:1236

On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote: > Linus Torvalds writes: > > > So my Dell XPS 13 seems to have grown a new warning as of the > > networking merge yesterday. > > > > Things still work, but when it starts warning, it generates a *lot* of > >

Re: [PATCH] iwlwifi: pcie: off by one in iwl_trans_pcie_dyn_txq_alloc()

On Fri, 2017-04-21 at 23:12 +0300, Dan Carpenter wrote: > Heh. I raced this one through to see if I could beat you to the punch. Yeah, this patch is in our internal tree. But maybe we can take Dan's for upstream for his efforts? :) -- Cheers, Luca.

Re: [PATCH] iwlwifi: pcie: missing unlock on error path

Hi Dan On Fri, 2017-04-21 at 13:39 +0300, Dan Carpenter wrote: > We should unlock before returning. > > Fixes: eda50cde58de ("iwlwifi: pcie: add context information support") > Signed-off-by: Dan Carpenter > > diff --git

Re: [RESEND PATCH 4.11] iwlwifi: mvm: cleanup pending frames in DQA mode

On Wed, 2017-03-15 at 11:52 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Sara Sharon > > > > When a station is asleep, the fw will set it as "asleep". > > All queues that are used only by one station will be stopped by > > the fw. > > > >

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

On Fri, 2017-03-10 at 14:01 +0200, Luca Coelho wrote: > Hi Jens, > > On Thu, 2017-03-09 at 21:41 -0700, Jens Axboe wrote: > > On 03/01/2017 09:10 PM, Jens Axboe wrote: > > > On 03/01/2017 08:33 PM, Luca Coelho wrote: > > > > Hi Jens, > > > > > > > > On Mar 1, 2017 20:25, Jens Axboe

Re: [PATCH 00/17] iwlwifi: updates intended for v4.11 2017-02-08

On Wed, 2017-02-08 at 16:29 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > This is the third and final pull-request before 4.11's merge window. > > This time I concentrated in bugfixes: > > > > * Fix 802.11w, which was failing to due an IGTK bug; > > * A few more bugzilla

Re: [PATCH 0/6] iwlwifi: updates intended for v4.10 2017-01-13

On Fri, 2017-01-13 at 14:39 +0200, Luca Coelho wrote: > From: Luca Coelho > > Hi, > > Here are a few fixes that I intend to send for v4.10: > > * fix suspend failure with unified firmware images > * fix a potential crash when dumping debug data > * fix a couple of

Re: iwlwifi: fix kernel crash when unregistering thermal zone

(resending, sorry for the HTML version my phone decided to use for this) On Jan 21, 2017 09:56, Kalle Valo wrote: Jens Axboe writes: > > A recent firmware change seems to have enabled thermal zones on the > > iwlwifi driver. Unfortunately, my device

Re: [PATCH 1/6] iwlwifi: mvm: don't restart HW if suspend fails with unified image

On Fri, 2017-01-13 at 16:13 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > For unified images, we shouldn't restart the HW if suspend fails. The > > only reason for restarting the HW with non-unified images is to go > >

Re: [PATCH v2 0/3] Fix -Wunused-but-set-variable in iwlwifi/pcie/trans and iwlwifi/mvm/rs

On Tue, 2016-11-08 at 21:49 -0800, Kirtika Ruchandani wrote: > This patchset is part of the effort led by Arnd Bergmann to clean up > warnings in the kernel. This and following patchsets will focus on > "-Wunused-but-set-variable" as it among the noisier ones. These were > found compiling with

Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode

Hi Kalle, On Wed, 2016-10-26 at 09:32 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Liad Kaufman > > > > Run DQA flows by default, as long as the FW supports it. > > > > Signed-off-by: Liad Kaufman > >

Re: [PATCH 07/10] iwlwifi: remove support for fw older than -17 and -22

On Thu, 2016-09-22 at 23:52 +0300, Luca Coelho wrote: > From: Luca Coelho > > FW versions older than -17 for 3160 and 7260 and older than -22 for > newer NICs are not supported anymore.  Don't load these versions > and remove code that handles them. > > Signed-off-by:

Re: [PATCH] nl80211: validate number of probe response CSA counters

On Tue, 2016-09-13 at 15:56 +0200, Johannes Berg wrote: > From: Johannes Berg > > Due to an apparent copy/paste bug, the number of counters for the > beacon configuration were checked twice, instead of checking the > number of probe response counters. Fix this to check

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: > Didn't get any feedback or review comments on this patch.  Resending > ... > > P. Sorry, this got flooded down my inbox. > ---8<--- > > The iwlwifi driver implements a thermal zone and hwmon device, but > returns -EIO on temperature

Re: [PATCH 4/7] nl80211: Add info to scan results to support beacon report

On Tue, 2016-07-05 at 15:23 +0300, Luca Coelho wrote: > From: Avraham Stern > > Beacon report radio measurement requires reporting observed BSSs > on the channels specified in the beacon request. If the measurement > mode is set to passive or active, it requires actually

Re: wireless-testing on 4.7

On Wed, 2016-06-01 at 16:08 -0600, Reinoud Koornstra wrote: > On Wed, Jun 1, 2016 at 7:19 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > On Wed, 2016-06-01 at 08:54 -0400, Bob Copeland wrote: > > > + Luca, Emmanuel > > > > Thanks, Bob! > &

Re: wireless-testing on 4.7

On Wed, 2016-06-01 at 08:54 -0400, Bob Copeland wrote: > + Luca, Emmanuel Thanks, Bob! > On Tue, May 31, 2016 at 10:06:57PM -0600, Reinoud Koornstra wrote: > > Today I compiled 4.6+ and pulled sources today > > iwlwifi isn't super smooth. > > I assume you mean wireless-testing, based on

Re: [PATCH 1/1] iwlwifi: rs: remove superfluous check

On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote: > If we dereference a variable anyway in other parts of the code, > there is no need to check against NULL in a single place. NACK.  This is not true. If lq_sta is NULL, it means that mvm_sta is also NULL.  Then we call the

Re: [GIT] Networking

On Wed, 2016-05-18 at 12:00 -0700, Linus Torvalds wrote: > On Wed, May 18, 2016 at 11:58 AM, Kalle Valo > wrote: > > > > > > It would be best if you could send a patch either directly to Dave > > or > > Linus to resolve this quickly. > I'm committing my patch myself right

Re: [GIT] Networking

On Wed, 2016-05-18 at 11:45 -0700, Linus Torvalds wrote: > On Wed, May 18, 2016 at 7:23 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > > > I can confirm that 4.6 contains the same bug.  And reverting the > > patch > > I mentioned does so

Re: [GIT] Networking

On Wed, 2016-05-18 at 06:51 -0600, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 6:41 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote: > > > > > > On Wed, May 18, 2016 at 4

Re: [GIT] Networking

On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 4:51 AM, Coelho, Luciano > <luciano.coe...@intel.com> wrote: > > > > Hi Emmanuel, Linus, > > > > > > On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: &g

Re: [GIT] Networking

Hi Emmanuel, Linus, On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: > On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds > wrote: > > > > On Tue, May 17, 2016 at 12:11 PM, David Miller > > wrote: > > > > > > > > > Highlights: > >

Re: pull-request: wireless-drivers-next 2016-05-13

On Mon, 2016-05-16 at 17:08 +0300, Kalle Valo wrote: > Kalle Valo writes: > > > > > Kalle Valo writes: > > > > > > > > The following changes since commit > > > ede00a5ceb4d903a8c137a52bb77d574baaef8bd: > > > > > >   Merge tag

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

Hi Kalle, On Mon, 2016-05-16 at 16:10 +0300, Kalle Valo wrote: > (Adding Luca and linux-wireless) > > Stephen Rothwell writes: > > > > > Today's linux-next merge of the wireless-drivers-next tree got a > > conflict in: > > > >  

Re: [patch] iwlwifi: mvm: remove an unused variable

On Wed, 2016-05-04 at 09:19 +0300, Dan Carpenter wrote: > We never initalize ampdu_status so it causes a static checker warning > when we pass it to iwl_mvm_pass_packet_to_mac80211().  Fortunately, > it's > never used so we can just remove it. > > Signed-off-by: Dan Carpenter

Re: pull request: iwlwifi 2016-05-04

On Fri, 2016-05-06 at 14:34 +0300, Kalle Valo wrote: > "Grumbach, Emmanuel" writes: > > > > > I know it is extremely late in the cycle, but this patch is > > intended > > for 4.6... It fixes a regression I introduced: a P2P specification > > violation as mentioned

Re: [PATCH] iwlwifi: fix fw version reading for DVM devices

On Mon, 2016-04-25 at 20:02 +0300, Luca Coelho wrote: > From: Luca Coelho > > In commit 97f95c93c8ed ("iwlwifi: remove support for fw older than > -16.ucode") we accidentally changed the fw version reading code for > DVM devices.  The code intended to remove the old fw

Re: pull request: iwlwifi-2016-02-16

Hi Arend, On Fri, 2016-03-18 at 20:52 +0100, Arend Van Spriel wrote: > On 15-2-2016 12:57, Grumbach, Emmanuel wrote: > > > > * Luca fixes a very visible bug in scheduled scan: our firmware > >   doesn't support scheduled scan with no profile configured and > >   the supplicant sometimes requests

Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans

On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote: > This fixes incorrect fallthrough in the switch statment checking > the scan type passed by the caller to iwl_mvm_check_running_scans > for the switch case IWL_MVM_SCAN_SCHED to return directly after > the call to iwl_mvm_scan_stop in

Re: iwlwifi/iwlmvm dies on resume when rfkill is set

On Mon, 2015-06-01 at 23:30 +, Grumbach, Emmanuel wrote: On Mon, 2015-06-01 at 15:51 -0700, Andy Lutomirski wrote: If I switch my laptop into airplane mode (hardware switch) and then suspend and resume, my wireless is dead on resume and it spews all over the kernel log (see below). I

Re: iwlwifi: mvm: set the TX disable bit when doing a chanctx switch

Hi Dan, Sorry for the late reply. On Tue, 2014-09-09 at 12:40 +0300, Dan Carpenter wrote: Hello Luciano Coelho, The patch 0ce04ce797f8: iwlwifi: mvm: set the TX disable bit when doing a chanctx switch from May 8, 2014, leads to the following static checker warning: