Re: [RFC v4 08/13] rtw88: debug files

On Thu, 2018-11-15 at 16:15 +0200, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > > > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > > > Joe Perches writes: > > [] > > > >

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

On Mon, 2018-11-05 at 12:18 +, ajay.kat...@microchip.com wrote: > Hi Joe, > > On 11/5/2018 4:27 PM, Joe Perches wrote: > > On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: > > > From: Ajay Singh > > > > > > Use shorter name for

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > Use shorter name for 'network_info' variable to avoid line over 80 chars > issue. I suppose this is OK, though perhaps unnecessary. As well, perhaps there are defects in the original code in a couple

Re: [RFC v5 08/13] rtw88: debug files

On Mon, 2018-11-05 at 06:13 +, Tony Chuang wrote: > > -Original Message- > > From: Joe Perches [mailto:j...@perches.com] > > Sent: Sunday, November 04, 2018 12:29 PM > > To: Tony Chuang; kv...@codeaurora.org; sgrus...@redhat.com > > Cc: larry.fin..

Re: [PATCH 4/8] staging: wilc1000: avoid line over 80 chars in wilc_parse_network_info()

On Thu, 2018-11-01 at 16:45 +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > Use shorter name for 'network_info' variable to avoid line over 80 chars > issue. This seems completely unnecessary as patch 7/8 and 8/8 removes the file.

Re: [RFC v4 08/13] rtw88: debug files

On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote: > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > > Joe Perches writes: [] > > > It's very unusual to have _all_ the logging under a CONFIG__DEBUG > > > config guard flag. > > > > For wireless

Re: [RFC v5 08/13] rtw88: debug files

On Wed, 2018-10-31 at 18:12 +0800, yhchu...@realtek.com wrote > From: Yan-Hsuan Chuang > debug files for Realtek 802.11ac wireless network chips [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.h > b/drivers/net/wireless/realtek/rtw88/debug.h [] > +#ifdef CONFIG_RTW88_DEBUG [] > +#else

Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. The patch subject

Re: [RFC v4 08/13] rtw88: debug files

On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > > > From: Yan-Hsuan Chuang > > [] > > > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > > >

Re: [RFC v4 08/13] rtw88: debug files

On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > From: Yan-Hsuan Chuang [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > b/drivers/net/wireless/realtek/rtw88/debug.c [] > +#ifdef CONFIG_RTW88_DEBUG > + > +void __rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...)

Re: [PATCH v2 28/29] staging: wilc1000: avoid spaces preferred around checkpatch issue

On Thu, 2018-09-20 at 11:53 +0530, Ajay Singh wrote: > Cleanup patch to add extra spaces around the '/' to avoid the below > checkpatch warning. > > 'spaces preferred around that '/' (ctx:VxV)' > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/linux_wlan.c | 2 +- > 1 file

Re: [PATCH] Fix Bug 199967 - change WARN_ON(1) to IWL_ERR()

On Sat, 2018-08-18 at 09:11 -0700, Nye Liu wrote: > On 8/18/2018 1:41 AM, Luciano Coelho wrote: > > > On Fri, 2018-08-17 at 20:35 -0700, Nye Liu wrote: > > > The TX_STATUS_FAIL_DEST_PS case fills logs with full backtraces, which > > > are pretty useless. Just do IWL_ERR() printk. > > > > > >

Re: [PATCH v1] PCI: Add PCI_DEVICE_DATA() macro to fully describe device ID entry

On Fri, 2018-07-27 at 23:39 +0300, Andy Shevchenko wrote: > There are a lot of examples in the kernel where PCI_VDEVICE() is used and > still > looks not so convenient due to additional driver_data field attached. > > Introduce PCI_DEVICE_DATA() macro to fully describe device ID entry in >

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

On Wed, 2018-07-25 at 15:12 +0200, Arnd Bergmann wrote: > tools/perf/tests/.gitignore: > LLVM byte-codes, uncompressed > On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton > wrote: > > On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches wrote: > >

Re: [PATCH] rtlwifi: remove duplicate code

On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote: > Remove and refactor some code in order to avoid having identical code > for different branches. True and nice tool and patch submittal thanks. > Notice that the logic has been there since 2014. But perhaps the original logic is a

Re: [PATCH 4.17] bcma: fix buffer size caused crash in bcma_core_mips_print_irq()

On Tue, 2018-05-08 at 11:31 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Used buffer wasn't big enough to hold whole strings. Example output of > this function is: > [0.180892] bcma: bus0: core 0x0800, irq: 2(S)* 3 4 5 6 D I > [0.180948] bcma: bus0: core

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On Thu, 2018-04-05 at 15:27 +0200, Felix Fietkau wrote: > On 2018-03-31 09:05, Joe Perches wrote: > > There are many local static and non-static arrays that are used for > > Ethernet broadcast address output or comparison. > > > > Centralize the array into a sing

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 14:01 +, Pkshih wrote: > On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > > Use the new ether_broadcast_addr global instead to save some object code. [] > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c [] > > @@ -1649,7

[PATCH 00/12] Ethernet: Add and use ether__addr globals

There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison. Centralize the array into a single separate file and remove the local arrays. Joe Perches (12): ethernet: Add generic ether__addr addresses treewide/net: Rename eth_stp_addr

[PATCH 03/12] net: mac80211: Use global ether_broadcast_addr

Remove statics and use the new global ether_broadcast_addr instead to save some overall object code size. Signed-off-by: Joe Perches <j...@perches.com> --- net/mac80211/iface.c| 5 + net/mac80211/key.c | 6 ++ net/mac80211/mesh_hwmp.c| 19 ++

[PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

Remove the local ALLFFMAC extern array and use the new global instead. Miscellanea: o Convert char *mac to const char *mac as it can't be modified Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- drivers/net/wireless/br

[PATCH 08/12] iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr

Remove the local array and use the new global instead to save some small amount of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- drivers/net/wireless/intel/iw

[PATCH 09/12] iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr

Use the new global to save a little bit of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 4 +--- 3 files chan

Re: [PATCH 2/4] wireless: Use octal not symbolic permissions

On Sat, 2018-03-24 at 12:09 +0200, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > Prefer the direct use of octal for permissions. [] > I don't know what tree are you planning to send these to, but I would > prefer to take this to wireless-drivers-next to m

[PATCH 2/4] wireless: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath5k/

[PATCH 3/4] net: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- net/8021q/vlanproc.c

[PATCH 0/4] net: drivers/net: Use octal permissions

Using octal and not symbolic permissions is preferred by many as more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than getting these piecemeal, just do them all. Done with checkpatch and some typing. Joe Perches (4): ethernet: Use octal not symbolic permissions wireless: Use octal

[trivial PATCH V2] treewide: Align function definition open/close braces

Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Signed-off-by: Joe Perches <j...@perches.

Re: [PATCH] staging: wilc1000: check for kmalloc allocation failures

On Wed, 2018-03-21 at 19:19 +, Colin King wrote: > From: Colin Ian King > > There are three kmalloc allocations that are not null checked which > potentially could lead to null pointer dereference issues. Fix this > by adding null pointer return checks. looks like

[PATCH] ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr

Remove the static array and use the generic routine to set the Ethernet broadcast address. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath.h| 2 -- drivers/net/wireless/ath/ath5k/attach.c | 2 +- drivers/net/wireless/ath/ath9k/htc_drv_

Re: rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures)

On Thu, 2018-03-15 at 10:08 -0700, Matthew Wilcox wrote: > On Thu, Mar 15, 2018 at 09:56:46AM -0700, Joe Perches wrote: > > I have a patchset that creates a vsprintf extension for > > print_vma_addr and removes all the uses similar to the > > print_symbol() removal. > &g

rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures)

On Thu, 2018-03-15 at 10:48 +0100, Geert Uytterhoeven wrote: > Hi David, > > On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote: > > Do we have anything left that still implements NOMMU? > > Sure: arm, c6x, m68k, microblaze, and sh. I have a patchset that creates a

[PATCH] net: drivers/net: Remove unnecessary skb_copy_expand OOM messages

skb_copy_expand without __GFP_NOWARN already does a dump_stack on OOM so these messages are redundant. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 - drivers/net/usb/lg-vl600.c | 6 +- drivers/net/wimax/i2400m/usb-rx.c

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > This is the correct patch. [] > diff --git a/drivers/net/wireless/ath/ath9k/dfs.c > b/drivers/net/wireless/ath/ath9k/dfs.c [] > @@ -101,7 +101,7 @@ static bool

Re: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy

On Fri, 2018-02-09 at 14:24 +0100, Arnd Bergmann wrote: > gcc-8 points out that source and destination of the memcpy() are > always the same pointer, so the effect of memcpy() is undefined > here (its arguments must not overlap): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In

[trivial PATCH] treewide: Align function definition open/close braces

line from xfs_agf_verify Signed-off-by: Joe Perches <j...@perches.com> --- git diff -w shows no difference other than the above 'Miscellanea' (this is against -next, but it applies against Linus' tree with a couple offsets) arch/x86/include/asm/atomic64_32.h | 2 +- d

Re: [PATCH] wlcore, wl1251: fix spelling mistake: "Couldnt" -> "Couldn't"

On Fri, 2017-12-01 at 09:34 +, Colin King wrote: > Trivial fix to spelling mistake in error message text. [] > diff --git a/drivers/net/wireless/ti/wl1251/init.c > b/drivers/net/wireless/ti/wl1251/init.c [] > @@ -311,7 +311,7 @@ static int wl1251_hw_init_data_path_config(struct wl1251 > *wl)

Re: drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8225se.c: Odd array size

(adding the original submitter: Andrea Merello) On Tue, 2017-11-28 at 14:39 -0600, Larry Finger wrote: > On 11/28/2017 10:49 AM, Joe Perches wrote: > > 61 entries in this table: > > > > static const u8 OFDM_CONFIG[] = { > > 0x10, 0x0F, 0x0A, 0x0C, 0x14, 0xFA, 0xF

drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8225se.c: Odd array size

61 entries in this table: static const u8 OFDM_CONFIG[] = { 0x10, 0x0F, 0x0A, 0x0C, 0x14, 0xFA, 0xFF, 0x50, 0x00, 0x50, 0x00, 0x00, 0x00, 0x5C, 0x00, 0x00, 0x40, 0x00, 0x40, 0x00, 0x00, 0x00, 0xA8, 0x26, 0x32, 0x33, 0x06, 0xA5, 0x6F, 0x55, 0xC8, 0xBB, 0x0A,

[PATCH V2] bcma: Use bcma_debug and not pr_cont in MIPS driver

be emitted. Correct this by removing the uses of pr_cont by using a temporary. Signed-off-by: Joe Perches <j...@perches.com> --- v2: Fix whitespace damage I hear there's this checkpatch tool... drivers/bcma/driver_mips.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletion

[PATCH] bcma: Use bcma_debug and not pr_cont in MIPS driver

be emitted. Correct this by removing the uses of pr_cont by using a temporary. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/bcma/driver_mips.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c in

Re: [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver

On Mon, 2017-10-16 at 23:21 +0200, Hauke Mehrtens wrote: > On 10/16/2017 02:54 PM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > Using bcma_debug gives a device-specific prefix for messages and pr_cont > > is a common helper for continuing a line. > > > > Signed-off-by:

Re: [PATCH] staging: wilc1000: replace redundant computations with 0

On Tue, 2017-10-10 at 15:05 +0100, Colin King wrote: > From: Colin Ian King > > Shifting and masking strHostIfSetMulti->enabled is redundant since > enabled is a bool and so all the shifted and masked values will be > zero. Replace them with zero to simplify the code. >

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On Wed, 2017-10-11 at 12:54 +, David Laight wrote: > From: Joe Perches > > Sent: 11 October 2017 11:21 > > On Tue, 2017-10-10 at 14:30 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On Tue, 2017-10-10 at 14:30 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. perhaps use Arnaldo's idea: https://lkml.org/lkml/2017/2/9/845 https://lkml.org/lkml/2017/2/10/485

Re: [PATCH 1/5] iwlwifi: mvm: do not print security error in monitor mode

On Fri, 2017-09-29 at 15:03 +0300, Luca Coelho wrote: > From: Shaul Triebitz > > In monitor mode we are not expected to decrypt encrypted > packets (not having the keys). > Hence we are expected to get an unknown rx security status. > Keeping the print in monitor mode

Re: [PATCH] rsi: fix integer overflow warning

On Thu, 2017-10-05 at 15:12 +, David Laight wrote: > From: Joe Perches > > Sent: 05 October 2017 13:19 > > On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > > > gcc produces a harmless warning about a recently introduced > > > signed integer overflow:

Re: [PATCH] rsi: fix integer overflow warning

On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > gcc produces a harmless warning about a recently introduced > signed integer overflow: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': > include/uapi/linux/swab.h:13:15: error: integer overflow in

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

On Wed, 2017-10-04 at 19:39 +0300, Luciano Coelho wrote: > On Wed, 2017-10-04 at 09:26 -0700, Joe Perches wrote: [] > > This might be more intelligble as separate tests > > > > static bool is_valid_channel(u16 ch_id) > > { > > if (ch_id &

Re: [PATCH 1/3] wireless: iwlwifi: use bool instead of int

On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote: > Change a usage of int in a boolean context to use the bool type instead, as it > makes the intent of the function clearer and helps clarify its semantics. > > Also eliminate the if/else and just return the boolean result directly, >

Re: [PATCH 3/3] wireless: iwlwifi: wrap macro into braces

On Wed, 2017-10-04 at 17:57 +0200, Christoph Böhmwalder wrote: > Macros should always be wrapped in braces, so fix this instance. > > Signed-off-by: Christoph Böhmwalder > --- > drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 2017-09-22 at 12:06 +0200, Julia Lawall wrote: > > On Fri, 22 Sep 2017, Colin Ian King wrote: > > > On 22/09/17 11:03, Joe Perches wrote: > > > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > > > > > > > > On Thu, 21 Sep 2017,

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: > > On Thu, 21 Sep 2017, Colin King wrote: > > > From: Colin Ian King > > > > Don't populate const array ac_to_fifo on the stack in an inlined > > function, instead make it static. Makes the object code smaller >

Re: [PATCH 1/2] iwlwifi: fix long debug print

On Fri, 2017-09-01 at 11:15 +0300, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote: > > > On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: > > > > On Fri, 2017-08-25 at 11:27 +0300, Luc

Re: [PATCH 1/2] iwlwifi: fix long debug print

On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote: > On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: > > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: > > > From: Liad Kaufman <liad.kauf...@intel.com> > > > > > > There is a debug print t

Re: [PATCH 1/2] iwlwifi: fix long debug print

On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: > From: Liad Kaufman > > There is a debug print that sometimes reaches over > 110 chars, thus generating a warning in those cases. What emits a warning here?

Re: [PATCH] ath9k: remove cast to void pointer

On Thu, 2017-08-31 at 18:37 +0530, Himanshu Jha wrote: > casting to void pointer from any pointer type and vice-versa is done > implicitly and therefore casting is not needed in such a case. You said you were going to remember to mention the tool and script that did this.

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

On Mon, 2017-08-14 at 16:17 -0500, Larry Finger wrote: > On 08/14/2017 01:56 PM, Joe Perches wrote: > > On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: > > > From: Ping-Ke Shih <pks...@realtek.com> > > > > > > Use debugfs to dump register and b

Re: [PATCH v2 09/10] rtlwifi: use debugfs to debug.

On Sun, 2017-06-25 at 10:43 -0500, Larry Finger wrote: > From: Ping-Ke Shih > > Use debugfs to dump register and btcoex status. [] > diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c > b/drivers/net/wireless/realtek/rtlwifi/debug.c [] > +void rtl_debug_add_one(struct

Re: [PATCH] Staging: wilc1000: Fix line over 80 characters

On Fri, 2017-08-04 at 03:30 +0530, Himanshu Jha wrote: > This patch fixes 80 characters limit coding style issue. > > Signed-off-by: Himanshu Jha > --- > drivers/staging/wilc1000/linux_wlan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()

On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote: > Each time we get disconencted from AP we get flooded with messages > like: > > ... > ath10k_pci :03:00.0: no channel configured; ignoring frame(s)! > > ath10k_warn: 155 callbacks suppressed

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

On Wed, 2017-07-12 at 08:12 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 12, 2017 at 10:23:02AM +0800, Rui Teng wrote: > > On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: > > > On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > > > > This patch sets memory to zero directly to avoid

[PATCH] staging: wilc1000: Neaten refresh_scan - remove always 1 argument

for the first void * argument as it's always the struct wilc_priv * o Move variables into loop where used Signed-off-by: Joe Perches <j...@perches.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 65 ++- 1 file changed, 28 insertions(+), 37 deletions(-) diff

Re: [PATCH 19/31] iwlwifi: pcie: improve debug in iwl_pcie_rx_handle_rb()

On Wed, 2017-06-28 at 23:13 +0300, Luca Coelho wrote: > Print the queue for the existing debug message and add a new > debug message indicating where the RB ended. trivia: > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c [] > @@

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 21:10 +0200, Lubomir Rintel wrote: > On Wed, 2017-06-28 at 17:02 +0200, Johannes Berg wrote: > > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > > The mac80211_hwsim doesn't offer a way to disable the debugging > > > output. > > > Unfortunately, it's pretty

Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages

On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > The mac80211_hwsim doesn't offer a way to disable the debugging output. > Unfortunately, it's pretty chatty, dumping a lot of stuff into the message > buffer. > > This patch changes it to use dyndbg for controlling the debug output. >

Re: [PATCH 10/10] rtlwifi: btcoex: Use seq_file to dump btcoex status

On Fri, 2017-06-23 at 20:53 -0500, Larry Finger wrote: > From: Ping-Ke Shih > > If we use seq_file to dump status, then we can use 'cat' to access > debugfs. Other related changes are > 1. implement btc_disp_dbg_msg() to access btcoex's common status. > 2. remove obsolete

Re: [PATCH 0/5] rtlwifi: Neatening

On Wed, 2017-06-21 at 13:12 -0500, Larry Finger wrote: > On 06/19/2017 03:18 PM, Joe Perches wrote: [] > In general, I approve of your patches. Unfortunately, they will conflict with > a > number of changes that I am currently making. If you would like, I can merge > yo

[PATCH 0/5] rtlwifi: Neatening

Joe Perches (5): rtlwifi: Use temporary ops variable to reduce code size rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops rtlwifi: Add and use convenience macro rtl_btc realtek: btcoexist: Make the rtl_btc_ops struct const realtek: rtlwifi: drivers: Use the rtl_

[PATCH 3/5] rtlwifi: Add and use convenience macro rtl_btc

bluetooth coexistence functions always check get_btc_status before accessing the function. Centralize this via a convenience macro to neaten the source code a little. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 8 ++-- drive

[PATCH 2/5] rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops

Reduce the code line length a little. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 7 --- drivers/net/wireless/realtek/rtlwifi/core.c | 10 ++ drivers/net/wireless/realtek/rtlwifi/pci.c | 8 +--- drivers/net/wireless/r

[PATCH 1/5] rtlwifi: Use temporary ops variable to reduce code size

0187e [...]/ps.o.defconfig.old 8435 1 4844020f8 [...]/usb.o.defconfig.old 761483121 32 79301 135c5 (TOTALS) Miscellanea around modified code: o Fix a few misindented code blocks o Realign arguments o Ignored 80 column checkpatch warnings Signed-off-by: Joe P

[PATCH 4/5] realtek: btcoexist: Make the rtl_btc_ops struct const

Avoid allowing a write into what should be const. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h | 2 +- drivers/net/wireless/realtek/rtlwifi/pci.c

[PATCH 5/5] realtek: rtlwifi: drivers: Use the rtl_btc convenience macro

Convert the uses of the btcoexist. to the rtl_btc macro to save a few lines of code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 3 +-- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 4 +--- drivers/net/wireless/r

Re: [RFC] networking: add and use skb_put_u8()

On Fri, 2017-06-16 at 05:04 -0700, Joe Perches wrote: > Perhaps > > skb_put_data(skb, , sizeof(c)) > > as that avoids api expansion. Hmm. Perhaps not. That wouldn't work very well for constants when some variant like skb_putchar/skb_put_u8 works perfectly. I still th

Re: [RFC] networking: add and use skb_put_u8()

On Fri, 2017-06-16 at 12:22 +0200, Johannes Berg wrote: > On Fri, 2017-06-16 at 12:16 +0200, Arend van Spriel wrote: > > > > >  @@ > > >  expression SKB, C, S; > > >  typedef u8; > > >  identifier fn = {skb_put}; > > >  fresh identifier fn2 = fn ## "_u8"; > > >  @@ > > >   

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

On Thu, 2017-06-01 at 12:46 +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Add maintainers entry for ks7010. [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -7429,6 +7429,13 @@ F: Documentation/auxdisplay/ks0108 > > F:

Re: [v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets

On Fri, 2017-05-12 at 15:20 +, Kalle Valo wrote: > Kalle Valo writes: > Here's the diff between v5 and v6: trivia: > diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c [] > @@ -93,9 +94,11 @@

Re: [PATCH] libertas: Avoid reading past end of buffer

On Wed, 2017-05-10 at 12:24 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. another bit of trivia: > diff --git

Re: [PATCH] libertas: Avoid reading past end of buffer

On Wed, 2017-05-10 at 12:24 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means [] > diff --git a/drivers/net/wireless/marvell/libertas/mesh.c > b/drivers/net/wireless/marvell/libertas/mesh.c [] > @@ -1170,17 +1170,11 @@ int

Re: [PATCH] libertas: Avoid reading past end of buffer

On Tue, 2017-05-09 at 16:23 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, use strncpy() which will fill the trailing bytes > with zeros.

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

On Fri, 2017-05-05 at 11:39 +0200, Johannes Berg wrote: > On Fri, 2017-05-05 at 02:34 -0700, Joe Perches wrote: > > On Fri, 2017-05-05 at 11:06 +0200, Johannes Berg wrote: > > > > o Use explicit casts to proper types instead of casts to (void *) > > > >   and have

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

On Fri, 2017-05-05 at 11:06 +0200, Johannes Berg wrote: > > o Use explicit casts to proper types instead of casts to (void *) > >   and have the compiler do the implicit cast > > I see no advantage in this, why? All it does is make the code longer, > and if anything changes, you have to change it

Re: [PATCH 12/13] rtlwifi: btcoex: 21a 1ant: fix some coding style issues

On Mon, 2017-04-17 at 12:13 -0500, Larry Finger wrote: > On 04/17/2017 11:09 AM, Joe Perches wrote: > > On Sun, 2017-04-16 at 19:06 -0500, Larry Finger wrote: > > > From: Yan-Hsuan Chuang <yhchu...@realtek.com> > > > > > > Fix alignment fo

Re: [PATCH 12/13] rtlwifi: btcoex: 21a 1ant: fix some coding style issues

On Sun, 2017-04-16 at 19:06 -0500, Larry Finger wrote: > From: Yan-Hsuan Chuang > > Fix alignment for coding style consistency. aside: Are all the btcoexist variants for this code identical? 8192e2ant.c 8723b1ant.c 8723b2ant.c 8821a1ant.c 8821a2ant.c Maybe some of these

Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

On Thu, 2017-04-06 at 16:54 -0700, Matthias Kaehlcke wrote: > Hi Joe, > > El Thu, Apr 06, 2017 at 02:29:20PM -0700 Joe Perches ha dit: > > > On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > > > The macro results are assigned to u8 variables/fields. Adding

Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > The macro results are assigned to u8 variables/fields. Adding the cast > fixes plenty of clang warnings about "implicit conversion from 'int' to > 'u8'". > > Signed-off-by: Matthias Kaehlcke > --- >

Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'

On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in wl1271_warning error message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/ti/wlcore/debugfs.c | 2 +- > 1

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: > On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches <j...@perches.com> wrote: > > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > > > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches <j...@perches.com>

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: > On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches <j...@perches.com> wrote: > > Fix fallout too. [] > My only question is why bother doing a format check on something > that's going to be compiled out anyway? To avoid int

[PATCH] ath6kl: Add __printf verification to ath6kl_dbg

Fix fallout too. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

On Wed, 2017-03-08 at 17:57 +0100, Hans de Goede wrote: > Hi, And hello back to you. > On 08-03-17 17:34, Joe Perches wrote: > > On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: > > > Using pr_err for things which are not errors is a bad idea. E.g. it > >

Re: [PATCH v3] brcmfmac: Do not print the firmware version as an error

On Wed, 2017-03-08 at 09:23 +0100, Hans de Goede wrote: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > >

Re: [PATCH 24/26] ocfs2: reduce stack size with KASAN

On Thu, 2017-03-02 at 23:59 +0100, Arnd Bergmann wrote: > KASAN decides that passing a pointer to _m into an extern function > (_mlog_printk) is potentially dangerous, as that function might > keep a reference to that pointer after it goes out of scope, > or it might not know the correct length of

Re: [PATCH 24/26] ocfs2: reduce stack size with KASAN

On Thu, 2017-03-02 at 23:22 +0100, Arnd Bergmann wrote: > On Thu, Mar 2, 2017 at 6:46 PM, Joe Perches <j...@perches.com> wrote: > > On Thu, 2017-03-02 at 17:38 +0100, Arnd Bergmann wrote: > > > The internal logging infrastructure in ocfs2 causes special warning code

Re: [PATCH 24/26] ocfs2: reduce stack size with KASAN

essing that the resulting code is comparable to what it was before. > > The current version was introduced by Joe Perches as an optimization, maybe > he can see if my change regresses compared to his. I don't see it. > Cc: Joe Perches <j...@perches.com> > Fixes: 7c2bd2f930ae (&qu

Re: [PATCH v2 3/4] mac80211-hwsim: add rate-limited debugging for rx-netlink

On Mon, 2017-02-27 at 13:56 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > This makes it easier to understand why wmediumd (or similar) > is getting errors when sending frames to the kernel. > > Signed-off-by: Ben Greear > --- >

Re: [PATCH v2] ath10k: Remove return statement from a void function

On Wed, 2017-02-22 at 20:54 +0100, Arend Van Spriel wrote: > > On 21-2-2017 11:28, Marcin Rokicki wrote: > > The empty 'return;' statement in a void function should be > > used to return from somewhere else than the end. > > > > Signed-off-by: Marcin Rokicki > > --- >

Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full

On Wed, 2017-02-22 at 20:50 +0100, Arend Van Spriel wrote: > On 22-2-2017 18:14, Tahia Khan wrote: > > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl: [] > Just a generic remark that may help you with other changes you will be > making in the linux kernel. Warnings from

Re: [PATCH] ath10k: Modify macros to fix style issues

(fyi Marcin, the reason this isn't getting on the list is because your 3 tries have all included text and html) On Wed, 2017-02-22 at 14:31 +0100, Marcin Rokicki wrote: > > > > Here is an alternate style used a few times in the kernel > > > > Maybe it'd be nicer to change the macros to

  1   2   3   >