[PATCH][BUG] rtlwifi: rtl_pci_probe: Fix fail path of _rtl_pci_find_adapter

kernel NULL pointer dereference at (null) [4.493067] IP: rtl_deinit_core+0x31/0x90 [rtlwifi] Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- Although this is the first time I have encounted this bug in 4.13-rc1 there are some historica

[PATCH 2/2] staging: rtl8192e: remove dead code rtllib_wpa_supplicant_ioctl

, rtllib_wpa_set_encryption and rtllib_wpa_supplicant_ioctl. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtllib.h | 54 - drivers/staging/rtl8192e/rtllib_softmac.c | 383 -- 2 files changed, 437 deletions(-) diff --git a/drivers/s

[PATCH 1/2] staging: rtl8192e: remove dead private call to _rtl92e_ioctl.

A RTL_IOCTL_WPA_SUPPLICANT call is a proprietary version of wpa supplicant. All kernel calls use SIOCSIWENCODEEXT call via wireless handlers already used in this driver. Remove dead code. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtl8192e/rtl_

[PATCH 4/5] staging: rtl8192e: Let user know mac address associated with.

User cannot tell which mac address(BSIDD) associated with so add this to info message. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rt

[PATCH 5/5] staging: rtl8192e: _rtl92e_dm_check_edca_turbo remove peername message.

This kinda reports this as if it was an error message. Now that bssid is reported at associate remove this piece of code serves no purpose as there is no code for peers so remove it. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.

[PATCH 3/5] staging: rtl8192e: HTSetConnectBwMode message replace with debug.

The flag status of bCurBW40MHz is printed as info and is only useful as debug message. Replace with netdev_dbg in line with rest of driver. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH 2/5] staging: rtl8192e: print alg name as debug.

alg name will be printed a number times during a connection it is only really useful as a debug message. Change to netdev_dbg. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/5] staging: rtl8192e: Remove RX: IEEE802.1X EAPOL frame! warning.

RX will receive countless EAPOL frames over the life of the connection. A number of conditional calls to rtllib_is_eapol_frame are made in this function. So this call serves no purpose other than to spam logs with false warning that it is indeed a EAPOL frame, remove it. Signed-off-by: Malcolm

[PATCH v2 1/4] staging: rtl8192e: rtl92e_fill_tx_desc fix write to mapped out memory.

The driver attempts to alter memory that is mapped to PCI device. This is because tx_fwinfo_8190pci points to skb->data Move the pci_map_single to when completed buffer is ready to be mapped with psdec is empty to drop on mapping error. Signed-off-by: Malcolm Priestley <tvbox...@gmail.c

[PATCH v2 3/4] staging: rtl8192e: rtl92e_get_eeprom_size Fix read size of EPROM_CMD.

EPROM_CMD is 2 byte aligned on PCI map so calling with rtl92e_readl will return invalid data so use rtl92e_readw. The device is unable to select the right eeprom type. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- v2 - Fix typo in subject l

[PATCH 4/4] staging: rtl8192e: GetTs Fix invalid TID 7 warning.

TID 7 is a valid value for QoS IEEE 802.11e. The switch statement that follows states 7 is valid. Remove function IsACValid and use the default case to filter invalid TIDs. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- drivers/stag

[PATCH v2 2/4] staging: rtl8192e: fix 2 byte alignment of register BSSIDR.

BSSIDR has two byte alignment on PCI ioremap correct the write by swapping to 16 bits first. This fixes a problem that the device associates fail because the filter is not set correctly. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- v

[PATCH 2/3] staging: rtl8192e: fix 2 byte alignment of register BSSIR.

BSSID has two byte alignment on PCI ioremap correct the write by swapping to 16 bits first. This fixes a problem that the device associates fail because the filter is not set correctly. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- dri

[PATCH 3/3] staging: rtl8192e rtl92e_get_eeprom_size Fix read size of EPROM_CMD.

EPROM_CMD is 2 byte aligned on PCI map so calling with rtl92e_readl will return invalid data so use rtl92e_readw. The device is unable to select the right eeprom type. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- drivers/staging/rtl81

[PATCH 1/3] staging: rtl8192e rtl92e_fill_tx_desc fix write to mapped out memory.

off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl819

[PATCH 3/4] staging: vt6556: vnt_start Fix missing call to vnt_key_init_table.

The key table is not intialized correctly without this call. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> # v3.17+ --- drivers/staging/vt6656/main_usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/vt6656/main_usb.

[PATCH 4/4] staging: vt6656: Only call vnt_set_bss_mode on basic rates change.

To ensure the bss is always synchronized only call on basic rate change. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/main_usb.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/d

[PATCH 1/4] staging: vt6656: vnt_update_ifs set max_min based on short slot time.

Short slot time is controlled by mac80211 so there is no need to find odfm rates. Merge PK_TYPE_11B and PK_TYPE_11GA & PK_TYPE_11GB into one else and switch on short slot time. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/c

[PATCH 2/4] staging: vt6656: always call vnt_update_ifs on short time change.

short time change needs to synchronize parameters in vnt_update_ifs so a call to the function is always necessary. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/main_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6656/main_us

[PATCH 2/2] staging: vt6656: use off stack for in buffer USB transfers.

Since 4.9 mandated USB buffers to be heap allocated. This causes the driver to fail. Create buffer for USB transfers. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <sta...@vger.kernel.org> # v4.9+ --- drivers/staging/vt6656/usbpipe.c | 17 +++-- 1 file

[PATCH 06/13] staging: vt6655: mac.c replace VNSvOutPortB with iowrite8

removing macro from functions Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655

[PATCH 12/13] staging: vt6655: mac.c replace wOffset with offset.

Removing camel case and type prefix. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655

[PATCH 10/13] staging: vt6655: mac Replace dwCurrDescAddr with curr_desc_addr.

Removing camel case and type prefix. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 30 +++--- drivers/staging/vt6655/mac.h | 14 +++--- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/s

[PATCH 08/13] staging: vt6655: MACvSetLoopbackMode replace byOrgValue with ioread8

Removing VNSvInPortB and nesting inside iowrite8. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index 6499709..e

[PATCH 02/13] staging: vt6655: MACvRestoreContext replace for loops with memcpy_toio.

Removing the need for variable ii. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index 9c4dabd..0

[PATCH 05/13] staging: vt6655: mac.c replace VNSvOutPortW with iowrite16

removig macro from functions. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index a9ddb95..4

[PATCH 04/13] staging: vt6655: mac.c replace VNSvOutPortD with iowrite32.

Removing the macro from functions. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 52 +--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655

[PATCH 13/13] staging: vt6655: mac.c replace dwData with data.

Removing camel case and type prefix. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655

[PATCH 07/13] staging: vt6655: MACbPSWakeup replace VNSvInPortB byOrgValue with ioread8

removing byOrgValue variable. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index a1be5a7..6499709 100644 --- a/d

[PATCH 09/13] staging: vt6655: mac.c replace VNSvInPortB with ioread8

Removing the macro from functions. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index ece2bf0..a1be62d

[PATCH 01/13] staging: vt6655: mac.c rename pbyCxtBuf to cxt_buf

Removing camel case and type prefix. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- Following on from patch MACvSaveContext use memcpy_fromio to read context. drivers/staging/vt6655/mac.c | 32 1 file changed, 16 insertions(+), 16 deletions(-)

[PATCH 03/13] staging: vt6655: mac.c/h resize all unsigned long to u32

All addressing is limited to 32 bits match this to all functions and port out functions. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 22 +++--- drivers/staging/vt6655/mac.h | 16 2 files changed, 19 insertions(

[PATCH 3/4] staging: vt6655: replace VNSvInPortD dwData reads with ioread32

Removing dwData variable altogether. The reads are always 32 bit insize. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/s

[PATCH 4/4] staging: vt6655: MACvSaveContext use memcpy_fromio to read context.

Use memcpy_fromio to store data removing the need for local count. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c

[PATCH 2/4] staging: vt6655: mac.c Replace VNSvInPortB byData reads with ioread8.

Removing byData variable altogether. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 36 +--- 1 file changed, 9 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c

[PATCH 1/4] staging: vt6655: mac.c rename dwIoBase to io_base

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/mac.c | 274 +-- 1 file changed, 137 insertions(+), 137 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c

[PATCH 7/8] staging: vt6655: PSbIsNextTBTTWakeUp Rename bWakeUp wake_up

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/power.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c index ad44746..5e968c9 100644 --- a/d

[PATCH 3/8] staging: vt6655: set_channel replace bResult with ret

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/channel.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c index d1c9116..9ac1ef9

[PATCH 8/8] staging: vt6655: mac.c replace void __iomem * with struct vnt_private

MACvSetKeyEntry MACvDisableKeyEntry Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/card.c| 18 ++ drivers/staging/vt6655/device_main.c | 24 drivers/staging/vt6655/key.c | 8 +-- drivers/staging/vt6655/mac.c

[PATCH 6/8] staging: vt6655: rf.c/h Replace DeviceContext with vnt_private

Removing void and including device.h for power.h Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/power.c | 10 +++--- drivers/staging/vt6655/power.h | 8 +--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/p

[PATCH 4/8] staging: vt6655: rf.c rename bResult ret.

Removing camel case and reflecting return value. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/rf.c | 138 ++-- 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/drivers/staging/vt6655/rf.c b/drivers/s

[PATCH 5/8] staging: vt6655: power.c replace pDevice with priv

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/power.c | 56 +- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c

[PATCH 2/8] staging: vt6655: set_channel replace void handler.

Replace with struct vnt_private. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/channel.c | 3 +-- drivers/staging/vt6655/channel.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/

[PATCH 1/8] staging: vt6655: channel.c replace pDevice with priv

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/channel.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c

[PATCH 6/9] staging: vt6655: remove static inline alloc_rd_info.

Since this only contains one function and only used twice remove inline altogether. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 5 - drivers/staging/vt6655/device_main.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-)

[PATCH 4/9] staging: vt6655: device.h remove typedef enum

Covert values to macros. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index be6c42b..83bb68b

[PATCH 9/9] staging: vt6655: card.c rename pDevice with priv

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/card.c | 386 +- 1 file changed, 193 insertions(+), 193 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c

[PATCH 3/9] staging: vt6655: device.h remove unsed headers.

Most of these headers rate to old api that are no longer used in driver. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/

[PATCH 8/9] staging: vt6655: rename pOpts and sOpts to opts.

bring pointers and members into line. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/card.c| 8 +-- drivers/staging/vt6655/device.h | 4 +- drivers/staging/vt6655/device_main.c | 108 +-- 3 files chang

[PATCH 2/9] staging: vt6655: device.h remove unused macros.

None of these are used in driver anymore. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 64 - 1 file changed, 64 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/de

[PATCH 1/9] staging: vt6655: device_main Replace uIdx with idx.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c

[PATCH 5/6] staging: vt6655: device_main replace pTDInfo with td_info.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 7

[PATCH 3/6] staging: vt6655: device_alloc_rx_buf replace pRDInfo with rd_info.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 41c08b3..b

[PATCH 1/6] staging: vt6655: device_main replace pDevice with priv.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 588 +-- 1 file changed, 292 insertions(+), 296 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/

[PATCH 2/6] staging: vt6655: device_main.c replace pDesc with desc.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 80 ++-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/

[PATCH 6/6] staging: vt6655: device_tx_srv rename pTD

Following the convention elsewhere for vnt_tx_desc rename desc. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6655/device_mai

[PATCH 4/6] staging: vt6655: device_main replace pRD with rd.

Removing camel case. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_

[PATCH 2/6] staging: vt6656: implement TSF counter

The TSF counter is presently unused on driver in infrastructure mode. It is needed to implement power saving functions and wireless stats that are passed in interrupt handling. Ensuring counter is synced with access point beacon. Signed-off-by: Malcolm Priestley <tvbox...@gmail.

[PATCH 1/6] staging: vt6655: don't stop TX queue unless buffer full.

. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 326bce3..07ebdea 100644 --- a/drivers/s

[PATCH 3/6] staging: vt6656: implement power saving code.

. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/device.h | 2 ++ drivers/staging/vt6656/int.c| 14 +++--- drivers/staging/vt6656/power.c | 2 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/d

[PATCH 5/6] staging: vt6656: don't stop TX queue unless buffer full.

is available. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/main_usb.c | 7 +-- drivers/staging/vt6656/rxtx.c | 5 - 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c

[PATCH 4/6] staging: vt6656: implement power saving.

The device can now operate in low power mode Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6656/main_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 7246c76..3fc6862

[PATCH 6/6] staging: vt6656: remove RX complete locking.

The lock in vnt_submit_rx_urb_complete is blocked by TX activity. The lock comes from a time when RX needed to be synchronized with other parts of the driver because the WLAN API was in driver. Since this is now dealt with in mac80211 the lock is unnecessary. Signed-off-by: Malcolm Priestley

[PATCH 02/11] staging: vt6655: remove get_chip_name and info message.

This prints "VIA Networking Solomon-A/B/G Wireless LAN Adapter" which has already printed once in vt6655_probe. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 12 1 file changed, 12 deletions(-) diff --git a/driver

[PATCH 08/11] staging: vt6655: device_get_pci_info remove variable cis_addr.

cis_addr is never used remove its call to pci_resource_start. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c

[PATCH 03/11] staging: vt6655: Remove typedef struct __chip_info_tbl

Only two values that are assigned from this table. DEVICE_FLAGS_TX_ALIGN and the value of io_size which is used as the size of ioremap which is 256. Remove all variables, DEVICE_FLAGS_TX_ALIGN check, apply io_size value and chip_info_table. Signed-off-by: Malcolm Priestley <tvbox...@gmail.

[PATCH 04/11] staging: vt6655: remove unused multicast_limit.

multicast_limit is assigned a vale that is never used. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 1 - drivers/staging/vt6655/device_main.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/s

[PATCH 10/11] staging: vt6655: device_get_pci_info pcid already assigned.

pcid has already been assigned earlier in vt6655_probe. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index e

[PATCH 09/11] staging: vt6655: device_get_pci_info remove call to set master.

a call to PCI_COMMAND is used to set master. However, a call to pci_set_master earlier in function which does the same thing. So remove the calls and variable b. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 5 - 1 file chan

[PATCH 07/11] staging: vt6655: device_get_pci_info remove unused pci_read_config_*

These values are read from pci but never used. Removing variables byRevId, SubSystemID, SubVendorID and pci_cmd. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device.h | 3 --- drivers/staging/vt6655/device_main.c | 9 - 2 files chang

[PATCH 11/11] staging: vt6655: Move code in device_get_pci_info

Function always returns true and now only a few lines move to vt6655_probe. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/staging/

[PATCH 01/11] staging: vt6655: vt6655_probe remove PCI debug info

Remove unnecessary debug PCI info that can be obtained by lspci. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 46 1 file changed, 46 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/d

[PATCH 06/11] staging: vt6655: remove and move vt6655_init_info

move code to vt6655_probe. Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> --- drivers/staging/vt6655/device_main.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 0

[PATCH 3/4] staging: vt6655: replace typedef struct tagDEVICE_RD_INFO

with struct vnt_rd_info volatile is removed because it will generate a warning (in any case this member is not) and renaming rd_info. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h| 6 +++--- drivers/staging/vt6655/device.h | 4 ++-- drivers

[PATCH 4/4] staging: vt6655: replace typedef struct tagSRxDesc

with struct vnt_rx_desc and all members the same. volatile is removed from pointers as this generates warning message. Only the first four members of vnt_rx_desc need to be volatile. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c| 2 +- drivers

[PATCH 1/4] staging: vt6655: replace typedef struct tagRDES0

with struct vnt_rdes0 replacing members as follows wResCount - res_count f15Reserved - f15_reserved f1Owner - owner big endian f8Reserved1 - f8_reserved1 f7Reserved - f7_reserved Narrowing endian differences to inside structure. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers

[PATCH 2/4] staging: vt6655: replace typedef struct tagRDES1

with struct vnt_rdes1 and members wReqCount - req_count wReserved - reserved Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c| 4 ++-- drivers/staging/vt6655/desc.h| 11 +-- drivers/staging/vt6655/device_main.c | 2 +- drivers

[PATCH 2/6] staging: vt6655: replaced typedef struct tagTDES1

Create struct vnt_tdes1 that replaces members wReqCount - req_count byTCR - tcr byReserved - reserved Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h| 13 ++--- drivers/staging/vt6655/device_main.c | 9 - 2 files changed, 10

[PATCH 5/6] staging: vt6655: replace typedef struct tagDEVICE_TD_INFO and structure

Create struct vnt_td_info with members mic_hdr skb buf buf_dma dwReqCount - req_count byFlags - flags In struct tagSTxDesc volatile is removed because it will generate a warning (in any case this member is not) and renaming td_info. Signed-off-by: Malcolm Priestley tvbox...@gmail.com

[PATCH 4/6] staging: vt6655: struct tagDEVICE_TD_INFO remove dwHeaderLength

dwHeaderLength is assigned a value but that is never used. Remove variable. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 1 - drivers/staging/vt6655/rxtx.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers

[PATCH 1/6] staging: vt6655: desc.h replace typedef struct tagTDES0

create struct vnt_tdes0 replacing used members byTSR0 - tsr0 byTSR1 - tsr1 f1Owner - owner Narrowing endian differences to inside structure. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c| 4 ++-- drivers/staging/vt6655/desc.h| 36

[PATCH] staging: vt6655: vnt_bss_info_changed check conf-beacon_rate is not NULL

conf-beacon_rate can be NULL on association. So check conf-beacon_rate BSS_CHANGED_BEACON_INFO needs to flagged in changed as the beacon_rate will appear later. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: sta...@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 5

[PATCH 03/15] staging: vt6655: dead code tx path remove dma_unmap_single

When pTDInfo-skb_dma not equal to pTDInfo-buf_dma, pTDInfo-skb_dma equals zero. as mentioned in comment pre-allocated buf_dma can't be unmapped so remove dead code. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 14 -- 1 file changed

[PATCH 07/15] staging: vt6655: fix tagSTxDesc - next_desc type

Should always be __le32 type Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 8dc53bd..26cd3e1 100644 --- a/drivers/staging

[PATCH 11/15] staging: vt6655: Fix wReqCount to __le16

Should be __le16 and do and correct endian conversion. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/card.c | 8 drivers/staging/vt6655/desc.h | 6 +++--- drivers/staging/vt6655/dpc.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 09/15] staging: vt6655: Fix tagSRxDesc - buff_addr type

Should always be __le32. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 3302d0182..42e005a 100644 --- a/drivers/staging

[PATCH 10/15] staging: vt6655: fix tagSRxDesc - next_desc type

Should always be __le32 Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 42e005a..251f7bc 100644 --- a/drivers/staging

[PATCH 12/15] staging: vt6655: fix tagTDES1 - wReqCount type

should be __le16 Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index f6563d3..2374fa5 100644 --- a/drivers/staging/vt6655

[PATCH 15/15] staging: vt6655: desc.h remove dead strctures

Remove these unsed structures. typedef struct tagSTxSyncDesc typedef struct tagSRrvTime_atim typedef struct tagSTxBufHead typedef struct tagSBEACONCtl typedef struct tagSSecretKey typedef struct tagSKeyEntry Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h

[PATCH 04/15] staging: vt6655: remove unnecessary variable skb_dma

skb_dma flips from 0 to the contents buf_dma. This is nolonger necessary so use buf_dma directly and remove skb_dma altogether. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h| 1 - drivers/staging/vt6655/device_main.c | 3 +-- drivers/staging

[PATCH 01/15] staging: vt6655: Remove ununsed macro ASSERT

VIAWET_DEBUG is not defined so macro is empty. Remove the macro. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/baseband.c| 4 +--- drivers/staging/vt6655/card.c| 1 - drivers/staging/vt6655/device_cfg.h | 9 - drivers/staging/vt6655

[PATCH 02/15] staging: vt6655: remove unused DBG_PORT80 and VIAWET_DEBUG

VIAWET_DEBUG is never defined so DBG_PORT80 is empty and never used. Remove both macros. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/baseband.c | 2 -- drivers/staging/vt6655/device_cfg.h | 6 -- drivers/staging/vt6655/mac.c| 17

[PATCH 13/15] staging: vt6655: always set 32 bit dma mask

The device is limited to 32 bit address space. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index c82bf48

[PATCH 08/15] staging: vt6655: remove unused tagDEVICE_RD_INFO - curr_desc

variable is assigned a value that is never used. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h| 1 - drivers/staging/vt6655/device_main.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655

[PATCH 14/15] staging: vt6655: s_cbFillTxBufHead replace STxBufHead

vnt_tx_fifo_head has now replaced STxBufHead Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 82380f3..380b879 100644

[PATCH 06/15] staging: vt6655: fix tagDEVICE_TD_INFO - buff_addr type

Should always be __le32 type Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 485c6fd..8dc53bd 100644 --- a/drivers/staging

[PATCH 05/15] staging: vt6655: Remove unused tagDEVICE_TD_INFO curr_desc

The variable is assigned a value that is never used. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/desc.h| 1 - drivers/staging/vt6655/device_main.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging

[PATCH 2/4 v2] staging: vt6655: Fix missing power saving support

Add IEEE80211_HW_SUPPORTS_PS to ieee80211_hw flags enabling this feature. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- v2 rebased for 4.2 drivers/staging/vt6655/device_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging

[PATCH 1/4] staging: vt6655: check ieee80211_bss_conf bssid not NULL

Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: sta...@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers

[PATCH] staging: vt6656: check ieee80211_bss_conf bssid not NULL

Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: sta...@vger.kernel.org # v3.17+ --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers

  1   2   3   >