Re: [PATCH] mac80211: debugfs var for the default aggregation timeout.

2016-02-16 Thread Sujith Manoharan
Avery Pennarun wrote: > Since around the beginning of time, ath9k aggregates have timed out after > 5000 TU (around 5000ms) of inactivity, but nobody seems to be quite sure > why, and this magic number seems to have migrated around from one place to > another. An openbsd mailing list recently had

Re: [PATCH] ath9k_htc: use ether_addr_copy() instead of memcpy()

2015-09-23 Thread Sujith Manoharan
Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel > --- > drivers/net/wireless/ath/ath9k/htc_drv_init.c | 2 +- > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 24 > 2 files changed, 13 insertions(+), 13 deletions(-) Both the arguments for

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-09-04 Thread Sujith Manoharan
Jes Sorensen wrote: > > Ah, this makes sense. There's an rc_update call or something like that, > > that might have the requisite information. Not really sure off the top > > of my head. ieee80211_sta doesn't contain the preamble information, though ? The bss information holds the short preamble

Re: [PATCH v2 2/2] ath9k: fix incorrect calibration initial for ar9561

2015-08-19 Thread Sujith Manoharan
miaoq...@qti.qualcomm.com wrote: - if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah)) + if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah) || + AR_SREV_9561(ah)) priv_ops-init_cal = ar9003_hw_init_cal_pcoem; else

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Janusz Dziedzic wrote: mac80211 configure rxfilter per HW, so we don't need this per channel. This fix problem when chanctx used and ath9k allocate new ath_chanctx. Then we loose rxfilter configuration. Eg. during p2p_find (when use_chanctx=1) during remain on channel, driver create new

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Felix Fietkau wrote: The filter is intended to be global in the mac80211 API. Treating it as per channel-context inside the driver is a bug. Agreed. Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More

Re: [RFCv2] ath9k: make rxfilter per HW

2015-06-17 Thread Sujith Manoharan
Janusz Dziedzic wrote: This is what I have with use_chanctx=1 Jun 17 06:57:54 dell6430 kernel: [53297.753256] xxx ath_calcrxfilter filter: 0x207 0x00080 is for probe_req Ok, so the probe_req filter is set before actually initiating RoC - this appears to be the current design in wpa_s.

Re: [RFC] ath9k: advertise p2p dev support when chanctx

2015-06-15 Thread Sujith Manoharan
Janusz Dziedzic wrote: Add p2p dev support when ath9k loaded with use_chanctx=1. This will fix problem, when first interface is an AP and next we would like to run p2p_find. Before p2p scan failed. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com --- @Felix, Sujith please review.

Re: [RFC] ath9k: allow to receive probe request when offchannel

2015-06-15 Thread Sujith Manoharan
Janusz Dziedzic wrote: case ATH_OFFCHANNEL_ROC_START: + /* Allow to receive probe requests */ + rfilt = ath_calcrxfilter(sc); + rfilt |= ATH9K_RX_FILTER_PROBEREQ; + ath9k_hw_setrxfilter(sc-sc_ah, rfilt); +

Re: [RFC] ath9k: advertise p2p dev support when chanctx

2015-06-15 Thread Sujith Manoharan
Janusz Dziedzic wrote: At least the callbacks for adding/removing interfaces need to be handled ? Strange, but I didn't hit any problem yet with my simple patch. Ok. But I am not very familiar with how p2p-device is supposed to be used... Sujith -- To unsubscribe from this list: send the

Re: ath10k to ath9k IBSS, ath9k has interface-combinations issue

2015-04-24 Thread Sujith Manoharan
Ben Greear wrote: TSF would jump around since the HW would sync with the received beacons and this will happen in both IBSS and station mode. Hence the limitation, but I think OpenWrt has a one-liner to remove this restriction... It seems I can only do a single VAP on ath9k as well?

Re: ath10k to ath9k IBSS, ath9k has interface-combinations issue

2015-04-07 Thread Sujith Manoharan
Ben Greear wrote: For the third set, why limit to a single interface. Can't we run IBSS + AP (and plus stations, for that matter), all at the same time with ath9k? TSF would jump around since the HW would sync with the received beacons and this will happen in both IBSS and station mode. Hence

Re: [PATCH 3/4] ath10k: Fix no-ack frame status

2015-04-02 Thread Sujith Manoharan
Kalle Valo wrote: https://patchwork.kernel.org/patch/5470621/ Naturally I did forget this :) But the patch is in pending branch now. Thanks... Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 02/11] ath9k: Register private AIC ops

2015-03-20 Thread Sujith Manoharan
Kalle Valo wrote: I guess you already saw the error from kbuild: ERROR: ar9003_hw_attach_aic_ops [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined! Can you send a fix for this, please? This slipped through the radar... I've posted a patch:

[PATCH] ath9k: Fix compilation error

2015-03-20 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com AIC needs to be registered only when BTCOEX is enabled. This fixes the error reported by kbuild: ERROR: ar9003_hw_attach_aic_ops [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined! Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com

Re: [PATCH 0/5] ath9k patches

2015-03-13 Thread Sujith Manoharan
Felix Fietkau wrote: It's probably enough to just change struct ath_aic_sram_info to make it fit: Just put the bool fields together and make them single-bit. This should save more than 300 bytes. Yes, that works too. Thanks. Sujith -- To unsubscribe from this list: send the line unsubscribe

[PATCH 3/4] ath9k: Handle MCI_STATE_AIC_CAL

2015-03-12 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Add the main AIC calibration function to handle MCI_STATE_AIC_CAL. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 28 ++-- drivers/net/wireless/ath/ath9k

[PATCH 4/4] ath9k: Start AIC calibration during MCI reset

2015-03-12 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com When a MCI reset is done, make sure that AIC is started. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_mci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath

[PATCH 1/4] ath9k: Handle MCI_STATE_AIC_CAL_RESET

2015-03-12 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Add a routine to handle the MCI_STATE_AIC_CAL_RESET message. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 8 drivers/net/wireless/ath/ath9k/ar9003_aic.h | 1 + drivers/net

[PATCH 2/4] ath9k: Handle MCI_STATE_AIC_START

2015-03-12 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch adds a function to handle the MCI message MCI_STATE_AIC_START. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 33 + drivers/net/wireless/ath/ath9k

[PATCH 6/7] ath9k: Process the AIC calibration results

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch adds support for post-processing the AIC calibration results. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 245 1 file changed, 245 insertions

[PATCH 2/7] ath9k: Register private AIC ops

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com AIC can be disabled or enabled on a per-card basis using MCI configuration, so register a function to check its status. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/Makefile | 3 ++- drivers

[PATCH 7/7] ath9k: Disable AIC by default

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Since various MCI messages need to be handled, along with driver-level support in upper layers, disable AIC for now. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 6 ++ drivers/net

[PATCH 5/7] ath9k: Finish AIC calibration

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Set the appropriate bits in the HW after AIC calibration is done. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 78 - 1 file changed, 77 insertions(+), 1

[PATCH 3/7] ath9k: Add register definitions for AIC

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Various registers to control and check AIC status. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 1 + drivers/net/wireless/ath/ath9k/ar9003_phy.h | 25 - drivers/net/wireless

[PATCH 0/7] ath9k patches

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This series adds initial support for AIC. Active Interference Cancellation is a method implemented in the HW to counter WLAN RX sensitivity degradation when BT is transmitting at the same time. This feature is supported by cards like WB222 based

Re: [PATCH 0/7] ath9k patches

2015-03-10 Thread Sujith Manoharan
Hi Kalle, Sorry, I forgot to mention that this is intended for -next. Sujith Sujith Manoharan wrote: From: Sujith Manoharan c_man...@qca.qualcomm.com This series adds initial support for AIC. Active Interference Cancellation is a method implemented in the HW to counter WLAN RX

[PATCH 4/7] ath9k: Handle MCI_STATE_AIC_CAL_SINGLE

2015-03-10 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch adds routines to handle the MCI message AIC_CAL_SINGLE, starting the required HW calibration. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_aic.c | 169

[PATCH 4/5] ath9k: Check allowed PCIE powersave configuration

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com When assigning the initvals for PCIE sleep/awake registers, check the configuration that has been assigned to pll_pwrsave during initialization. Also, display a warning if we don't have valid arrays. Signed-off-by: Sujith Manoharan c_man

[PATCH 2/5] ath9k: Fix PLL powersave for AR9485

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Use the value in ah-config.pll_pwrsave to determine which array needs to be loaded. Also, initialize pll_pwrsave to 1 by default. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_hw.c | 10

[PATCH 5/5] ath9k: Fix RTT chainmask usage

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Since the RTT registers need to be configured for all valid chains irrespective of the runtime chainmask, use the actual chainmask of the chip. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k

[PATCH 3/5] ath9k: Initialize pll_pwrsave for AR9462/AR9565

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Cards based on AR9462/AR9565 support more PCIE power save mechanisms, so register them correctly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/hw.c | 3 +++ drivers/net/wireless/ath/ath9k/hw.h

[PATCH 1/5] ath9k: Add PCIE powersave macros

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com These will be used to handle chip-specific power save configuration. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/hw.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless

[PATCH 0/5] ath9k patches

2015-03-09 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com For -next. Sujith Manoharan (5): ath9k: Add PCIE powersave macros ath9k: Fix PLL powersave for AR9485 ath9k: Initialize pll_pwrsave for AR9462/AR9565 ath9k: Check allowed PCIE powersave configuration ath9k: Fix RTT chainmask usage

[PATCH 3/6] ath9k: Fix MCI scheme initialization

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Commit ath9k_hw: remove ATH_BTCOEX_CFG_MCI removed MCI as a separate coex scheme, but we need it to avoid fiddling with GPIO registers during ath9k_init_btcoex() that are meant only for 3-wire cards. Cc: Rajkumar Manoharan rmano

[PATCH 1/6] ath9k: Remove useless return value check

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath_init_btcoex_timer() always returns 0, so checking for error conditions is not required. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/gpio.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH 0/6] ath9k patches

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (6): ath9k: Remove useless return value check ath9k: Initialize MCI state correctly ath9k: Fix MCI scheme initialization ath9k: Fix wlan-active gpio for the AR9003 family ath9k: Handle timers

[PATCH 5/6] ath9k: Handle timers for MCI

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Make sure that the btcoex timers are started/stopped properly for both 3-wire and MCI schemes. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/gpio.c | 52 +-- 1 file

[PATCH 4/6] ath9k: Fix wlan-active gpio for the AR9003 family

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com When disabling BTCOEX, clearing the wlanactive gpio line is required only for pre-AR9003 cards. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/btcoex.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 6/6] ath9k: Fix issues in the main btcoex timer

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com * ath9k_mci_update_rssi() is required only for cards that use MCI scheme. Make sure that it is not called for 3-wire cards. * Call ath9k_ps_wakeup() early since register accesses are made in ath9k_mci_update_rssi(). * Fix usage

[PATCH 2/6] ath9k: Initialize MCI state correctly

2015-02-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The MCI configuration values are assigned in ath9k_hw_btcoex_init_mci() which are used by the MCI reset routine. When initializing BTCOEX/MCI, ath_mci_setup() ends up using uninitialized data. Fix this by setting up the configuration parameters

Re: AR9462 problems connecting again..

2015-02-23 Thread Sujith Manoharan
Jouni Malinen wrote: Even I think that this goes a bit too far especially on 2.4 GHz band, but I would actually consider limiting EAPOL frames to using non-HT/VHT (e.g., 6 Mbps OFDM at least for EAPOL-Key frames) to avoid some interoperability issues. I would say that the current minstrel_ht

Re: [ath9k-devel] AR9462 problems connecting again..

2015-02-22 Thread Sujith Manoharan
Linus Torvalds wrote: 14:07:23.542927: wlp1s0: Event DEAUTH (12) received 14:07:23.542946: wlp1s0: Deauthentication notification 14:07:23.542964: wlp1s0: * reason 2 14:07:23.542982: wlp1s0: * address 20:9f:db:e7:80:80 14:07:23.542997: Deauthentication frame IE(s) - hexdump(len=0): [NULL]

Re: [ath9k-devel] AR9462 problems connecting again..

2015-02-22 Thread Sujith Manoharan
Sujith Manoharan wrote: 'iw dev wlp1s0 set bitrates ht-mcs-2.4 1' would choose a lower rate for the key-exchange frames. Or 'iw dev wlp1s0 set bitrates ht-mcs-2.4 0' to choose the lowest HT rate. Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body

Re: AR9462 problems connecting again..

2015-02-22 Thread Sujith Manoharan
Linus Torvalds wrote: I've got the wpa supplicant log for this timeframe, but I'd rather not send it out in public. I see [REMOVED] for what looks like the key data, but there's a lot of other hex data. Is any of it sensitive? Unless the '-K' option is used with wpa_s, the keys are not

[PATCH 0/9] ath9k patches

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (9): ath9k: Move MCI registers to reg_mci.h ath9k: Remove useless check in MCI reset ath9k: Add new MCI configuration parameters ath9k: Handle 2-ANT AR9565 in MCI reset ath9k: Fix MCI TX control

[PATCH 6/9] ath9k: Setup MCI statistics properly

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Use a subroutine to enable MCI debug statistics if it is present in the global configuration. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_mci.c | 23 --- drivers/net

[PATCH 4/9] ath9k: Handle 2-ANT AR9565 in MCI reset

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The value programmed in the BTCOEX control register is different for each chip. This patch adds support for 2-ANT, 1-ANT solutions based on AR9565. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k

[PATCH 1/9] ath9k: Move MCI registers to reg_mci.h

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/hw.h | 1 + drivers/net/wireless/ath/ath9k/reg.h | 275 drivers/net/wireless/ath/ath9k/reg_mci.h | 300

[PATCH 5/9] ath9k: Fix MCI TX control

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch makes sure that the antenna configuration is used properly when setting AR_MCI_TX_CTRL. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_mci.c | 8 ++-- drivers/net/wireless/ath

[PATCH 9/9] ath9k: Mute BT properly

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Set The BT/WLAN priority weights correctly and make sure that MCI_LNA_TAKE is sent only for cards that share PA/LNA. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_mci.c | 13

[PATCH 8/9] ath9k: Fix GPM initialization

2015-02-15 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Handle MCI_STATE_INIT_GPM_OFFSET separately and do not overload ar9003_mci_get_next_gpm_offset() with a special case. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_mci.c | 27

Re: NULL pointer dereference in ath_isr+0x27/0x250 [ath9k]

2015-02-12 Thread Sujith Manoharan
Davide Pesavento wrote: I have no experience in debugging kernel panics, but running gdb on vmlinux seems to point to the test_bit() call in ath_isr, which dereferences the struct ath_common *common pointer. I looked around a bit and noticed that in ath9k/pci.c:ath_pci_probe(), the

[PATCH 5/7] ath9k: Handle additional patterns on wakeup

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Handle the user-configured patterns in the range 8..15 when waking up and update wow_status correctly. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 16 drivers/net

[PATCH 7/7] ath9k: Restart TSF2 timers on wakeup

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com When coming out of WoW sleep, check and restart timers based on TSF2. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net

[PATCH 4/7] ath9k: Check MCI PowerSave state

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The power save state of MCI has to be disabled when enabling WoW sleep, check this properly. ar9003_mci_state() doesn't handle MCI_STATE_GET_WLAN_PS_STATE right now, but this will be done later when proper support for MCI/PS is added. Signed-off

[PATCH 0/7] ath9k patches

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (7): ath9k: Fix descriptors for keep-alive frame ath9k: Set keep awake timer ath9k: Add new MCI states ath9k: Check MCI PowerSave state ath9k: Handle additional patterns on wakeup ath9k: Clear

[PATCH 1/7] ath9k: Fix descriptors for keep-alive frame

2015-02-04 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Along with AR9462, AR9565 also has an extra field in the TX descriptor which needs to be zeroed out for the keep alive frame. This makes the earlier REG_WRITE redundant, so it can be removed. Signed-off-by: Sujith Manoharan c_man

[PATCH 0/6] ath9k patches

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (6): ath9k: Add support for more WOW patterns ath9k: Register correct WOW details with mac80211 ath9k: Fix issues with WoW enable ath9k: Program AR_WA correctly ath9k: Clear TSF2 properly ath9k

[PATCH 1/6] ath9k: Add support for more WOW patterns

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Newer chips like WB222, WB335 support more than 8 user-configurable patterns. This patch adds support for it by setting up the correct HW registers. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k

[PATCH 2/6] ath9k: Register correct WOW details with mac80211

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Since the number of user patterns is higher for newer chips, make sure that this is registered during initialization. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/wow.c | 16 ++-- 1 file

[PATCH 3/6] ath9k: Fix issues with WoW enable

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch addresses several issues with the ath9k_hw_wow_enable() routine: * The usage of set/clr variables is removed. Writing the required values to registers is cleaner. * The shift value of 28 for the contention window field

[PATCH 6/6] ath9k: Choose correct rate for 2GHz channel

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Set the transmit rate for the keep-alive frames as 1M/CCK when the current channel is in the 2GHz band. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 6 +- 1 file changed, 5

[PATCH 5/6] ath9k: Clear TSF2 properly

2015-02-02 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Chips in the AR9003 family have a second TSF, which needs to be cleared when putting the card to sleep. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 9 + drivers/net/wireless

Re: [PATCH] ath10k: Replace ioread with wmb for data sync

2015-01-30 Thread Sujith Manoharan
Peter Oh wrote: Please refer the email thread that I mentioned about other architectures. (dsb is for ARM and other platforms have the equivalent instruction such as sfence, sync, mf, and dcs). Ok. Also the patch is updated with 2nd patch set replacing wmb to mb. Would be good to test this

Re: [PATCH] ath10k: Replace ioread with wmb for data sync

2015-01-30 Thread Sujith Manoharan
Peter Oh wrote: As I addressed wmb uses dsb (in arm arch) and here is the description of arm architecture. What about other architectures ? Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 00/17] ath9k patches

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (17): ath9k: Remove ATH9K_HW_WOW_DEVICE_CAPABLE ath9k: Return early for error conditions ath9k: Remove redundant device_can_wakeup() check ath9k: Check early for multi-vif/STA conditions ath9k

[PATCH 14/17] ath9k: Move WOW registers to reg_wow.h

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 1 + drivers/net/wireless/ath/ath9k/reg.h| 120 drivers/net/wireless/ath/ath9k/reg_wow.h| 136

[PATCH 03/17] ath9k: Remove redundant device_can_wakeup() check

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com WOW capability is registered with mac80211 only when the device has the ability to wakeup, so there is no need to check in the suspend() routine. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/wow.c

[PATCH 06/17] ath9k: Fix wow init/deinit

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Registering the card as a wakeup source needs to be done once, during initialization. When the WOW configuration changes, the card's status as wakeup source needs to be changed too and this is done via the set_wakeup() callback. Also, make sure

[PATCH 11/17] ath9k: Simplify user pattern configuration

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com There is no need to allocate a new structure and free it for every user pattern, instead use local variables. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ath9k.h | 6 - drivers/net/wireless

[PATCH 13/17] ath9k: Register max WOW patterns

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Since the number of patterns that can be configured in the HW is higher for newer chips, store the chip-specific value in ath9k_hw_wow. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/hw.c | 7

[PATCH 16/17] ath9k: Cleanup reg_wow.h

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com * Remove unnecessary comments. * Remove unused macros. * Indent the macros. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/reg_wow.h | 68 +++- 1 file changed, 15

[PATCH 10/17] ath9k: Add a debugfs file for WOW

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This can be used to force WOW for cards that are not present in the supported PCI ID list. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ath9k.h | 1 + drivers/net/wireless/ath/ath9k/debug.c | 68

[PATCH 05/17] ath9k: Check multi-channel context for WOW

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com If CONFIG_ATH9K_CHANNEL_CONTEXT is enabled, check whether multiple contexts are active and if so, return 1 without enabling WOW since we don't support it in this case. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net

[PATCH 04/17] ath9k: Check early for multi-vif/STA conditions

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com If multiple interfaces are active or there is no associated station interface, bail out early and return 1 so that mac80211 can proceed with the normal suspend routine. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net

[PATCH 12/17] ath9k: Add a HW structure for WOW

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This can be used to hold the WOW state in ath9k_hw. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 10 +- drivers/net/wireless/ath/ath9k/hw.h | 6 +- 2 files

[PATCH 08/17] ath9k: Remove unused BMISS processing

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The various variables tracking bmiss interrupts are not really used anywhere except in a debug message. Remove them since they have no functional purpose. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

[PATCH 09/17] ath9k: Remove ath9k_hw_wow_event_to_string

2015-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com Printing the value of the wakeup status is sufficient. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_wow.c | 15 --- drivers/net/wireless/ath/ath9k/hw.h | 5 - drivers

[PATCH v2 1/6] ath9k: Update QCA953x initvals

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch disables HW peak detect calibration for QCA953x, since it is problematic on a few boards. Instead, manual calibration will be done in the driver. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

Re: [PATCH 3/6] ath9k: Add a macro to identify PCOEM chips

2015-01-28 Thread Sujith Manoharan
Kalle Valo wrote: Kalle, this is a typo - I'll resend the series. Ok. I had actually put these into Not Applicable by accident and that's why I had missed them. Ah ok. I thought I had to enable some patchwork filters manually to see the pending ath9k patches. Sujith -- To unsubscribe from

[PATCH v2 2/6] ath9k: Update AR955x initvals

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch disables HW peak detect calibration for AR955x, since it is problematic on a few boards. Instead, manual calibration will be done in the driver. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

[PATCH v2 4/6] ath9k: Fix manual peak calibration initialization

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The LNA gain setting override needs to be done only for AR9330 and PCOEM chips. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_calib.c | 38 +-- 1 file changed, 30

Re: [PATCH 3/6] ath9k: Add a macro to identify PCOEM chips

2015-01-28 Thread Sujith Manoharan
Sujith Manoharan wrote: #define AR_SREV_9462(_ah) 0 #define AR_SREV_9485(_ah) 0 #define AR_SREV_9565(_ah) 0 +#define AR_SREV_9003_PCOEM(_ah) ) Kalle, this is a typo - I'll resend the series. Sujith -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body

[PATCH v2 5/6] ath9k: Set correct peak detect threshold

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The value is different for PCOEM cards and AR955x/AR953x. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_calib.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH v2 6/6] ath9k: Enable manual peak detect calibration

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com On some AR955x/QCA953x boards, noise floor calibration gets stuck and the cause is a hardware/BB issue. To fix this, peak detect calibration in the HW is disabled and is done in the driver instead. There a few differences with the calibration

[PATCH v2 3/6] ath9k: Add a macro to identify PCOEM chips

2015-01-28 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This can be used if we need to apply register settings for all PCOEM solutions (in the AR9003 family). Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/reg.h | 3 +++ 1 file changed, 3 insertions

Re: [RFC 2/2] mac80211: support RX rate statistics

2015-01-19 Thread Sujith Manoharan
Johannes Berg wrote: Not right now - and there's practically no space left in the rate u16 to store it. Eyal also commented that perhaps not just antennas but also STBC/LDPC/beamforming should be tracked. We can achieve this by increasing the size of the rate field to u32, but then we

[PATCH 3/6] ath9k: Add a macro to identify PCOEM chips

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This can be use if we need to apply register settings for all PCOEM solutions (in the AR9003 family). Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/reg.h | 3 +++ 1 file changed, 3 insertions

[PATCH 1/6] ath9k: Update QCA953x initvals

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com This patch disables HW peak detect calibration for QCA953x, since it is problematic on a few boards. Instead, manual calibration will be done in the driver. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath

[PATCH 6/6] ath9k: Enable manual peak detect calibration

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com On some AR955x/QCA953x boards, noise floor calibration gets stuck and the cause is a hardware/BB issue. To fix this, peak detect calibration in the HW is disabled and is done in the driver instead. There a few differences with the calibration

[PATCH 5/6] ath9k: Set correct peak detect threshold

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The value is different for PCOEM cards and AR955x/AR953x. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_calib.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH 4/6] ath9k: Fix manual peak calibration initialization

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com The LNA gain setting override needs to be done only for AR9330 and PCOEM chips. Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com --- drivers/net/wireless/ath/ath9k/ar9003_calib.c | 38 +-- 1 file changed, 30

[PATCH 0/6] ath9k patches

2015-01-18 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com ath9k patches for -next. Sujith Manoharan (6): ath9k: Update QCA953x initvals ath9k: Update AR955x initvals ath9k: Add a macro to identify PCOEM chips ath9k: Fix manual peak calibration initialization ath9k: Set correct peak detect

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-15 Thread Sujith Manoharan
Kalle Valo wrote: Yeah, but everyone want higher throughput (including me). So what value is best in your opinion? Lower throughput has been okay for all this time, with a value of 16. I suppose the value can be retained to not cause regressions on AP135 or other platforms with a low-powered

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-15 Thread Sujith Manoharan
Kalle Valo wrote: I STILL don't know what values you think people should use with the htt_fill parameter. None. The default stays the same. But, it can be adjusted based on the platform, if higher throughput is desired. Sujith -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 3.19] ath9k: fix race condition in irq processing during hardware reset

2015-01-15 Thread Sujith Manoharan
Felix Fietkau wrote: To fix invalid hardware accesses, the commit ath9k: do not access hardware on IRQs during reset made the irq handler ignore interrupts emitted after queueing a hardware reset (which disables the IRQ). This left a small time window for the IRQ to get re-enabled by the

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-15 Thread Sujith Manoharan
Kalle Valo wrote: Would it help if I write an RFC patch? No, I think having profiles like 'slow', 'fast', 'super-fast' for a network driver will makes things complex. But, maybe others on this list might want it... Sujith -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-14 Thread Sujith Manoharan
Michal Kazior wrote: If I were to narrow down I'd say all uniprocessors. AP135 is just an example where the problem easily occurs since it has an underpowered cpu for the task. Even a more powerful single-core system will get into trouble - all you need is a couple extra netfilter rules, nat,

Re: [PATCH] ath10k: Make HTT fill size configurable

2015-01-14 Thread Sujith Manoharan
Michal Kazior wrote: We should just fix the tx/rx processing instead. The HTT throttling limit was originally introduced to deal with watchdog issues we've seen on AP135. Tasklets were starving system too much. Then the fill limit restriction is a workaround for AP135 and shouldn't be

  1   2   3   >