Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-16 Thread Arend Van Spriel
On 16-12-2016 11:13, Johannes Berg wrote: > On Wed, 2016-12-14 at 10:01 +0100, Arend Van Spriel wrote: > >> Had to look for "> 16" ;-) > > Sorry. > >> Here an instance of the tab vs. space issue you mentioned. Will go >> over the patch and fix that. > > There were a few, not really interesting

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-16 Thread Johannes Berg
On Wed, 2016-12-14 at 10:01 +0100, Arend Van Spriel wrote: > Had to look for "> 16" ;-) Sorry. > Here an instance of the tab vs. space issue you mentioned. Will go > over the patch and fix that. There were a few, not really interesting though - git would probably flag it anyway, or checkpatch

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-14 Thread Arend Van Spriel
On 13-12-2016 23:29, Johannes Berg wrote: > On Tue, 2016-12-13 at 21:09 +0100, Arend Van Spriel wrote: >> >>> There's a bit of a weird hard-coded restriction to 16 channels too, >>> that's due to the bucket map? >> >> Uhm. Is there? I will check, but if you can give me a pointer where >> to

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-13 Thread Johannes Berg
On Tue, 2016-12-13 at 21:09 +0100, Arend Van Spriel wrote: >  > > There's a bit of a weird hard-coded restriction to 16 channels too, > > that's due to the bucket map? > > Uhm. Is there? I will check, but if you can give me a pointer where > to look it is appreciated. Just look for "< 16" or "<=

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-13 Thread Arend Van Spriel
On 13-12-2016 17:19, Johannes Berg wrote: > On Mon, 2016-12-12 at 11:59 +, Arend van Spriel wrote: >> This patch adds support for GScan which is a scan offload feature >> used in Android. > > Found a few places with spaces instead of tabs as indentation, and > spurious braces around

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-13 Thread Johannes Berg
On Mon, 2016-12-12 at 11:59 +, Arend van Spriel wrote: > This patch adds support for GScan which is a scan offload feature > used in Android. Found a few places with spaces instead of tabs as indentation, and spurious braces around single-statement things, but other than that it looks fine

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-12 Thread Arend Van Spriel
On 12-12-2016 18:43, Dan Williams wrote: >> + >> +/** >> + * enum nl80211_bucket_band - GScan bucket band selection. > Quite possibly this was already covered and somebody requested you to > change this to the current name. If that's the case, ignore this. Nope. You are the first ;-) > But

Re: [RFC V3 03/11] nl80211: add support for gscan

2016-12-12 Thread Dan Williams
On Mon, 2016-12-12 at 11:59 +, Arend van Spriel wrote: > This patch adds support for GScan which is a scan offload feature > used in Android. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts m> >

[RFC V3 03/11] nl80211: add support for gscan

2016-12-12 Thread Arend van Spriel
This patch adds support for GScan which is a scan offload feature used in Android. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel