Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-09-03 Thread Kalle Valo
Stanislaw Gruszka wrote: > Since 41634aa8d6db ("mt76: only schedule txqs from the tx tasklet") > I can observe firmware hangs on MT7630E on station mode: tx stop > functioning after minor activity (rx keep working) and on module > unload device fail to stop with messages: > > [ 5446.141413] mt76

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-22 Thread Felix Fietkau
On 2019-08-21 13:22, Stanislaw Gruszka wrote: > On Wed, Aug 21, 2019 at 12:40:14PM +0200, Felix Fietkau wrote: >> On 2019-08-21 11:03, Felix Fietkau wrote: >> > On 2019-08-21 10:47, Stanislaw Gruszka wrote: >> >> On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: >> >>> > Can you te

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-21 Thread Stanislaw Gruszka
On Wed, Aug 21, 2019 at 12:40:14PM +0200, Felix Fietkau wrote: > On 2019-08-21 11:03, Felix Fietkau wrote: > > On 2019-08-21 10:47, Stanislaw Gruszka wrote: > >> On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: > >>> > Can you test if disabling hw encryption only for shared or onl

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-21 Thread Felix Fietkau
On 2019-08-21 11:03, Felix Fietkau wrote: > On 2019-08-21 10:47, Stanislaw Gruszka wrote: >> On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: >>> > Can you test if disabling hw encryption only for shared or only for >>> > pairwise keys makes any difference? >>> >>> Disabling only

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-21 Thread Felix Fietkau
On 2019-08-21 10:47, Stanislaw Gruszka wrote: > On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: >> > Can you test if disabling hw encryption only for shared or only for >> > pairwise keys makes any difference? >> >> Disabling only pairwise keys helps. Disabling only shared keys

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-21 Thread Stanislaw Gruszka
On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: > > Can you test if disabling hw encryption only for shared or only for > > pairwise keys makes any difference? > > Disabling only pairwise keys helps. Disabling only shared keys does > not help. > > Not sure if this will be helpf

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-20 Thread Stanislaw Gruszka
On Tue, Aug 20, 2019 at 12:31:56PM +0200, Felix Fietkau wrote: > >> >> void mt76x0e_wake_tx_queue(struct ieee80211_hw *hw, struct > >> >> ieee80211_txq *txq) > >> >> { > >> >> if (is_mt7630(dev)) { > >> >> mt76_txq_schedule(dev, txq->ac); > >> >> } else { > >> >>

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-20 Thread Felix Fietkau
On 2019-08-19 13:06, Stanislaw Gruszka wrote: > On Thu, Aug 15, 2019 at 12:20:54PM +0200, Felix Fietkau wrote: >> On 2019-08-15 12:09, Stanislaw Gruszka wrote: >> >> Hi Stanislaw, >> >> >> >> Can you please try if disabling/enabling the tx tasklet during hw key >> >> configuration fixes the issue?

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-19 Thread Stanislaw Gruszka
On Thu, Aug 15, 2019 at 12:20:54PM +0200, Felix Fietkau wrote: > On 2019-08-15 12:09, Stanislaw Gruszka wrote: > >> Hi Stanislaw, > >> > >> Can you please try if disabling/enabling the tx tasklet during hw key > >> configuration fixes the issue? > >> Doing something like: > >> > >> tasklet_disabl

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-15 Thread Felix Fietkau
On 2019-08-15 12:09, Stanislaw Gruszka wrote: >> Hi Stanislaw, >> >> Can you please try if disabling/enabling the tx tasklet during hw key >> configuration fixes the issue? >> Doing something like: >> >> tasklet_disable(tx_tasklet) >> mt76x02_set_key() >> tasklet_enable(tx_tasklet) > > It does n

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-15 Thread Stanislaw Gruszka
On Wed, Aug 14, 2019 at 11:50:12AM +0200, Lorenzo Bianconi wrote: > > > > Since 41634aa8d6db ("mt76: only schedule txqs from the tx tasklet") > > I can observe firmware hangs on MT7630E on station mode: tx stop > > functioning after minor activity (rx keep working) and on module > > unload device f

Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E

2019-08-14 Thread Lorenzo Bianconi
> > Since 41634aa8d6db ("mt76: only schedule txqs from the tx tasklet") > I can observe firmware hangs on MT7630E on station mode: tx stop > functioning after minor activity (rx keep working) and on module > unload device fail to stop with messages: > > [ 5446.141413] mt76x0e :06:00.0: TX DMA d