RE: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-26 Thread David Laight
> If you want to create enum->#ENUM structs and > "const char *" lookup functions, please be my guest. > > otherwise, hex is at least a consistent way to display > what should be infrequent output. If I've typed it right: #define tags(x) x(A) x(B) x(C) #define x(t) t, enum {tags(x) tag_count};

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: > On 09/24/2016 12:32 PM, Joe Perches wrote: [] > o Reindent all the switch/case blocks to a more normal > kernel style (git diff -w would show no changes here) > That sounds like busy work to me, but if you want to do it, go ahead. It's

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 12:32 PM, Joe Perches wrote: (adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers, and one that sets the enum values for that particular statement to hex values.

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
(adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: > I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the > drivers,  > and one that sets the enum values for that particular statement to hex > values. I  > also looked at the other large

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 11:15 AM, Joe Perches wrote: On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: Would it make sense to explicitly set the enum values, or add them as comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jean Delvare
Hi Joe, Larry, On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote: > On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > > I'm not familiar with the %#x format. What does it do? > > Outputs SPECIAL prefix, it's the same as "0x%x" > > lib/vsprintf.c: > #define SPECIAL 64

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Larry Finger
On 09/23/2016 01:27 PM, Joe Perches wrote: Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches Acked-by: Larry Finger Thanks, Larry

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Joe Perches
On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > I'm not familiar with the %#x format. What does it do? Outputs SPECIAL prefix, it's the same as "0x%x" lib/vsprintf.c: #define SPECIAL 64 /* prefix hex with "0x", octal with "0" */

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Larry Finger
On 09/23/2016 01:27 PM, Joe Perches wrote: Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches Joe, You beat me to the patch. No problem as this one looks OK; however, I'm not familiar with the %#x

[PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-23 Thread Joe Perches
Help along debugging by showing what switch/case variable is not being processed in these messages. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/core.c | 3 ++- drivers/net/wireless/realtek/rtlwifi/pci.c | 3 ++-