Re: [PATCH 1/1] iwlwifi: rs: remove superfluous check

2016-05-19 Thread Coelho, Luciano
On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote: > If we dereference a variable anyway in other parts of the code, > there is no need to check against NULL in a single place. NACK.  This is not true. If lq_sta is NULL, it means that mvm_sta is also NULL.  Then we call the

[PATCH 1/1] iwlwifi: rs: remove superfluous check

2016-05-17 Thread Heinrich Schuchardt
If we dereference a variable anyway in other parts of the code, there is no need to check against NULL in a single place. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git