Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-16 Thread Arnd Bergmann
On Monday 16 November 2015 10:36:47 glen lee wrote: > On 2015년 11월 13일 18:17, Arnd Bergmann wrote: > > On Friday 13 November 2015 16:49:22 glen lee wrote: > >> Hi arnd, > >> > >> I found this. These should be like this. It works fine. > >> + .hif_block_tx_ext = sdio_write, > >> +

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-15 Thread glen lee
On 2015년 11월 13일 18:17, Arnd Bergmann wrote: On Friday 13 November 2015 16:49:22 glen lee wrote: Hi arnd, I found this. These should be like this. It works fine. + .hif_block_tx_ext = sdio_write, + .hif_block_rx_ext = sdio_read, also, wilc_hif_spi need to be fixed together like

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-13 Thread Arnd Bergmann
On Friday 13 November 2015 16:49:22 glen lee wrote: > > Hi arnd, > > I found this. These should be like this. It works fine. > + .hif_block_tx_ext = sdio_write, > + .hif_block_rx_ext = sdio_read, > > also, wilc_hif_spi need to be fixed together like this. > + .hif_block_tx_ext

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-12 Thread glen lee
Hi arnd, I appreciate the patches. I did test this patch series on h/w which is arm based MCU. From this patch wilc is not working properly. After downloading firmware, the firmware cannot start and it fails. I double check this patch and the previous one(14/20) which works fine. I cannot find

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-12 Thread Arnd Bergmann
On Thursday 12 November 2015 19:05:41 glen lee wrote: > Hi arnd, > > I appreciate the patches. > I did test this patch series on h/w which is arm based MCU. > From this patch wilc is not working properly. After downloading firmware, > the firmware cannot start and it fails. > I double check

[PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-10 Thread Arnd Bergmann
The wilc_hif_spi and wilc_hif_sdio structures are part of the bus specific code, and the generic code should have no knowledge of their addresses. This changes the code to reference them only from the bus specific initialization code, which we can then use to split up the driver into separate