Re: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-12 Thread Sujith Manoharan
Felix Fietkau wrote: > Makes sense. I don't like all these duplicated SREV checks though. > Let's store the chip_chainmask variable from ath9k_hw_fill_cap_info > somewhere in ath_hw and use that. I'll send a v2. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" i

Re: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-12 Thread Felix Fietkau
On 2014-11-12 04:34, Sujith Manoharan wrote: > Pan, Miaoqing wrote: >> the issue was found on ap143(QCA9531, 11n, 2x2), reported by Korea team. >> They >> want to make ap143 to work on 1x2 or 2x2 mode. > > Ok, so apparently there are boards that are 2x2 in the HW, but the > tx chainmask is set a

RE: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-11 Thread Sujith Manoharan
Pan, Miaoqing wrote: > the issue was found on ap143(QCA9531, 11n, 2x2), reported by Korea team. They > want to make ap143 to work on 1x2 or 2x2 mode. Ok, so apparently there are boards that are 2x2 in the HW, but the tx chainmask is set as 1 in the eeprom. In such cases, the thermometer has to be

RE: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-11 Thread Pan, Miaoqing
: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode Felix Fietkau wrote: > That doesn't seem right to me. ah->caps.tx_chainmask is not altered > based on software antenna configuration. Yes, that's true. Miaoqing, can you clarify ? Should the thermometer for chain 1 be e

Re: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-11 Thread Sujith Manoharan
Felix Fietkau wrote: > That doesn't seem right to me. ah->caps.tx_chainmask is not altered > based on software antenna configuration. Yes, that's true. Miaoqing, can you clarify ? Should the thermometer for chain 1 be enabled even though the HW caps contain 0x1 as TX chainmask, for example ? Are

Re: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-11 Thread Felix Fietkau
On 2014-11-11 08:07, Sujith Manoharan wrote: > From: Miaoqing Pan > > For multi-chain chips, if the thermometer is switched off for a chain > which can be disabled by software(e.g tx_chainmask=0x1), the measured tx > power is about 5dB higher than target power. > > Set thermometer on for all cha

[PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-10 Thread Sujith Manoharan
From: Miaoqing Pan For multi-chain chips, if the thermometer is switched off for a chain which can be disabled by software(e.g tx_chainmask=0x1), the measured tx power is about 5dB higher than target power. Set thermometer on for all chains to fix this issue. Signed-off-by: Miaoqing Pan Signed