Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
(I think Dmitry noticed the same while I wrote this.) On Mon, Oct 10, 2016 at 04:47:08PM -0700, Brian Norris wrote: > [*] The other cases are in error handling cases. I guess I should make > sure those didn't race too... Ah, well I think I missed one case: For the async FW request code path,

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Dmitry Torokhov
>> > > From: Brian Norris [mailto:briannor...@chromium.org] >> >> > > Sent: Wednesday, October 05, 2016 3:28 AM >> >> > > To: Amitkumar Karwar >> >> > > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; >&

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
f Of Brian Norris > >> Sent: Wednesday, October 05, 2016 10:00 PM > >> To: Amitkumar Karwar > >> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > >> raja...@google.com; Xinming Hu > >> Subject: Re: [PATCH v2 1/2] mwifiex: reset card->ad

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Dmitry Torokhov
t; To: Amitkumar Karwar >> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; >> raja...@google.com; Xinming Hu >> Subject: Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device >> unregister >> >> Hi, >> >> On W

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
r > > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > > raja...@google.com; Xinming Hu > > Subject: Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device > > unregister > > > > On Wed, Oct 05, 2016 at 02:04:53PM +, Amit

RE: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-06 Thread Amitkumar Karwar
oogle.com; Xinming Hu > Subject: Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device > unregister > > Hi, > > On Wed, Oct 05, 2016 at 02:04:53PM +, Amitkumar Karwar wrote: > > > From: Brian Norris [mailto:briannor...@chromium.org] > > > Sent

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-05 Thread Brian Norris
; > > raja...@google.com; briannor...@google.com; Xinming Hu > > Subject: Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device > > unregister > > > > Hi, > > > > On Tue, Oct 04, 2016 at 10:38:24PM +0530, Amitkumar Karwar wrote: > > > ---

RE: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-05 Thread Amitkumar Karwar
CH v2 1/2] mwifiex: reset card->adapter during device > unregister > > Hi, > > On Tue, Oct 04, 2016 at 10:38:24PM +0530, Amitkumar Karwar wrote: > > From: Xinming Hu <h...@marvell.com> > > > > card->adapter gets initialized during device registration.

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-04 Thread Brian Norris
Hi, On Tue, Oct 04, 2016 at 10:38:24PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > card->adapter gets initialized during device registration. > As it's not cleared, we may end up accessing invalid memory > in some corner cases. This patch fixes the problem. > >

[PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-04 Thread Amitkumar Karwar
From: Xinming Hu card->adapter gets initialized during device registration. As it's not cleared, we may end up accessing invalid memory in some corner cases. This patch fixes the problem. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar