Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-06-04 Thread Pkshih
On Thu, 2018-05-24 at 11:27 +0300, Kalle Valo wrote: >  > You are missing my point: I don't even have time to review huge rtlwifi > patches when they are not even ready for upstream. I cannot start > working on cleaning up rtlwifi code and doing multiple iterations of > reviews on these kind of

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-05-24 Thread Kalle Valo
18 at 8:10 AM, Pkshih <pks...@realtek.com> wrote: >> >> > >> >> > >> >> > > -Original Message- >> >> > > From: Barry Day [mailto:brise...@gmail.com] >> >> > > Sent: Saturday, April 28, 2018 6:42 AM >> >> > &g

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-05-18 Thread Pkshih
t; > > >> > > -Original Message- > >> > > From: Barry Day [mailto:brise...@gmail.com] > >> > > Sent: Saturday, April 28, 2018 6:42 AM > >> > > To: Pkshih > >> > > Cc: Kalle Valo; larry.fin...@lwfinger.net; > >&

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-05-16 Thread Kalle Valo
Pkshih writes: >> And I even read all 19 commit logs and there was no mention of why this >> is needed either. I cannot just blindly apply patches without knowing >> what they do. >> > > This new module halmac is an abstract layer for Realtek WiFi MAC to provide > common

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-05-16 Thread Kalle Valo
l 28, 2018 6:42 AM >> > To: Pkshih >> > Cc: Kalle Valo; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org >> > Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac >> > >> > On Fri, Apr 27, 2018 at 05:44:16AM +, Pkshih wrote:

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-05-15 Thread Pkshih
8, 2018 6:42 AM > > > To: Pkshih > > > Cc: Kalle Valo; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org > > > Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac > > > > > > On Fri, Apr 27, 2018 at 05:44:16AM +, Pksh

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-30 Thread Krishna Chaitanya
linux-wireless@vger.kernel.org > > Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac > > > > On Fri, Apr 27, 2018 at 05:44:16AM +, Pkshih wrote: > > > > > > The registers reside in driver causes error frequently, because MAC > > >

RE: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-29 Thread Pkshih
> -Original Message- > From: Barry Day [mailto:brise...@gmail.com] > Sent: Saturday, April 28, 2018 6:42 AM > To: Pkshih > Cc: Kalle Valo; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org > Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac &

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-27 Thread Barry Day
On Fri, Apr 27, 2018 at 05:44:16AM +, Pkshih wrote: > > The registers reside in driver causes error frequently, because MAC register > is maintained by Realtek's MAC team so they create this module to avoid > mistakes. > Another benefit is to make it possible to become a thin driver, because

RE: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-26 Thread Pkshih
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Wednesday, April 25, 2018 3:36 PM > To: Pkshih > Cc: larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org > Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac >

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-25 Thread Kalle Valo
writes: > From: Ping-Ke Shih > > v3: patch 06/17 in v2 is too big, so mail server may block the mail. > In this patchset, I decompose the patch into three patches 06/19-08/19, > so in patchset view v2 and v3 are identical. I can confirm, all

[PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

2018-04-24 Thread pkshih
From: Ping-Ke Shih v3: patch 06/17 in v2 is too big, so mail server may block the mail. In this patchset, I decompose the patch into three patches 06/19-08/19, so in patchset view v2 and v3 are identical. v2: remove indirection to get halmac ops Only patches 1/17