RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-23 Thread Reizer, Eyal
> > Here's a modified version of your patch, does that put wlcore to > idle with wowlan during suspend for you? > Still no joy. It suspends/resumes ok but leaves the firmware disabled from entering ELP. You can see the log below with some prints added to wlcore_runtime_suspend() And

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Tony Lindgren [180522 15:03]: > * Reizer, Eyal [180522 14:07]: > > > > > > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > > > wlcore_fw_sleep() call, with that

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Reizer, Eyal [180522 14:07]: > > > > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > > > > > > > I

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Reizer, Eyal
> > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > > > > I have tried that already. Same problem. The last call to: > >

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Reizer, Eyal [180522 13:50]: > > > > OK try replacing the pm_runtime_put_noidle() above with just > > pm_runtime_put_sync(). The reason why I put noidle there was the > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > I have tried that already.

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Reizer, Eyal [180522 06:42]: > It still crash. > The crash is different now. > It also complains about: > [ 60.544224] Unbalanced enable for IRQ 65 > Need down/up of the interface to recover after it. Oh OK so no need for this patch and interrupts are already enabled at that

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Reizer, Eyal
> > * Reizer, Eyal [180522 13:28]: > > Actually the below patch removing the call to wlcore_fw_sleep() avoids this > error. > > The downside is that the wl8 firmware remains fully active during supend, so > we > > Would need to find the root cause why the last call allowing the

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Kalle Valo [180522 08:05]: > Tony Lindgren writes: > > > * Reizer, Eyal [180521 07:31]: > >> > Here's a series of patches to add runtime PM support for wlcore. It does > >> > not > >> > yet implement autosuspend support, but let's get

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Tony Lindgren
* Reizer, Eyal [180522 13:28]: > Actually the below patch removing the call to wlcore_fw_sleep() avoids this > error. > The downside is that the wl8 firmware remains fully active during supend, so > we > Would need to find the root cause why the last call allowing the wilink8 >

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Reizer, Eyal
> > > > 8< > > diff --git a/drivers/net/wireless/ti/wlcore/main.c > > b/drivers/net/wireless/ti/wlcore/main.c > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -1867,8 +1867,6 @@ static int __maybe_unused > >

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Kalle Valo
Tony Lindgren writes: > * Reizer, Eyal [180521 07:31]: >> > Here's a series of patches to add runtime PM support for wlcore. It does >> > not >> > yet implement autosuspend support, but let's get this tested first as the >> > autosuspend can mask enable/disable

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-22 Thread Reizer, Eyal
> > > > This warning is because wlcore is wlcore is still in ELP. This is > > somehow possible even though we call pm_runtime_get_sync() in > > wl1271_op_resume(). Anyways, I'll try to reproduce it here. > > Sorry I can't somehow get my beagleboard to wake-up from suspend, > I'm almost certain

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-21 Thread Tony Lindgren
* Tony Lindgren [180521 16:40]: > * Reizer, Eyal [180521 07:31]: > > > Here's a series of patches to add runtime PM support for wlcore. It does > > > not > > > yet implement autosuspend support, but let's get this tested first as the > > > autosuspend can mask

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-21 Thread Tony Lindgren
* Reizer, Eyal [180521 07:31]: > > Here's a series of patches to add runtime PM support for wlcore. It does not > > yet implement autosuspend support, but let's get this tested first as the > > autosuspend can mask enable/disable issues easily. > > Testing on BBB+WL1837 cape, scan,

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-21 Thread Reizer, Eyal
Hi Tony, > > Hi all, > > Here's a series of patches to add runtime PM support for wlcore. It does not > yet implement autosuspend support, but let's get this tested first as the > autosuspend can mask enable/disable issues easily. > > Regards, > > Tony > > Changes since v1: > > - Fix issues