Re: pull-request: wireless-drivers-next 2016-05-13 (take two)

On Thu, May 19, 2016 at 6:45 AM, Kalle Valo wrote: > Hi Dave, > > this the second version of the last pull request to net-next for 4.7, > which got postponed due to the recent iwlwifi merge conflict. Now that > Linus fixed the merge problem in his tree I actually didn't have

Re: "kernel: BUG: scheduling while atomic:" errors with linux kernel 4.6

+linux-wireless On Thu, May 19, 2016 at 03:11:16PM -0600, James Feeney wrote: > Arch linux 4.6-1 > wpa_supplicant 1:2.5-3 > Toshiba Satellite, circa 2011, with a Pentium Dual-Core Mobile > Error is not seen on other machines. > > kernel: BUG: scheduling while atomic:

Re: [GIT] Networking

On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds wrote: > On Wed, May 18, 2016 at 11:45 AM, Linus Torvalds > wrote: >> >> From what I can tell, there's a merge bug in commit 909b27f70643, >> where David seems to have lost some of the

Re: [PATCH 1/1] iwlwifi: rs: remove superfluous check

On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote: > If we dereference a variable anyway in other parts of the code, > there is no need to check against NULL in a single place. NACK.  This is not true. If lq_sta is NULL, it means that mvm_sta is also NULL.  Then we call the

[PATCHv5 3/5] mac80211: add debug knobs for fair queuing

This adds a debugfs entry to read and modify some fq parameters and inroduces a module parameter to control number of flows mac80211 shuold maintain. This makes it easy to debug, test and experiment. Signed-off-by: Michal Kazior --- Notes: v5: * expose a

[PATCHv5 4/5] mac80211: implement codel on fair queuing flows

There is no other limit other than a global packet count limit when using software queuing. This means a single flow queue can grow insanely long. This is particularly bad for TCP congestion algorithms which requires a little more sophisticated frame dropping scheme than a mere headdrop on limit

[PATCHv5 2/5] mac80211: implement fair queueing per txq

mac80211's software queues were designed to work very closely with device tx queues. They are required to make use of 802.11 packet aggregation easily and efficiently. Due to the way 802.11 aggregation is designed it only makes sense to keep fair queuing as close to hardware as possible to reduce

[PATCHv5 1/5] mac80211: skip netdev queue control with software queuing

Qdiscs are designed with no regard to 802.11 aggregation requirements and hand out packet-by-packet with no guarantee they are destined to the same tid. This does more bad than good no matter how fairly a given qdisc may behave on an ethernet interface. Software queuing used per-AC netdev

[PATCHv5 0/5] mac80211: implement fq_codel

Hi, This patchset disables qdiscs for drivers using software queuing and performs fq_codel-like dequeuing on txqs. This is based on net-next/master (0b7962a6c4a37ef3cbb25d976af7b9ec4ce8ad01). Background: https://www.spinics.net/lists/linux-wireless/msg149776.html

[PATCHv5 5/5] mac80211: add debug knobs for codel

This adds a few debugfs entries to make it easier to test, debug and experiment. Signed-off-by: Michal Kazior --- Notes: v5: * use the single "aqm" debugfs knob [Dave] v4: * stats adjustments (in-kernel codel has more of them)

Re: [PATCH] rtl8xxxu: increase polling timeout for firmware startup

You're welcome, and thanks for writing this great driver. It really makes a huge difference for stability of the Yoga 13 wifi! Unfortunately, I ran into a case today where even 5000 loops was not enough after a cold boot. 5000 loops meant about 1.5 second delay between finishing the firmware

Re: [GIT] Networking

On Thu, May 19, 2016 at 2:20 AM, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 12:51 PM, Linus Torvalds > wrote: >> On Wed, May 18, 2016 at 11:45 AM, Linus Torvalds >> wrote: >>> >>> From what I can

[PATCH 4.8 2/2] brcmfmac: support get_channel cfg80211 callback

This is important for brcmfmac as the firmware may pick different channel than requested. This has been tested with BCM4366B1 (in D-Link DIR-885L). Signed-off-by: Rafał Miłecki --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 59 ++ 1 file changed,

[PATCH 4.8 1/2] brcmutil: add field storing control channel to the struct brcmu_chan

Our d11 code supports encoding/decoding channel info into/from chanspec format used by firmware. Current implementation is quite misleading because of the way "chnum" field is used. When encoding channel info, "chnum" has to be filled by a caller with *center* channel number. However when decoding

Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git

On Thursday, May 19, 2016 04:08:10 PM Kalle Valo wrote: > Lauri Kasanen writes: > > > On Tue, 03 May 2016 15:09:39 +0200 > > Christian Lamparter wrote: > > > >> On Thursday, April 21, 2016 03:22:15 PM Kalle Valo wrote: > >> > Christian Lamparter

[PATCH] brcmfmac: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated region. It replaces call to allocation followed by memcpy, by a single call to kmemdup. Signed-off-by: Muhammad Falak R Wani --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +-- 1

Re: [RESEND] Re: updating carl9170-1.fw in linux-firmware.git

Lauri Kasanen writes: > On Tue, 03 May 2016 15:09:39 +0200 > Christian Lamparter wrote: > >> On Thursday, April 21, 2016 03:22:15 PM Kalle Valo wrote: >> > Christian Lamparter writes: >> > >> > > Maintainers. So for those people

Re: [PATCH] iwlegacy: avoid warning about missing braces

On Thu, May 19, 2016 at 09:58:49AM +0200, Arnd Bergmann wrote: > gcc-6 warns about code in il3945_hw_txq_ctx_free() being > somewhat ambiguous: > > drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit > braces to avoid ambiguous 'else' [-Wparentheses] > > This adds a set

pull-request: wireless-drivers-next 2016-05-13 (take two)

Hi Dave, this the second version of the last pull request to net-next for 4.7, which got postponed due to the recent iwlwifi merge conflict. Now that Linus fixed the merge problem in his tree I actually didn't have to fix anything in my tree anymore. So that's why I still use the same tag as in

[PATCH] mac80211: fix fast_tx header alignment

The header field is defined as u8[] but also accessed as struct ieee80211_hdr. Enforce an alignment of 2 to prevent unnecessary unaligned accesses, which can be very harmful for performance on many platforms. Fixes: e495c24731a2 ("mac80211: extend fast-xmit for more ciphers") Cc:

Re: [PATCH 1/1] net: rsi: eliminate superfluous NULL check

From: Heinrich Schuchardt Date: Wed, 18 May 2016 00:30:41 +0200 > msg is dereferenced before checking against NULL, e.g. > when assigning pad_bytes. > Remove the superfluous check in function rsi_mgmt_pkt_to_core. > > Signed-off-by: Heinrich Schuchardt

Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger

On Thu 2016-05-12 11:32:52, Johannes Berg wrote: > On Wed, 2016-05-04 at 09:29 +0200, Pavel Machek wrote: > >  > > If userspace wants to control the manually, it can do just that -- > > control it manually. There should not be a need to "override the > > default policy". > > I'm still not buying

[PATCH] iwlegacy: avoid warning about missing braces

gcc-6 warns about code in il3945_hw_txq_ctx_free() being somewhat ambiguous: drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] This adds a set of curly braces to avoid the warning. Signed-off-by: Arnd Bergmann