[PATCH] cfg80211: Create structure for combination check/iter function parameters

2016-10-10 Thread Purushottam Kushwaha
Move growing parameter list to a structure for check/iter combination functions in cfg80211 and mac80211. Signed-off-by: Purushottam Kushwaha --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 25 - include/net/cfg80211.h | 56

[PATCH] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

2016-10-10 Thread Purushottam Kushwaha
This commit enhances the current beacon interval validation to also consider the "radar_detect" and "num_different_channels". Rename "cfg80211_validate_beacon_int" to "cfg80211_validate_beacon_combination" as the validation considers other parameters. Signed-off-by: Purushottam Kushwaha

[PATCH v9] cfg80211: Provision to allow the support for different beacon intervals

2016-10-10 Thread Purushottam Kushwaha
This commit provides a mechanism for the host drivers to advertise the support for different beacon intervals among the respective interface combinations in a group, through beacon_int_min_gcd (u32). This beacon_int_min_gcd will be compared against GCD of all beaconing interfaces of matching

[PATCH] ath10k: Fix kernel panic due to race in accessing arvif list

2016-10-10 Thread Vasanthakumar Thiagarajan
arvifs list is traversed within data_lock spin_lock in tasklet context to fill channel information from the corresponding vif. This means any access to arvifs list for add/del operations should also be protected with the same spin_lock to avoid the race. Fix this by performing list add/del on

[PATCH] mac80211: fix A-MSDU outer SA/DA

2016-10-10 Thread Michael Braun
According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS values. Signed-off-by: Michael Braun --- net/mac80211/tx.c | 24 +++- 1 file changed, 23 insertions(+), 1

[PATCH v6 2/4] mac80211: filter multicast data packets on AP / AP_VLAN

2016-10-10 Thread Michael Braun
This patch adds filtering for multicast data packets on AP_VLAN interfaces that have no authorized station connected and changes filtering on AP interfaces to not count stations assigned to AP_VLAN interfaces. This saves airtime and avoids waking up other stations currently authorized in this

[PATCH v6 3/4] cfg80211: configure multicast to unicast for AP interfaces

2016-10-10 Thread Michael Braun
This add a userspace toggle to configure multicast to unicast. Signed-off-by: Michael Braun -- v6: - clarify documentation - fix policy for NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED --- include/net/cfg80211.h | 6 ++ include/uapi/linux/nl80211.h | 18

[PATCH v6 1/4] mac80211: remove unnecessary num_mcast_sta user

2016-10-10 Thread Michael Braun
Checking for num_mcast_sta in __ieee80211_request_smps_ap() is unnecessary, as sta list will be empty in this case anyway, so list_for_each_entry(sta, ...) will exit immediately. Signed-off-by: Michael Braun --- net/mac80211/cfg.c | 7 --- 1 file changed, 7

[PATCH v2] mac80211: enable to inject a-msdu frames using monitor interface

2016-10-10 Thread Michael Braun
Problem: When injecting an A-MSDU using a PF_PACKET socket, the qos flag IEEE80211_QOS_CTL_A_MSDU_PRESENT is cleared. How to reproduce: Inject a frame on a mac80211 hwsim monitor interface and have tshark sniffing on this monitor interface. You'll see the packet twice: Once with correct flag and

Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Johannes Berg
On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > rtl8821ae, > the Coccinelle script missed the fact that the code changes the > firmware > name. When that

[PATCH v6 4/4] mac80211: multicast to unicast conversion

2016-10-10 Thread Michael Braun
This patch adds support for sending multicast data packets with ARP, IPv4 and IPv6 payload (possible 802.1q tagged) as 802.11 unicast frames to all stations. IEEE 802.11 multicast has well known issues, among them: 1. packets are not acked and hence not retransmitted, resulting in decreased

Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Julia Lawall
On Mon, 10 Oct 2016, Larry Finger wrote: > On 10/10/2016 11:56 AM, Johannes Berg wrote: > > On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > > > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > > > > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > > >

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
Hi Amit, On Thu, Oct 06, 2016 at 01:03:02PM +, Amitkumar Karwar wrote: > > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > > ow...@vger.kernel.org] On Behalf Of Brian Norris > > Sent: Wednesday, October 05, 2016 10:00 PM > > To: Amitkumar Karwar > > Cc:

Re: [PATCH v4 1/3] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
Hi Amit, On Thu, Oct 06, 2016 at 11:36:24PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > card->adapter gets initialized during device registration. > As it's not cleared, we may end up accessing invalid memory > in some corner cases. This patch fixes the problem. > >

Re: [PATCH v4 2/3] mwifiex: remove redundant pdev check in suspend/resume handlers

2016-10-10 Thread Brian Norris
On Thu, Oct 06, 2016 at 11:36:25PM +0530, Amitkumar Karwar wrote: > to_pci_dev() would just do struct offset arithmetic on struct > device to get 'pdev' pointer. We never get NULL pdev pointer > > Signed-off-by: Amitkumar Karwar > --- > New patch introduced in v3 as per

Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Larry Finger
On 10/10/2016 11:56 AM, Johannes Berg wrote: On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, the Coccinelle script missed the fact that the code changes

Re: [PATCH v2] ath10k: cache calibration data when the core is stopped

2016-10-10 Thread Valo, Kalle
Marty Faltesek writes: > ath10k: cache calibration data when the core is stopped > > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek Thanks, I'll now send v3. -- Kalle Valo

[PATCH v3] ath10k: cache calibration data when the core is stopped

2016-10-10 Thread Kalle Valo
From: Marty Faltesek Commit 0b8e3c4ca29f ("ath10k: move cal data len to hw_params") broke retrieving the calibration data from cal_data debugfs file. The length of file was always zero. The reason is: static ssize_t ath10k_debug_cal_data_read(struct file *file,

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Dmitry Torokhov
Hi Brian, On Mon, Oct 10, 2016 at 4:47 PM, Brian Norris wrote: > Hi Dmitry, > > On Mon, Oct 10, 2016 at 04:43:06PM -0700, Dmitry Torokhov wrote: >> On Thu, Oct 6, 2016 at 6:03 AM, Amitkumar Karwar wrote: >> >> From:

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
(I think Dmitry noticed the same while I wrote this.) On Mon, Oct 10, 2016 at 04:47:08PM -0700, Brian Norris wrote: > [*] The other cases are in error handling cases. I guess I should make > sure those didn't race too... Ah, well I think I missed one case: For the async FW request code path,

[PATCH] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-10 Thread Larry Finger
In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), the configuration struct for most of the drivers was changed to be constant. The problem is that five of the modified drivers need to be able to update the firmware name based on the exact model of the card. As the file names

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
Hi Dmitry, On Mon, Oct 10, 2016 at 04:43:06PM -0700, Dmitry Torokhov wrote: > On Thu, Oct 6, 2016 at 6:03 AM, Amitkumar Karwar wrote: > >> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > >> ow...@vger.kernel.org] On Behalf Of Brian Norris > >> Sent:

Re: [PATCH v2 1/2] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Dmitry Torokhov
On Thu, Oct 6, 2016 at 6:03 AM, Amitkumar Karwar wrote: > Hi Brian, > >> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- >> ow...@vger.kernel.org] On Behalf Of Brian Norris >> Sent: Wednesday, October 05, 2016 10:00 PM >> To: Amitkumar Karwar >> Cc:

Re: [PATCH v4 1/3] mwifiex: reset card->adapter during device unregister

2016-10-10 Thread Brian Norris
+ Dmitry Hi Amit, On Mon, Oct 10, 2016 at 01:53:32PM -0700, Brian Norris wrote: > On Thu, Oct 06, 2016 at 11:36:24PM +0530, Amitkumar Karwar wrote: > > From: Xinming Hu > > > > card->adapter gets initialized during device registration. > > As it's not cleared, we may end up

[PATCH] mac80211_hwsim: make multi-channel ops const

2016-10-10 Thread Johannes Berg
From: Johannes Berg Instead of building the multi-channel ops at runtime, declare the common ops with a macro and build both that way, so that the multi-channel ops can also be const. As a side effect, due to the removed code, this decreases the size of the module

Re: [PATCH] Report scan_abort as part of iw phy

2016-10-10 Thread Johannes Berg
On Sat, 2016-10-08 at 15:40 +0200, Ola Olsson wrote: > nl80211: abort_scan has not been reported under the 'Supported > commands' > category when calling iw phy. Add that. > > Signed-off-by: Ola Olsson > --- >  net/wireless/nl80211.c | 1 + >  1 file changed, 1

Re: [PATCH] Report scan_abort as part of iw phy

2016-10-10 Thread Kalle Valo
Ola Olsson writes: > nl80211: abort_scan has not been reported under the 'Supported commands' > category when calling iw phy. Add that. > > Signed-off-by: Ola Olsson > --- > net/wireless/nl80211.c | 1 + > 1 file changed, 1 insertion(+) You

Re: [RFC] mac80211: fix A-MSDU outer SA/DA

2016-10-10 Thread Johannes Berg
>   > + /* according to IEEE 802.11-2012 8.3.2 table 8-19, the outer > SA/DA > +  * fields needs to be changed to BSSID for A-MSDU frames > depending > +  * on FromDS/ToDS values. > +  */ > + hdr = data; > + if (bssid && (hdr->frame_control & >

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-10 Thread Luca Coelho
Hi, On Mon, 2016-10-10 at 02:19 -0500, Chris Rorvick wrote: > Commit bcb079a14d75 ("iwlwifi: pcie: retrieve and parse ACPI power > limitations") looks for a specific structure in the ACPI tables for > setting the default power limit. The data returned for at least some > dual band chipsets is not

Re: [PATCH v2] ath10k: cache calibration data when the core is stopped

2016-10-10 Thread Valo, Kalle
Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > --- Signed-off-by missing. Can you send it as a reply to this message and I'll add it to v3? > drivers/net/wireless/ath/ath10k/core.h | 1 + >

[PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Larry Finger
This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, the Coccinelle script missed the fact that the code changes the firmware name. When that happens, the kernel issues a BUG splat because it is unable to overwrite

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-10 Thread Sergey Senozhatsky
return -EINVAL; > } > > to ieee80211_aes_ccm_decrypt() given the following backtrace > > WARNING: CPU: 5 PID: 252 at net/mac80211/aes_ccm.c:77 > ieee80211_aes_ccm_decrypt+0xc8/0x197 > CPU: 5 PID: 252 Comm: irq/29-iwlwifi Tainted: GW > 4.8.0-next-20161010-dbg-7-g79797e9-di

Re: [PATCH v2] ath10k: cache calibration data when the core is stopped

2016-10-10 Thread Marty Faltesek
ath10k: cache calibration data when the core is stopped Caching calibration data allows it to be accessed when the device is not active. Signed-off-by: Marty Faltesek On Mon, Oct 10, 2016 at 10:54 AM, Valo, Kalle wrote: > Marty Faltesek

[mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-10 Thread Sergey Senozhatsky
+0xc8/0x197 CPU: 5 PID: 252 Comm: irq/29-iwlwifi Tainted: GW 4.8.0-next-20161010-dbg-7-g79797e9-dirty #88 c9413638 811ff0e3 c9413678 8103fe91 004d01c8 192826d3 88040fc526d8 0008