Re: mwifiex: use module_*_driver helper macros

Amitkumar Karwar wrote: > After user_rmmod global flag removal, *_init_module() and > *_cleanup_module() have become just a wrapper functions. > We will get rid of them with the help of module_*_driver() macros. > > For pcie, existing ".init_if" handler has same name as what

Re: brcmfmac: fix spelling mistakes on "Ivalid"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fixes to spelling mistake "Ivalid" to "Invalid" in > brcmf_err error messages. > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel

[PATCH][V3] rtlwifi: fix spelling mistake: "encrypiton" -> "encryption"

From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: adm80211: return an error if adm8211_alloc_rings() fails

Dan Carpenter wrote: > We accidentally return success when adm8211_alloc_rings() fails but we > should preserve the error code. > > Fixes: cc0b88cf5ecf ("[PATCH] Add adm8211 802.11b wireless driver") > Signed-off-by: Dan Carpenter > > diff

Re: orinoco: Use shash instead of ahash for MIC calculations

Kalle Valo writes: > Andrew Lutomirski wrote: >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >> simpler, faster, and more correct. >> >> Cc:

Re: [01/14] rtlwifi: Correct power save capability while init mac80211

Larry Finger wrote: > Set IEEE80211_HW_SUPPORTS_PS when driver is fwlps > Because mac80211 control SW-LPS only, we add constraints to avoid errors. > > Signed-off-by: Vincent Fann > Signed-off-by: shaofu > Signed-off-by:

Re: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: rtlwifi: Fix alignment issues

Larry Finger wrote: > From: Ping-Ke Shih > > The addresses of Wlan NIC registers are natural alignment, but some > drivers have bugs. These are evident on platforms that need natural > alignment to access registers. This change contains the

Re: rtlwifi: fix spelling mistake: "contry" -> "country"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Patch applied to

Re: [1/2] ath10k: add accounting for the extended peer statistics

On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo wrote: > Christian Lamparter wrote: >> The 10.4 firmware adds extended peer information to the >> firmware's statistics payload. This additional info is >> stored as a separate data field and the

Re: [1/5] mwifiex: get rid of mwifiex_do_flr wrapper

Amitkumar Karwar wrote: > From: Xinming Hu > > This patch gets rid of mwifiex_do_flr. We will call > mwifiex_shutdown_sw() and mwifiex_reinit_sw() directly. > These two general purpose functions will be useful for > sdio card reset handler. > >

Re: [1/2] mwifiex: code rearrangement in pcie.c and sdio.c

Amitkumar Karwar wrote: > From: Xinming Hu > > Next patch in this series is going to use mwifiex_read_reg() in remove > handlers. The changes here are prerequisites to avoid forward > declarations. > > Signed-off-by: Xinming Hu >

Re: orinoco: Use shash instead of ahash for MIC calculations

Kalle Valo writes: > Kalle Valo writes: > >> Andrew Lutomirski wrote: >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >>> Fix it by switching from ahash to shash. The result should be

[PATCH] ath9k: fix spelling mistake: "meaurement" -> "measurement"

From: Colin Ian King Trivial fix to spelling mistake in ath_err message Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath9k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

wireless-drivers-next open for 4.11

Now that the merge window is closed wireless-drivers-next is open for new features going to 4.11. wireless-drivers remains open for important fixes for 4.10. -- Kalle Valo

Re: [PATCH 01/11] rt2800: make rx ampdu_factor depend on number of rx chains

Stanislaw Gruszka writes: > Initalize max ampdu_factor supported by us based on rx chains, vendor > driver do the same. > > Signed-off-by: Stanislaw Gruszka When I was applying these patches I did an off by one error with my patchwork script ('commit

Re: rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

Larry Finger wrote: > These drivers need to be able to reference "struct ieee80211_hw" from > the driver's private data, and vice versa. The USB driver failed to > store the address of ieee80211_hw in the private data. Although this > bug has been present for a long

Re: [PATCH 14/14 V2] rtlwifi: Remove some redundant code

Larry Finger writes: > The symbol DBG_EMERG is no longer used and is removed. > > In a number of places, the code has redundant messages. For example, if > the failure for the firmware to run is logged, it is not necessary to > log that the firmware has been started.

Re: iwlegacy: make il3945_mac_ops __ro_after_init

Johannes Berg wrote: > From: Johannes Berg > > There's no need for this to be only __read_mostly, since > it's only written in a single way depending on the module > parameter, so that can be moved into the module's __init > function, and the

Re: orinoco: Use shash instead of ahash for MIC calculations

Andrew Lutomirski wrote: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric

Re: net: wireless: ath: wil6210: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: net: wireless: marvell: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: [01/14,V2] rtlwifi: Replace local debug macro RT_ASSERT

Larry Finger wrote: > This macro can be replaced with WARN_ONCE. In addition to using a > standard debugging macro for these critical errors, we also get > a stack dump. > > In rtl8821ae/hw.c, a senseless comment was removed, and an incorrect > indentation was fixed. >

Re: [PATCH][V2] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

Colin King writes: > From: Colin Ian King > > Trivial fix to spelling mistake in err message. Also change "don't" to > "does not". > > Signed-off-by: Colin Ian King > --- > drivers/media/usb/dvb-usb/gp8psk.c

Re: [1/2] ath10k: add accounting for the extended peer statistics

Christian Lamparter writes: > On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo wrote: >> Christian Lamparter wrote: >>> The 10.4 firmware adds extended peer information to the >>> firmware's statistics payload. This

Re: [1/2] mwifiex: code rearrangement in pcie.c and sdio.c

Amitkumar Karwar writes: > Hi Kalle, > >> Failed to apply: >> >> fatal: sha1 information is lacking or useless >> (drivers/net/wireless/marvell/mwifiex/pcie.c). >> Applying: mwifiex: get rid of global user_rmmod flag Repository lacks >> necessary blobs to fall back on 3-way

Re: [11/11] rt2x00: add mutex to synchronize config and link tuner

Stanislaw Gruszka wrote: > Do not perform mac80211 config and link_tuner at the same time, > this can possibly result in wrong RF or BBP configuration. > > Signed-off-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks.

Re: [1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

Larry Finger wrote: > From: Ping-Ke Shih > > The btcoexist routines for the RTL8192EE have been extensively rewritten. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger Dropped per

Re: [PATCH] cfg80211: Random local address for Public Action frame exchange

On 12/20/2016 11:39 PM, Jouni Malinen wrote: From: vamsi krishna Add support to use random local address (Address 2 = SA in transmit and the same address in receive functionality) for Public Action frames in order to improve privacy of WLAN clients. Applications fill the random source address

Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties

On 30 December 2016 at 21:20, Arend van Spriel wrote: > On 29-12-16 10:43, Rafał Miłecki wrote: >> On 29 December 2016 at 09:57, Arend van Spriel >> wrote: >>> On 28-12-16 22:30, Rafał Miłecki wrote: On 28 December 2016 at 22:28,

[PATCH] mac80211: Fix invalid 'info' access in xmit-fast.

From: Ben Greear ieee80211_xmit_fast assigns info from the passed-in skb, but then later it also checks for skb_shared(skb), and may create a new skb based on that check. But, the code did not re-assign 'info', so it pointed into the old shared skb. This leads to all

Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties

On 29-12-16 10:43, Rafał Miłecki wrote: > On 29 December 2016 at 09:57, Arend van Spriel > wrote: >> On 28-12-16 22:30, Rafał Miłecki wrote: >>> On 28 December 2016 at 22:28, Rafał Miłecki wrote: On 28 December 2016 at 22:07, Arend van Spriel

Re: [2/2] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

Christian Lamparter wrote: > ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...) > function, which allocates memory. If any of the three error-paths are > taken, this tb needs to be freed. > > Signed-off-by: Christian Lamparter

Re: [V2] ath10k: fix incorrect txpower set by P2P_DEVICE interface

Ryan Hsu wrote: > From: Ryan Hsu > > Ath10k reports the phy capability that supports P2P_DEVICE interface. > > When we use the P2P supported wpa_supplicant to start connection, it'll > create two interfaces, one is wlan0 (vdev_id=0) and one

Re: ath10k: ignore configuring the incorrect board_id

Ryan Hsu wrote: > From: Ryan Hsu > > With command to get board_id from otp, in the case of following > > boot get otp board id result 0x board_id 0 chip_id 0 > boot using board name 'bus=pci,bmi-chip-id=0,bmi-board-id=0" > ... >

Re: ath10k: support dev_coredump for crash dump

Kalle Valo wrote: > From: Arun Khandavalli > > Whenever firmware crashes, and both CONFIG_ATH10K_DEBUGFS and > CONFIG_ALLOW_DEV_COREDUMP are enabled, dump information about the crash via a > devcoredump device. Dump can be read from userspace

Re: ath10k: recal the txpower when removing interface

Ryan Hsu wrote: > From: Ryan Hsu > > The txpower is being recalculated when adding interface to make sure > txpower won't overshoot the spec, and when removing the interface, > the txpower should again to be recalculated to restore the correct

Re: ath10k: Remove passing unused argument for ath10k_mac_tx

Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > 'ath10k_mac_tx' does not seems to use the per station table > entry pointer 'sta' (struct ieee80211_sta), hence remove passing > this unused argument > > Signed-off-by:

Re: ath10k: Enable advertising support for channel 169, 5Ghz

Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Enable advertising support for channel 169, 5Ghz so that > based on the regulatory domain(country code) this channel > shall be active for use. For example in countries