Re: [PATCH 5/7] mac80211: add wide bandwidth channel switch announcement to CSA action frames and mesh beacons

2017-05-19 Thread Simon Wunderlich
Hi Johannes, On Friday, May 19, 2017 1:33:37 PM CEST Johannes Berg wrote: > I've applied patches 1-4 now. > > The subject is a bit long - I was going to change it to > > mac80211: mesh: support sending wide bandwidth CSA > > To support HT and VHT channel switch announcements, both

[PATCH v3 4/6] mwifiex: usb: add timer to flush aggregation packets

2017-05-19 Thread Xinming Hu
From: Xinming Hu Aggregation will wait for next packet until limit aggr size/number reach. Packet might be drop and also packet dequeue will be stop in some cases. This patch add timer to flush packets in aggregation list to avoid long time waiting. Signed-off-by: Xinming Hu

[PATCH v3 2/6] mwifiex: usb: kill urb before free its memory

2017-05-19 Thread Xinming Hu
From: Xinming Hu we have observed host system hang when device firmware crash, stack trace show it was an use-after-free case: previous submitted urb will be holding in usbcore, and given back to device driver when device disconnected, while the urb have been freed in usb

[PATCH v3 6/6] mwifiex: check next packet length for usb tx aggregation

2017-05-19 Thread Xinming Hu
From: Xinming Hu The next packet length will be used by interface driver, to check if the next packet still could be aggregated. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat --- v3:

[PATCH v3 5/6] mwifiex: do not aggregate tcp ack in usb tx aggregation queue

2017-05-19 Thread Xinming Hu
From: Xinming Hu Tcp ack should be send as soon to avoid throuput drop during receive tcp traffic. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat --- v2: same as v1 v3: avoid to use

[PATCH v3 3/6] mwifiex: usb: transmit aggregation packets

2017-05-19 Thread Xinming Hu
From: Xinming Hu Instead of using 4KB packet buffer for data transfer, new chipset have more device memory. This patch try to aggregation packets in an 16KB buffer. In this way, totally usb transaction cost will be reduced. Thoughput test on usb 2.0 show both TCP TX and UPD TX

[PATCH v3 1/6] mwifiex: use variable interface header length

2017-05-19 Thread Xinming Hu
From: Xinming Hu Usb tx aggregation feature will utilize 4-bytes bus interface header, otherwise it will be set to zero in default case. Signed-off-by: Xinming Hu Signed-off-by: Cathy Luo Signed-off-by: Ganapathi Bhat

RE: [PATCH v2 5/6] mwifiex: do not aggregate tcp ack in usb tx aggregation queue

2017-05-19 Thread Xinming Hu
Hi Kalle, > -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: 2017年5月18日 22:33 > To: Xinming Hu > Cc: Linux Wireless; Brian Norris; Dmitry Torokhov; raja...@google.com; > Zhiyuan Yang; Cathy Luo; Xinming Hu; Ganapathi Bhat > Subject: Re: [PATCH v2 5/6] mwifiex:

Re: [PATCH v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets

2017-05-19 Thread Johannes Berg
Hi, > Thanks for the review ! Fixes will be queued to the upcoming patches > with various cleanups as well as new features. Great :) FWIW, regarding the qtnf_mgmt_frame_register() and cfg80211_rx_mgmt() thing, I think we'll have to discuss how to do this, and perhaps you need to think about

Re: [PATCH 5/7] mac80211: add wide bandwidth channel switch announcement to CSA action frames and mesh beacons

2017-05-19 Thread Johannes Berg
Hi, > The spec says I need it, and if I understood the parsing function > correctly it will only search for the wide bw IE when it finds the > wrapper. Yeah, I think there's some difference between action frames and beacons though. You're only building the beacon here, so I think this is right.

Re: [PATCH v3] mac80211: Dynamically set CoDel parameters per station

2017-05-19 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote: >> CoDel can be too aggressive if a station sends at a very low rate, >> leading reduced throughput. This gets worse the more stations are >> present, as each station gets more

Re: [PATCH] ath10k: add configurable debugging.

2017-05-19 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) >

Re: [PATCH] ath10k: add configurable debugging.

2017-05-19 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) >

Re: [PATCH 08/29] rfkill.txt: standardize document format

2017-05-19 Thread Johannes Berg
On Thu, 2017-05-18 at 22:25 -0300, Mauro Carvalho Chehab wrote: > > +.. CONTENTS >   > +  1. Introduction > +  2. Implementation details > +  3. Kernel API > +  4. Userspace support Why not let this be auto-generated? .. contents:: :depth: 1 should work, no? johannes

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-19 Thread Kalle Valo
Sven Eckelmann writes: > On Montag, 1. Mai 2017 14:43:27 CEST Adrian Chadd wrote: >> This reverts b057886524be060021e3cfad0ba8458c850330cd in 2015 >> which converted this allocation from dma_map_coherent() to >> kzalloc() / dma_map_single(). >> >> The current

Re: [PATCH] ath10k : Fix channel survey dump

2017-05-19 Thread Kalle Valo
Felix Fietkau writes: > On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote: >> Channel active/busy time are showing incorrect >> (less than previous or sometimes zero) for >> successive survey dump command. >> >> example: >> Survey data from wlan0 >> frequency:

Re: [PATCH 7/7] mac80211: mark as action frame when parsing IEs of CSA action frames

2017-05-19 Thread Johannes Berg
Applied this as well, I assume you don't want patch 6 in before 5. johannes

Re: [PATCH] [ath10k] go back to using dma_alloc_coherent() for firmware scratch memory.

2017-05-19 Thread Kalle Valo
Adrian Chadd writes: > This reverts b057886524be060021e3cfad0ba8458c850330cd in 2015 > which converted this allocation from dma_map_coherent() to > kzalloc() / dma_map_single(). > > The current problem manifests when using later model NICs with larger > (>700KiB) scratch

Re: [PATCHv4 1/2] cfg80211: Add support to enable or disable btcoex and set btcoex_priority

2017-05-19 Thread Johannes Berg
Hi, Sorry for the long delay. > +/** > + * enum nl80211_btcoex_priority - btcoex priority supported frame > types and > + * its bitmap values. > + * @NL80211_BTCOEX_SUPPORTS_BE_PREF - wlan Best effort frame takes > more You should drop the _SUPPORTS part from these names, it's not just for

Re: [PATCH v3 6/6] mwifiex: check next packet length for usb tx aggregation

2017-05-19 Thread Brian Norris
On Fri, May 19, 2017 at 09:06:45AM +, Xinming Hu wrote: > From: Xinming Hu > > The next packet length will be used by interface driver, to check if the > next packet still could be aggregated. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo

[PATCH] rtlwifi: fix REG_USTIME_TSF register definition

2017-05-19 Thread Kevin Lo
The REG_USTIME_TSF (US Time Tuning for TSF) definition of Realtek chips should be 0x55C. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h index 15400ee6c04b..0c0d64aea651 100644

Re: [PATCH] ath10k : Fix channel survey dump

2017-05-19 Thread Adrian Chadd
On 19 May 2017 at 02:17, Kalle Valo wrote: > Felix Fietkau writes: > >> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote: >>> Channel active/busy time are showing incorrect >>> (less than previous or sometimes zero) for >>> successive survey dump

[PATCH 05/10] rtlwifi: btcoex: 23b 1ant: Add power_on_setting

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih This change is highly related to init_hwconfig that was decomposed into two parts for better program flow. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang

Re: [PATCH v3 5/6] mwifiex: do not aggregate tcp ack in usb tx aggregation queue

2017-05-19 Thread Brian Norris
On Fri, May 19, 2017 at 09:06:44AM +, Xinming Hu wrote: > From: Xinming Hu > > Tcp ack should be send as soon to avoid throuput drop during receive tcp > traffic. > > Signed-off-by: Xinming Hu > Signed-off-by: Cathy Luo >

[PATCH 01/10] rtlwifi: btcoex: 23b 1ant: Switch antenna to wifi or BT.

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih Since wifi and BT share the same physical antenna, we should switch antenna to fit every situation. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc:

[PATCH 00/10] rtlwifi: btcoex: More updates for 23b 1ant

2017-05-19 Thread Larry Finger
This set is the second for file halbtc8723b1ant.c. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu Cc: Steven Ting

[PATCH 07/10] rtlwifi: btcoex: 23b 1ant: Setup register for BT WHCK test

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih If BT is under WHCK, we enter a special mode. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu

[PATCH 03/10] rtlwifi: btcoex: 23b 1ant: adjust wifi duration for bt a2dp

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih The larger the bt a2dp bit pool is, the more time bt needs to receive them. If we do not adjust the wifi duration, the voice quality will be low. Hence we reduce the time that wifi holds, to improve the a2dp service. If the bt is slave, it may receive a

[PATCH 08/10] rtlwifi: btcoex: 23b 1ant: Add rf status notification

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih If driver announce wifi RF status is off, btc can switch antenna to BT. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 04/10] rtlwifi: btcoex: 23b 1ant: add wifi_only argument to init_hwconfig

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih In case of wifi_only, we can simply switch antenna to wifi. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc:

[PATCH 02/10] rtlwifi: btcoex: 23b 1ant: need these information when scan

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih Log the scan procedure, and update ap_num for future usage when scan done. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 06/10] rtlwifi: btcoex: 23b 1ant: parse more BT information from C2H

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih BT FW provide more BT status as clues, thus we also display them in coex log to help debug in field. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc:

[PATCH 10/10] rtlwifi: btcoex: 23b 1ant: Revise media status notify to fix no scan result issue

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih Force antenna setup for no scan result issue Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu

[PATCH 09/10] rtlwifi: btcoex: 23b 1ant: fine tune connect notify

2017-05-19 Thread Larry Finger
From: Ping-Ke Shih When association starts, force antenna setup for no scan result issue. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

2017-05-19 Thread Arend Van Spriel
On 14-5-2017 13:45, Hans de Goede wrote: > Hi, > > On 14-05-17 10:21, Arend Van Spriel wrote: >> On 13-5-2017 16:55, Hans de Goede wrote: >>> Hi, >>> >>> On 13-05-17 15:39, Heiner Kallweit wrote: Am 13.05.2017 um 14:35 schrieb Hans de Goede: > > > Hi, > > On 13-05-17

Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

2017-05-19 Thread Heiner Kallweit
Am 19.05.2017 um 20:03 schrieb Arend Van Spriel: > On 14-5-2017 13:45, Hans de Goede wrote: >> Hi, >> >> On 14-05-17 10:21, Arend Van Spriel wrote: >>> On 13-5-2017 16:55, Hans de Goede wrote: Hi, On 13-05-17 15:39, Heiner Kallweit wrote: > Am 13.05.2017 um 14:35 schrieb Hans de

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> I've managed to split up my long patch into a series of reasonble >> steps now. >> >> The first two are required to fix a regression from commit 41977e86c984 >> ("rt2x00: add

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg wrote: > warning: 'rt2800_bbp_read' used but never defined > static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >^ >

Re: Make BCMA a menuconfig to ease disabling it all

2017-05-19 Thread Kalle Valo
Vincent Legoll wrote: > No need to get into the submenu to disable all BCMA-related config entries > > Signed-off-by: Vincent Legoll I would like to get an ack from someone before I'll apply this. Patch set to Deferred. --

Re: [01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-19 Thread Kalle Valo
Brian Norris wrote: > If we fail to add an interface in mwifiex_add_virtual_intf(), we might > hit a BUG_ON() in the networking code, because we didn't tear things > down properly. Among the problems: > > (a) when failing to allocate workqueues, we fail to unregister

Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code

2017-05-19 Thread Kalle Valo
Brian Norris wrote: > This code was duplicated as part of the PCIe FLR code added to this > driver. Let's de-duplicate it to: > > * make things easier to read (mwifiex_pcie_free_buffers() now has a >corresponding mwifiex_pcie_alloc_buffers()) > * reduce likelihood

Re: mwifiex: add missing USB-descriptor endianness conversion

2017-05-19 Thread Kalle Valo
Johan Hovold wrote: > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor bcdUSB field during probe. > > Signed-off-by: Johan Hovold Patch applied to wireless-drivers-next.git, thanks. a1ad7198202f mwifiex: add

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Kalle Valo
Arnd Bergmann writes: > On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg > wrote: >> warning: 'rt2800_bbp_read' used but never defined >> static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >>^ >>

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Kalle Valo
Arnd Bergmann writes: > On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: >> Arnd Bergmann writes: >> >>> I've managed to split up my long patch into a series of reasonble >>> steps now. >>> >>> The first two are required to fix a regression

[RFC] nl80211/cfg80211: allow setting multiple group cipher suites

2017-05-19 Thread Johannes Berg
From: Avraham Stern For drivers with SME offload, allow setting multiple group cipher suites so that userspace can configure all the permissible cipher suites allowing the driver to connect to a network that supports either of the configured group ciphers (similar to the

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 9:15 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: >>> Arnd Bergmann writes: >>> I've managed to split up my long patch into a series

Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

2017-05-19 Thread Kalle Valo
Arend Van Spriel wrote: > An issue was found brcmfmac driver in which a skbuff in .start_xmit() > callback was actually cloned. So instead of checking for sufficient > headroom it should also be writable. Hence use skb_cow_head() to > check and expand the headroom

Re: net: ath: tx99: fixed a spelling issue

2017-05-19 Thread Kalle Valo
ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick Patch applied to ath-next branch of ath.git, thanks. c46e2a848f29 ath9k: fix spelling in ath9k_tx99_init() -- https://patchwork.kernel.org/patch/9703211/

Re: [PATCH] brcmfmac: remove setting IBSS mode when stopping AP

2017-05-19 Thread Arend van Spriel
On 5/19/2017 6:49 AM, Kalle Valo wrote: Wright Feng writes: From: Chi-hsien Lin Setting IBSS mode when stopping AP may affect functionality of INFRA mode on another interface. For instance, if user creates and stops hostap daemon on

Re: ath5k: fix memory leak on buf on failed eeprom read

2017-05-19 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The AR5K_EEPROM_READ macro returns with -EIO if a read error > occurs causing a memory leak on the allocated buffer buf. Fix > this by explicitly calling ath5k_hw_nvram_read and exiting on > the

Re: [PATCH] brcmfmac: remove setting IBSS mode when stopping AP

2017-05-19 Thread Kalle Valo
Arend van Spriel writes: > On 5/19/2017 6:49 AM, Kalle Valo wrote: >> Wright Feng writes: >> >>> From: Chi-hsien Lin >>> >>> Setting IBSS mode when stopping AP may affect functionality of INFRA >>> mode on

Re: wil6210: use memdup_user

2017-05-19 Thread Kalle Valo
Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Patch applied to ath-next branch of ath.git, thanks. 9a49290919e1 wil6210: use memdup_user --

[PATCH V4 2/3] brcmfmac: add mutex to protect pno requests

2017-05-19 Thread Arend van Spriel
From: Arend Van Spriel The request references kept in pno are accessed in user-space context and in firmware event handler context. As such we need to protect it with a lock. As both context allow sleep a mutex seems appropriate. Reviewed-by: Hante Meuleman

[PATCH V4 1/3] brcmfmac: add support multi-scheduled scan

2017-05-19 Thread Arend van Spriel
From: Arend Van Spriel This change adds support for multi-scheduled scan in the driver. It currently relies on g-scan support in firmware and will set struct wiphy::max_sched_scan_reqs accordingly. This is limited to 16 concurrent requests. The firmware currently

[PATCH V4 3/3] brcmfmac: add scheduled scan support for specified BSSIDs

2017-05-19 Thread Arend van Spriel
From: Arend Van Spriel Add support to handle scheduled scan request containing BSSID in the matchsets. The firmware can send event upon finding BSSIDs and SSIDs. To get these in one event the bit REPORT_SEPARATELY needed to be removed from the flags in

Re: [v2] ath9k: remove unnecessary code

2017-05-19 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > The array field eeprom_data in struct th9k_platform_data > is a fixed size array so it can never be NULL. > > Addresses-Coverity-ID: 1364903 > Cc: Arend Van Spriel > Cc: Kalle Valo >

Re: ath9k: check ah->curchan when updating tx power

2017-05-19 Thread Kalle Valo
Stanislaw Gruszka wrote: > When driver fail to reset card ah->curchan value stay NULL. When > later driver try to update tx power it oops by using ah->curchan > (calltrace is shown below). > > This problem were reported at various places and for some it was > fixed by making

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 2:15 PM, Tom Psyborg wrote: > > > On 19 May 2017 at 08:55, Arnd Bergmann wrote: >> >> >> On which base version did you apply my patches? There may be a conflict >> against patches that are in your tree but not yet in linux-next,