Re: [PATCH] ssb:: use put_device() if device_register fail

2018-03-07 Thread arvindY
On Wednesday 07 March 2018 11:08 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 22:46:14 +0530 arvindY wrote: diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..c4449e0 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -521,6 +521,7 @@

[RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-07 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify a 'level'. This level can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow.

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-07 Thread Sebastian Gottschall
Am 07.03.2018 um 17:22 schrieb Rafał Miłecki: On 2 March 2018 at 10:22, Sebastian Gottschall wrote: leds-gpio is crap and limited. you can just register one platform data at kernel runtime since its identified by its object name "led-gpio" but the kernel forbidds to

Re: [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature

2018-03-07 Thread Jakub Kicinski
On Wed, 7 Mar 2018 10:25:50 +0100, Lorenzo Bianconi wrote: > Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since > dev pointer is never used in routine body > > Signed-off-by: Lorenzo Bianconi Acked-by: Jakub Kicinski

RE: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module

2018-03-07 Thread yamada.masahiro
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Tuesday, March 06, 2018 9:41 PM > To: Govind Singh ; Yamada, Masahiro/山田 真弘 > > Cc: linux-wireless@vger.kernel.org; ath...@lists.infradead.org > Subject:

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-07 Thread Enrico Mioso
And BTW, thank you to all of you involved on this, for the testing and the work involved. And all. BTW - happy woman fest to all of you wimen, and the ones you know. Enrico On Wed, 7 Mar 2018, Jamie Stuart wrote: Date: Wed, 7 Mar 2018 16:47:34 From: Jamie Stuart To:

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-07 Thread Enrico Mioso
Thank you very very much guys for keeping me up to date with the progress, it's important for me. Even if I am not subscribed to the list. Thank you for all guys. On Wed, 7 Mar 2018, Jamie Stuart wrote: Date: Wed, 7 Mar 2018 16:47:34 From: Jamie Stuart To: Stanislaw

[PATCH v3] ssb: use put_device() if device_register fail

2018-03-07 Thread Arvind Yadav
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- changes in v2: Removed kfree() call for @dev. changes in v3:

,Your urgent confirmation

2018-03-07 Thread James Williams
Attn: Beneficiary, We have contacted the Federal Ministry of Finance on your Behalf and they have brought a solution to your problem by coordinating your payment in total (10,000,000.00) Ten Million Dollars in an atm card which you can use to withdraw money from any ATM MACHINE CENTER anywhere in

[PATCH v3] iw: avgerage ack rssi changes for data frames

2018-03-07 Thread Balaji Pothunoori
This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities. Example output: localhost ~ #iw dev wlan-5000mhz station dump Station 34:f3:9a:aa:3b:29 (on wlan-5000mhz) inactive time: 5370 ms rx bytes:

[PATCH] mwifiex: correct antenna number with high bits reserved

2018-03-07 Thread Xinming Hu
High bits of antenna number are reserved in hardware spec, using low 4 bits represent supported antenna. Signed-off-by: Cathy Luo Signed-off-by: Xinming Hu --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] iw: avgerage ack rssi changes for data frames

2018-03-07 Thread Balaji Pothunoori
This patchset changes to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities. Example output: localhost ~ #iw dev wlan-5000mhz station dump Station 34:f3:9a:aa:3b:29 (on wlan-5000mhz) inactive time: 5370 ms rx

[PATCH] iw: avgerage ack rssi changes for data frames

2018-03-07 Thread Balaji Pothunoori
This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities. Example output: localhost ~ #iw dev wlan-5000mhz station dump Station 34:f3:9a:aa:3b:29 (on wlan-5000mhz) inactive time: 5370 ms rx bytes:

[PATCH v2] ssb: use put_device() if device_register fail

2018-03-07 Thread Arvind Yadav
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- changes in v2: Removed kfree() call for @dev. drivers/ssb/main.c | 2 +-

Re: [PATCH v2] ssb: use put_device() if device_register fail

2018-03-07 Thread Michael Büsch
On Thu, 8 Mar 2018 10:39:49 +0530 Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav

Re: [PATCH] ssb:: use put_device() if device_register fail

2018-03-07 Thread arvindY
On Wednesday 07 March 2018 10:17 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 15:31:30 +0530 Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH] ssb:: use put_device() if device_register fail

2018-03-07 Thread Michael Büsch
On Wed, 7 Mar 2018 22:46:14 +0530 arvindY wrote: > >> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > >> index 65420a9..c4449e0 100644 > >> --- a/drivers/ssb/main.c > >> +++ b/drivers/ssb/main.c > >> @@ -521,6 +521,7 @@ static int ssb_devices_register(struct

[PATCH] ssb:: use put_device() if device_register fail

2018-03-07 Thread Arvind Yadav
if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ssb/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..c4449e0

[PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature

2018-03-07 Thread Lorenzo Bianconi
Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since dev pointer is never used in routine body Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt7601u/mcu.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] ath10k: Advertize beacon_int_min_gcd

2018-03-07 Thread Anilkumar Kolli
This patch fixes regression caused by 0c317a02ca98 ("cfg80211: support virtual interfaces with different beacon intervals"), with this change cfg80211 expects the driver to advertize 'beacon_int_min_gcd' to support different beacon intervals in multivap scenario. This support is added for,

Re: [for-4.16, V3, 1/2] brcmfmac: add possibility to obtain firmware error

2018-03-07 Thread Kalle Valo
Arend Van Spriel wrote: > The feature module needs to evaluate the actual firmware error return > upon a control command. This adds a flag to struct brcmf_if that the > caller can set. This flag is checked to determine the error code that > needs to be returned. >

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-07 Thread Stanislaw Gruszka
I forgot to attach the patches, do it now. On Wed, Mar 07, 2018 at 01:27:01PM +0100, Stanislaw Gruszka wrote: > On Thu, Mar 01, 2018 at 04:30:10PM +0100, Daniel Golle wrote: > > [forwarding to all other involved players] > > > > On Thu, Mar 01, 2018 at 05:50:51PM +0300, Jamie Stuart wrote: > > >

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-07 Thread Stanislaw Gruszka
On Thu, Mar 01, 2018 at 04:30:10PM +0100, Daniel Golle wrote: > [forwarding to all other involved players] > > On Thu, Mar 01, 2018 at 05:50:51PM +0300, Jamie Stuart wrote: > > Hi Daniel, > > The driver seems much improved after this fix. > > it's about those two > [PATCH 1/2] rt2x00: pause

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-03-07 Thread Jamie Stuart
Hi Stanis, Our environment has the following wireless config (MT7620A): config wifi-device 'radio0' option type 'mac80211' option channel 'auto' option hwmode '11g' option path 'platform/1018.wmac' option txpower '20' option country 'GB'

Re: [PATCH] ssb:: use put_device() if device_register fail

2018-03-07 Thread Michael Büsch
On Wed, 7 Mar 2018 15:31:30 +0530 Arvind Yadav wrote: > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/ssb/main.c | 1 + > 1 file

[PATCH] mac80211_hwsim: fixed use-after-free bug in hwsim_exit_net

2018-03-07 Thread Benjamin Beichler
When destroying a net namespace, all hwsim interfaces, which are not created in default namespace are deleted. But the async deletion of the interfaces could last longer than the actual destruction of the namespace, which results to an use after free bug. Therefore use synchronous deletion in this

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-07 Thread Rafał Miłecki
On 2 March 2018 at 10:22, Sebastian Gottschall wrote: >>> leds-gpio is crap and limited. you can just register one platform data at >>> kernel runtime since its identified by its object name "led-gpio" but the >>> kernel forbidds to register 2 platform datas with the same

Re: Query on queues in mesh mode

2018-03-07 Thread Phani Siriki
Hi Thomas Thank you for your reply. Could you please let me know how can I verify these queues on a mesh router? (I am using TPLink router with Ath9k chipset). Also, the TXQ parameters can only be set if device is in AP or P2P mode. Do you have any idea why this restriction is in place?