Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-12 Thread Mathias Kresin
10.03.2018 08:56, Sebastian Gottschall: taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the mix. It adds extra complexity and an extra dependency

[PATCH] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

2018-03-12 Thread hariprasath . elango
From: Hari Prasath Use the kernel pre-defined macro is_broadcast_ether_addr() instead of doing a memcmp here. Signed-off-by: Hari Prasath --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drive

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

2018-03-12 Thread Arend van Spriel
On 3/11/2018 10:47 PM, Hans de Goede wrote: Various models Asus laptops with a SDIO attached brcmfmac wifi chip, store the nvram contents in a special EFI variable. This commit adds support for getting nvram directly from this EFI variable, without the user needing to manually copy it. This make

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-03-12 Thread Sebastian Gottschall
Am 12.03.2018 um 08:53 schrieb Mathias Kresin: 10.03.2018 08:56, Sebastian Gottschall: taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the mix.

Re: [PATCH] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

2018-03-12 Thread
On Mon, Mar 12, 2018 at 02:17:15PM +0530, hariprasath.ela...@gmail.com wrote: > From: Hari Prasath > > Use the kernel pre-defined macro is_broadcast_ether_addr() instead of > doing a memcmp here. > > Signed-off-by: Hari Prasath > --- > drivers/staging/wilc1000/linux_mon.c | 3 +-- > 1 file cha

[PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

2018-03-12 Thread hariprasath . elango
From: HariPrasath Elango Use the kernel pre-defined macro is_broadcast_ether_addr() instead of doing a memcmp here. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mo

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-12 Thread Kalle Valo
Arend Van Spriel wrote: > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > it is possible to initiate a device coredump from user-space. This > patch adds support for it adding the .coredump() driver callback. > As there is no longer a need to initiate it through debugfs rem

Re: [PATCH] brcmfmac: Add support for getting nvram contents from EFI variables

2018-03-12 Thread Hans de Goede
Hi, On 12-03-18 09:55, Arend van Spriel wrote: On 3/11/2018 10:47 PM, Hans de Goede wrote: Various models Asus laptops with a SDIO attached brcmfmac wifi chip, store the nvram contents in a special EFI variable. This commit adds support for getting nvram directly from this EFI variable, without

Re: [RESEND] rsi: Remove stack VLA usage

2018-03-12 Thread Kalle Valo
tcharding wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum size. We add a

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 27 February 2018 at 18:05, Stephen Hemminger wrote: > On Tue, 27 Feb 2018 11:08:20 +0100 > Rafał Miłecki wrote: > >> I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> FullMAC WiFi chipset. >> >> >> First of all OpenWrt/LEDE uses bridge interface for LAN network with: >>

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 28 February 2018 at 12:31, Arend van Spriel wrote: > On 2/27/2018 11:14 AM, Rafał Miłecki wrote: >> >> Sending with a fixed linux-wireless ML address. Please kindly send your >> replies using linux-wireless@ >> >> On 02/27/2018 11:08 AM, Rafał Miłecki wrote: >>> >>> I've problem when using Open

Re: [v9 0/8] rsi: add bluetooth and coex support

2018-03-12 Thread Kalle Valo
Amitkumar Karwar writes: > From: Amitkumar Karwar > > This patch series adds new bluetooth driver and coex enhancments > in existing wlan driver for RSI chipsets. > As per our architecture, both wlan and bluetooth drivers talk > over same SDIO interface to device. Separate endpoint will be > use

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > FullMAC WiFi chipset. Hi Rafał, Thanks for reporting this issue! > Can you see any solution for this problem? Is that an option to stop > multicast-to-unicast

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Mon, Mar 12, 2018 at 10:46:45AM +0100, Rafał Miłecki wrote: > On 27 February 2018 at 18:05, Stephen Hemminger [...] > > ebtables is your friend in dealing with weird and broken devices. > > It may be weird, not sure if actually broken. Anyway I'd like to have > some generic solution instead of

[PATCH] ath10k: Fix kernel panic while using worker (ath10k_sta_rc_update_wk)

2018-03-12 Thread Karthikeyan Periyasamy
When attempt to run worker (ath10k_sta_rc_update_wk) after the station object (ieee80211_sta) delete will trigger the kernel panic. This problem arise in AP + Mesh configuration, Where the current node AP VAP and neighbor node mesh VAP MAC address are same. When the current mesh node try to establ

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Linus Lüssing
On Mon, Mar 12, 2018 at 12:08:56PM +0100, Linus Lüssing wrote: > On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: > > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > > FullMAC WiFi chipset. > > Hi Rafał, > > Thanks for reporting this issue! > > > Can you see

Re: [2/3] mwifiex: support sysfs initiated device coredump

2018-03-12 Thread Arend van Spriel
On 3/12/2018 10:41 AM, Kalle Valo wrote: Arend Van Spriel wrote: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is no longer a nee

[PATCH] staging: wilc1000: Fix code block alignment

2018-03-12 Thread hariprasath . elango
From: HariPrasath Elango Fix the code alignment for a block of code to adhere to coding guidelines Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/driv

Re: pull-request: iwlwifi firmwares update 2018-03-02

2018-03-12 Thread Josh Boyer
On Fri, Mar 2, 2018 at 5:58 AM, Luca Coelho wrote: > Hi, > > I have updated the firmwares for the 9000 series. > > Please pull or let me know if there are any issues. > > Cheers, > Luca. > > > The following changes since commit 7344ec9e1df9e27d105ed48d2db99e22370236de: > > Merge branch 'ath10k-2

[PATCH] staging: wilc1000: Destroy mutex object in deinitialization

2018-03-12 Thread hariprasath . elango
From: HariPrasath Elango Destroy the mutex object that is initialized in wlan_init_locks() Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_wlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wla

[PATCH v2] wcn36xx: Add support for FTM WLAN

2018-03-12 Thread Ramon Fried
From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved as follows: 1) Register w

[PATCH] net: drivers/net: Remove unnecessary skb_copy_expand OOM messages

2018-03-12 Thread Joe Perches
skb_copy_expand without __GFP_NOWARN already does a dump_stack on OOM so these messages are redundant. Signed-off-by: Joe Perches --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 - drivers/net/usb/lg-vl600.c | 6 +- drivers/net/wimax/i2400m/usb-rx.c | 3 --- drivers/net/wi

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-12 Thread Luis R. Rodriguez
On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: > On 3/11/2018 5:05 PM, Andres Rodriguez wrote: > > > Your patch series then should also have the driver callers who you > > > want to modify to use this new API. Collect from the 802.11 folks the > > > other drivers which I think th

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 12 March 2018 at 12:08, Linus Lüssing wrote: > On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: >> I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> FullMAC WiFi chipset. > > Hi Rafał, > > Thanks for reporting this issue! > >> Can you see any solution for th

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 12 March 2018 at 12:48, Linus Lüssing wrote: > On Mon, Mar 12, 2018 at 12:08:56PM +0100, Linus Lüssing wrote: >> On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: >> > I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> > FullMAC WiFi chipset. >> >> Hi Rafał, >

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network with: 1) IFLA_BRPORT_MCAST_TO_UCAST 2) Clients isolation in hostapd 3) Hairpin mode enabled F

Re: [PATCH v3 20/20] mt7601u: use request_firmware_cache() to address cache on reboot

2018-03-12 Thread Jakub Kicinski
On Sat, 10 Mar 2018 06:15:01 -0800, Luis R. Rodriguez wrote: > request_firmware_cache() will ensure the firmware is available on resume > from suspend if on reboot the device retains the firmware. > > This optimization is in place given otherwise on reboot we have to > reload the firmware, the opm

[PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

2018-03-12 Thread hariprasath . elango
From: HariPrasath Elango Kmalloc followed by memcpy can be replaced by kmemdup. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linu

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-12 Thread Rafał Miłecki
On 03/13/2018 12:01 AM, Stephen Hemminger wrote: On Mon, 12 Mar 2018 23:42:48 +0100 Rafał Miłecki wrote: 2) Blame bridge + mcast-to-ucast + hairpin for 802.11f incompatibility If we agree that 802.11f support in FullMAC firmware is acceptable, then we have to make sure Linux's bridge doesn't