From: Zhi Chen
The 5ghz channel parameters of TLV target wasn't passed to host, it caused
host can only use lower channels from 36 to 64.
Signed-off-by: Zhi Chen
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/
From: Zhi Chen
Length of WMI scan message was not calculated correctly. The allocated
buffer was smaller than what we expected. So WMI message corrupted
skb_info, which is at the end of skb->data. This fix takes TLV header
into account even if the element is zero-length.
Crash log:
[49.629986]
On 14-03-18 15:34, Kalle Valo wrote:
Bas Vermeulen writes:
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -67,6 +67,9 @@ static int ath9k_ps_enable;
module_param_named(ps_enable, ath9k_ps_enable, int, 0444);
MODULE_PARM_DESC(ps_enable, "Enabl
On Mon, Apr 09, 2018 at 04:53:44PM +0200, Lorenzo Bianconi wrote:
> On Apr 09, Stanislaw Gruszka wrote:
> > On Mon, Apr 09, 2018 at 04:26:42PM +0200, Lorenzo Bianconi wrote:
> > > > I would like to integrate the driver to kernel via mt76 driver, i.e.
> > > > add USB hooks and mt76x0 mac/phy code to
Hi
On Mon, Apr 09, 2018 at 08:45:20PM +0200, Hans Ulli Kroll wrote:
> here are my changes for working 5Ghz band and more USB ID's form my side
I applied the changes and pushed to github repo.
Thanks
Stanislaw
Am 09.04.2018 um 17:49 schrieb Kalle Valo:
Sebastian Gottschall writes:
you removed the call to leds_start from certain locations but you seem
to have ignored the comment i wrote above the function call.
IIRC I moved the comment to ath10k_leds_start().
there is a reason why i reinitialize t
On Sun, Apr 08, 2018 at 08:58:35AM +0200, Dusan Bruncko wrote:
> My problem is following: This firmware was created for kernel 4.2+,
> but I am using
> Centos 7 with kernels a la 3.10. Therefore I see during booting and
Wireless stack and drivers are regularly updated in Centos kernel,
(for exampl
zd1201_probe() is never called in atomic context.
zd1201_probe() is only set as ".probe" in struct usb_driver.
Despite never getting called from atomic context, zd1201_probe()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.
This is fo
zd1201_probe() is never called in atomic context.
zd1201_fw_upload() is only called by zd1201_probe(),
which is only set as ".probe" in struct usb_driver.
Despite never getting called from atomic context,
zd1201_fw_upload() calls kmalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GF
flashgchar() is never called in atomic context.
flashgchar() is only called by flashcard().
flashcard() calls copy_from_user() and kmalloc(GFP_KERNEL), which
indicates this function is not called in atomic context.
Despite never getting called from atomic context, flashgchar()
calls mdelay() to
dma_tx_fragment() is never called in atomic context.
dma_tx_fragment() is only called by b43legacy_dma_tx(), which is
only called by b43legacy_tx_work().
b43legacy_tx_work() is only set a parameter of INIT_WORK() in
b43legacy_wireless_init().
Despite never getting called from atomic context,
dm
From: Rakesh Pillai
Enable STA idle mode power save(IMPS) for WCN3990 TLV target.
In-order to support STA idle mode ps direct access to CE registers are
protected via 2 mechanism. As target can power collapse based on idle
inactivity and any target register access during that state can lead to
u
From: Rakesh Pillai
wcn3990 supports shadow register for ce write.
Add a hw param for shadow register support.
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/core.c | 13 +
drivers/net/wireless/ath/ath10k/hw.h | 4
2 files changed, 17 insertions(+)
diff
From: Govind Singh
SRRI/DRRI are not mapped in the HW Shadow block and can lead
to un-clocked access if common subsystem in the target is
powered down due to idle mode.
To mitigate this problem SRRI/DRRI can be read from
DDR instead of doing an actual hardware read.
Host allocates non cached mem
From: Govind Singh
Enable sta power save in fw for the targets that
supports idle power save. The idle ps enable command
will be ignored by the firmware which does not support
this feature.
Signed-off-by: Govind Singh
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/mac.c | 7
From: Rakesh Pillai
WCN3990 needs shadow register write operation support
for copy engine for regular operation in powersave mode.
Add support for copy engine shadow register write in
datapath tx for WCN3990
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/ce.c | 143 ++
Govind Singh wrote:
> Add device tree binding documentation details for wcn3990
> wifi block present in Qualcomm SDM845/APQ8098 SoC into
> "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh
> Signed-off-by: Kalle Valo
Govind, you forgot to CC devicetree list. I was wondering why there's no ac
Arnd Bergmann wrote:
> The way that 'strncat' is used here raised a warning in gcc-8:
>
> drivers/net/wireless/ath/ath10k/wmi.c: In function
> 'ath10k_wmi_tpc_stats_final_disp_tables':
> drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output
> truncated before terminating nul co
Colin Ian King wrote:
> The pointer ndev is being dereferenced before it is being null checked,
> hence there is a potential null pointer deference. Fix this by only
> dereferencing ndev after it has been null checked
>
> Detected by CoverityScan, CID#1467010 ("Dereference before null check")
>
Marcus Folkesson wrote:
> These allocations are not freed upon release.
> When on it; go for managed resources instead.
>
> Signed-off-by: Marcus Folkesson
> [kvalo: fix two checkpatch warnings]
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
ec2c64e20257 ath
Colin Ian King wrote:
> Trivial fix to spelling mistake in message text
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
6ce36faeac35 ath10k: fix spelling mistake: "tiggers" -> "triggers"
--
https://patchwork.kernel.org/patc
"Gustavo A. R. Silva" wrote:
> In preparation to enabling -Wvla, remove accidental use of stack VLA.
>
> This avoids an accidental stack VLA (since the compiler thinks
> the value of FFT_NUM_SAMPLES can change, even when marked
> "const"). This just replaces it with a #define.
>
> Also, fixed a
On Tue, 2018-04-10 at 02:19 +, Xinming Hu wrote:
> Hi Kalle,
>
> > -Original Message-
> > From: Kalle Valo [mailto:kv...@codeaurora.org]
> > Sent: 2018年4月9日 18:51
> > To: Xinming Hu
> > Cc: Linux Wireless ; Brian Norris
> > ; Dmitry Torokhov ;
> > raja...@google.com; Zhiyuan Yang ; Ti
Daniel Mack wrote:
> Bail out if the mapping fails. Even though this hasn't occured during
> tests, this unlikely case should still be handled.
>
> Signed-off-by: Daniel Mack
> Acked-by: Ramon Fried
> Signed-off-by: Kalle Valo
3 patches applied to ath-next branch of ath.git, thanks.
7cae351
Loic Poulain wrote:
> This prevents GCC warning.
>
> Reported-by: Dan Carpenter
> Signed-off-by: Loic Poulain
> Acked-by: Bjorn Andersson
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
1391cce7daf6 wcn36xx: Add missing fall through comment in smd.c
--
ht
Loic Poulain wrote:
> Each DXE control block is associated to a specific channel.
> The channel lock is always taken before accessing a control block.
> There is no need to have an extra (useless) spinlock for the control
> block skb.
>
> Signed-off-by: Loic Poulain
> Signed-off-by: Kalle Valo
Remove unnecessary braces {} around an 'if' statement block with a single
statement. Issue found by checkpatch.
Signed-off-by: Eyal Ilsar
---
This is part of my take on the Eudyptula challenge
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
Daniel Mack wrote:
> GFP_ATOMIC should only be used when the allocation is done from atomic
> context. Introduce a new flag to wcn36xx_dxe_fill_skb() and use GFP_KERNEL
> when pre-allocating buffers during init.
>
> This doesn't fix an issue that was observed in the wild, but it reduces
> the ch
From: Siva Rebbagondla
This patch series brings in some improvements in power save, Tx data
path etc.
Changes in v2:
Below patches are split and created smaller incremental patches[Kalle]
[08/10] rsi: device disconnect changes
[09/10] rsi: tx improvements
Amitkumar Karwa
From: Amitkumar Karwar
Some device configuration flags need to be enabled while sending 'bootup
params' internal frame to firmware. This patch takes care of it.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_boot_params.h | 3 ++-
1 file chang
From: Amitkumar Karwar
Power save request should be sent on station interface. Virtual
interface which is connected should be preferred. This patch
resolves device not entering power save problem in certain
situations
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers
From: Amitkumar Karwar
Firmware's watchdog timer should be disabled as a part of reset
sequence. This change fixes a firmware hang issue observed during
stress tests.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_91x_usb.c | 7 +++
driver
From: Amitkumar Karwar
Currently TID is extracted by checking at specific offset in data frame.
This approach doesn't work for some of the frames. This patch uses mac80211
API and do it correctly
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_
From: Amitkumar Karwar
Power save is by default enabled for WLAN and BT coex mode.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
From: Amitkumar Karwar
Maximum number of supported aggregation subframes has been increased
to 8. This is the optimal number for the driver.
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 3 ++-
drivers/net/wireless/rsi/rsi_mg
From: Amitkumar Karwar
Currently 5GHz gets advertised even for the device which supports
only 2.4Ghz band. This patch fixes the issue
Signed-off-by: Amitkumar Karwar
Signed-off-by: Siva Rebbagondla
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 11 +++
1 file changed, 7 insertions(
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".
Signed-off-by: Govind Singh
---
.../bindings/net/wireless/qcom,ath10k.txt | 31 ++
1 file changed, 31 insertions(+)
diff --git a/Docum
On Tue, 10 Apr 2018 21:54:19 +0800
Jia-Ju Bai wrote:
> dma_tx_fragment() is never called in atomic context.
>
> dma_tx_fragment() is only called by b43legacy_dma_tx(), which is
> only called by b43legacy_tx_work().
> b43legacy_tx_work() is only set a parameter of INIT_WORK() in
> b43legacy_wir
Thanks Rob for the review comments. I have addressed the review comments
in [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block.
diff --git
a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index
When accessing shared memory to check for the stat of submitted
descriptors, make sure to use READ_ONCE(). This will guarantee the
compiler treats these memory locations as volatile and doesn't apply
any caching.
While this doesn't fix any particular problem I ran into, it's best
practice to do it
When wcn36xx_dxe_tx_frame() is entered while the device is still processing
the queue asyncronously, we are racing against the firmware code with
updates to the buffer descriptors. Presumably, the firmware scans the ring
buffer that holds the descriptors and scans for a valid control descriptor,
an
I found something that I believe might be an issue, and I have an
idea on how to correct this, but unfortunately, this doesn't solve
the issues I occasionally see with this driver. I'd still like to
share it, because I might be totally mistaken in my understanding.
With no firmware code or docume
On 10 April 2018 at 20:42, Daniel Mack wrote:
> I found something that I believe might be an issue, and I have an
> idea on how to correct this, but unfortunately, this doesn't solve
> the issues I occasionally see with this driver. I'd still like to
> share it, because I might be totally mistaken
On 10 April 2018 at 20:35, Daniel Mack wrote:
> When accessing shared memory to check for the stat of submitted
> descriptors, make sure to use READ_ONCE(). This will guarantee the
> compiler treats these memory locations as volatile and doesn't apply
> any caching.
The structure that is tested is
On Fri, Mar 30, 2018 at 01:24:44PM +0530, Nipun Gupta wrote:
> It is bus specific aspect to map a given device on the bus and
> relevant firmware description of its DMA configuration.
> So, this change introduces 'dma_configure' as bus callback
> giving flexibility to busses for implementing its ow
On Fri, Mar 30, 2018 at 01:24:45PM +0530, Nipun Gupta wrote:
> With each bus implementing its own DMA configuration callback,
> there is no need for bus to explicitly have force_dma in its
> global structure. This patch modifies of_dma_configure API to
> accept an input parameter which specifies if
hi.
I am trying to capture on 2 channels at the same time with 2 cards.
One card is TP-Link TL-W722N v1 using ath9k_htc and the second one is
an Alfa AWUS051NH v2 using rt2800usb.
I have tried this, first, on raspberry pi 0 W using archlinux-arm and
reproduced the issue on a netbook using archl
Hi Ramon,
On Tuesday, April 10, 2018 08:11 PM, Ramon Fried wrote:
> On 10 April 2018 at 20:42, Daniel Mack wrote:
>> I found something that I believe might be an issue, and I have an
>> idea on how to correct this, but unfortunately, this doesn't solve
>> the issues I occasionally see with this d
From: Siva Rebbagondla
Following overflow kernel panic is observed on some platforms while
loading the driver. It is fixed if dynamically allocated memory is
passed to SDIO instead of static one
[ 927.513963] nommu_map_sg: overflow 17d54064ba7c+20 of device mask
[ 927.517712] Modules
From: Siva Rebbagondla
While performing cleanup, driver is messing with card->ocr
value by not masking rocr against ocr_avail. Below panic
is observed with some of the SDIO host controllers due to
this. Issue is resolved by reverting incorrect modifications
to vdd.
[ 927.423821] mmc1: Invalid v
On Tuesday, April 10, 2018 08:17 PM, Ramon Fried wrote:
> On 10 April 2018 at 20:35, Daniel Mack wrote:
>> When accessing shared memory to check for the stat of submitted
>> descriptors, make sure to use READ_ONCE(). This will guarantee the
>> compiler treats these memory locations as volatile and
51 matches
Mail list logo