Re: rtlwifi: btcoex: remove identical statements within if-else branches

Ping-Ke Shih wrote: > From: Ping-Ke Shih > > Since the statements are identical, we can safely remove the statements. > The commit 42e74946f016 ("rtlwifi: btcoexist: Fix if == else warnings in > halbtc8821a1ant.c") had fixed the statements, but the

Re: [PATCH v2 00/17] rtlwifi: halmac: Add new module halmac

writes: > From: Ping-Ke Shih > > v2: remove indirection to get halmac ops > Only patches 1/17 and 11/17 are changed. > > Patches 1/17-3/17 are added structure to support this module. > Patches 4/17-16/17 add new files. > Patch 17/17 add this module to

Re: [v2] rsi: remove unecessary PTR_ALIGN()s

Dan Carpenter wrote: > The issue here is that we allocate "data" and then set > "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer > instead of the original pointer. > > kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or > more on

Re: [v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

Lorenzo Bianconi wrote: > Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value > will be properly set according to the usage of an external power amplifier > > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix

Re: [3/3] qtnfmac: add DFS offload support

Sergey Matyukevich wrote: > From: Dmitry Lebed > > DFS offload support implemented: > - DFS_OFFLOAD feature is advertised depending on HW capabilities > - CAC_STARTED event forwarding from HW implemented > - start_radar_detection()

Re: [1/2,v2] mt7601u: use EWMA to calculate avg_rssi

Stanislaw Gruszka wrote: > avr_rssi is not calculated correctly as we do not divide result > by 256 (mt76 sum avg_rssi1 and avg_rssi2 and divide by 512). > However dividing by 256 will make avg_rssi almost the same as > last rssi value - not really an average. So use EWMA to

Re: mt76x2: fix TXD_INFO bitmask definition

Lorenzo Bianconi wrote: > Despite this issue is not harmful since it is not actually used in > mt76 driver, fix DMA txinfo bitmask definition > > Fixes: 7bc04215a66b ('mt76: add driver code for MT76x2e') > Signed-off-by: Lorenzo Bianconi

Re: mt76x2: set default values in TX_ALC_CFG_{1, 2} for tempetaure compensation

Lorenzo Bianconi wrote: > Initialize default values for temperature compensation in TX_ALC_CFG_{1,2} > if tssi has been enabled > > Signed-off-by: Lorenzo Bianconi Patch applied to wireless-drivers-next.git, thanks. b9e5d4feb4fc

[PATCH 2/2] staging: wilc1000: updated TODO list

Removed the items from WILC1000 TODO list, which are already addressed to keep it updated. The removed items are already taken care by previously submitted patches. Signed-off-by: Ajay Singh --- If someone feels differently please update for this patch. There are

[PATCH 0/2] staging: wilc1000: TODO list updates

Updated the TODO list by removing items, which are already addressed. Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is not present in the driver. Ajay Singh (2): staging: wilc1000: remove registering of ndo_do_ioctl callback staging: wilc1000: updated TODO list

[PATCH 1/2] staging: wilc1000: remove registering of ndo_do_ioctl callback

Remove registering of ndo_do_ioctl in wilc_netdev_ops structure. As RSSI information is already avaliable through cfg80211, so remove the IOCTL call use to fetch the same information. Wext support is not present in the driver. Its also done to address the TODO list item mentioned below: "use

Re: mt76x2: fix tx_alc_enabled check

Lorenzo Bianconi wrote: > Fix mt76x2_temp_tx_alc_enabled routine since in order to enable tx_alc > temperature compensation it necessary to take into account BIT(15) of > MT_EE_TX_POWER_EXT_PA_5G eeprom info > > Fixes: 7bc04215a66b ("mt76: add driver code for

Re: ath9k_htc - Division by zero in kernel (as well as firmware panic)

I finally got around to applying your patch, building the toolchain (based on master source (gcc8)), but alas while there is no firmware panic in the log, wifi drops off the face of the planet (ssid disappears and hostapd doesn't know wifi failed (nothing in the log either)). On Wed, Jun 7, 2017

Re: mt76x2: fix tssi initialization for 5GHz band

Lorenzo Bianconi wrote: > Fix mcu initial configuration for tssi calibration on 5GHz band > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix Fietkau Patch

Re: mt7601u: phy: mark expected switch fall-through

"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Jakub Kicinski Patch applied to

Re: [1/2] rsi: fix nommu_map_sg overflow kernel panic

Amitkumar Karwar wrote: > From: Siva Rebbagondla > > Following overflow kernel panic is observed on some platforms while > loading the driver. It is fixed if dynamically allocated memory is > passed to SDIO instead of static one > > [

Re: [v2,1/7] rsi: disable fw watchdog timer during reset

Siva Rebbagondla wrote: > From: Amitkumar Karwar > > Firmware's watchdog timer should be disabled as a part of reset > sequence. This change fixes a firmware hang issue observed during > stress tests. > > Signed-off-by: Amitkumar Karwar

Re: [v2, RESEND, 1/4] rsi: move xtend_desc structure from rsi_main.h to rsi_mgmt.h

Amitkumar Karwar wrote: > From: Prameela Rani Garnepudi > > All descriptor structures are in rsi_mgmt.h except this > extended descriptor structure. Hence moving it to rsi_mgmt.h > and also renaming to rsi_xtend_desc. > > Signed-off-by: Prameela

Re: cw1200: fix spelling mistake: "Mailformed" -> "Malformed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in wiphy_warn warning message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: mt76x2: make mt76x2_mac_reset routine static

Lorenzo Bianconi wrote: > Add static qualifier to mt76x2_mac_reset routine and remove the > prototype from mt76x2_mac.h since it is used just in mt76x2_init.c > > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix Fietkau

Re: [1/7] mt76: stop tx queues from the driver callback instead of common code

Felix Fietkau wrote: > Allows the driver to control whether to send a BlockAckReq after waking > up. MT76x2 needs this set to true, for MT7603 (to be submitted later) > it needs to be false. > > Signed-off-by: Felix Fietkau 7 patches applied to

rsi_91x: Failed to read status register / FIRMWARE Assert issues

Hi Amitkumar, I'm seeing quite a strange behavior of RedPine RS9113SB module. I tried to use it as wifi hotspot, and sometimes I fail to connect to it. Moreover after that failure RSI driver starts to flood me with following messages: Issue 1: ->8 rsi_91x:

[PATCH v3 16/19] rtlwifi: halmac: add bus interface commands

From: Ping-Ke Shih The halmac supports three buses interfaces, PCI, USB and SDIO, and this commit makes it possible to change their phy parameters. Signed-off-by: Ping-Ke Shih --- .../halmac_88xx/halmac_8822b/halmac_pcie_8822b.c | 218 +

[PATCH v3 12/19] rtlwifi: halmac: access efuse through halmac helper functions

From: Ping-Ke Shih This file provides interfaces to read and write efuse contents. Signed-off-by: Ping-Ke Shih --- .../rtlwifi/halmac/halmac_88xx/halmac_efuse_88xx.c | 1918 .../rtlwifi/halmac/halmac_88xx/halmac_efuse_88xx.h | 101

[PATCH v3 17/19] rtlwifi: halmac: add to control WiFi mac functions and registers

From: Ping-Ke Shih This commit provides WiFi mac functions to control wifi easier, and also provides generic access entries for driver and other modules. Signed-off-by: Ping-Ke Shih --- .../halmac_8822b/halmac_cfg_wmac_8822b.c | 144 +

[PATCH v3 18/19] rtlwifi: halmac: add to support BB and RF functions

From: Ping-Ke Shih Some BB and RF functions collaborate with firmware or MAC. For instances, the IQK and PSD functions are implemented in firmware, so use a H2C command to trigger. For MIMO function, use the helper functions to control related MAC registers. Signed-off-by:

[PATCH v3 10/19] rtlwifi: halmac: add GPIO pin/pinmux definitions

From: Ping-Ke Shih GPIO with pinmux can switch to many functions such as LED, UART, JTAG, WoWLAN, etc. Signed-off-by: Ping-Ke Shih --- .../halmac_88xx/halmac_8822b/halmac_gpio_8822b.c | 847 +

[PATCH v3 14/19] rtlwifi: halmac: add halmac init/deinit functions

From: Ping-Ke Shih Add files to initialize and free halmac context. Since halmac is an three levels hierarchy file structure, so the added files provide interfaces of halmac, 88xx and 8822b. Signed-off-by: Ping-Ke Shih ---

[PATCH v3 13/19] rtlwifi: halmac: add files to implement halmac ops

From: Ping-Ke Shih The structure halmac_ops defined in wifi.h, and this commit implements and hooks ops to the structure, so a symbol rtl_halmac_get_ops_pointer is expoerted to access this module. Meanwhile, we implement ops defined and needed by this module. Signed-off-by:

[PATCH v3 01/19] rtlwifi: add halmac structure to wifi.h

From: Ping-Ke Shih Add structure and ops to interact with halmac and other modules. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 58 + 1 file changed, 58 insertions(+) diff --git

[PATCH v3 06/19] rtlwifi: halmac: add register definitions

From: Ping-Ke Shih List all MAC registers including rtl8822b. Signed-off-by: Ping-Ke Shih --- .../wireless/realtek/rtlwifi/halmac/halmac_reg2.h | 1292 .../realtek/rtlwifi/halmac/halmac_reg_8822b.h | 733 +++ 2 files

[PATCH v3 19/19] rtlwifi: add halmac to Makefile and Kconfig

From: Ping-Ke Shih Add halmac to Makefile and Kconfig, so we can build this module if 8822BE is selected. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/Kconfig | 5 drivers/net/wireless/realtek/rtlwifi/Makefile |

[PATCH v3 02/19] rtlwifi: add debug ID COMP_HALMAC

From: Ping-Ke Shih Add a debug ID for the module halmac Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/debug.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.h

[PATCH v3 05/19] rtlwifi: halmac: describe number and size of chip functions

From: Ping-Ke Shih The number and size of chip fucntions are different, such as TX/RX FIFO size, efuse size, etc. So they are defined in an individual file. Signed-off-by: Ping-Ke Shih --- .../halmac_88xx/halmac_8822b/halmac_8822b_cfg.h| 68

[PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

From: Ping-Ke Shih v3: patch 06/17 in v2 is too big, so mail server may block the mail. In this patchset, I decompose the patch into three patches 06/19-08/19, so in patchset view v2 and v3 are identical. v2: remove indirection to get halmac ops Only patches 1/17

[PATCH v3 04/19] rtlwifi: halmac: add main definition used by halmac

From: Ping-Ke Shih The files contain main definition of struct, enum, prototypes, state machine, etc. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/halmac/halmac_state_machine.h | 157 ++ .../wireless/realtek/rtlwifi/halmac/halmac_type.h | 2134

[PATCH v3 09/19] rtlwifi: halmac: add definition of TX/RX descriptor

From: Ping-Ke Shih TX/RX descriptor are the headers to describe the packet content. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/halmac/halmac_rx_bd_nic.h | 36 ++ .../realtek/rtlwifi/halmac/halmac_rx_desc_chip.h | 100 +

[PATCH v3 11/19] rtlwifi: halmac: add power sequence to turn on/off wifi card

From: Ping-Ke Shih Define power sequence command, and fill the sequences of 8822b. Signed-off-by: Ping-Ke Shih --- .../halmac_8822b/halmac_pwr_seq_8822b.c| 396 + .../halmac_8822b/halmac_pwr_seq_8822b.h| 26

Re: [PATCH v2 00/17] rtlwifi: halmac: Add new module halmac

On Tue, 2018-04-24 at 17:12 +, Kalle Valo wrote: > writes: >  > > From: Ping-Ke Shih > > > > v2: remove indirection to get halmac ops > > Only patches 1/17 and 11/17 are changed. > > > > Patches 1/17-3/17 are added structure to support this module.

[PATCH v3 03/19] rtlwifi: add dmdef.h to share with driver and other modules

From: Ping-Ke Shih This header file is maintained by new module phydm, and share with driver and other modules, such as halmac. This patch adds only one enumeration, and more information will be added later. Signed-off-by: Ping-Ke Shih ---

linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree

Hi all, Commit 84226ca1c5d3 ("iwlwifi: mvm: support offload of AMSDU rate control") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpH_8cAXV1iy.pgp Description: OpenPGP digital signature

Re: Simultaneous 2.4 GHz WiFi and Bluetooth issue on Intel Dual Band Wireless-AC 8260

On 04/20/2018 01:03 AM, Emmanuel Grumbach wrote: >> Under Windows 10, the hardware appears to work without issue. >> Additionally, I believe I managed to warm-reboot from Windows 10 to >> Linux (with Bluetooth connected), and was able to continue using the >> same 2.4 GHz WiFi and Bluetooth audio

[PATCH v3] ath9k: dfs: Remove VLA usage

In the quest to remove all stack VLA usage from the kernel[1], this redefines FFT_NUM_SAMPLES as a #define instead of const int, which still triggers gcc's VLA checking pass. [1] https://lkml.org/lkml/2018/3/7/621 Co-developed-by: Andreas Christoforou Signed-off-by:

[PATCH] mwifiex: fix nested rtnl locking on BG_SCAN_STOPPED

Whenever sched_scan(BG_SCAN) is in progress and driver downloads any command, firmware will send an event BG_SCAN_STOPPED. On recieving this, driver calls cfg80211_sched_scan_stopped. This function in turn will try to acquire rtnl_lock. But if the rtnl_lock was already held(while sending the

RE: [linuxwifi] Simultaneous 2.4 GHz WiFi and Bluetooth issue on Intel Dual Band Wireless-AC 8260

> On 04/20/2018 01:03 AM, Emmanuel Grumbach wrote: > >> Under Windows 10, the hardware appears to work without issue. > >> Additionally, I believe I managed to warm-reboot from Windows 10 to > >> Linux (with Bluetooth connected), and was able to continue using the > >> same 2.4 GHz WiFi and

Re: linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree

Hi, On Wed, 2018-04-25 at 10:56 +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 84226ca1c5d3 ("iwlwifi: mvm: support offload of AMSDU rate > control") > > is missing a Signed-off-by from its author. I checked this and it should be fine. The author is actually wrong in the commit.

Re: [v2, 1/5] wcn36xx: abort scan request when 'dequeued' indicator is sent

Daniel Mack wrote: > When the firmware sends a WCN36XX_HAL_SCAN_IND_DEQUEUED indication, > the request is apparently no longer valid. Attempts to stop the hardware > scan request subsequently will lead to the following error message, and > the hardware is no longer able to

Re: [v2] ath10k: Enable hw checksum for wcn3990

Rakesh Pillai wrote: > By default ath10k driver enables the support for HW_CHECKSUM > (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled > in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets > and all patckets are dropped. But

Re: [PATCH v1 1/1] ath10k: convert kmemdup to dma_alloc_coherent

Jared Bents writes: > On Sat, Apr 21, 2018 at 2:10 AM, Kalle Valo wrote: >> Jared Bents writes: >> >>> Update to convert the use of kmemdup to dma_alloc_coherent as >>> dma_alloc_coherent will consider DMA

Re: [v2,1/4] ath10k: Add hw params for shadow register support

Rakesh Pillai wrote: > wcn3990 supports shadow register for ce write. > > Add a hw param for shadow register support. > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo 4 patches applied to ath-next branch of

Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()

Anilkumar Kolli writes: > Mesh path metric needs txrate information from ieee80211_tx_status() > call but in ath10k there is no mechanism to report tx rate information > via ieee80211_tx_status(), the rate is only accessible via > sta_statiscs() op. > > Per peer stats has

Re: [PATCH] ath10k: add dynamic vlan support

Yes Sebastian, Your point is valid. This would break the 4-addr operation on other ath10k devices which does not support the new WMI service. I have another approach to solve this problem, I will come with a small patch and see what johannes has to say on that approach. Manikanta On

Re: [PATCH 09/12] iwlwifi: pcie: remove non-responsive device

Luca Coelho writes: > From: Luca Coelho > > If we fail to to grab NIC access because the device is not responding > (i.e. CSR_GP_CNTRL returns 0x), remove the device from the PCI > bus, to avoid any further damage, and to let the user space

Re: [PATCH 12/12] iwlwifi: mvm: set wakeup filters for wowlan "any" configuration

Luca Coelho writes: > From: Eliad Peller > > In can of "any" wowlan trigger is configured, no valid wakeup filter > was configured. "In case"? -- Kalle Valo

Re: [02/10] wil6210: set/get EDMG channel through debugfs

me...@codeaurora.org writes: > On 2018-04-19 19:15, Kalle Valo wrote: >> Maya Erez wrote: >> >>> Setting EDMG channel through debugfs for connect and PCP start >>> commands. >> Why? And what is an EDMG channel? >>

Re: pull-request: iwlwifi-next 2018-04-20

Luca Coelho writes: > This is the first batch of patches intended for v4.18 (or whatever > Linus turns out to call it ;). Nothing major here, just the usual > continued development, bugfixes, new FW APIs and some new > features. More details about the contents in the tag

Re: [PATCH] ath10k: add dynamic vlan support

Am 24.04.2018 um 11:52 schrieb Kalle Valo: Sebastian Gottschall writes: consider my comment regarding vlan_ap. I am considering comment, I just go one issue at a time and haven't had a time to look at your comment. But PLEASE do not top post, it's very annoying and

Re: iwlwifi: mvm: fix old scan version sizes

Luciano Coelho wrote: > From: Luca Coelho > > When version 8 of the scan command API was introduced, only the size > of version 7 was updated, causing older versions of the firmware to > throw BAD_COMMAND errors. > > Calculating the old version based

Re: [PATCH 09/12] iwlwifi: pcie: remove non-responsive device

On Tue, 2018-04-24 at 12:44 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Luca Coelho > > > > If we fail to to grab NIC access because the device is not > > responding > > (i.e. CSR_GP_CNTRL returns 0x), remove the device from the

Re: [PATCH 12/12] iwlwifi: mvm: set wakeup filters for wowlan "any" configuration

On Tue, 2018-04-24 at 12:45 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Eliad Peller > > > > In can of "any" wowlan trigger is configured, no valid wakeup > > filter > > was configured. > > "In case"? Yeah, I'll fix it and resend. --

Re: [PATCH] ath10k: add dynamic vlan support

Sebastian Gottschall writes: > consider my comment regarding vlan_ap. I am considering comment, I just go one issue at a time and haven't had a time to look at your comment. But PLEASE do not top post, it's very annoying and creates a mess in patchwork.

Re: [PATCH] ath10k: add dynamic vlan support

Manikanta Pubbisetty writes: > Mutlicast/broadcast traffic destined for a particular vlan group will > always be encrypted in software. To enable dynamic VLANs, it requires > driver support for sending software encrypted packets. > > In ath10k, sending sw encrypted

Re: [PATCHv3] ath10k: fix kernel panic while reading tpc_stats

Tamizh chelvam writes: > When attempt to read tpc_stats for the chipsets which support > more than 3 tx chain will trigger kernel panic(kernel stack is corrupted) > due to writing values on rate_code array out of range. > This patch changes the array size depends on the

Re: [PATCH] ath10k: fixed scan crash

zhic...@codeaurora.org writes: > From: Zhi Chen > > Length of WMI scan message was not calculated correctly. The allocated > buffer was smaller than what we expected. So WMI message corrupted > skb_info, which is at the end of skb->data. This fix takes TLV header > into

Re: [PATCH] ath10k: add dynamic vlan support

consider my comment regarding vlan_ap. this patch will break wds ap / wds sta support with latest mac80211 (see also my post on the wireless mailing list about the breaking patch in mac80211) so AP_VLAN must be masked always for all chipsets. otherwise wds breaks and this is not just a guess.

Re: [v2] rtlwifi: cleanup 8723be ant_sel definition

Ping-Ke Shih wrote: > From: Ping-Ke Shih > > Some HP laptops have only a single wifi antenna. This would not be a > problem except that they were shipped with an incorrectly encoded > EFUSE. It should have been possible to open the computer and transfer

Re: [PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

Daniel Mack writes: > Hi Loic, > > On Wednesday, April 11, 2018 03:30 PM, Loic Poulain wrote: >>> /* Move the head of the ring to the next empty descriptor */ >>> -ch->head_blk_ctl = ctl->next; >>> +ch->head_blk_ctl = ctl_skb->next; >>> + >>> + /*

[PATCH] staging/wilc1000: fix wilc_mac_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] ath6kl: fix ath6kl_data_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] mwifiex: fix mwifiex_hard_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH 1/1 RFC] wcn36xx: fix buffer commit logic on TX path

Hi Loic, On Wednesday, April 11, 2018 03:30 PM, Loic Poulain wrote: >> /* Move the head of the ring to the next empty descriptor */ >> -ch->head_blk_ctl = ctl->next; >> +ch->head_blk_ctl = ctl_skb->next; >> + >> + /* Commit all previous writes and set descriptors to