Re: [PATCH] NFC: pn533: don't send USB data off of the stack

2018-05-17 Thread kbuild test robot
Hi Greg, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 02/10] wcn36xx: set DMA mask explicitly

2018-05-17 Thread Ramon Fried
On Wed, May 16, 2018 at 5:08 PM, Daniel Mack wrote: > The device takes 32-bit addresses only, so inform the DMA API about it. > This is the default on msm8016, so that doesn't change anything, but > it's best practice to be explicit. > > Signed-off-by: Daniel Mack

Re: [PATCH 01/10] wcn36xx: fix buffer commit logic on TX path

2018-05-17 Thread Ramon Fried
On Wed, May 16, 2018 at 5:08 PM, Daniel Mack wrote: > When wcn36xx_dxe_tx_frame() is entered while the device is still processing > the queue asyncronously, we are racing against the firmware code with > updates to the buffer descriptors. Presumably, the firmware scans the ring

pull-request: wireless-drivers-next 2018-05-17

2018-05-17 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 4.18. I forgot to mention in the signed tag was that one id is added to include/linux/mmc/sdio_ids.h but that was acked by Ulf. I suspect hat because of my merge of wireless-drivers into wireless-drivers-next the diffstat from request-pull was wrong

[bug report] mwifiex: add rx histogram statistics support

2018-05-17 Thread Dan Carpenter
Hello Xinming Hu, The patch cbf6e05527a7: "mwifiex: add rx histogram statistics support" from Dec 23, 2014, leads to the following static checker warning: drivers/net/wireless/marvell/mwifiex/util.c:714 mwifiex_hist_data_set() error: buffer underflow 'phist_data->snr'

[PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-17 Thread Dedy Lansky
From: Dedy Lansky Allocation size of nlmsg in cfg80211_ft_event is based on ric_ies_len and doesn't take into account ies_len. This leads to NL80211_CMD_FT_EVENT message construction failure in case ft_event contains large enough ies buffer. Add ies_len to the nlmsg

[PATCH] mac80211: mesh: fix premature update of rc stats

2018-05-17 Thread Bob Copeland
The mesh_neighbour_update() function, queued via beacon rx, can race with userspace creating the same station. If the station already exists by the time mesh_neighbour_update() is called, the function wrongly assumes rate control has been initialized and calls rate_control_rate_update(), which in

[no subject]

2018-05-17 Thread George Thompson
Dobrý den, Stále čekám na odpověď na e-mail, obdrželi jste můj první e-mail? S úctou, Pan George Thompson (Esq)

[PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Ramon Fried
From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved

[bug report] ath9k: Fix issue with MCS15

2018-05-17 Thread Dan Carpenter
Hello Sujith Manoharan, The patch 6fcbe538be43: "ath9k: Fix issue with MCS15" from Nov 14, 2013, leads to the following static checker warning: drivers/net/wireless/ath/ath9k/ar9003_phy.c:836 ar9003_doubler_fix() warn: 'ah->hw_version.macVersion == 448' 'false' implies

[PATCH] WHENCE: Fix typo Version v3

2018-05-17 Thread Sedat Dilek
I have seen that in the WHENCE file there is "Version" with and without ":", mostly iwlwifi ucodes. As an example: File: iwlwifi-8265-36.ucode -Version 36.e91976c0.0 +Version: 36.e91976c0.0 The usual case is "Version:". This patch is against iwlwifi.git#linux-firmware. Signed-off-by: Sedat

[PATCHv2] wlcore: sdio: Fix flakey SDIO runtime PM handling

2018-05-17 Thread Tony Lindgren
We can have pm_runtime_get_sync() return 1, and we can have pm_runtime_put_sync() return -EBUSY. See rpm_suspend() and rpm_resume() for more information. Fix the issue by returning 0 from wl12xx_sdio_power_on() on success. And use pm_runtime_put() instead of pm_runtime_put_sync() for

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

2018-05-17 Thread Greg KH
Adding the network and NFC developers as this really is a NFC driver bug, not a USB core issue... On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: > On Thu, May 17, 2018 at 02:10:57PM +0100, Carlos Manuel Santos wrote: > > Hello. > > I'm having troubles with this NFC card reader. It seems

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

2018-05-17 Thread Greg KH
On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: > Adding the network and NFC developers as this really is a NFC driver > bug, not a USB core issue... > > On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: > > On Thu, May 17, 2018 at 02:10:57PM +0100, Carlos Manuel Santos wrote: > >

Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-17 Thread Johannes Berg
On Thu, 2018-05-17 at 11:43 -0700, Jeff Johnson wrote: > > > - msg = nlmsg_new(100 + ft_event->ric_ies_len, GFP_KERNEL); > > + msg = nlmsg_new(100 + ft_event->ies_len + ft_event->ric_ies_len, > > + GFP_KERNEL); > > if (!msg) > > return; > > should these

Re: [PATCHv2 0/5] Runtime PM support for wlcore

2018-05-17 Thread Tony Lindgren
* Tony Lindgren [180517 18:52]: > Hi all, > > Here's a series of patches to add runtime PM support for wlcore. It does not > yet implement autosuspend support, but let's get this tested first as the > autosuspend can mask enable/disable issues easily. Sorry forgot to mention

[PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Niklas Cassel
The following problem was observed when running iperf: [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec [ 3] 3.0- 4.0 sec 655 KBytes 5.36 Mbits/sec [ 3] 4.0- 5.0 sec 0.00 Bytes 0.00 bits/sec

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Jeff Johnson
On 2018-05-17 04:32, Ramon Fried wrote: From: Eyal Ilsar ... +static int wcn36xx_smd_process_ptt_msg_rsp(void *buf, size_t len, + void **p_ptt_rsp_msg) +{ + struct wcn36xx_hal_process_ptt_msg_rsp_msg *rsp; + int ret =

Re: pull-request: wireless-drivers-next 2018-05-17

2018-05-17 Thread David Miller
From: Kalle Valo Date: Thu, 17 May 2018 11:44:34 +0300 > here's a pull request to net-next for 4.18. I forgot to mention in the > signed tag was that one id is added to include/linux/mmc/sdio_ids.h but > that was acked by Ulf. > > I suspect hat because of my merge of

[PATCH 5/5] wlcore: sdio: Warn about runtime PM suspend errors

2018-05-17 Thread Tony Lindgren
We may get -EBUSY from runtime PM and that most likely means some earlier wlcore command did not complete yet and further calls may fail. Let's add a warning to make it easier to track down and fix such issues in wlcore code. Signed-off-by: Tony Lindgren ---

[PATCH 3/5] wlcore: Add support for runtime PM

2018-05-17 Thread Tony Lindgren
We can update wlcore to use PM runtime by adding functions for wlcore_runtime_suspend() and wlcore_runtime_resume() and replacing calls to wl1271_ps_elp_wakeup() and wl1271_ps_elp_sleep() with calls to pm_runtime_get_sync() and pm_runtime_put(). Note that the new wlcore_runtime_suspend() and

[PATCH 2/5] wlcore: Make sure PM calls are paired

2018-05-17 Thread Tony Lindgren
The call to wl1271_ps_elp_wakeup() in wl12xx_queue_recovery_work() is unpaired. Let's remove it and add paired calls to wl1271_recovery_work() instead in preparation for changing things to use runtime PM. Signed-off-by: Tony Lindgren --- drivers/net/wireless/ti/wlcore/main.c |

[PATCHv2 0/5] Runtime PM support for wlcore

2018-05-17 Thread Tony Lindgren
Hi all, Here's a series of patches to add runtime PM support for wlcore. It does not yet implement autosuspend support, but let's get this tested first as the autosuspend can mask enable/disable issues easily. Regards, Tony Changes since v1: - Fix issues reported by Eyal for recovery - Add

[PATCH 4/5] wlcore: Fix misplaced PM call for scan_complete_work()

2018-05-17 Thread Tony Lindgren
With runtime PM enabled, we now need to have wlcore enabled longer until after we're done calling wlcore_cmd_regdomain_config_locked(): scan_complete_work() wlcore_cmd_regdomain_config_locked() wlcore_cmd_send_failsafe() wl12xx_sdio_raw_read() Note that this is not needed before runtime

[PATCH 1/5] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()

2018-05-17 Thread Tony Lindgren
Otherwise we can get: WARNING: CPU: 0 PID: 55 at drivers/net/wireless/ti/wlcore/io.h:84 I've only seen this few times with the runtime PM patches enabled so this one is probably not needed before that. This seems to work currently based on the current PM implementation timer. Let's apply this

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

2018-05-17 Thread Jeff Johnson
On 2018-05-17 04:32, Ramon Fried wrote: From: Eyal Ilsar ... +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn, + struct ieee80211_vif *vif, void *ptt_msg, size_t len, + void **ptt_rsp_msg) +{ + struct

Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

2018-05-17 Thread Jeff Johnson
On 2018-05-17 06:25, Dedy Lansky wrote: From: Dedy Lansky Allocation size of nlmsg in cfg80211_ft_event is based on ric_ies_len and doesn't take into account ies_len. This leads to NL80211_CMD_FT_EVENT message construction failure in case ft_event contains large enough

Re: [PATCH] ath10k: transmit queued frames after waking queues

2018-05-17 Thread Adrian Chadd
On Thu, 17 May 2018 at 16:16, Niklas Cassel wrote: > diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c > index cda164f6e9f6..1d3b2d2c3fee 100644 > --- a/drivers/net/wireless/ath/ath10k/txrx.c > +++

Re: ath10k wake_tx_queue issues

2018-05-17 Thread Niklas Cassel
On Wed, May 16, 2018 at 07:28:21PM +0200, Erik Stromdahl wrote: > Hello Niklas > > Quick question: > Are you using my patch: "ath10k: add htt_tx num_pending window"? Nope, but I definitely think that your patch should be merged, since the current code can lock/unlock/lock a lot of times for no