Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 10:21 AM, Johannes Berg wrote: On Tue, 2018-05-22 at 09:53 +0200, Arend van Spriel wrote: On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands from clients other than

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 12:33 PM, Andrew Zaborowski wrote: On 22 May 2018 at 09:53, Arend van Spriel wrote: On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands

Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event

On Mon, 2018-05-21 at 10:23 +0300, Dedy Lansky wrote: > > We do, technically we should have something like nla_total_size() of > > various things including all those wiphy, ifindex, MAC attributes etc. > > so we just get lazy... > > nla_total_size is currently not used in nl80211.c (actually not

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/8/2018 5:05 PM, Denis Kenzior wrote: Hi Arend, Sure. I guess we all have been there kicking of wpa_s and discovering there is already one running in the background. I am just a bit squeamish to change the behavior like this. H. Is wpa_s already using SOCKET_OWNER. If so, I might

Re: [1/3] MAINTAINERS: update Kalle's email address

Kalle Valo wrote: > I switched to use my codeaurora.org address. > > Signed-off-by: Kalle Valo 3 patches applied to wireless-drivers.git, thanks. c76700ab337a MAINTAINERS: update Kalle's email address b561290995b2 MAINTAINERS: change Kalle as

netdev 0x12 conference update

Folks, This is a small update to the community on the Netdev 0x12 conference (July 11-13, 2018 in Montreal, Canada, https://www.netdevconf.org/0x12). Early registration fees (20% off) are still in effect until June 1st. To Register: https://www.netdevconf.org/0x12/registration.html Our

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Reizer, Eyal [180522 13:50]: > > > > OK try replacing the pm_runtime_put_noidle() above with just > > pm_runtime_put_sync(). The reason why I put noidle there was the > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > I have tried that already.

[PATCH] cfg80211: Add cumulative channel survey dump support.

This patch provides support to send accumulated survey data to user if low level drivers provides non-accumulated survey data. Signed-off-by: Venkateswara Naralasetty --- include/net/cfg80211.h | 5 + net/wireless/core.c| 21 +

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 22 May 2018 at 09:53, Arend van Spriel wrote: > On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: >> Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, >> NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands >> from clients other than the connection

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Reizer, Eyal [180522 13:28]: > Actually the below patch removing the call to wlcore_fw_sleep() avoids this > error. > The downside is that the wl8 firmware remains fully active during supend, so > we > Would need to find the root cause why the last call allowing the wilink8 >

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

> > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > > > > I have tried that already. Same problem. The last call to: > >

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Reizer, Eyal [180522 06:42]: > It still crash. > The crash is different now. > It also complains about: > [ 60.544224] Unbalanced enable for IRQ 65 > Need down/up of the interface to recover after it. Oh OK so no need for this patch and interrupts are already enabled at that

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

Hi Arend, On 05/22/2018 05:39 AM, Arend van Spriel wrote: On 5/8/2018 5:05 PM, Denis Kenzior wrote: Hi Arend, Sure. I guess we all have been there kicking of wpa_s and discovering there is already one running in the background. I am just a bit squeamish to change the behavior like this.

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Tue, 2018-05-22 at 09:48 -0500, Denis Kenzior wrote: > Hi Arend, > > > > Are you saying the first result is from the Beacon and the other is from > > > the Probe Response? Then why are the 'Information elements from Probe > > > Response frame' the way they are? > > > > Nope. I am not saying

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, On 05/22/2018 03:12 AM, Johannes Berg wrote: Hi Denis, Just FYI, there's definitely something funny with the scanning code: denkenz@iwd-test ~ $ sudo iw dev wlp2s0 scan flush BSS 10:c3:7b:54:74:d4(on wlp2s0) last seen: 274.815s [boottime] freq: 5765

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Tue, 2018-05-22 at 16:50 +0200, Johannes Berg wrote: > On Tue, 2018-05-22 at 09:48 -0500, Denis Kenzior wrote: > > Hi Arend, > > > > > > Are you saying the first result is from the Beacon and the other is from > > > > the Probe Response? Then why are the 'Information elements from Probe > > >

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Kalle Valo [180522 08:05]: > Tony Lindgren writes: > > > * Reizer, Eyal [180521 07:31]: > >> > Here's a series of patches to add runtime PM support for wlcore. It does > >> > not > >> > yet implement autosuspend support, but let's get

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

> > * Reizer, Eyal [180522 13:28]: > > Actually the below patch removing the call to wlcore_fw_sleep() avoids this > error. > > The downside is that the wl8 firmware remains fully active during supend, so > we > > Would need to find the root cause why the last call allowing the

[PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware generates radiotap header

[PATCH 1/3] brcmfmac: allow specifying features per firmware version

From: Rafał Miłecki Some features supported by firmware aren't advertised and there is no way for a driver to query them. This includes e.g. monitor mode details. Some firmwares support tagging monitor frames, some build radiotap header but there is no way to detect it. This

[PATCH 3/3] brcmfmac: add initial support for monitor mode interface

From: Rafał Miłecki Right now it's limited to firmwares that mark monitor interface packets with a special flag. It's required to distinguish them from other interface packets as firmware doesn't use any unique ifidx for monitor interface. In the future one may also add

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

> > > > 8< > > diff --git a/drivers/net/wireless/ti/wlcore/main.c > > b/drivers/net/wireless/ti/wlcore/main.c > > --- a/drivers/net/wireless/ti/wlcore/main.c > > +++ b/drivers/net/wireless/ti/wlcore/main.c > > @@ -1867,8 +1867,6 @@ static int __maybe_unused > >

Re: [PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM)

Ramon Fried writes: > From: Eyal Ilsar > > Introduce infrastructure for supporting Factory Test Mode (FTM) of the > wireless LAN subsystem. In order for the user space to access the > firmware in test mode the relevant netlink channel needs to be

Re: [4.17 iwlwifi regression] NULL pointer dereference in reg_query_regdb_wmm()

"Dreyfuss, Haim" writes: > Yeah, MCC stands for Mobile Country Code. > You can find it in the dmesg > "iwl_mvm_get_regdomain Getting regdomain data for ZZ from FW " > " iwl_mvm_update_mcc send MCC update to FW with 'ZZ' src = 16" Please do not top post:

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Arend, Are you saying the first result is from the Beacon and the other is from the Probe Response?  Then why are the 'Information elements from Probe Response frame' the way they are? Nope. I am not saying that. I am saying that there are two probe requests being sent. One with broadcast

[PATCH] staging: wilc1000: fix spelling mistake: "Preamle" -> "Preamble"

From: Colin Ian King Trivial fix to spelling mistake in netdev_err error message Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On 2018-05-22 14:15, Niklas Cassel wrote: On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: On 2018-05-21 13:43, Niklas Cassel wrote: > The following problem was observed when running iperf: [...] Sorry for the late response. ath10k_mac_tx_push_pending is already called at

[PATCH 1/2] rfkill: Rename rfkill_any_led_trigger* functions

Rename these functions to rfkill_global_led_trigger*, as they are going to be extended to handle another global rfkill led trigger. This commit does not change any functionality. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 47

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Tue, 2018-05-22 at 16:25 -0500, Denis Kenzior wrote: > Hi Johannes, > > > But in theory, I think you could've received the beacon with hidden SSID > > *before* the scan, yet it might be present in the scan results if the > > new scan caused the probe response to be associated with that scan. >

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On Mon, May 21, 2018 at 04:11:38PM -0700, Rajkumar Manoharan wrote: > On 2018-05-21 13:43, Niklas Cassel wrote: > > The following problem was observed when running iperf: > [...] > > > > In order to avoid trying to flush the queue every time we free a frame, > > only do this when there are 3 or

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, I think I finally figured out what's going on. It's a mix between strange 'iw' behaviour, and strange backward-compatibility behaviour in cfg80211. If you do this again and give the scan dump command explicitly with -b added, like sudo iw dev wlp2s0 scan passive iw dev wlp2s0

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, On 05/22/2018 03:40 PM, Johannes Berg wrote: Hi, So I need to absorb all of this some more, but I'm still wondering why we are seeing two separate scan entries (with hidden & plain ssid) when we requested a flush? Is there a way to force the kernel to only show us the probe

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Tue, 2018-05-22 at 16:00 -0500, Denis Kenzior wrote: > > > So what's the practical use of the flush flag? Or is that something > > > that was meant to be 'for-testing-only'? > > > > I think you misunderstand? The value is that it ensures that nothing is > > present in the list that was

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, But in theory, I think you could've received the beacon with hidden SSID *before* the scan, yet it might be present in the scan results if the new scan caused the probe response to be associated with that scan. Right, your explanation was helpful, thanks. It still seems

Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

On Tue, May 22, 2018 at 6:30 AM, Yisheng Xie wrote: >> But it's up tu Loca. Shame on me. I meant Luca, of course! Luca, sorry. > OK, I will change it if Loca agree your opinion. -- With Best Regards, Andy Shevchenko

[PATCH 2/2] rfkill: Create rfkill-none LED trigger

Creates a new trigger rfkill-none, as a complement to rfkill-any, which drives LEDs when any radio is enabled. The new trigger is meant to turn a LED ON whenever all radios are OFF, and turn it OFF otherwise. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 27

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Denis, Thanks for the capture file (for everyone else - Denis provided this to Arend and myself privately). In it, we see that there are only ever beacons with zeroed out SSID, and probe responses with correct SSID. Nothing weird mixed. > denkenz@iwd-test ~ $ sudo iw dev wlp2s0 scan flush >

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi, > So I need to absorb all of this some more, but I'm still wondering why > we are seeing two separate scan entries (with hidden & plain ssid) when > we requested a flush? Is there a way to force the kernel to only show > us the probe responses. Oh. I didn't even think about this part,

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, > On May 22, 2018, at 3:52 PM, Johannes Berg wrote: > > On Tue, 2018-05-22 at 15:49 -0500, Denis Kenzior wrote: > >> Okay, so we need to use NL80211_BSS_PRESP_DATA if we want to filter out >> scan results that are coming from beacons, right? > > You

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On 05/22/2018 04:28 PM, Johannes Berg wrote: On Tue, 2018-05-22 at 16:25 -0500, Denis Kenzior wrote: Hi Johannes, But in theory, I think you could've received the beacon with hidden SSID *before* the scan, yet it might be present in the scan results if the new scan caused the probe response

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On Tue, 2018-05-22 at 15:49 -0500, Denis Kenzior wrote: > Okay, so we need to use NL80211_BSS_PRESP_DATA if we want to filter out > scan results that are coming from beacons, right? You could do that, yes. In non-hidden cases you get the beacon/probe response data combined, in hidden cases you

[PATCH v3] wcn36xx: Add support for Factory Test Mode (FTM)

From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Reizer, Eyal [180522 14:07]: > > > > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > > wlcore_fw_sleep() call, with that gone put_sync should do the trick. > > > > > > > > > > I

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Johannes, On 05/22/2018 09:51 AM, Johannes Berg wrote: On Tue, 2018-05-22 at 16:50 +0200, Johannes Berg wrote: On Tue, 2018-05-22 at 09:48 -0500, Denis Kenzior wrote: Hi Arend, Are you saying the first result is from the Beacon and the other is from the Probe Response? Then why are the

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

* Tony Lindgren [180522 15:03]: > * Reizer, Eyal [180522 14:07]: > > > > > > > > > > OK try replacing the pm_runtime_put_noidle() above with just > > > > > pm_runtime_put_sync(). The reason why I put noidle there was the > > > > > wlcore_fw_sleep() call, with that

Atheros AR9462 - 5Ghz not working

I've run out of ideas and am hoping someone here can help. All I want to do is connect a client to my 5Ghz network. My client: OS is Debian stable "Stretch" with sysvinit instead of systemd Atheros AR9462 (World roaming 0x64 regdomain in EEPROM) "iw reg set US" "iw list" shows both

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands from clients other than the connection owner set in the connect, authenticate or associate commands, if it was set. The main

RE: [4.17 iwlwifi regression] NULL pointer dereference in reg_query_regdb_wmm()

Thanks Eric, I will look into it Cheers Dreyfuss -Original Message- From: Eric Biggers [mailto:ebigge...@gmail.com] Sent: Tuesday, May 22, 2018 7:59 AM To: Dreyfuss, Haim Cc: linuxwifi ; linux-wireless@vger.kernel.org; Coelho, Luciano

Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

Tony Lindgren writes: > * Reizer, Eyal [180521 07:31]: >> > Here's a series of patches to add runtime PM support for wlcore. It does >> > not >> > yet implement autosuspend support, but let's get this tested first as the >> > autosuspend can mask enable/disable

Re: [PATCH] cfg80211: Fix support for flushing old scan results

Hi Denis, > Just FYI, there's definitely something funny with the scanning code: > > denkenz@iwd-test ~ $ sudo iw dev wlp2s0 scan flush > BSS 10:c3:7b:54:74:d4(on wlp2s0) > last seen: 274.815s [boottime] > freq: 5765 > beacon interval: 100 TUs > signal: -35.00 dBm >

RE: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore

> > > > This warning is because wlcore is wlcore is still in ELP. This is > > somehow possible even though we call pm_runtime_get_sync() in > > wl1271_op_resume(). Anyways, I'll try to reproduce it here. > > Sorry I can't somehow get my beagleboard to wake-up from suspend, > I'm almost certain

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On 5/18/2018 9:00 PM, Denis Kenzior wrote: Hi Arend, On 05/18/2018 01:54 PM, Arend van Spriel wrote: On 5/18/2018 6:47 PM, Denis Kenzior wrote: Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function was

[PATCH 1/3] cfg80211: use separate struct for fils parameters

Put FILS related parameters into their own struct definition so it can be reused for roam events in subsequent change. Reviewed-by: Jithu Jance Reviewed-by: Eylon Pedinovsky Signed-off-by: Arend van Spriel

[PATCH 3/3] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

From: Vidyullatha Kanchanapally Use NL80211_CMD_UPDATE_CONNECT_PARAMS to update new ERP information, Association IEs and the Authentication type to driver / firmware which will be used in subsequent roamings. Signed-off-by: Vidyullatha Kanchanapally

[PATCH 2/3] nl80211: add FILS related parameters to ROAM event

In case of FILS shared key offload the parameters can change upon roaming of which user-space needs to be notified. Reviewed-by: Jithu Jance Reviewed-by: Eylon Pedinovsky Signed-off-by: Arend van Spriel ---

[PATCH 0/3] nl80211: support offloading FILS-SK roaming scenarios

This small patch series is based on patch originally submitted by Vidyullatha to support driver/firmware roaming for FILS-SK offload. It also reworks the connection response code to reuse the fils parameter structure for the ROAM event. The series is intended for 4.18 and applies to the master

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On Tue, 2018-05-22 at 09:53 +0200, Arend van Spriel wrote: > On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: > > Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, > > NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands > > from clients other than the connection owner set in the