mt76x0 bug report

2018-09-04 Thread Sid Hayn
I have one mt76x2u (Alfa AWUS036ACM) and a few mt76x0. I've noticed two additional issues in my testing. First issue, is that it appears the mt76x0 devices don't work properly in monitor mode. Sometimes they seem to monitor one channel properly, but nothing else. The mt76x2u works great,

Re: Build iw for 32bit ARM

2018-09-04 Thread Fabio Estevam
Hi Jakov, On Mon, Sep 3, 2018 at 11:20 AM, Jakov Simunic wrote: > Hi Steve, > We are building with ptxdist, we have a compiler for arm > (arm-linux-gnueabihf-gcc), I am not a total novice in this, and have already > written some ptxdist rules, but haven't done it with non-autoconfizzed >

Re: [PATCH 4.19] mt76x0: fix remove_interface

2018-09-04 Thread Sid Hayn
confirmed, I didn't intentionally remove the interface, but I do see something about the interface being removed in wpa_supplicant output. Thanks, Zero On Tue, Sep 4, 2018 at 10:23 AM Stanislaw Gruszka wrote: > > On Mon, Sep 03, 2018 at 09:36:37AM -0400, Sid Hayn wrote: > > Best I can say is

Re: mt76x0 bug report

2018-09-04 Thread Lorenzo Bianconi
> > I have one mt76x2u (Alfa AWUS036ACM) and a few mt76x0. > > I've noticed two additional issues in my testing. > > First issue, is that it appears the mt76x0 devices don't work properly > in monitor mode. Sometimes they seem to monitor one channel properly, > but nothing else. The mt76x2u

[PATCH v2 2/3] ath9k_htc: enable ANI debug output

2018-09-04 Thread Tomislav Požega
Enable ANI output in debug file similar to how it's done on ath9k. Disabling the entire feature is also working. Tested with ALFA AWUS036NHA device. Signed-off-by: Tomislav Požega --- drivers/net/wireless/ath/ath9k/htc.h |1 + drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 98

[PATCH v2 1/3] ath9k: use common debug for ack timeout output

2018-09-04 Thread Tomislav Požega
Move ack debug code to common-debug and adjust ath9k/ath9k_htc debug for common ack output. This enables ack output in debugfs for ath9k_htc driver too. Signed-off-by: Tomislav Požega --- drivers/net/wireless/ath/ath9k/common-debug.c | 29

[PATCH] ath9k_htc: add fw 1.4.1

2018-09-04 Thread Tomislav Požega
Add firmware v1.4.1 that supports up to 8 virtual APs and up to 16 (current limit, at least on AR9271) client interfaces. (1 AP + 15 STA, 4 AP + 12 STA etc) Signed-off-by: Tomislav Požega --- ath9k_htc/htc_7010-1.4.1.fw | Bin 0 -> 72812 bytes ath9k_htc/htc_9271-1.4.1.fw | Bin 0 -> 51008

[RESEND PATCH v2 7/9] cfg80211: reg: Init wiphy_idx in regulatory_hint_core()

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Core regulatory hints didn't set wiphy_idx to WIPHY_IDX_INVALID. Since the regulatory request is zeroed, wiphy_idx was always implicitly set to 0. This resulted in updating only phy #0. Fix that. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho ---

[RESEND PATCH v2 1/9] mac80211: support reporting 0-length PSDU in radiotap

2018-09-04 Thread Luca Coelho
From: Shaul Triebitz For certain sounding frames, it may be useful to report them to userspace even though they don't have a PSDU in order to determine the PHY parameters (e.g. VHT rate/stream config.) Add support for this to mac80211. Signed-off-by: Johannes Berg Signed-off-by: Shaul Triebitz

[RESEND PATCH v2 8/9] mac80211: Always report TX status

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski If a frame is dropped for any reason, mac80211 wouldn't report the TX status back to user space. As the user space may rely on the TX_STATUS to kick its state machines, resends etc, it's better to just report this frame as not acked instead. Signed-off-by: Andrei

[RESEND PATCH v2 5/9] mac80211: allow AMSDU size limitation per-TID

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some drivers may have AMSDU size limitation per TID, due to HW constrains. Add an option to set this limit. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h | 2 ++ net/mac80211/tx.c | 4 2 files changed, 6 insertions(+) diff --git

[RESEND PATCH v2 0/9] cfg80211/mac80211: reworked patches from our internal tree 2018-08-31

2018-09-04 Thread Luca Coelho
From: Luca Coelho Hi, [I'm resending this set again due to the corrupted X-SA headers in the previous attempts. I have now removed all the X-SA headers and hopefully it will work fine. Please let me know if you still have issues with it.] I'm resending the patches that came out corrupted,

[RESEND PATCH v2 3/9] wireless: align to draft 11ax D3.0

2018-09-04 Thread Luca Coelho
From: Shaul Triebitz Align to new 11ax draft D3.0. Change/add new MAC and PHY capabilities and update drivers' 11ax capabilities and mac80211's debugfs accordingly. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/iwl-nvm-parse.c| 51

[RESEND PATCH v2 4/9] mac80211: add an option for station management TXQ

2018-09-04 Thread Luca Coelho
From: Sara Sharon We have a TXQ abstraction for non-data packets that need powersave buffering. Since the AP cannot sleep, in case of station we can use this TXQ for all management frames, regardless if they are bufferable. Add HW flag to allow that. Signed-off-by: Sara Sharon Signed-off-by:

[RESEND PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Otherwise the offchannel frame might be queued due to IEEE80211_QUEUE_STOP_REASON_PS and later dropped (in ieee80211_tx_frags()). Anyway, it doesn't make much sense to wake up the device during ROC. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[RESEND PATCH v2 2/9] mac80211: fix saving a few HE values

2018-09-04 Thread Luca Coelho
From: Naftali Goldstein After masking the he_oper_params, to get the requested values as integers one must rshift and not lshift. Fix that by using the le32_get_bits() macro. Fixes: 41cbb0f5a295 ("mac80211: add support for HE") Signed-off-by: Naftali Goldstein [converted to use

[RESEND PATCH v2 6/9] mac80211: add an option for drivers to check if packets can be aggregated

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some hardwares have limitations on the packets' type in AMSDU. Add an optional driver callback to determine if two skbs can be used in the same AMSDU or not. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h| 7 +++

[PATCH 18/22] mt76: use mt76_rx_status in mt76x0

2018-09-04 Thread Stanislaw Gruszka
Make rx status processing similar to mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mac80211.c | 3 ++- drivers/net/wireless/mediatek/mt76/mt76.h | 2 ++ drivers/net/wireless/mediatek/mt76/mt76x0/dma.c | 2 ++

[PATCH 21/22] mt76: unify {insert/remove}_hdr_pad

2018-09-04 Thread Stanislaw Gruszka
Merge insert/remove _hdr_pad from mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 2 +- drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 4 --- drivers/net/wireless/mediatek/mt76/mt76x0/tx.c | 5 +--

[PATCH 19/22] mt76: unify mac_process_rate

2018-09-04 Thread Stanislaw Gruszka
Merge mac_process_rate from mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 69 +- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 68 + drivers/net/wireless/mediatek/mt76/mt76x02_mac.h |

Re: [Regression]BCM4312 is broken in kernel 4.18[Root cause found]

2018-09-04 Thread Larry Finger
On 09/04/2018 09:21 AM, prabhu wrote: Larry, I didn't find this patch in 4.18.6 stable review mail. forgot to push or any other reason? The patch is listed as "Under review". Larry

[PATCH 08/22] mt76: unify AC to hw queue mapping

2018-09-04 Thread Stanislaw Gruszka
Use the same AC to hardware queue mappings for all subdrivers. Note: this change BK and BE mappings for USB drivers. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 8 +--- drivers/net/wireless/mediatek/mt76/mt76x0/tx.c | 4 ++--

[PATCH 12/22] mt76: unify remove_interface

2018-09-04 Thread Stanislaw Gruszka
Use common remove_interface callback in mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 10 +- drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 9 + drivers/net/wireless/mediatek/mt76/mt76x02_util.h | 2 ++

[PATCH 14/22] mt76: unify sta_rate_tbl_update and related helpers

2018-09-04 Thread Stanislaw Gruszka
Use common sta_rate_tbl_update on mt76x0 and mt76x2. mt76x0 do not have support TPC (transmision power control) implmented, msta->wcid.max_txpwr_adj is only set for mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 2 +

[PATCH 10/22] mt76: unify conf_tx

2018-09-04 Thread Stanislaw Gruszka
Use one conf_tx implementation in mt76x0 and mt76x2. Note this change conf_tx for mt76x0, but it should work with mt76x2 version. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 2 +- drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 -

[PATCH 09/22] mt76: remove q->hw_idx

2018-09-04 Thread Stanislaw Gruszka
We use q->hw_idx in very few places, remove it and provide hwq index by diffrent way. This will allow ot unify conf_tx mac80211 callback. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 1 - drivers/net/wireless/mediatek/mt76/mt76x2_common.c | 2 +-

[PATCH 13/22] mt76: unify add_interface

2018-09-04 Thread Stanislaw Gruszka
Make common add_interface for mt76x0 and mt76x2e. This change behavior for mt76x0, but it should work with the new implementation. mt76x2u has different implementation. Maybe it can use common one, but for now leave it as is. Signed-off-by: Stanislaw Gruszka ---

[PATCH 17/22] mt76: unify send_tx_status and related helpers

2018-09-04 Thread Stanislaw Gruszka
Merge send_tx_status and helper functions from mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 147 drivers/net/wireless/mediatek/mt76/mt76x0/mac.h| 4 - drivers/net/wireless/mediatek/mt76/mt76x0/tx.c |

[PATCH 07/22] mt76x0: remove empty sta_notify

2018-09-04 Thread Stanislaw Gruszka
Remove empty implementation of sta_notify. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c b/drivers/net/wireless/mediatek/mt76/mt76x0/main.c index

[PATCH 15/22] mt76: unify txwi and rxwi structures

2018-09-04 Thread Stanislaw Gruszka
txwi and rxwi are the same for mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/dma.c| 12 ++-- drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 4 +- drivers/net/wireless/mediatek/mt76/mt76x0/mac.h| 67 --

[PATCH 11/22] mt76x0: remove vif_mask

2018-09-04 Thread Stanislaw Gruszka
Make remove_interface more similar to mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 11 +-- drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 -- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH 16/22] mt76: unify load_tx_status

2018-09-04 Thread Stanislaw Gruszka
Unify load/fetch tx status from mt76x0 and mt76x2 Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 21 -- drivers/net/wireless/mediatek/mt76/mt76x0/tx.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 25

[PATCH 06/22] mt76: unify set_key

2018-09-04 Thread Stanislaw Gruszka
Merge mt76x0 and mt76x2 set_key mac80211 callback. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 37 +--- drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 67 ++ drivers/net/wireless/mediatek/mt76/mt76x02_util.h | 4

[PATCH 20/22] mt76x0: reserve enough space in mac80211

2018-09-04 Thread Stanislaw Gruszka
Allocate skg with enough headroom by mac80211 , this eliminate need to add extra skb headroom by the mt76x0 driver. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 1 + drivers/net/wireless/mediatek/mt76/mt76x0/tx.c | 17 + 2 files

[PATCH 22/22] mt76: partially unify filling txwi fields

2018-09-04 Thread Stanislaw Gruszka
Merge code filing txwi fields the same way on mt76x0 and mt76x2. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/tx.c | 44 ++ drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 42 +

[PATCH 03/22] mt76: pratially unify add_interface

2018-09-04 Thread Stanislaw Gruszka
Create common mt76x02_vif_init function and use int on drivers add_interface callback. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 7 +-- drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 9 -

[PATCH 02/22] mt76: unify sta_add / sta_remove

2018-09-04 Thread Stanislaw Gruszka
Merge mt76x0 and mt76x0 sta add/remove callback. We drop mt76x0_mac_set_ampdu_factor() for now. Need to consider to add it to common code, but mt76x2 don't do it so perhaps mt76x0 don't need it as well. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 61

[PATCH 01/22] mt76: move wcid fields to common mt76_dev struct

2018-09-04 Thread Stanislaw Gruszka
All current MT devices including new MT7603 type chips support 128 WCIDs, we can unify wcid data in common mt76_dev structure. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 7 +++ drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 22

[PATCH 00/22] mt76 patches 2018-09-04

2018-09-04 Thread Stanislaw Gruszka
More mt76x0/mt76x2 integration. This set is quite big but I would like to move patches upstream from my github tree as fast as possible. I have there 42 more ready to post patches from me and Lorenzo. https://github.com/sgruszka/wireless-drivers-next/commits/mt76x0-draft-v3 Note this set

[PATCH 04/22] mt76x0: fix wrong usage of wcid_mask in remove_interface

2018-09-04 Thread Stanislaw Gruszka
We wrongly use wcid_mask instead of vif_mask Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c

[PATCH 05/22] mt76: unify ampdu_action

2018-09-04 Thread Stanislaw Gruszka
Use mt76x2_ampdu_action as common function, mt76x0 ampdu_action was diffrent, but mt76x2 version should work for this driver as well. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 3 ++ drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 45

Re: [PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX

2018-09-04 Thread Sven Eckelmann
On Dienstag, 4. September 2018 14:40:55 CEST Luca Coelho wrote: > ) > Sender: linux-wireless-ow...@vger.kernel.org > Precedence: bulk > List-ID: > X-Mailing-List: linux-wireless@vger.kernel.org Looks like the SMTP headers are broken in all your patches. Here the interesting part (as received by

Re: [PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX

2018-09-04 Thread Luca Coelho
On Tue, 2018-09-04 at 14:10 +0200, Johannes Berg wrote: > On Tue, 2018-09-04 at 14:07 +0200, Sven Eckelmann wrote: > > On Dienstag, 4. September 2018 14:40:55 CEST Luca Coelho wrote: > > > ) > > > Sender: linux-wireless-ow...@vger.kernel.org > > > Precedence: bulk > > > List-ID: > > >

Re: [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-09-04 Thread Johannes Berg
On Tue, 2018-09-04 at 13:43 +0300, Luca Coelho wrote: > On Mon, 2018-09-03 at 10:56 +0200, Johannes Berg wrote: > > On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > > > > > > + cap = cfg80211_find_ext_ie(WLAN_EID_EXT_HE_CAPABILITY, ies, > > > ies_len); > > > + if (cap && cap[1] >=

[PATCH v2 3/9] wireless: align to draft 11ax D3.0

2018-09-04 Thread Luca Coelho
From: Shaul Triebitz Align to new 11ax draft D3.0. Change/add new MAC and PHY capabilities and update drivers' 11ax capabilities and mac80211's debugfs accordingly. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- .../wireless/intel/iwlwifi/iwl-nvm-parse.c| 51

[PATCH v2 8/9] mac80211: Always report TX status

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski If a frame is dropped for any reason, mac80211 wouldn't report the TX status back to user space. As the user space may rely on the TX_STATUS to kick its state machines, resends etc, it's better to just report this frame as not acked instead. Signed-off-by: Andrei

[PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Otherwise the offchannel frame might be queued due to IEEE80211_QUEUE_STOP_REASON_PS and later dropped (in ieee80211_tx_frags()). Anyway, it doesn't make much sense to wake up the device during ROC. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho

[PATCH v2 2/9] mac80211: fix saving a few HE values

2018-09-04 Thread Luca Coelho
From: Naftali Goldstein After masking the he_oper_params, to get the requested values as integers one must rshift and not lshift. Fix that by using the le32_get_bits() macro. Fixes: 41cbb0f5a295 ("mac80211: add support for HE") Signed-off-by: Naftali Goldstein [converted to use

[PATCH v2 1/9] mac80211: support reporting 0-length PSDU in radiotap

2018-09-04 Thread Luca Coelho
From: Shaul Triebitz For certain sounding frames, it may be useful to report them to userspace even though they don't have a PSDU in order to determine the PHY parameters (e.g. VHT rate/stream config.) Add support for this to mac80211. Signed-off-by: Johannes Berg Signed-off-by: Shaul Triebitz

[PATCH v2 0/9] cfg80211/mac80211: reworked patches from our internal tree 2018-08-31

2018-09-04 Thread Luca Coelho
From: Luca Coelho Hi, I'm resending the patches that came out corrupted, excluding patch 22 that was already in and with 19 and 20 reworked. I've left 9 and 12 out for now, because they still need to be reworked according to your comments. Please review. Cheers, Luca. Andrei Otcheretianski

[PATCH v2 7/9] cfg80211: reg: Init wiphy_idx in regulatory_hint_core()

2018-09-04 Thread Luca Coelho
From: Andrei Otcheretianski Core regulatory hints didn't set wiphy_idx to WIPHY_IDX_INVALID. Since the regulatory request is zeroed, wiphy_idx was always implicitly set to 0. This resulted in updating only phy #0. Fix that. Signed-off-by: Andrei Otcheretianski Signed-off-by: Luca Coelho ---

[PATCH v2 5/9] mac80211: allow AMSDU size limitation per-TID

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some drivers may have AMSDU size limitation per TID, due to HW constrains. Add an option to set this limit. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h | 2 ++ net/mac80211/tx.c | 4 2 files changed, 6 insertions(+) diff --git

[PATCH v2 4/9] mac80211: add an option for station management TXQ

2018-09-04 Thread Luca Coelho
From: Sara Sharon We have a TXQ abstraction for non-data packets that need powersave buffering. Since the AP cannot sleep, in case of station we can use this TXQ for all management frames, regardless if they are bufferable. Add HW flag to allow that. Signed-off-by: Sara Sharon Signed-off-by:

[PATCH v2 6/9] mac80211: add an option for drivers to check if packets can be aggregated

2018-09-04 Thread Luca Coelho
From: Sara Sharon Some hardwares have limitations on the packets' type in AMSDU. Add an optional driver callback to determine if two skbs can be used in the same AMSDU or not. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- include/net/mac80211.h| 7 +++

Re: [PATCH 4.19] mt76x0: fix remove_interface

2018-09-04 Thread Stanislaw Gruszka
On Mon, Sep 03, 2018 at 09:36:37AM -0400, Sid Hayn wrote: > Best I can say is that it seemed to happen after a failed connection. It > would connect and disconnect a few times and work fine, but if it failed to > connect for any reason (mostly mismatched settings between AP and >

Re: [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-09-04 Thread Luca Coelho
On Mon, 2018-09-03 at 10:56 +0200, Johannes Berg wrote: > On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > > > > + cap = cfg80211_find_ext_ie(WLAN_EID_EXT_HE_CAPABILITY, ies, > > ies_len); > > + if (cap && cap[1] >= sizeof(*params->he_cap) + 1) > > + params->he_cap = (void

[PATCH v2 13/26] staging: wilc1000: rename 'dummy_statistics' variable to 'periodic_stat'

2018-09-04 Thread Ajay Singh
Cleanup patch to use appropriate variable name to fetch the periodic statistics. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 25/26] staging: wilc1000: refactor wilc_netdev_init() to handle memory free in error path

2018-09-04 Thread Ajay Singh
Refactor the wilc_netdev_init() to cleanup the memory for error scenario and remove unnecessary 'dev' pointer check. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 36 --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++- 2 files

[PATCH v2 11/26] staging: wilc1000: move hif_workqueue static variables to 'wilc' structure

2018-09-04 Thread Ajay Singh
Avoid use of static variable hif_workqueue and move it inside 'wilc' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 13 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH v2 12/26] staging: wilc1000: move 'periodic_rssi' as part of 'wilc_vif' struct

2018-09-04 Thread Ajay Singh
Refactor code to move 'periodic_rssi' as part of wilc_vif struct. Move 'dummy_statistics' from 'wilc' struct to 'wilc_vif' to maintain for each interface separately. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 19 ---

[PATCH v2 19/26] staging: wilc1000: use short names to fix over 80 issue in tcp_process()

2018-09-04 Thread Ajay Singh
Use short variable names to avoid line over 80 chars checkpatch warning in tcp_process(). struct pending_acks_info --> struct pending_ack int tcp_pending_ack_idx --> int ack_idx u32 pending_ack --> u32 pending_ack_idx Signed-off-by: Ajay Singh ---

[PATCH v2 21/26] staging: wilc1000: move 'chip_ps_state' static variable as part of 'wilc' struct

2018-09-04 Thread Ajay Singh
Move the static variable as part of 'wilc' priv struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + drivers/staging/wilc1000/wilc_wlan.c | 10 -- 3 files changed, 6 insertions(+), 6

[PATCH v2 16/26] staging: wilc1000: use lowercase for get_BSSID() and HIL variable

2018-09-04 Thread Ajay Singh
Cleanup patch to use lowercase name for get_BSSID() and HIL variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c| 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v2 23/26] staging: wilc1000: remove unnecessary static variable 'p2p_listen_state'

2018-09-04 Thread Ajay Singh
Remove the use of unnecessary static variable 'p2p_listen_state'. Already 'p2p_listen_state' is present in 'wilc_priv' struct. So making use of that variable as its getting set in channel ready and remain on channel expired callback. Signed-off-by: Ajay Singh ---

[PATCH v2 20/26] staging: wilc1000: remove unused code to set and get IP address

2018-09-04 Thread Ajay Singh
Cleanup code to remove the variables related to setting and getting IP address as this case was not handled from firmware side. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 105 -- drivers/staging/wilc1000/host_interface.h | 3 -

[PATCH v2 14/26] staging: wilc1000: move 'rcv_assoc_resp' as part of hif_drv

2018-09-04 Thread Ajay Singh
Avoid use of static variable and move 'rcv_assoc_resp' as part of 'hif_drv' struct. Rename from 'rcv_assoc_resp' to 'assoc_resp'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 +++- drivers/staging/wilc1000/host_interface.h | 1 + 2 files changed, 4

[PATCH v2 08/26] staging: wilc1000: avoid use of extra 'if' condition in wilc_init()

2018-09-04 Thread Ajay Singh
Cleanup patch to avoid the avoid extra 'if' condition and clubbed the same condition in single 'if' block. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH v2 17/26] staging: wilc1000: move tcp_ack_filter algo related variables to 'wilc_vif' struct

2018-09-04 Thread Ajay Singh
Avoid use of static variables and move them as part of wilc_vif struct. Move all the parameters related to tcp_ack_filter algo to wilc_vif struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +-

[PATCH v2 03/26] staging: wilc1000: fix to use correct index to free scanned info in clear_shadow_scan()

2018-09-04 Thread Ajay Singh
Fixes to use correct index to free the allocated memory for ies information. The check was done using 'last_scanned_cnt' index and its not correct, so use the correct index ('i') to check for before freeing the allocated memory. Signed-off-by: Ajay Singh ---

[PATCH v2 05/26] staging: wilc1000: moved last_scanned_shadow & last_scanned_cnt to wilc_priv struct

2018-09-04 Thread Ajay Singh
Avoid use of static variables and moved the varibles as part of private data. last_scanned_shadow & last_scanned_cnt variable is moved to 'wilc_priv' to maintain for each interface. After moving static variable, clear_shadow_scan() doesn't require check 'op_ifcs' count as now for each interface

[PATCH v2 00/26] staging: wilc1000: avoid use of static and global variable

2018-09-04 Thread Ajay Singh
This patch set mainly contains changes to avoid the use of static and global variables. Also contains few patch to avoid the checkpatch warning arise due to code refactor. Changes since v1: 1. rework on patch#10, use dynamically allocating memory to maintain multicast mac address filter

[PATCH v2 15/26] staging: wilc1000: refactor tcp_process() to avoid extra leading tabs

2018-09-04 Thread Ajay Singh
Refactor tcp_process() to avoid unnecessary leading tabs in the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 52 +++- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH v2 18/26] staging: wilc1000: avoid line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

2018-09-04 Thread Ajay Singh
Cleanup patch to avoid line over 80 chars checkpatch issue introduced in previous code refactor commit. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH v2 10/26] staging: wilc1000: refactor code to avoid use of wilc_set_multicast_list global

2018-09-04 Thread Ajay Singh
Refactor the code to avoid use of 'wilc_set_multicast_list' global variable. Allocate the memory required to keep the multicast mac address and pass it to the worker thread. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 13 +++--

[PATCH v2 06/26] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-09-04 Thread Ajay Singh
Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to 'wilc_vif' structure. Rename these variables like below wilc_during_ip_timer -> during_ip_timer wilc_optaining_ip -> obtaining_ip. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15

[PATCH v2 09/26] staging: wilc1000: move static variable clients_count to 'wilc' structure

2018-09-04 Thread Ajay Singh
Avoid use of static variable 'clients_count' and move it part of 'wilc' structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 07/26] staging: wilc1000: remove unused variable 'op_ifcs'

2018-09-04 Thread Ajay Singh
After code refactor in previous commit now 'op_ifcs' is not require any more, so remove it. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH v2 04/26] staging: wilc1000: remove unnecessary NULL check in clear_shadow_scan()

2018-09-04 Thread Ajay Singh
Cleanup patch to remove the unnecessary NULL check before freeing up ies information in clear_shadow_scan(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v2 22/26] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct

2018-09-04 Thread Ajay Singh
Move static variable 'wilc_connecting' as part of 'wilc_vif' private struct. Remove "wilc_" prefix from name as its already part of wilc_vif struct. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2

[PATCH v2 24/26] staging: wilc1000: refactor code to move initilization in wilc_netdev_init()

2018-09-04 Thread Ajay Singh
Refactor code to move the initialization of wilc related parameters in wilc_netdev_init() and move their deinitialization in wilc_netdev_cleanup(). For 'hif_workqueue' creation 'clients_count' check is not required as the single instance is maintained. Signed-off-by: Ajay Singh ---

[PATCH v2 26/26] staging: wilc1000: remove handle_hif_exit_work() function

2018-09-04 Thread Ajay Singh
Cleanup to remove handle_hif_exit_work(), as after code refactoring its not required anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH v3 01/16] mt76: unify wait_for_mac

2018-09-04 Thread Kalle Valo
Stanislaw Gruszka wrote: > Create new mt76x02_mac.h for common mac functions of mt76x0 and mt76x2 > and unity wait_for_mac for both drivers. > > Signed-off-by: Stanislaw Gruszka 16 patches applied to wireless-drivers-next.git, thanks. 2735a6dd7df3 mt76: unify wait_for_mac 89e1b1bc075a mt76:

Re: [PATCH 01/16] mt76: move mt76_reg_pair definition in mt76.h

2018-09-04 Thread Kalle Valo
Lorenzo Bianconi wrote: > Move common definition of mt76_reg_pair in mt76.h > and remove duplicated code in mt76x2_init_common.c > > Signed-off-by: Lorenzo Bianconi 16 patches applied to wireless-drivers-next.git, thanks. 5090efa4a2e8 mt76: move mt76_reg_pair definition in mt76.h

[PATCH v2 01/26] staging: wilc1000: move 'wilc_enable_ps' global variable into 'wilc' struct

2018-09-04 Thread Ajay Singh
Instead of having 'wilc_enable_ps' as global variable moved it to 'wilc' structure. Rename 'wilc_enable_ps' to 'enable_ps' as its already part of 'wilc' structure Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 5 ++---

Re: [PATCH v2] rtlwifi: remove set but unused variables

2018-09-04 Thread Kalle Valo
Kevin Lo wrote: > Remove set but unused variables from _rtl88ee_hw_configure() and > _rtl8723e_hw_configure(). > > Signed-off-by: Kevin Lo > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. b9bcce366bd5 rtlwifi: remove set but unused variables --