mt76 uses __skb_pad() with free_on_error set to true, this is the same
as calling skb_pad().
This patch does not change any functionality, but it makes it easier to
backport this driver in backports, because skb_pad() is also available
in older kernel versions.
Fixes: b40b15e1521f ("mt76: add usb
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> index 76d607f73758..b7a1069ecd0e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> @@ -45,7 +45,8 @@
>
On 9/25/2018 11:28 AM, Enrique Giraldo wrote:
The main reason is to be able to stop the CAC when you want to make a
channel switch and the CAC is ongoing. It's true that the radio would
not pass to the next phase, the behavior is the same as when during
the CAC a radar event is detected. In the
Instead of using static variable 'g_sdio' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and free during
deinitialization.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 1 +
drivers/staging/wilc1000/wilc_sdio.c | 54
Rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' as its more
appropriate for structure to store the values of string configuration.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 14 +++---
drivers/staging/wilc1000/wilc_wlan_cfg.h | 4 ++--
2 files changed,
Refactor the code in wilc_wlan_cfg.c file to avoid the use of static
variables. Move the static variables as part of wilc struct and also
dynamically allocating memory for keeping those variables.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 12 +-
Refactor the code by removing use of 'mac_status' from 'wilc_mac_cfg'
and only have the string type configuration values in 'wilc_mac_cfg'
struct. Now fetch the value 'WID_STATUS' configuration from 'g_cfg_byte'
array.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c
Instead of using static variable 'g_spi' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and
free is taken care in wilc_netdev_cleanup().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 58 +++--
1 file
Cleanup changes to avoid unnecessary setting 'wilc->bus_data' value to
zero as the buffer was allocated using kzalloc().
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 4 +---
drivers/staging/wilc1000/wilc_spi.c | 3 ---
2 files changed, 1 insertion(+), 6 deletions(-)
'wilc_connected_ssid' actually used to store the BSSID information for
connected BSSID. 'wilc_vif' already has 'bssid' variable to store the
same information. So refactor code to remove 'wilc_connected_ssid' and
instead used 'wilc_vif' struct 'bssid' element.
Signed-off-by: Ajay Singh
---
Instead of using extra completion variable to handle the sync call now
using msg->is_sync flag to handle the sync call.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 23 +++
drivers/staging/wilc1000/host_interface.h | 2 +-
Return 'void' from wilc_wlan_parse_info_frame() as same constant value
is returned always. Also removed the 'size' from input parameter as its
not used in the function.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 12
1 file changed, 4 insertions(+), 8
Use the correct datatype for storing the byte value in 'wilc_cfg_byte'
struct.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.h
Handle the setting of default value for 'wilc_cfg_rsp' type for all
cases in wilc_wlan_cfg_indicate_rx() as the caller make use of this
value to know the type of the received message.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 +--
1 file changed, 1 insertion(+),
Cleanup patch to remove the wid type not used in the code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
b/drivers/staging/wilc1000/wilc_wlan_if.h
index b81a73b..ce2066b
Use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack() as it always
return value '1' and its not used by the caller.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Cleanup patch to remove the unused element stored in cfg struct.
Removed those wid from the cfg variables whose value is not
fetched(GET_CFG) from the code. In case the wid is only set to the
firmware then there is need to store them as part of cfg variables, so
removed the unused code.
Change return type to 'void' for host_int_get_assoc_res_info() as its
return value is not used. 'rcvd_assoc_resp_info_len' parameter value is
used to know the status.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 11 +--
1 file changed, 5 insertions(+), 6
Cleanup patch to use 'void' return type for wilc_wlan_cfg_indicate_rx(),
as its return value is not used in caller. The value set in
'rsp' argument is used to get the success status.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 ++--
Use 'void' return for wilc_wlan_txq_add_to_head() as its always
return '0' value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
Use 'void' return type for below functions as they always return '0' and
their return value is not used by caller.
add_tcp_pending_ack()
update_tcp_session()
add_tcp_pending_ack()
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 15 ++-
1 file changed, 6
Cleanup patch to use 'void' return type for wilc_deinit_host_int(),
as its return value is not used in caller.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
2 files changed, 2 insertions(+), 4
Cleanup patch to use 'void' return type for wilc_wlan_set_bssid(),
as its always returns the same value.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 4 +---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
Cleanup patch to use 'void' return type for wilc_frame_register(), as
its return value is not used.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6 ++
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git
Use 'void' return type for wilc_wfi_deinit_mon_interface(), as same
value always return.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_mon.c | 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff
Cleanup patch to use 'void' return type for wlan_deinit_locks() &
wlan_init_locks(), as same value is return.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
On 2018-09-25 09:54, Lorenzo Bianconi wrote:
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
>> b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
>> index 76d607f73758..b7a1069ecd0e 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
>> +++
The main reason is to be able to stop the CAC when you want to make a
channel switch and the CAC is ongoing. It's true that the radio would
not pass to the next phase, the behavior is the same as when during
the CAC a radar event is detected. In the case of aborting, a later
action is expected,
On Tue, Sep 25, 2018 at 11:55:48AM +0200, Arend van Spriel wrote:
> On 9/25/2018 11:48 AM, Stanislaw Gruszka wrote:
> >On Tue, Sep 25, 2018 at 11:07:47AM +0200, Lorenzo Bianconi wrote:
> >>On Sep 25, Felix Fietkau wrote:
> >>>On 2018-09-25 09:54, Lorenzo Bianconi wrote:
> >
> >diff --git
On 9/25/2018 11:48 AM, Stanislaw Gruszka wrote:
On Tue, Sep 25, 2018 at 11:07:47AM +0200, Lorenzo Bianconi wrote:
On Sep 25, Felix Fietkau wrote:
On 2018-09-25 09:54, Lorenzo Bianconi wrote:
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
This patch series contains changes to avoid the use of static variables.
Cleanup changes to fix some checkpatch issues and return void for
function if their return value is not used.
Also deleted 'wilc_debugfs.c' file as it's not used.
Changes since v2:
Included Joe's suggestion for patch#28
On Tue, Sep 25, 2018 at 11:07:47AM +0200, Lorenzo Bianconi wrote:
> On Sep 25, Felix Fietkau wrote:
> > On 2018-09-25 09:54, Lorenzo Bianconi wrote:
> > >>
> > >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > >> b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > >> index
Refactor wilc_netdev_init() to return the error code received from
register_netdev() during the failure condition.
Earlier discussion link
[1]. https://www.spinics.net/lists/linux-wireless/msg177304.html
Suggested-by: Claudiu Beznea
Signed-off-by: Ajay Singh
---
Changes to avoid the below checkpatch warning:
'usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt;'
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Avoid use of static variable and move them as part of private
data(wilc_priv) struct.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/linux_wlan.c | 2 +
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 60 +++
Refactor wilc_set_multicast_list() by making below changes:
o use kmalloc_array
o remove unnecessary res
o add u8 *cur_mc
o use i as index
o use '%pM' extension in netdev_dbg()
The below checkpatch issue is also resolved after code refactor.
'spaces preferred around that '/' (ctx:VxV)'
Cleanup patch to remove -I(src) and -DWILC_ASIC_A0 option used in
ccflag-y in Makefile.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/Makefile
b/drivers/staging/wilc1000/Makefile
index
Deleted wilc_debugfs.c file as it's not used.
Earlier discussion link:
[1]. https://www.spinics.net/lists/linux-wireless/msg176076.html
Suggested-by: Greg KH
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/Makefile | 5 +-
drivers/staging/wilc1000/wilc_debugfs.c | 115
TP-LINK Archer T1U do not support 2.4GHz band despite EEPROM
reports that. Add quirk to mask out 2.4GHz support.
Reported-by: Sid Hayn
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 5 +
drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 ++
The allocation of hwsim radio identifiers uses a post-increment from 0,
so the first radio has idx 0. This idx is explicitly excluded from
multicast announcements ever since, but it is unclear why.
Drop that idx check and announce the first radio as well. This makes
userspace happy if it relies
On 9/25/2018 10:19 AM, Enrique Giraldo wrote:
Add NL80211_CMD_ABORT_CAC to the nl80211 interface.
This one really needs a good motivation. The CAC duration is a hard
requirement so aborting it means that the radio can not proceed to the
next phase. You really need to describe your reasoning
Hi all,
Konstantin has graciously added this list to lore, so we now have a web
archive here:
https://lore.kernel.org/linux-wireless
As it's done with public-inbox, you can also git clone the archive
and/or access it via NNTP. Somebody just needs to write a gmane-like
interface for it ;-)
On Sep 25, Felix Fietkau wrote:
> On 2018-09-25 09:54, Lorenzo Bianconi wrote:
> >>
> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> >> b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> >> index 76d607f73758..b7a1069ecd0e 100644
> >> ---
> -Original Message-
> From: Larry Finger [mailto:larry.fin...@gmail.com] On Behalf Of Larry Finger
> Sent: Tuesday, September 25, 2018 1:10 AM
> To: Tony Chuang; kv...@codeaurora.org
> Cc: linux-wireless@vger.kernel.org; Pkshih; Andy Huang
> Subject: Re: [RFC 00/12] rtwlan: mac80211
Add NL80211_CMD_ABORT_CAC to the nl80211 interface.
Signed-off-by: Enrique Giraldo
---
include/net/cfg80211.h | 2 ++
include/uapi/linux/nl80211.h | 4
net/mac80211/cfg.c | 6 ++
net/wireless/nl80211.c | 23 +++
net/wireless/rdev-ops.h
While testing out some other issue, I noticed that my ath10k system creates
several hundred null-data probes when I abruptly down the AP the station
is connected to.
I guess this is because I use the mac80211 stack to handle the probes, and
the firmware then retries each mac80211 probe many
What you commented was the first thing that I tried, but doing it, the
radio stays in an inconsistent state and the hostapd is not able to
raise an instance again.
Attached is the log of what is happening:
Tue Sep 25 09:58:10 2018 daemon.notice hostapd: wlan0: DFS-CAC-START
freq=5500 chan=100
> -Original Message-
> From: Kalle Valo [mailto:kv...@codeaurora.org]
> Sent: Monday, September 24, 2018 7:05 PM
> To: Stanislaw Gruszka
> Cc: Tony Chuang; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org;
> Pkshih; Andy Huang
> Subject: Re: [RFC 00/12] rtwlan: mac80211 driver
Hello all,
I'm experiencing an iwlwifi crash with Linux 4.18.9 in the following situation:
1) I'm suspending the laptop (into S3 sleep state)
2) Sometimes the laptop immediately wakes up again (as if a wake event fires)
3) In the immediate wakeup case iwlwifi crashes
I'm not sure if in
From: Pavel Machek
.max_tfd_queue_size was ommited for 1000 card serries leading to oops in
swiotlb.
Fixes: 7b3e42ea2ead ("iwlwifi: support multiple tfd queue max sizes for
different devices")
Tested-by: Randy Dunlap
Signed-off-by: Pavel Machek
Signed-off-by: Emmanuel Grumbach
On Tue, Sep 25, 2018 at 12:22 AM Johannes Berg
wrote:
>
> Hi all,
>
> Konstantin has graciously added this list to lore, so we now have a web
> archive here:
>
> https://lore.kernel.org/linux-wireless
>
That is fantastic! Thank you Konstantin, Johannes, and Jouni! While
the development on this
51 matches
Mail list logo
