[PATCH 05/12] staging: wilc1000: rename Handle_SetMulticastFilter to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 03/12] staging: wilc1000: rename variables using camelCase in handle_rcvd_ntwrk_info()

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 45 +++ 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 07/12] staging: wilc1000: rename pstrStatistics to avoid camelCase

Fix "Avoid caseCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 09/12] staging: wilc1000: rename pstrDelStaParam to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 08/12] staging: wilc1000: rename strDisconnectNotifInfo to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 11/12] staging: wilc1000: rename _WPAPtk_end_case_ label to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 12/12] staging: wilc1000: rename _WPARxGtk_end_case_ label to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 10/12] staging: wilc1000: rename pstrStationParam to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 46 +++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 00/12] staging: wilc1000: fixes to avoid use of camelCase in host interface

This patch series contains fixes for "Avoid camelCase" issues found by checkpatch.pl script. Ajay Singh (12): staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase staging: wilc1000: rename variables using ca

[PATCH 01/12] staging: wilc1000: rename pu8HdnNtwrksWidVal to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 04/12] staging: wilc1000: rename pu32InactiveTime to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 02/12] staging: wilc1000: rename ptstrJoinBssParam to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 78 +++ 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 06/12] staging: wilc1000: rename pstrSetBeaconParam to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 51 +++ 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

Modified wilc_spi_read_int() by removing unnecessary use of "happened" variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/stagin

[PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

Use existing macro GENMASK to get the bitmask value. Moved the code to get the bitmask value outside the loop, as its only required one time. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 3/4] staging: wilc1000: refactor wilc_spi_clear_int_ext() by using GENMASK macro

Use available macro GENMASK to get the bitmask value of specific value. Simplified the logic by adding expected_irqs & unexpected_irqs to check the interrupt bits. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 46 +++-- 1 file changed

[PATCH 4/4] staging: wilc1000: refactor sdio_clear_int_ext() by using GENMASK macro

Use GENMASK macro in sdio_clear_int_ext function to get the required bitmask value. Simplified the logic by making use of GENMASK macro. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 74 +++- 1 file changed, 31 insertions(+), 43 deletions

[PATCH 0/4] staging: wilc1000: modify functions by making use of GENMASK macro

This patch series contains changes to refactor functions by making use of GENMASK macro and also removed unnecessary variable from wilc_spi_read_int(). Ajay Singh (4): staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int() staging: wilc1000: modified wilc_sp

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

Hi Claudiu, On Mon, 19 Feb 2018 15:33:09 +0200 Claudiu Beznea wrote: > Since you re-factor this, as I suggested in patch: > "[PATCH 6/6] staging: wilc1000: fix line over 80 chars in > wilc_spi_clear_int_ext()" form your previous series: > "fix line over 80 char & coding style in wilc_spi.c", > f

Re: [PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

Hi Dan, On Thu, 22 Feb 2018 10:20:58 +0300 Dan Carpenter wrote: > On Wed, Feb 21, 2018 at 09:42:09PM +0530, Ajay Singh wrote: > > Modified wilc_spi_read_int() by removing unnecessary use of "happened" > > variable. > > > > Signed-off-by: Ajay Singh

Re: [PATCH 0/4] staging: wilc1000: modify functions by making use of GENMASK macro

Please ignore this patch series, I will work on review comments and submit another version later. Regards, Ajay

[PATCH 0/8] staging: wilc1000: fix coding style & checkpatch reported issues

Cleanup patch series to fix checkpatch.pl reported issue & code modification to follow linux coding style. Ajay Singh (8): staging: wilc1000: remove unnecessary while(0) in wilc_wlan_handle_txq() staging: wilc1000: rename label _end_ in wilc_wlan_handle_txq() staging: wilc1000: fix

[PATCH 1/8] staging: wilc1000: remove unnecessary while(0) in wilc_wlan_handle_txq()

Refactor wilc_wlan_handle_txq() by removing unnecessary while(0) loop. "Line over 80 char" issues in wilc_wlan_handle_txq() are fix by reducing extra leading tab. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 295 +-- 1 file ch

[PATCH 5/8] staging: wilc1000: rename WILC_WFI_mgmt_rx() to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 3 files changed, 3 insert

[PATCH 4/8] staging: wilc1000: move multiple definition of same macro to common header

Move the same #define from multiple '.c' files to common header file. Instead of having same macro in different '.c' files, now kept in common '.h' file. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 3 --- drivers/staging/wil

[PATCH 6/8] staging: wilc1000: fix line over 80 char in wilc_wlan_handle_rxq()

Fix 'line over 80 character' issue found by checkpatch.pl script. Refactor wilc_wlan_handle_rxq() code to remove the checkpatch.pl warnings. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 46 1 file changed, 25 inserti

[PATCH 3/8] staging: wilc1000: fix line over 80 char in wilc_wlan_handle_txq()

Refactor wilc_wlan_handle_txq() to fix 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 76 ++-- 1 file changed, 39 insertions(+), 37 deletions(-) diff --git a/drivers/stagin

[PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()

Fix 'Alignment should match open parenthesis' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/stagin

[PATCH 7/8] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()

Fix 'line over 80 character' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wl

[PATCH 2/8] staging: wilc1000: rename label _end_ in wilc_wlan_handle_txq()

Rename label name starting with '_' to follow as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/w

Re: [PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()

Hi Dan, On Tue, 27 Feb 2018 12:41:40 +0300 Dan Carpenter wrote: > The first 5 patches are good, but the last 3 are not OK. Thanks for your review comments. I will resubmit the patch series by only including first 5 patches. I will recheck the last 3 patches and submit them separately. > > No

[PATCH 0/3] staging: wilc1000: fix line over 80 char & coding style

This patch series contains fixes for open parenthesis mismatch and line over 80 char issue found by checkpatch script. Ajay Singh (3): staging: wilc1000: fix open parenthesis mismatch in wilc_wlan_cfg_get() staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set() staging

[PATCH 1/3] staging: wilc1000: fix open parenthesis mismatch in wilc_wlan_cfg_get()

Fix 'Alignment should match open parenthesis' issue found by checkpatch.pl script. Reduce the leading tab, to make space for open parenthesis match. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 25 + 1 file changed, 13 insertions(+), 12

[PATCH 2/3] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()

Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 37 ++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c

[PATCH 3/3] staging: wilc1000: fix line over 80 char in wilc_wlan_handle_rxq()

Refactor wilc_wlan_handle_rxq() to fix line over 80 character issue found by checkpatch.pl script. Added a new function to split 'wilc_wlan_handle_rxq' function code. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 114 +++ 1 file c

[PATCH 03/13] staging: wilc1000: fix line over 80 char in handle_cfg_param()

Fix 'line over 80 char' issues found by checkpatch.pl script in handle_cfg_param(). Rename variables and used temporary variables to fix the line over 80 characters issue. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 175 +---

[PATCH 02/13] staging: wilc1000: remove always 'true' check from 'if' statement

=> (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->active_scan_time < 65536) => (0-u16max < 65536)' handle_cfg_param() warn: always true condition '(cfg_param_attr->passive_scan_time < 65536) => (0-u16max < 65536)' Si

[PATCH 05/13] staging: wilc1000: fix line over 80 char for wilc_gnrl_async_info_received()

Fix 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 04/13] staging: wilc1000: fix line over 80 char in wilc_network_info_received()

Fix 'line over 80 character' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 06/13] staging: wilc1000: fix line over 80 char in host_int_parse_join_bss_param()

Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 216 +++--- 1 file changed, 108 insertions(+), 108 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 01/13] staging: wilc1000: rename enuEvent to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 00/13] staging: wilc1000: fix camelcase,line over 80 char and few smatch warning

This patch series contains fixes for checkpatch.pl reported issue & 'always true condition' smatch warning. Ajay Singh (13): staging: wilc1000: rename enuEvent to avoid camelCase staging: wilc1000: remove always 'true' check from 'if' statement staging:

[PATCH 09/13] staging: wilc1000: fix line over 80 char in wilc_del_allstation() & wilc_deinit()

Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 08/13] staging: wilc1000: fix line over 80 char in wilc_add_ptk()

Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 07/13] staging: wilc1000: rename pstrHostIFkeyAttr to avoid camelCase issue

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 119 +++--- 1 file changed, 59 insertions(+), 60 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 10/13] staging: wilc1000: fix line over 80 char in wilc_scan_complete_received()

Fix 'line over 80 character' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 12/13] staging: wilc1000: fix line over 80 char in handle_rcvd_ntwrk_info()

Fix 'line over 80 character' issues found by checkpatch.pl script by use of temporary variable and avoided leading tab. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 66 +++ 1 file changed, 33 insertions(+), 33 deletions(-) di

[PATCH 13/13] staging: wilc1000: rename u16DummyReasonCode to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfa

[PATCH 11/13] staging: wilc1000: rename handle_connect_timeout() variables to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/stagin

[PATCH 03/10] staging: wilc1000: rename CfgScanResult to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drive

[PATCH 02/10] staging: wilc1000: rename pstrNetworkInfo to avoid camelCase

Fix 'Avoid camleCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 51 +++ 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 05/10] staging: wilc1000: fix line over 80 char in change_virtual_intf()

Fix 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/stagin

[PATCH 06/10] staging: wilc1000: fix line over 80 char in get_key() & set_default_key()

Fix 'line over 80 characters' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drive

[PATCH 07/10] staging: wilc1000: fix line over 80 char for cfg parse RX and TX function

Fix 'line over 80 characters' issue found by checkpatch.pl script. Moved the common code from wilc_wfi_cfg_parse_tx_action() & wilc_wfi_cfg_parse_rx_action() to new function to avoid checkpatch issue. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgope

[PATCH 01/10] staging: wilc1000: rename strHiddenNetwork to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drive

[PATCH 00/10] staging: wilc1000: fixes related to camelCase & line over 80 chars

Patch series contains fixes to remove checkpatch reported warnings. Ajay Singh (10): staging: wilc1000: rename strHiddenNetwork to avoid camelCase staging: wilc1000: rename pstrNetworkInfo to avoid camelCase staging: wilc1000: rename CfgScanResult to avoid camelCase staging: wilc1000

[PATCH 09/10] staging: wilc1000: rename pJoinParams to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/stagin

[PATCH 10/10] staging: wilc1000: fix line over 80 char in cfg_scan_result()

Refactor cfg_scan_result() API to avoid 'line over 80 chars' issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 148 +++--- 1 file changed, 77 insertions(+), 71 deletions(-) diff --git a/drive

[PATCH 04/10] staging: wilc1000: rename au8ScanChanList to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/stagin

[PATCH 08/10] staging: wilc1000: fix line over 80 char in mgmt_tx_cancel_wait()

Fix 'line over 80 char' issue found in checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/stagin

[PATCH 02/10] staging: wilc1000: rename strConnectInfo to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 00/10] staging: wilc1000: fixes for checkpatch issues & coding style related

This patch series contains modification to remove the checkpatch warnings and changes to follow linux coding style. Ajay Singh (10): staging: wilc1000: rename pstrHostIFconnectAttr to avoid camelCase issue staging: wilc1000: rename strConnectInfo to avoid camelCase staging: wilc1000

[PATCH 01/10] staging: wilc1000: rename pstrHostIFconnectAttr to avoid camelCase issue

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 104 +++--- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 03/10] staging: wilc1000: rename label 'ERRORHANDLER' to avoid uppercase name

Cleanup patch to avoid use of uppercase for label names, to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 05/10] staging: wilc1000: fix line over 80 char in handle_connect()

Fix 'line over 80 characters' issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 48 +-- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/staging/wilc1000/host_inte

[PATCH 10/10] staging: wilc1000: fix line over 80 char issue in handle_scan_done()

Fix 'line over 80 characters' issue found by checkpatch.pl script in handle_scan_done(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 09/10] staging: wilc1000: rename variables using camelCase in handle_rcvd_gnrl_async_info()

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drive

[PATCH 08/10] staging: wilc1000: rename WILC_HostIf_PackStaParam to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_i

[PATCH 06/10] staging: wilc1000: fix line over 80 character in handle_disconnect()

Refactor handle_disconnect() to avoid line over 80 characters issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 90 +++ 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/staging

[PATCH 07/10] staging: wilc1000: rename variables prefix using datatype 'u8'

Rename variables with datatype 'u8' in their name to follow the linux coding style. Renamed following variables: u8abort_running_scan pu8Buffer pu8keybuf pu8msa u8remain_on_chan_flag Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.c | 28 +++--- drive

[PATCH 04/10] staging: wilc1000: fix line over 80 char in handle_scan()

Fix 'line over 80 character' issue reported by checkpatch.pl script in handle_scan(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_inte

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

Reviewed-by: Ajay Singh On Mon, 12 Mar 2018 15:09:03 +0530 wrote: > From: HariPrasath Elango > Please avoid use of 'From' tag specially when there is only one 'Signed-off-by' tag and its same. > Use the kernel pre-defined macro is_broadcast_ether_addr() ins

Re: [PATCH] staging: wilc1000: Fix code block alignment

On Mon, 12 Mar 2018 18:30:44 +0530 wrote: > From: HariPrasath Elango > > Fix the code alignment for a block of code to adhere to coding > guidelines > > Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh Regards, Ajay

Re: [PATCH] staging: wilc1000: Destroy mutex object in deinitialization

On Mon, 12 Mar 2018 18:49:49 +0530 wrote: > From: HariPrasath Elango > > Destroy the mutex object that is initialized in wlan_init_locks() > > Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh Regards, Ajay

Re: [PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

On Tue, 13 Mar 2018 11:50:48 +0530 wrote: > From: HariPrasath Elango > > Kmalloc followed by memcpy can be replaced by kmemdup. > > Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh Regards, Ajay

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

On Tue, 13 Mar 2018 10:58:16 +0100 Greg Kroah-Hartman wrote: > On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > > > Reviewed-by: Ajay Singh > > > > On Mon, 12 Mar 2018 15:09:03 +0530 > > wrote: > > > > > From: HariPrasath El

Re: [PATCH 6/7] staging: wilc1000: remove unwanted braces and correct code alignment

On Wed, 14 Mar 2018 18:15:04 +0530 wrote: > From: HariPrasath Elango > > Remove the unwated brace and corrected the code block alignment > accordingly Changes done in this patch are already taken care. Today, Greg has applied the patch which had these changes. This patch can be ignore from the

[PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

Added changes to free the allocated memory in scan() for error condition. Also added 'NULL' check validation before accessing allocated memory. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 62 +-- 1 file changed, 46 inserti

[PATCH 02/11] staging: wilc1000: removed unused global variables for gtk and ptk information

; g_ptk_keys_saved; g_gtk_keys_saved; g_wep_keys_saved; Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 80 --- 1 file changed, 80 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000

[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

This patch series contains fixes to avoid checkpatch issues and removed unused code. Few patch contains changes related to NULL check and freeing of dynamically allocated memory. Ajay Singh (11): staging: wilc1000: refactor scan() to free kmalloc memory on failure cases staging: wilc1000

[PATCH 03/11] staging: wilc1000: remove line over 80 char warnings in set_wiphy_params()

Fix 'line over 80 character' issue reported by checkpatch.pl script in set_wiphy_params(). Directly used the 'wiphy' pointer received as function argument instead of using 'priv->dev->ieee80211_ptr->wiphy'. Signed-off-by: Ajay Singh --- drivers/stagin

[PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Fix 'line over 80 characters' issue found by checkpatch.pl script. Refactor and split the function to avoid the checkpatch reported issues. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 145 -- 1 file changed, 82 inserti

[PATCH 05/11] staging: wilc1000: rename WILC_WFI_p2p_rx & s32Freq to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +- drivers/staging/wilc1000/wilc_wlan.h | 2 +

[PATCH 07/11] staging: wilc1000: rename hAgingTimer to avoid camelCase issue

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/stagin

[PATCH 06/11] staging: wilc1000: refactor mgmt_tx to fix line over 80 chars

Refactor mgmt_tx() to fix line over 80 characters issue. Split the function to avoid the checkpatch.pl warning. Returning the same error code in case of memory allocation failure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 187 +- 1

[PATCH 08/11] staging: wilc1000: fix line over 80 char issue in clear_shadow_scan()

Remove 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgopera

[PATCH 10/11] staging: wilc1000: remove unused 'struct add_key_params'

Cleanup patch to remove unused struct data structure. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 11/11] staging: wilc1000: remove line over 80 char warning in few functions

Remove 'line over 80 characters' issues found by checkpatch.pl script for following functions. disconnect() del_pmksa() wilc_create_wiphy() del_pmksa() Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 1 file changed, 8 insert

[PATCH 09/11] staging: wilc1000: remove line over 80 char in cfg_connect_result()

Fix 'line over 80 characters' issues reported by checkpatch.pl script in cfg_connect_result(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/stagin

Re: [PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

Hi Dan, Thanks for your detailed review comments. On Tue, 20 Mar 2018 22:46:32 +0300 Dan Carpenter wrote: > On Tue, Mar 20, 2018 at 10:25:34PM +0530, Ajay Singh wrote: > > Added changes to free the allocated memory in scan() for error condition. > > Also added 'NULL'

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

Hi Dan, On Wed, 21 Mar 2018 10:51:16 +0300 Dan Carpenter wrote: > These look good. I've reviewed them all. > > Reviewed-by: Dan Carpenter Thanks for reviewing all the patches. > > I had some small process complaints but it doesn't make life easier for > me if you resend them and I have to

[PATCH 0/9] staging: wilc1000: fix memory leaks and checkpatch reported issues

This patch series contains changes to fix memory leaks, avoid NULL pointer exceptions and checkpatch reported issue fixes. Ajay Singh (9): staging: wilc1000: remove unused global variables related to p2p staging: wilc1000: avoid 'NULL' pointer access in wilc_network_inf

[PATCH 1/9] staging: wilc1000: remove unused global variables related to p2p

Cleanup patch to remove the unused global variables defined for p2p. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 2/9] staging: wilc1000: avoid 'NULL' pointer access in wilc_network_info_received()

Added 'NULL' check before accessing the allocated memory. Free up the memory incase of failure to enqueue the command. Used kmemdup instead of kmalloc & memcpy. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 9 ++--- 1 file changed, 6 insertions(+

[PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

Free memory allocated for wep key when command enqueue is failed. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 3/9] staging: wilc1000: free allocated memory in edit and add station functions

Added fix to free the allocated memory in case of failure to enqueue the command. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging

[PATCH 6/9] staging: wilc1000: fix to free allocated memory in wilc_add_ptk()

Free allocated memory in wilc_add_ptk() when it fails to enqueue the command. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 5/9] staging: wilc1000: free allocated memory after processing wilc_send_config_pkt()

Free allocated memory after completing wilc_send_config_pkt() function. Remove unncessary use of 'stamac' pointer in handle_get_inactive_time(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) di

[PATCH 7/9] staging: wilc1000: free allocated memory in wilc_add_rx_gtk()

Free memory allocated in wilc_add_rx_gtk() before returing from the function. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging

[PATCH 9/9] staging: wilc1000: free memory allocated for general info message from firmware

Free allocated memory for failure scenario while processing the information message received from the firmware. Added NULL check and used kmemdup in the flow of handling information message. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 48

  1   2   3   4   5   6   7   8   >