[PATCH] mwifiex: fix kernel crash after shutdown command timeout

2017-02-24 Thread Amitkumar Karwar
mwifiex_remove_card(). At this point no further work will be scheduled. Signed-off-by: Amitkumar Karwar Signed-off-by: Cathy Luo --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +-- drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] MAINTAINERS: update for mwifiex driver maintainers

2017-02-28 Thread Amitkumar Karwar
Ganapathi & Xinming are starting to take a more active role in the mwifiex driver maintainership here onwards on account of organizational changes. CC: Xinming Hu CC: Ganapathi Bhat Signed-off-by: Amitkumar Karwar Signed-off-by: Nishant Sarmukadam Signed-off-by: Cathy Luo --- MAINTAI

Re: [PATCH] mwifiex: fix kernel crash after shutdown command timeout

2017-03-15 Thread Amitkumar Karwar
> From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, March 15, 2017 12:03 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; dmitry.torok...@gmail.com > Subject: [EXT] Re: [PATCH] mwifiex: fix

[PATCH v2] mwifiex: fix kernel crash after shutdown command timeout

2017-03-16 Thread Amitkumar Karwar
rdown path to resolve the issue. Signed-off-by: Amitkumar Karwar --- v2: New work_flag has been added to resolve the issue cleanly as per Brian's suggestion. --- drivers/net/wireless/marvell/mwifiex/main.h | 1 + drivers/net/wireless/marvell/mwifiex/pcie.c | 4 drivers/net/wireless/marve

[PATCH] mwifiex: send fewer channels to scan while connected

2017-03-16 Thread Amitkumar Karwar
Application triggers periodic background scans when device is connected. We will scan less number of channels per scan command so that data traffic won't get affected. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/scan.c | 11 --- 1 file changed, 8 inser

[PATCH] mwifiex: enable auto deep sleep mode for USB chipsets

2017-03-27 Thread Amitkumar Karwar
Chip goes into low power state when this feature is enabled. This was already enabled for SDIO and PCIe interface based chipsets. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net

[PATCH] mwifiex: apply radar flag

2017-03-30 Thread Amitkumar Karwar
-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index 1e3bd43..44d0617 100644 --- a/drivers/net

[v2 00/11] Firmware loading changes

2017-05-09 Thread Amitkumar Karwar
This patch series includes firmware loading enhancements for Redpine 9113 chipset. The older method is not being used by any Redpine chipset. There is no firmware image submitted to upstream yet. We will submit 9113's firmware image once these changes are accepted. This patch series is based on or

[v2 02/11] rsi: Changes to sdio reads and writes

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi SDIO read or write maximum size is limited to 2^16. This is done to make the host interface operations common for SDIO and USB. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 10

[v2 01/11] rsi: Rename file rsi_91x_pkt.c to rsi_91x_hal.c

2017-05-09 Thread Amitkumar Karwar
more relevant as per it's functionality. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/Makefile | 2 +- drivers/net/wireless/rsi/{rsi_91x_pkt.c => rsi_91x_hal.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-)

[v2 03/11] rsi: Changes in USB read and write operations

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi USB read and write registers maximum size is limited 2^16. More than this size is not used in the driver. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_usb.c | 6 +++--- drivers/net/wireless/rsi

[v2 04/11] rsi: use macros in USB specific code

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi For USB vendor read and write operations new macros added to avoid redundant usage of long or'ed macros. Also for timeouts standard USB macros are used. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireles

[v2 11/11] rsi: Remove old firmware loading method

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi The older firmware loading method is not usable by any Redpine chipset. Hence removing that part of the code. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 187

[v2 06/11] rsi: Handle usb multi-byte write failure case properly

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi In function usb_write_register_multiple, if any intermediate block transfer is failed, further operations should be terminated. 'else' is removed, as there is no significance for it after return. Signed-off-by: Prameela Rani Garnepudi Signed-off-by:

[v2 09/11] rsi: Add new host interface operations

2017-05-09 Thread Amitkumar Karwar
. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 179 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 3 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 65 ++ drivers/net/wireless/rsi

[v2 07/11] rsi: Add usb multi-byte read operation

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi USB multibyte read will be used in the new firmware loading method for RS9113 chipset. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_usb.c | 40 ++ 1 file changed, 40

[v2 05/11] rsi: Remove unnecessary buffer allocation

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi In functions usb read register and usb write register, dynamic allocation of 4 bytes is used. This is removed as it is unncessary for local variable and for such small data. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net

[v2 08/11] rsi: Add host interface operations as separate structure.

2017-05-09 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Host interface operations are currently function pointers in rsi_hw structure. As more host interface operations are going to be introduced, separate structure is added for these for convenience. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar

[v2 10/11] rsi: Add new firmware loading method

2017-05-09 Thread Amitkumar Karwar
, host issues boot loader commands to verify whether firmware to load is different from the current functional firmware. If not, firmware upgrade progresses and boot loader will switch to the new functional firmware. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar

[v3 00/11] Firmware loading changes

2017-05-16 Thread Amitkumar Karwar
This patch series includes firmware loading enhancements for Redpine 9113 chipset. The older method is not being used by any Redpine chipset. There is no firmware image submitted to upstream yet. We will submit 9113's firmware image once these changes are accepted. Amitkumar Karwar (1):

[v3 01/11] rsi: Rename file rsi_91x_pkt.c to rsi_91x_hal.c

2017-05-16 Thread Amitkumar Karwar
more relevant as per it's functionality. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Same as earlier --- drivers/net/wireless/rsi/Makefile | 2 +- drivers/net/wireless/rsi/{rsi_91x_pkt.c => rsi_91x_hal.c} | 0 2 files changed, 1 i

[v3 02/11] rsi: Changes to sdio reads and writes

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi SDIO read or write maximum size is limited to 2^16. This is done to make the host interface operations common for SDIO and USB. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Same as earlier --- drivers/net/wireless/rsi

[v3 05/11] rsi: use macros in USB specific code

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi For USB vendor read and write operations new macros added to avoid redundant usage of long or'ed macros. Also for timeouts standard USB macros are used. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Same as v2 04/11 --- dr

[v3 03/11] rsi: define RSI_USB_BUF_SIZE macro

2017-05-16 Thread Amitkumar Karwar
RSI_USB_BUF_SIZE macro is used instead of hardcoding a buffer size to 4096. Signed-off-by: Amitkumar Karwar --- v3: Newly added patch in v3 --- drivers/net/wireless/rsi/rsi_91x_usb.c | 4 ++-- drivers/net/wireless/rsi/rsi_usb.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff

[v3 06/11] rsi: Handle usb multi-byte write failure case properly

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi In function usb_write_register_multiple, if any intermediate block transfer is failed, further operations should be terminated. 'else' is removed, as there is no significance for it after return. Signed-off-by: Prameela Rani Garnepudi Signed-off-by:

[v3 04/11] rsi: Changes in USB read and write operations

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi USB read and write registers maximum size is limited 2^16. More than this size is not used in the driver. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Same as v2 03/11 --- drivers/net/wireless/rsi/rsi_91x_usb.c | 6

[v3 09/11] rsi: Add new host interface operations

2017-05-16 Thread Amitkumar Karwar
. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Same as earlier --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 179 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 3 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 65

[v3 07/11] rsi: Add usb multi-byte read operation

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi USB multibyte read will be used in the new firmware loading method for RS9113 chipset. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Use RSI_USB_BUF_SIZE macro for 4096 --- drivers/net/wireless/rsi/rsi_91x_usb.c | 40

[v3 08/11] rsi: Add host interface operations as separate structure.

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Host interface operations are currently function pointers in rsi_hw structure. As more host interface operations are going to be introduced, separate structure is added for these for convenience. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar

[v3 10/11] rsi: Add new firmware loading method

2017-05-16 Thread Amitkumar Karwar
ned-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Included new firmware name in commit description(Kalle Valo) --- drivers/net/wireless/rsi/rsi_91x_hal.c | 527 drivers/net/wireless/rsi/rsi_91x_sdio.c | 11 +- drivers/net/wi

[v3 11/11] rsi: Remove old firmware loading method

2017-05-16 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi The older firmware loading method is not usable by any Redpine chipset. Hence removing that part of the code. Older firmware image with rsi_91x.fw name is deprecated Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v3: Included the name

[v8 0/8] rsi: add bluetooth and coex support

2018-02-23 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series adds new bluetooth driver and coex enhancments in existing wlan driver for RSI chipsets. As per our architecture, both wlan and bluetooth drivers talk over same SDIO interface to device. Separate endpoint will be used in case of USB interface. Change in

[v8 1/8] rsi: add rx control block to handle rx packets in USB

2018-02-23 Thread Amitkumar Karwar
Signed-off-by: Amitkumar Karwar --- v8: Same as v6, v7 v6: Removed unnecessary GFP_DMA flag for kzalloc(Kalle) v5: Same as earlier version --- drivers/net/wireless/rsi/rsi_91x_main.c | 4 +- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 75

[v8 2/8] rsi: add bluetooth rx endpoint

2018-02-23 Thread Amitkumar Karwar
ulk) MxPS= 512 Ivl=0ms E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms Signed-off-by: Siva Rebbagondla Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v8: Same as previos revisions v2: Included '/sys/kernel/debug/usb/de

[v8 4/8] rsi: add coex support

2018-02-23 Thread Amitkumar Karwar
introduced for this purpose. Protocol operations structure is global structure which can be shared among different modules. Move initialization of coex and operating mode values to rsi_91x_init(). Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar

[v8 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

2018-02-23 Thread Amitkumar Karwar
Signed-off-by: Siva Rebbagondla Acked-by: Marcel Holtmann Reviewed-by: Marcel Holtmann Signed-off-by: Amitkumar Karwar --- v8: Resolve 'kbuild test robot' reported error. Used asm/unaligned.h header file instead of linux/unaligned/le_byteshift.h v7: Same as v6 v6: Renamed CON

[v8 7/8] rsi: add module parameter operating mode

2018-02-23 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Operating mode determines the support for other protocols. This is made as module parameter for better usage. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_main.c | 48

[v8 8/8] rsi: sdio changes to support BT

2018-02-23 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Queue number is correctly updated for BT traffic. Also, kzalloc instead of kmalloc is used for Rx packet allocation. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 ++ drivers/net

[v8 6/8] rsi: handle BT traffic in driver

2018-02-23 Thread Amitkumar Karwar
initialization time. Build flag CONFIG_RSI_COEX is introduced to enable coex support if CONFIG_BT_RSIHCI is enabled. Coex operations are valid if coex mode is greater than 1 only. Signed-off-by: Siva Rebbagondla Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v8: Same as v6, v7

[v8 3/8] rsi: add header file rsi_91x

2018-02-23 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi The common parameters used by wlan and bt modules are add to a new header file "rsi_91x.h" defined in 'include/net' Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- v8: Same a

[v9 1/8] rsi: add rx control block to handle rx packets in USB

2018-02-27 Thread Amitkumar Karwar
Signed-off-by: Amitkumar Karwar --- v9: No change since v6 v6: Removed unnecessary GFP_DMA flag for kzalloc(Kalle) v5: Same as earlier version --- drivers/net/wireless/rsi/rsi_91x_main.c | 4 +- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- drivers/net/wireless/rsi/rsi_91x_usb.c

[v9 0/8] rsi: add bluetooth and coex support

2018-02-27 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series adds new bluetooth driver and coex enhancments in existing wlan driver for RSI chipsets. As per our architecture, both wlan and bluetooth drivers talk over same SDIO interface to device. Separate endpoint will be used in case of USB interface. Change in

[v9 3/8] rsi: add header file rsi_91x

2018-02-27 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi The common parameters used by wlan and bt modules are add to a new header file "rsi_91x.h" defined in 'include/net' Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- v9: No change

[v9 2/8] rsi: add bluetooth rx endpoint

2018-02-27 Thread Amitkumar Karwar
ulk) MxPS= 512 Ivl=0ms E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms Signed-off-by: Siva Rebbagondla Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v9: No change since v2 v2: Included '/sys/kernel/debug/usb/devices&

[v9 6/8] rsi: handle BT traffic in driver

2018-02-27 Thread Amitkumar Karwar
initialization time. Build flag CONFIG_RSI_COEX is introduced to enable coex support if CONFIG_BT_RSIHCI is enabled. Coex operations are valid if coex mode is greater than 1 only. Signed-off-by: Siva Rebbagondla Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v8: Same as v6, v7

[v9 7/8] rsi: add module parameter operating mode

2018-02-27 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Operating mode determines the support for other protocols. This is made as module parameter for better usage. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_main.c | 48

[v9 4/8] rsi: add coex support

2018-02-27 Thread Amitkumar Karwar
introduced for this purpose. Protocol operations structure is global structure which can be shared among different modules. Move initialization of coex and operating mode values to rsi_91x_init(). Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar

[v9 8/8] rsi: sdio changes to support BT

2018-02-27 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Queue number is correctly updated for BT traffic. Also, kzalloc instead of kmalloc is used for Rx packet allocation. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 ++ drivers/net

[v9 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

2018-02-27 Thread Amitkumar Karwar
Signed-off-by: Siva Rebbagondla Acked-by: Marcel Holtmann Reviewed-by: Marcel Holtmann Signed-off-by: Amitkumar Karwar --- v8: Resolve 'kbuild test robot' reported error. Used asm/unaligned.h header file instead of linux/unaligned/le_byteshift.h v7: Same as v6 v6: Renamed CON

[PATCH 0/3] rsi: RX path improvements

2018-02-27 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series adds a thread for Rx handling and other related enhancements for better throughput. Prameela Rani Garnepudi (3): rsi: improve RX handling in SDIO interface rsi: use dynamic RX control blocks instead of MAX_RX_URB rsi: improve RX packet handling in

[PATCH 2/3] rsi: use dynamic RX control blocks instead of MAX_RX_URB

2018-02-27 Thread Amitkumar Karwar
Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_usb.c | 34 ++ drivers/net/wireless/rsi/rsi_91x_usb_ops.c | 5 +++-- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless

[PATCH 1/3] rsi: improve RX handling in SDIO interface

2018-02-27 Thread Amitkumar Karwar
event. RX thread processes the packets from RX queue. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 45 +++- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 64 +++-- drivers/net

[PATCH 3/3] rsi: improve RX packet handling in USB interface

2018-02-27 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Curretly, RX packet processing is done sequencially. To improve the efficiency, RX skb queue is introduced. Here, while preparing RX URB skb is allocated and used for RX buffer. When rx done handler is called, enqueue the skb to rx_q and set the thread event. RX thre

Re: [v7 3/8] rsi: add header file rsi_91x

2018-03-05 Thread Amitkumar Karwar
Hi Dave and Johannes, On Tue, Feb 20, 2018 at 6:44 PM, Kalle Valo wrote: > Hi Dave and Johannes, > > a question to both of you below: > > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> The common parameters used by wlan and bt mod

[PATCH 00/10] rsi driver enhancements

2018-03-05 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series brings in improvements in scan, Tx path, roaming and regulatory handling. Prameela Rani Garnepudi (9): rsi: add support for hardware scan offload rsi: move xtend_desc structure from rsi_main.h to rsi_mgmt.h rsi: move descriptor preparation to core

[PATCH 04/10] rsi: enable 80MHz clock by default

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi 80MHz clock for device should be enabled by default in TX command frame radio capabilities. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/

[PATCH 07/10] rsi: regulatory modifications for 'dlcar' mode

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Changes in this patch are for applying custom regulatory rules for 'dlcar' regulatory mode. Max channel power values are updated for 12, 13, and 14. Dlcar only has 2.4GHz band. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_mac80211.c

[PATCH 08/10] rsi: device disconnect changes

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Below changes are done: 1. When HCI detach is called, making bt_adapter null and checking for this variable where ever required. 2. In USB case, one extra register write is added to disable firmware watchdog. 3. When interface down is called as part of disconnect, do

[PATCH 05/10] rsi: roaming enhancements

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi To support roaming below changes are done: * Station notify frame is send to firmware after sending assoc request. This will avoid dropping of first EAPOL frame due to delay in creation of station control block in firmware. * Data queues are unblocked after sendi

[PATCH 06/10] rsi: add module parameter rsi_reg

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi For few regulatory customizations, we are taking rsi_reg as module parameter. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_main.c | 4 drivers/net/wireless/rsi/rsi_common.h | 3 +++ 2 files changed, 7 insertions(+) diff --git

[PATCH 01/10] rsi: add support for hardware scan offload

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi With the current approach of scanning, roaming delays are observed. Firmware has support for back ground scanning. To get this advantage, mac80211 hardware scan is implemented. In this method, foreground scan is performed in driver and back ground scan is configured

[PATCH 03/10] rsi: move descriptor preparation to core

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi To avoid synchronization issues in sending TX frames, descriptors preparation is moved to core, instead of HAL. This will avoid races during foreground scan because of mgmt configurations. Also xtended descriptor is moved from rsi_main.h to rsi_mgmt.h as all descript

[PATCH 02/10] rsi: move xtend_desc structure from rsi_main.h to rsi_mgmt.h

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi All descriptor structures are in rsi_mgmt.h except this extended descriptor structure. Hence moving it to rsi_mgmt.h and also renaming to rsi_xtend_desc. Signed-off-by: Prameela Rani Garnepudi --- drivers/net/wireless/rsi/rsi_91x_hal.c | 12 ++-- drivers/n

[PATCH 10/10] rsi: drop RX broadcast/multicast packets with invalid PN

2018-03-05 Thread Amitkumar Karwar
From: Siva Rebbagondla This patch adds a check to drop received broadcast/multicast frames if PN is invalid (i.e. not greater than last PN). bc_mc_pn variable added for each interface Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi

[PATCH 09/10] rsi: tx improvements

2018-03-05 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Changes done to improve TX path: 1. Max number of frames to aggregate is increased to 8 2. Bootup parameters updated. 3. registering 5g band is done only when device supports 4. Vif is properly taken to enable power save. 5. When coex mode exist, power save on by def

Re: Variable-length arrays considered bad

2018-03-08 Thread Amitkumar Karwar
..@mail.gmail.com > > [2] http://paste.ubuntu.com/p/srQxwPQS9s/ > I will submit a cleanup patch for RSI warning Regards, Amitkumar Karwar

Re: [PATCH 01/10] rsi: add support for hardware scan offload

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:46 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> With the current approach of scanning, roaming delays >> are observed. Firmware has support for back ground scanning. >> To get this

Re: [PATCH 01/10] rsi: add support for hardware scan offload

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:48 PM, Kalle Valo wrote: > Kalle Valo writes: > >> Amitkumar Karwar writes: >> >>> From: Prameela Rani Garnepudi >>> >>> With the current approach of scanning, roaming delays >>> are observed. Firmware has suppo

Re: [PATCH 05/10] rsi: roaming enhancements

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:54 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> To support roaming below changes are done: >> * Station notify frame is send to firmware after sending assoc >> request. This will avoid

Re: [PATCH 01/10] rsi: add support for hardware scan offload

2018-03-15 Thread Amitkumar Karwar
On Thu, Mar 15, 2018 at 2:30 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> On Tue, Mar 13, 2018 at 8:46 PM, Kalle Valo wrote: >>> Amitkumar Karwar writes: >>> >>>> From: Prameela Rani Garnepudi >>>> >>>> With the curren

Re: [PATCH 06/10] rsi: add module parameter rsi_reg

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:55 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> For few regulatory customizations, we are taking rsi_reg >> as module parameter. > > Why? We have a custom power table and country to regio

Re: [PATCH 08/10] rsi: device disconnect changes

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:57 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> Below changes are done: >> 1. When HCI detach is called, making bt_adapter null and checking >> for this variable where ever required. &

Re: [PATCH 09/10] rsi: tx improvements

2018-03-15 Thread Amitkumar Karwar
On Tue, Mar 13, 2018 at 8:59 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> Changes done to improve TX path: >> 1. Max number of frames to aggregate is increased to 8 >> 2. Bootup parameters updated. >> 3. re

[PATCH 1/2] rsi: fix error path handling in SDIO probe

2018-03-20 Thread Amitkumar Karwar
From: Amitkumar Karwar We miss to release IRQ in certain error path in SDIO probe which causes following kernel panic. This patch corrects error path handling BUG: unable to handle kernel NULL pointer dereference at(null) IP: (null) PGD 0 P4D 0 Oops: 0010 [#1] SMP PTI Call

[PATCH 2/2] rsi: fix kernel panic observed on 64bit machine

2018-03-20 Thread Amitkumar Karwar
From: Amitkumar Karwar Following kernel panic is observed on 64bit machine while loading the driver. It is fixed if we pass dynamically allocated memory to SDIO for DMA. BUG: unable to handle kernel paging request at eb04000172e0 IP: sg_miter_stop+0x56/0x70 PGD 0 P4D 0 Oops: [#1] SMP

Re: [PATCH 01/10] rsi: add support for hardware scan offload

2018-03-23 Thread Amitkumar Karwar
On Wed, Mar 21, 2018 at 4:02 AM, Johannes Berg wrote: > On Thu, 2018-03-15 at 14:57 +0530, Amitkumar Karwar wrote: >> >> > What I don't like here is that you are duplicating functionality >> > already >> > existing in mac80211 and I hope there is a better

Re: [PATCH 10/10] rsi: drop RX broadcast/multicast packets with invalid PN

2018-03-23 Thread Amitkumar Karwar
On Wed, Mar 21, 2018 at 4:25 AM, Johannes Berg wrote: > On Mon, 2018-03-05 at 20:07 +0530, Amitkumar Karwar wrote: >> From: Siva Rebbagondla >> >> This patch adds a check to drop received broadcast/multicast frames >> if >> PN is invalid (i.e. not greater th

Re: [PATCH 01/10] rsi: add support for hardware scan offload

2018-03-27 Thread Amitkumar Karwar
Hi Kalle/Johannes, On Tue, Mar 27, 2018 at 7:48 PM, Kalle Valo wrote: > Johannes Berg writes: > >> On Fri, 2018-03-23 at 20:20 +0530, Amitkumar Karwar wrote: >> >>> > But maybe that's not really true at all? At least in one case it seems >>>

[v2 0/4] rsi driver enhancements

2018-03-29 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series includes some code rearrangement and roaming related improvements. Changes in v2: v2 1/4 is same as v1 2/10 v2 2/4 is same as v1 3/10 v2 3/4 is same as v1 4/10 v2 4/4 is updated version of v1 5/10 Remaining patches in v1 need major improvements. Couple

[v2 1/4] rsi: move xtend_desc structure from rsi_main.h to rsi_mgmt.h

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi All descriptor structures are in rsi_mgmt.h except this extended descriptor structure. Hence moving it to rsi_mgmt.h and also renaming to rsi_xtend_desc. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi

[v2 3/4] rsi: enable 80MHz clock by default

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi 80MHz clock for device should be enabled by default in TX command frame radio capabilities. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[v2 2/4] rsi: move descriptor preparation to core

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Descriptors preparation is moved to core instead of HAL to avoid synchronization issues in sending TX frames Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_core.c | 11 + drivers/net/wireless

[v2 4/4] rsi: roaming enhancements

2018-03-29 Thread Amitkumar Karwar
sending station notify in open mode, after configuring key in WEP mode, and after receiving EAPOL4 confirm in WPA mode. * Initial EAPOL frames priority is chaged to MGMT, rekey EAPOL frames priority changed to VO. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar

[v2 RESEND 1/4] rsi: move xtend_desc structure from rsi_main.h to rsi_mgmt.h

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi All descriptor structures are in rsi_mgmt.h except this extended descriptor structure. Hence moving it to rsi_mgmt.h and also renaming to rsi_xtend_desc. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi

[v2 RESEND 3/4] rsi: enable 80MHz clock by default

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi 80MHz clock for device should be enabled by default in TX command frame radio capabilities. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[v2 RESEND 2/4] rsi: move descriptor preparation to core

2018-03-29 Thread Amitkumar Karwar
From: Prameela Rani Garnepudi Descriptors preparation is moved to core instead of HAL to avoid synchronization issues in sending TX frames Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_core.c | 11 + drivers/net/wireless

[v2 RESEND 4/4] rsi: roaming enhancements

2018-03-29 Thread Amitkumar Karwar
sending station notify in open mode, after configuring key in WEP mode, and after receiving EAPOL4 confirm in WPA mode. * Initial EAPOL frames priority is chaged to MGMT, rekey EAPOL frames priority changed to VO. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar --- v2

[v2 RESEND 0/4] rsi driver enhancements

2018-03-29 Thread Amitkumar Karwar
From: Amitkumar Karwar This patch series includes some code rearrangement and roaming related improvements. Changes in v2: v2 1/4 is same as v1 2/10 v2 2/4 is same as v1 3/10 v2 3/4 is same as v1 4/10 v2 4/4 is updated version of v1 5/10 Remaining patches in v1 need major improvements. Couple

[PATCH 1/2] rsi: fix nommu_map_sg overflow kernel panic

2018-04-10 Thread Amitkumar Karwar
/0x50 [rsi_sdio] [ 927.518041] sdio_register_driver+0x20/0x30 [ 927.518047] rsi_module_init+0x16/0x40 [rsi_sdio] Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_hal.c | 35 - drivers/net/wireless/rsi

[PATCH 2/2] rsi: Fix 'invalid vdd' warning in mmc

2018-04-10 Thread Amitkumar Karwar
xe0 [ 927.424227] ? rsi_sdio_ack_intr+0x50/0x50 [rsi_sdio] [ 927.424231] sdio_register_driver+0x20/0x30 [ 927.424237] rsi_module_init+0x16/0x40 [rsi_sdio] Signed-off-by: Siva Rebbagondla Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 -- 1 file changed, 2 deleti

RE: [PATCH] mwifiex: handle edmac vendor command

2016-08-31 Thread Amitkumar Karwar
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Amitkumar Karwar > Sent: Wednesday, August 03, 2016 4:51 PM > To: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Subject: RE: [PATCH] mwifiex: handle edmac vendor com

RE: [PATCH] mwifiex: handle edmac vendor command

2016-09-01 Thread Amitkumar Karwar
Hi Kalle, > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Thursday, September 01, 2016 8:23 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org > Subject: Re: [PATCH] mwifiex: handle edmac vendor command > > Amitkumar Karwar writes: > > >

[PATCH v5 1/2] mwifiex: add manufacturing mode support

2016-09-02 Thread Amitkumar Karwar
-by: Amitkumar Karwar --- v5: Fix format issue and enhance mfg_mode module parameter description (Brian Norris). v4: Removed mfg_firmware module parameter and hardcoded the firmware name in driver(Kalle Valo). --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 8 drivers/net

[PATCH v5 2/2] mwifiex: add cfg80211 testmode support

2016-09-02 Thread Amitkumar Karwar
From: Xinming Hu This patch adds cfg80211 testmode support so that userspace tools can download necessary commands to firmware during manufacturing mode tests. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v5: Made the function as static.(Brian Norris) v4: Used cfg80211

RE: [v4,1/2] mwifiex: add manufacturing mode support

2016-09-02 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Thursday, September 01, 2016 1:05 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam > Subject: Re: [v4,1/2] mwifiex: add manufacturing mode support > > Hi

RE: [v4,2/2] mwifiex: add cfg80211 testmode support

2016-09-02 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Thursday, September 01, 2016 1:10 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > Xinming Hu > Subject: Re: [v4,2/2] mwifiex: add cfg80211 testmode support &

RE: [PATCH] mwifiex: handle edmac vendor command

2016-09-07 Thread Amitkumar Karwar
Hi Kalle, > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Friday, September 02, 2016 8:26 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org > Subject: Re: [PATCH] mwifiex: handle edmac vendor command > > Amitkumar Karwar writes: > > >>

RE: mwifiex: PCIe8997 chip specific handling

2016-09-07 Thread Amitkumar Karwar
Hi Kalle, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Amitkumar Karwar > Sent: Thursday, August 11, 2016 4:11 PM > To: Steve deRosier > Cc: Brian Norris; linux-wireless@vger.kernel.org; Cathy Luo; Nishant > Sar

RE: mwifiex: add PCIe function level reset support

2016-09-08 Thread Amitkumar Karwar
Hi Kalle, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Kalle Valo > Sent: Saturday, September 03, 2016 9:10 PM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Amitkumar Karwar > Subject: Re: mwifiex:

RE: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-09-08 Thread Amitkumar Karwar
Hi Javier, > From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] > Sent: Tuesday, September 06, 2016 5:43 PM > To: Kalle Valo > Cc: linux-ker...@vger.kernel.org; Amitkumar Karwar; > net...@vger.kernel.org; linux-wireless@vger.kernel.org; Nishant > Sarmukadam; Arend va

  1   2   3   4   5   6   7   8   9   10   >