Re: [RFC v2] device coredump: add new device coredump class

2014-09-08 Thread Arend van Spriel
On 09/05/14 10:50, Johannes Berg wrote: From: Johannes Bergjohannes.b...@intel.com Many devices run firmware and/or complex hardware, and most of that can have bugs. When it misbehaves, however, it is often much harder to debug than software running on the host. Introduce a device coredump

Re: Mesh Support in brcmsmac

2014-09-09 Thread Arend van Spriel
+ linux-wireless On 09/09/14 12:22, chandrika parimoo wrote: Hello, I have broadcom bcm4313 card and am using brcmsmac driver which does not have mesh support currently. I wanted to know if there is a workaround for it? No workaround. I am not familiar with wireless mesh networking. I

Re: P2P_DEVICE support in Android KitKat

2014-09-10 Thread Arend van Spriel
, Thanks, Ilan Got the hint from brcm colleague as well. Regards, Arend Ilan. -Original Message- From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- ow...@vger.kernel.org] On Behalf Of Jouni Malinen Sent: Wednesday, September 10, 2014 14:11 To: Arend van Spriel Cc: linux

Re: [PATCH net-next 2/2] mac80211: Resolve sk_refcnt/sk_wmem_alloc issue in wifi ack path

2014-09-11 Thread Arend van Spriel
On 09/11/14 09:06, Johannes Berg wrote: On Wed, 2014-09-10 at 18:05 -0400, Alexander Duyck wrote: There is a possible issue with the use, or lack thereof of sk_refcnt and sk_wmem_alloc in the wifi ack status functionality. Specifically if a socket were to request acknowledgements, and the

Re: P2P_DEVICE support in Android KitKat

2014-09-11 Thread Arend van Spriel
On 10-09-14 16:15, Arend van Spriel wrote: On 09/10/14 13:10, Jouni Malinen wrote: On Wed, Sep 10, 2014 at 09:30:05AM +0200, Arend van Spriel wrote: I am running some tests on a haswell target with Android KitKat (3.10.20 kernel). In this configuration our brcmfmac driver is used with driver

[PATCH for-3.17 2/3] brcmfmac: conditionally compile firmware protocol source code

2014-09-11 Thread Arend van Spriel
...@linux-m68k.org Reviewed-by: Franky (Zhenhui) Lin fran...@broadcom.com Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Daniel (Deognyoun) Kim de...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers

[PATCH for-3.17 1/3] brcmfmac: Fix memory leak and missing assignment.

2014-09-11 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com The function brcmf_enable_bw40_2g contains a memory leak. The function is also missing initialisation of one of the members of ch struct, which can lead to warning but this has no impact on result. Reviewed-by: Arend Van Spriel ar...@broadcom.com

[PATCH for-3.17 3/3] brcmfmac: obtain ifp through wdev structure

2014-09-11 Thread Arend van Spriel
-by: Franky (Zhenhui) Lin fran...@broadcom.com Reviewed-by: Daniel (Deognyoun) Kim de...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 7 +-- 1 file changed, 5

Re: [PATCH 0/4 linux-next] drivers/net: use container_of where possible

2014-09-14 Thread Arend van Spriel
the patches they can each go through their own subsystem git tree. Generally I tend to submit patches to the subsystem maintainer and Cc the appropriate mailing lists. Regarding the patches for brcmsmac, you can add Acked-by: Arend van Spriel ar...@broadcom.com Regards, Arend Fabian Frederick (4

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-15 Thread Arend van Spriel
On 27-08-14 17:27, Arend van Spriel wrote: On 08/27/14 12:02, Michael Tokarev wrote: 27.08.2014 01:37, Arend van Spriel wrote: On 08/26/14 18:15, Michael Tokarev wrote: [] Well, sorry about that. I did see the other messages fly by and noticed you were using the wl driver so assumed you were

Re: [PATCH v2 1/2] bcma: register bcma as device tree driver

2014-09-18 Thread Arend van Spriel
On 09/17/14 17:10, Rafał Miłecki wrote: On 16 September 2014 23:56, Hauke Mehrtensha...@hauke-m.de wrote: This driver is used by the bcm53xx ARM SoC code. Now it is possible to give the address of the chipcommon core in device tree and bcma will search for all the other cores. Did you get

Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-22 Thread Arend van Spriel
in the brcmu_d11n_decchspec function, which is how I discovered the bug. Introduced by: commit b48d891676f756d48b4d0ee131e4a7a5d43ca417 (brcmfmac: rework wiphy structure setup) My bad :-(. You can add: Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Emil Goodeemilgo...@gmail.com --- drivers

Re: WL1271 SDIO timeouts after device reset

2014-09-22 Thread Arend van Spriel
On 09/22/14 17:19, Bruno De Paoli wrote: Hi, We have a custom iMX53 based platform running Android Gingerbread, Linux kernel 2.6.35 with a TiWi-BLE Wlan/Bluetooth device using the SDIO interface for WLAN. This uses a TI WL1271 WLAN device. We are using a Freescale BSP and the Wl12xx NLCP

Re: [PATCH v2] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-23 Thread Arend van Spriel
On 09/23/14 00:49, Emil Goode wrote: In the brcmf_count_20mhz_channels function we are looping through a list of channels received from firmware. Since the index of the first channel is 0 the condition leads to an off by one bug. This is causing us to hit the WARN_ON_ONCE(1) calls in the

Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels()

2014-09-23 Thread Arend van Spriel
query. So 17 channel configs which is expected. Regards, Arend Best regards, Emil On Mon, Sep 22, 2014 at 11:56:43AM +0200, Arend van Spriel wrote: On 09/21/14 00:58, Emil Goode wrote: In the brcmf_count_20mhz_channels function we are looping through a list of channels received from firmware

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-23 Thread Arend van Spriel
On 09/23/14 12:04, Michael Tokarev wrote: 21.09.2014 19:30, Michael Tokarev wrote: Namely, after resume, the card does not work. ARP works, ping and DNS sometimes/somewhat work, inital TCP connection establisment works, but eg http download does not work, it stalls almost immediately. It does

Re: [PATCH for-3.12] brcmfmac: handle IF event for P2P_DEVICE interface

2014-09-23 Thread Arend van Spriel
On 09/23/14 15:22, Greg KH wrote: On Tue, Sep 23, 2014 at 11:52:26AM +0200, Arend van Spriel wrote: upstream: 87c4790330810fe5caf0172d9320cf24ef19cebe That commit id doesn't match anything in Linus's tree :( Hmmm, that is weird: [arend@lb-bun-235 ~/scm/brcm80211-next] $ git remote show

Re: [PATCH for-3.12] brcmfmac: handle IF event for P2P_DEVICE interface

2014-09-23 Thread Arend van Spriel
On 09/23/14 15:51, Greg KH wrote: On Tue, Sep 23, 2014 at 03:42:42PM +0200, Arend van Spriel wrote: On 09/23/14 15:22, Greg KH wrote: On Tue, Sep 23, 2014 at 11:52:26AM +0200, Arend van Spriel wrote: upstream: 87c4790330810fe5caf0172d9320cf24ef19cebe That commit id doesn't match anything

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-24 Thread Arend van Spriel
On 09/23/14 20:10, Michael Tokarev wrote: 23.09.2014 21:35, Arend van Spriel wrote: On 09/23/14 18:02, Michael Tokarev wrote: Oh. Indeed. While I enabled it, I recompiled only drivers/net/wireless, but not net/. Rebuilt, another trace is here -- http://www.corpit.ru/mjt/tmp/brcmsmac

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-26 Thread Arend van Spriel
On 09/26/14 16:26, Michael Tokarev wrote: Okay, so finally, today, without any updates from your side, I opened up the laptop again and inserted a newly bought Intel 6235ANHMW card instead of this creaky brcm4313. This card works right out of the box - plug it in and set up, both wifi and

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-29 Thread Arend van Spriel
On 09/26/14 17:20, Michael Tokarev wrote: I can send it your way, -- guess it will be quite a bit costly, but I don't have any use for it anyway (short of throwing it away), and since I already spent significantly more money due to all this (whole thinkpad plus ssds and several wifi adaptors),

[PATCH 3/6] brcmfmac: Avoid usage of GFP_ATOMIC.

2014-09-30 Thread Arend van Spriel
of flowring. Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Franky (Zhenhui) Lin fran...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Reviewed-by: Daniel (Deognyoun) Kim de...@broadcom.com Signed-off-by: Hante Meuleman meule...@broadcom.com Signed-off-by: Arend

[PATCH 6/6] brcmfmac: Add wowl support for PCIE devices.

2014-09-30 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com Add basic wowl (magic packet and disconnect) support. This patch adds this support only for PCIE bus devices. This feature requires FW which has support for wowl built in. Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Franky (Zhenhui

[PATCH 4/6] brcmfmac: assure P2P discovery is disabled when setting P2P_DEVICE mac address

2014-09-30 Thread Arend van Spriel
) Lin fran...@broadcom.com Reviewed-by: Daniel (Deognyoun) Kim de...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH 5/6] brcmfmac: Fix crash on cleanup.

2014-09-30 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com When driver gets unloaded due to error situation there is a chance a packet gets received while fws has already been cleaned up. This will result in kernel crash. This patch adds a check to avoid this crash. Reviewed-by: Arend Van Spriel ar

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-09-30 Thread Arend van Spriel
On 09/29/14 21:40, Maximilian Engelhardt wrote: On Monday 29 September 2014 15:44:03 Arend van Spriel wrote: On 09/26/14 17:20, Michael Tokarev wrote: I can send it your way, -- guess it will be quite a bit costly, but I don't have any use for it anyway (short of throwing it away), and since I

Re: [PATCH] cfg80211: allow to configure dynamic PS timeout

2014-09-30 Thread Arend van Spriel
On 30-09-14 16:04, Arend van Spriel wrote: On 30-09-14 15:18, Stanislaw Gruszka wrote: Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set it using that tool. Allow to configure PS timeout via nl80211 - add

Re: [PATCH] cfg80211: allow to configure dynamic PS timeout

2014-09-30 Thread Arend van Spriel
On 30-09-14 15:18, Stanislaw Gruszka wrote: Dynamic power save timeout value is suppose to be configurable via wext, but due to iwconfig bug is not possible to set it using that tool. Allow to configure PS timeout via nl80211 - add NL80211_ATTR_PS_TIMEOUT attribute which become timeout

Re: [PATCH] wireless: support configuring vdev mac addr on create.

2014-10-01 Thread Arend van Spriel
On 09/30/14 20:43, gree...@candelatech.com wrote: From: Ben Greeargree...@candelatech.com This is useful when creating virtual-stations, and probably APs and other devices as well. Keeps udev from mucking with things it shouldn't, since the default MAC is never seen by udev when specified on

Re: brcm8021: BCM43341

2014-10-03 Thread Arend van Spriel
On 02-10-14 16:14, Aron Szabo wrote: Hi! I have an ASUS T200TA that has this chip BCM43341 02D0:A94D (http://www.broadcom.com/products/Bluetooth/Bluetooth-RF-Silicon-and-Software-Solutions/BCM43341). This chip is supported by the bcmdhd driver under Android, but not by this driver. I

Re: [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth

2014-10-09 Thread Arend van Spriel
On 10/09/14 12:11, Rafał Miłecki wrote: On 9 October 2014 11:46, Arend van Sprielar...@broadcom.com wrote: On 10/09/14 11:02, Rafał Miłecki wrote: On 9 October 2014 10:37, Rafał Miłeckizaj...@gmail.com wrote: + /* TODO: Fix the condition. Only for boards= P250 */ + if

Re: [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth

2014-10-09 Thread Arend van Spriel
On 10/09/14 12:37, Rafał Miłecki wrote: On 9 October 2014 12:28, Michael Tokarevm...@tls.msk.ru wrote: 09.10.2014 14:22, Arend van Spriel wrote: I know where the function should be called according our driver and guess what: if (bfl BFL_FEM chip == 4313) { Can you fix whitespace

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

2014-10-09 Thread Arend van Spriel
On 10/09/14 18:54, Rafał Miłecki wrote: On 9 October 2014 18:41, Guenter Roeckli...@roeck-us.net wrote: Commit 2101e533f41a (bcma: register bcma as device tree driver) introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is specifically disabled for the sparc

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

2014-10-09 Thread Arend van Spriel
On 10/09/14 19:15, Arend van Spriel wrote: On 10/09/14 18:54, Rafał Miłecki wrote: On 9 October 2014 18:41, Guenter Roeckli...@roeck-us.net wrote: Commit 2101e533f41a (bcma: register bcma as device tree driver) introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

2014-10-10 Thread Arend van Spriel
On 10/09/14 23:48, Hauke Mehrtens wrote: On 10/09/2014 09:25 PM, Guenter Roeck wrote: On Thu, Oct 09, 2014 at 08:28:31PM +0200, Hauke Mehrtens wrote: On 10/09/2014 07:29 PM, Guenter Roeck wrote: On Thu, Oct 09, 2014 at 07:18:31PM +0200, Arend van Spriel wrote: On 10/09/14 19:15, Arend van

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Arend van Spriel
(skip net:...). - Send the patch to the wireless maintainer, ie. John Linville. Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 25 ++-- 1 file

[PATCH 0/3] debugfs: adding helper for single seq_file

2014-10-28 Thread Arend van Spriel
helper/ath9k.o This series is for 3.19 kernel and applies to the driver-core-next branch of the driver-core repository. If needed the ath9k patches may be dropped for now and I will resubmit them to wireless-next once the debugfs patch has made it into linux-next. Arend van Spriel (3): debugfs: add

[PATCH 1/3] debugfs: add helper function to create device related seq_file

2014-10-28 Thread Arend van Spriel
the driver can obtain his data from it and do its task of providing the file content using seq_printf() calls and alike. Using this helper function also gets rid of the need to specify file operations per debugfs file. Signed-off-by: Arend van Spriel ar...@broadcom.com --- fs/debugfs/file.c

[PATCH 3/3] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries

2014-10-28 Thread Arend van Spriel
Use the helper to get rid of the file operations per debugfs file. The struct ath9k_softc pointer is set as device driver data to be obtained in the seq_file read operation. Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/ath/ath9k/ahb.c | 1 + drivers/net

[PATCH 00/16] brcmfmac: wowl support and cleanup

2014-10-28 Thread Arend van Spriel
. Arend van Spriel (3): brcmfmac: show firmware error as string in debug message brcmfmac: remove unused defintion brcmfmac: do not use firmware error code in driver Hante Meuleman (13): brcmfmac: Add wowl support for USB devices. brcmfmac: Add wowl support for SDIO devices. brcmfmac: Add

[PATCH 02/16] brcmfmac: Add wowl support for SDIO devices.

2014-10-28 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com This patch adds wowl support for SDIO bus devices. This feature requires FW which has support for wowl built in. Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Franky (Zhenhui) Lin fran...@broadcom.com Reviewed-by: Pieter-Paul Giesberts

[PATCH 04/16] brcmfmac: show firmware error as string in debug message

2014-10-28 Thread Arend van Spriel
...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/brcm80211/brcmfmac

[PATCH 06/16] brcmfmac: do not use firmware error code in driver

2014-10-28 Thread Arend van Spriel
-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Daniel (Deognyoun) Kim de...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 9 - 1 file changed, 4 insertions

[PATCH 10/16] brcmfmac: (clean) Rename files dhd_dbg to debug

2014-10-28 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Hante Meuleman meule...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac

[PATCH 12/16] brcmfmac: (clean) Rename dhd_common.c in common.c

2014-10-28 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Hante Meuleman meule...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac

[PATCH 15/16] brcmfmac: (clean) Rename sdio related files.

2014-10-28 Thread Arend van Spriel
From: Hante Meuleman meule...@broadcom.com Rename sdio_host.h to sdio.h and dhd_sdio.c to sdio.c. Reviewed-by: Arend Van Spriel ar...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Hante Meuleman meule...@broadcom.com Signed-off-by: Arend van Spriel ar

Re: [PATCH 00/16] brcmfmac: wowl support and cleanup

2014-10-29 Thread Arend van Spriel
On 10/28/14 15:54, Joe Perches wrote: On Tue, 2014-10-28 at 14:56 +0100, Arend van Spriel wrote: This series has a couple of wowl patches that were too late to make the 3.18 merge window. Apart from those there are a number of rename and rework patches that get rid of the terms dhd and wl

[PATCH 2/2] brcmsmac: expose 802.11 core statistics in debugfs

2014-10-29 Thread Arend van Spriel
The 802.11 statistics obtained from the device can be retrieved dumping the 'macstat' file in debugfs folder. Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless

[PATCH 0/2] brcmsmac: fix and expose 802.11 core statistics

2014-10-29 Thread Arend van Spriel
for 3.19 and applies to the master branch of the wireless-next repository. Arend van Spriel (2): brcmsmac: fix statistic counter update function brcmsmac: expose 802.11 core statistics in debugfs drivers/net/wireless/brcm80211/brcmsmac/debug.c | 166 +++- drivers/net

[PATCH 1/2] brcmsmac: fix statistic counter update function

2014-10-29 Thread Arend van Spriel
...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmsmac/main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac

Re: [PATCH 0/3] debugfs: adding helper for single seq_file

2014-10-30 Thread Arend van Spriel
On 10/30/14 20:39, Greg Kroah-Hartman wrote: On Thu, Oct 30, 2014 at 03:19:22PM -0400, John W. Linville wrote: On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote: The first patch was already posted earlier: Message-ID:1413043315-22332-1-git-send-email-ar...@broadcom.com

Re: [PATCH 0/6 3.18] Fixes for iwlwifi drivers

2014-10-30 Thread Arend van Spriel
On 10/30/14 16:27, Larry Finger wrote: On 10/30/2014 06:08 AM, Luca Coelho wrote: The cover-letter subject is wrong. :) I guess you meant s/iwlwifi/rtlwifi/ ;) Yes, the changes were for rtlwifi, not iwlwifi. Sorry. (: My laptop has an Intel 7260 card built in, and it is working correctly on

Re: brcm80211: use endian annotation for pmk related structure

2014-10-31 Thread Arend van Spriel
On 10/31/14 13:51, Dan Carpenter wrote: Hello Arend van Spriel, The patch 40c8e95af02d: brcm80211: use endian annotation for pmk related structure from Oct 12, 2011, leads to the following static checker warning: drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c:2965

Re: brcm80211: use endian annotation for pmk related structure

2014-10-31 Thread Arend van Spriel
On 10/31/14 15:26, Dan Carpenter wrote: On Fri, Oct 31, 2014 at 03:18:27PM +0100, Arend van Spriel wrote: Understood. Not sure what the motivation is to mistrust endian more. Endian data tends to come from suspicious places such as disk images, usb devices, and networks. Simply because

Re: [PATCH 4/5] mwifiex: do not setup AMPDU/AMSDU with broadcast receiver

2014-11-04 Thread Arend van Spriel
On 11/04/14 12:57, Amitkumar Karwar wrote: From: Avinash Patilpat...@marvell.com It is observed that device sometimes sends BA setup requests for broadcast mac address. Its pointless to check for availablity of AMPDU/AMSDU streams for broadcast mac address. This patch adds this check. Maybe

Re: [PATCH] mac80211: Fix regression that triggers a kernel BUG with CCMP

2014-11-06 Thread Arend van Spriel
On 11/06/14 14:55, Ard Biesheuvel wrote: On 6 November 2014 14:50, Ronald Wahlronald.w...@raritan.com wrote: On 06.11.2014 14:14, Johannes Berg wrote: On Thu, 2014-11-06 at 14:07 +0100, Ronald Wahl wrote: But there are LTS kernels not maintained by Greg like 3.12 and 3.16. How about these?

Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

2014-11-08 Thread Arend van Spriel
On 11/07/14 20:37, Luca Coelho wrote: On November 7, 2014 9:15:21 PM EET, Johannes Bergjohan...@sipsolutions.net wrote: On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: +#if 0 + struct ieee80211_vendor_radiotap *rtap; + + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4);

Re: [PATCH 2/3] ath: use seq_file api for ath9k debugfs files

2014-11-08 Thread Arend van Spriel
On 11/07/14 20:05, Greg Kroah-Hartman wrote: On Tue, Oct 28, 2014 at 01:19:11PM +0100, Arend van Spriel wrote: The debugfs files that are defined in debug.c which are read-only and using a simple_open as .open file operation have been modified to use the single_open seq_file API

Re: [PATCH 2/3] ath: use seq_file api for ath9k debugfs files

2014-11-08 Thread Arend van Spriel
On 11/08/14 14:44, Arend van Spriel wrote: On 11/07/14 20:05, Greg Kroah-Hartman wrote: On Tue, Oct 28, 2014 at 01:19:11PM +0100, Arend van Spriel wrote: The debugfs files that are defined in debug.c which are read-only and using a simple_open as .open file operation have been modified to use

[PATCH V2 2/3] ath: use seq_file api for ath9k debugfs files

2014-11-09 Thread Arend van Spriel
The debugfs files that are defined in debug.c which are read-only and using a simple_open as .open file operation have been modified to use the single_open seq_file API. This simplifies the read functions defining the file contents. Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers

Re: [PATCH 11/16] cfg80211: introduce TDLS channel switch commands

2014-11-09 Thread Arend van Spriel
On 11/09/14 17:50, Arik Nemtsov wrote: Introduce commands to initiate and cancel TDLS channel-switching. Once TDLS channel-switching is started, the lower level driver is responsible for continually initiating channel-switch operations and returning to the base (AP) channel to listen for beacons

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

2014-11-11 Thread Arend van Spriel
On 11-11-14 06:56, Gautam (Gautam Kumar) Shukla wrote: Hi Gautam, Good to see more upstream contributions, but it might be useful to have a driver implementation as well in this series. Maybe we can take a shot with brcmfmac for obvious reasons. Would you happen to have wpa_supplicant changes

Re: [PATCH 2/2] linux-wireless:Added wiphy capability flag for offloading 4way handshake to driver

2014-11-11 Thread Arend van Spriel
On 11-11-14 07:27, Gautam (Gautam Kumar) Shukla wrote: For offloading 4 way handshake to driver , currently we don't have WIPHY capability flag to communicate same to supplicant. I have added the flag NL80211_ATTR_4WAY_KEY_HANDSHAKE and rest of the code for the same. Tested on x86

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

2014-11-11 Thread Arend van Spriel
On 11-11-14 10:29, Johannes Berg wrote: On Tue, 2014-11-11 at 05:56 +, Gautam (Gautam Kumar) Shukla wrote: For offloading 4 way handshake to driver, currently we don't have any member of struct cfg80211_connect_params to pass PSK from supplicant to driver. I have added psk for the same

Re: (Intel Wireless 7260) + 5G + AP mode

2014-11-11 Thread Arend van Spriel
On 10-11-14 22:31, Efill wrote: I’m trying to get the 7260 to act as an AP on the 5G band. Unfortunately it seems to be impossible due to the „no IR“ reg domain restriction done by the Intel firmware internally (this is what I’ve googled so far..). Could someone explain to me the technical

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

2014-11-11 Thread Arend van Spriel
On 11-11-14 11:03, Johannes Berg wrote: On Tue, 2014-11-11 at 10:54 +0100, Arend van Spriel wrote: Also, there's a competing approach from QCA that's far more suited. I probably was not paying attention to it, but would you have a reference to this. ... digs around in email ... http

Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

2014-11-11 Thread Arend van Spriel
On 11-11-14 11:38, Johannes Berg wrote: On Tue, 2014-11-11 at 11:35 +0100, Arend van Spriel wrote: What did pop up is the wiphy flags vs. nl80211 feature flags. When that comes up it looks like 'potAtoes, potaetoes' to me. So is there are clear design rule for when to use which flag. For me

Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-11 Thread Arend van Spriel
On 10-11-14 17:08, Mathy Vanhoef wrote: On 11/10/2014 06:18 AM, Arend van Spriel wrote: On 09-11-14 19:10, Mathy Vanhoef wrote: From: Mathy Vanhoef vanho...@gmail.com Unlink the submitted URB in brcmf_usb_dl_cmd if the request timed out. This assures the URB is never submitted twice

Re: brcmfmac not working on ECS LIVA

2014-11-11 Thread Arend van Spriel
On 10-11-14 21:48, Felipe Contreras wrote: Hi, On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel ar...@broadcom.com wrote: The ideas may come to us with a bit more trace information. The logging above is the usual stuff so no problem indication there. I looked at the nvram file from [1

[PATCH for-3.18] brcmfmac: fix conversion of channel width 20MHZ_NOHT

2014-11-11 Thread Arend van Spriel
(Deognyoun) Kim de...@broadcom.com Reviewed-by: Franky (Zhenhui) Lin fran...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 6 ++ 1 file changed, 6 insertions

Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-11 Thread Arend van Spriel
usb_unlink_urb() by usb_kill_urb(). Do you mean you end up with a working usb device providing a wireless interface? Or does probe still fail, but you do not get a crash. Regards, Arend On 11/11/2014 06:05 AM, Arend van Spriel wrote: On 10-11-14 17:08, Mathy Vanhoef wrote: On 11/10/2014 06:18

Re: brcmfmac not working on ECS LIVA

2014-11-11 Thread Arend van Spriel
On 11-11-14 19:32, Felipe Contreras wrote: On Tue, Nov 11, 2014 at 5:08 AM, Arend van Spriel ar...@broadcom.com wrote: On 10-11-14 21:48, Felipe Contreras wrote: /etc/modprobe.d/brcmfmac.conf options brcmfmac debug=0xd416 I see nothing extra in the debug log... Am I doing something wrong

Re: brcmfmac not working on ECS LIVA

2014-11-11 Thread Arend van Spriel
On 11/11/14 19:49, Felipe Contreras wrote: On Tue, Nov 11, 2014 at 12:35 PM, Arend van Sprielar...@broadcom.com wrote: On 11-11-14 19:32, Felipe Contreras wrote: On Tue, Nov 11, 2014 at 5:08 AM, Arend van Sprielar...@broadcom.com wrote: On 10-11-14 21:48, Felipe Contreras wrote:

Re: brcmfmac not working on ECS LIVA

2014-11-12 Thread Arend van Spriel
On 11-11-14 23:32, Felipe Contreras wrote: On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel ar...@broadcom.com wrote: Could you share the nvram obtained from EFI? Also please create a kernel log with debug=0xd416. There you go: http://people.freedesktop.org/~felipec/dmesg-brcm.txt

Re: brcmfmac not working on ECS LIVA

2014-11-13 Thread Arend van Spriel
On 12-11-14 16:23, Felipe Contreras wrote: On Wed, Nov 12, 2014 at 4:40 AM, Arend van Spriel ar...@broadcom.com wrote: On 11-11-14 23:32, Felipe Contreras wrote: On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel ar...@broadcom.com wrote: Could you share the nvram obtained from EFI? Also please

Re: [PATCH] brcmfmac: kill URB when request timed out

2014-11-14 Thread Arend van Spriel
On 13-11-14 03:33, Mathy Vanhoef wrote: Kill the submitted URB in brcmf_usb_dl_cmd if the request timed out. This assures the URB is never submitted twice. It also prevents a possible use-after-free of the URB transfer buffer if a timeout occurs. Acked-by: Arend van Spriel ar...@broadcom.com

Re: brcmfmac not working on ECS LIVA

2014-11-14 Thread Arend van Spriel
On 11/14/14 18:03, Felipe Contreras wrote: On Thu, Nov 13, 2014 at 4:47 AM, Arend van Sprielar...@broadcom.com wrote: On 12-11-14 16:23, Felipe Contreras wrote: On Wed, Nov 12, 2014 at 4:40 AM, Arend van Sprielar...@broadcom.com wrote: I tried this patch, and although it seems to make a

Re: [PATCH] brcmfmac: fix error handling of irq_of_parse_and_map

2014-11-16 Thread Arend van Spriel
...@vger.kernel.org # v3.17 +Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Dmitry Torokhovd...@chromium.org --- Not tested, found by casual code inspection. drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-11-19 Thread Arend van Spriel
On 11/17/14 23:36, Maximilian Engelhardt wrote: On Thursday 09 October 2014 10:21:12 Rafał Miłecki wrote: On 9 October 2014 09:52, Arend van Sprielar...@broadcom.com wrote: I have been staring at differences brcmsmac and our internal driver (which wl is derived from as well). Would you be

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-11-19 Thread Arend van Spriel
On 11/19/14 14:46, Arend van Spriel wrote: On 11/17/14 23:36, Maximilian Engelhardt wrote: On Thursday 09 October 2014 10:21:12 Rafał Miłecki wrote: On 9 October 2014 09:52, Arend van Sprielar...@broadcom.com wrote: I have been staring at differences brcmsmac and our internal driver (which wl

Re: [PATCH] brcmfmac: don't include linux/unaligned/access_ok.h

2014-11-19 Thread Arend van Spriel
be good to mention this was found by kbuild test robot. Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Johannes Bergjohannes.b...@intel.com --- drivers/net/wireless/brcm80211/brcmfmac/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless

Re: [PATCH] brcmfmac: don't include linux/unaligned/access_ok.h

2014-11-19 Thread Arend van Spriel
On 11/19/14 21:42, Johannes Berg wrote: On Wed, 2014-11-19 at 21:36 +0100, Arend van Spriel wrote: On 11/19/14 21:18, Johannes Berg wrote: From: Johannes Bergjohannes.b...@intel.com This is a specific implementation,asm/unaligned.h is the multiplexer that has the arch-specific knowledge

Re: [PATCH] brcmfmac: don't include linux/unaligned/access_ok.h

2014-11-19 Thread Arend van Spriel
On 11/19/14 21:48, Johannes Berg wrote: On Wed, 2014-11-19 at 21:47 +0100, Arend van Spriel wrote: On 11/19/14 21:42, Johannes Berg wrote: On Wed, 2014-11-19 at 21:36 +0100, Arend van Spriel wrote: On 11/19/14 21:18, Johannes Berg wrote: From: Johannes Bergjohannes.b...@intel.com

[PATCH for-3.18] brcmfmac: don't include linux/unaligned/access_ok.h

2014-11-19 Thread Arend van Spriel
in linux/ieee80211.h resulting in redefinition of get_unaligned_be16 (and probably others). Cc: sta...@vger.kernel.org # v3.17 Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net

Re: Broadcom Corporation BCM43228 802.11a/b/g/n

2014-11-20 Thread Arend van Spriel
On 11/20/14 13:43, Ruben De Smet wrote: Hello b43 and linux-wireless I'm not subscribed (anymore) to these lists, so please use the reply all feature of your mailclient. Thank you :) This will be the last day I'm using my Broadcom Corporation BCM43228 802.11a/b/g/n miniPCI WiFi card, as I'm

[PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-20 Thread Arend van Spriel
The hardware info now also include radio and phy information, which can be helpful in debugging issues. Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211

[PATCH 2/4] brcmutil: add helper function to format board revision

2014-11-20 Thread Arend van Spriel
The board revision that is available in hardware can be translated so it matches the labelling on the board. This is accomplished by this helper function. Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar

[PATCH 0/4] brcm80211: minor rework

2014-11-20 Thread Arend van Spriel
. The series is intended for 3.19 and applies to the master branch of the wireless-next repository. Arend van Spriel (4): brcmfmac: fix static checker warning in pmklist handling brcmutil: add helper function to format board revision brcmsmac: extend hardware info shown in debugfs brcmfmac: correct

Re: [PATCH V2 0/3] debugfs: adding helper for single seq_file

2014-11-21 Thread Arend van Spriel
On 11/09/14 11:31, Arend van Spriel wrote: This series replaces the initial series posted: Message-ID:1414498752-9746-1-git-send-email-ar...@broadcom.com This series include changes in driver code to investigate potential code savings. As example used the ath9k driver as it has a fair amount

Re: BCM4313 brcmsmac 3.12: only semi-working?

2014-11-23 Thread Arend van Spriel
On 19-11-14 22:00, Michael Tokarev wrote: 19.11.2014 22:58, Michael Tokarev wrote: 19.11.2014 20:54, Arend van Spriel wrote: [] I submitted two patches upstream and additionally I have attached two other that are still under review. Could you try these patches and sent me the content

Re: [PATCH 2/4] brcmutil: add helper function to format board revision

2014-11-25 Thread Arend van Spriel
On 11/24/14 22:53, John W. Linville wrote: I am holding patches 2-4 until we resolve the brcmu_boardrev_str build thing... Actually, only patch 2 and 3 are related to the build thing. If that is what this is. Regards, Arend On Thu, Nov 20, 2014 at 10:27:00PM +0100, Arend van Spriel wrote

Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
(patch 2/4) and I did an EXPORT_SYMBOL and added it to the include file. Missing something? Also I don't see this issue over here. I will do a clean build on the wireless-next tree and see if I can reproduce this. Regards, Arend On Thu, Nov 20, 2014 at 10:27:01PM +0100, Arend van Spriel wrote

Re: [PATCH] mac80211: check if channels allow 80 MHz for VHT probe requests

2014-11-25 Thread Arend van Spriel
On 11/25/14 15:18, Johannes Berg wrote: On Tue, 2014-11-25 at 22:13 +0800, YanBo wrote: But is all of that really the right way? I'm not completely convinced. Except set the flag, the HW itself should support this feature, or else it also doesn't work, I'd send the patch in soon for public

Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
On 11/25/14 20:05, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: On 11/24/14 22:50, John W. Linville wrote: Hmmm...I'm not sure why, but this is causing problems for me... ERROR

Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
On 11/25/14 20:16, Arend van Spriel wrote: On 11/25/14 20:05, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: On 11/24/14 22:50, John W. Linville wrote: Hmmm...I'm not sure why

Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
On 11/25/14 20:23, Arend van Spriel wrote: On 11/25/14 20:16, Arend van Spriel wrote: On 11/25/14 20:05, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: On 11/24/14 22:50, John W

Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
On 11/25/14 20:20, John W. Linville wrote: On Tue, Nov 25, 2014 at 08:16:17PM +0100, Arend van Spriel wrote: On 11/25/14 20:05, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: On 11/24

[PATCH V2 2/2] brcmsmac: extend hardware info shown in debugfs

2014-11-25 Thread Arend van Spriel
The hardware info now also include radio and phy information, which can be helpful in debugging issues. Reviewed-by: Hante Meuleman meule...@broadcom.com Reviewed-by: Pieter-Paul Giesberts piete...@broadcom.com Signed-off-by: Arend van Spriel ar...@broadcom.com --- drivers/net/wireless/brcm80211

Re: [PATCH iw 2/2] add WoWLAN net-detect trigger

2014-11-27 Thread Arend van Spriel
On 11/27/14 22:06, Luca Coelho wrote: From: Luciano Coelholuciano.coe...@intel.com Adds a netdetect option to the wowlan triggers that allows the user to request network detection to be started when the device goes to suspend mode. So it can start heating up my backpack when I get home. Nice

Multiple-BSSID issues with hostapd

2014-11-28 Thread Arend van Spriel
Hi Jouni, For the brcmfmac we started working on Multiple-BSSID support and came across some issues with hostapd that are listed listed below. BSS1 setup on netdev wlan0 BSS2 setup on netdev wlan0_0 * get_station() done on wrong netdev observed: Upon association of STA1 with BSS2 (wlan0_0) a

  1   2   3   4   5   6   7   8   9   10   >