Re: [PATCH 2/2] mac80211: improve minstrel_ht rate sorting by throughput probability

2014-09-08 Thread Felix Fietkau
On 2014-08-22 16:05, Thomas Huehn wrote: This patch improves the way minstrel_ht sorts rates according to throughput and success probability. 3 FOR-loops across the entire rate and mcs group set in function minstrel_ht_update_stats() which where used to determine the fastest, second fastest

Re: [PATCH v2 0/2] Unify improve Minstrel Minstrel_HT rate control

2014-09-09 Thread Felix Fietkau
On 2014-09-09 23:22, Thomas Huehn wrote: This patch series consolidates rate statistic variables between Minstrel and Minstrel_HT. It improves the sorting function to find the max throughput rate set in Minstrel_HT. For this series: Acked-by: Felix Fietkau n...@openwrt.org -- To unsubscribe

[PATCH 2/2] ath9k_hw: disable hardware ad-hoc flag on ar934x rev 3

2014-09-27 Thread Felix Fietkau
. AR934x rev 2 and older are not affected by this bug Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 9 ++--- drivers/net/wireless/ath/ath9k/reg.h | 4 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k

[PATCH 1/2] ath9k: use ah-get_mac_revision for all SoC devices if available

2014-09-27 Thread Felix Fietkau
It is needed for AR934x as well Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 3aed729..cf0128e

[PATCH 2/3] ath9k_hw: reduce ANI spur immunity setting on HT40 extension channel

2014-09-29 Thread Felix Fietkau
and throughput in some environments. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c

[PATCH 3/3] ath9k_hw: fix PLL clock initialization for newer SoC

2014-09-29 Thread Felix Fietkau
to be set during PLL clock initialization. This patch also removes more instances of hardcoded register values in favor of properly computed ones with the PLL_BYPASS bit added. Reported-by: Lorenzo Bianconi lorenzo.biancon...@gmail.com Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net

[PATCH 1/3] Revert ath9k_hw: reduce ANI firstep range for older chips

2014-09-29 Thread Felix Fietkau
This reverts commit 09efc56345be4146ab9fc87a55c837ed5d6ea1ab I've received reports that this change is decreasing throughput in some rare conditions on an AR9280 based device Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar5008_phy.c

Re: [PATCH] mac80211: minstrel_ht: add basic support for VHT rates = 80MHz@NSS2

2014-09-29 Thread Felix Fietkau
On 2014-09-29 15:58, Karl Beldan wrote: You mean having a common hardcoded value for both ? Yes. And at the same time also getting rid of #if tests for it. After 4441e8e9 the minstrel rate indexes have to be u8-s and having this common param 2 would require something like: {{{ diff --git

[PATCH v2] ath9k: fix getting tx duration for dynack

2014-09-30 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9002_mac.c | 26 +++--- drivers/net/wireless/ath/ath9k/ar9003_mac.c | 28 +++- drivers/net/wireless/ath/ath9k/dynack.c | 2 +- drivers/net/wireless/ath/ath9k/hw-ops.h

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

2014-10-18 Thread Felix Fietkau
...@rivierawaves.com Cc: Felix Fietkau n...@openwrt.org Acked-by: Felix Fietkau n...@openwrt.org -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH v2 4/4] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

2014-10-18 Thread Felix Fietkau
/LGI MCS5/20.0 0.0 0.0 00( 0) 0(0) Signed-off-by: Karl Beldan karl.bel...@rivierawaves.com Cc: Felix Fietkau n...@openwrt.org Aside from the module parameter issue that you already pointed out, the series looks good to me. - Felix -- To unsubscribe from

[PATCH 10/10] ath9k: use a random MAC address if the EEPROM address is invalid

2014-10-18 Thread Felix Fietkau
Based on OpenWrt patch by Gabor Juhos Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 47f410e

[PATCH 08/10] ath9k: add support for endian swap of eeprom from platform data

2014-10-18 Thread Felix Fietkau
On some devices (especially little-endian ones), the flash EEPROM data has a different endian, which needs to be detected. Add a flag to the platform data to allow overriding that behavior Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/eeprom_def.c | 31

[PATCH 03/10] ath9k: fix processing RXORN interrupts

2014-10-18 Thread Felix Fietkau
allow them to fire again. Even if RXORN was triggering a reset, it is not critical enough to need the bypass here. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH 09/10] ath9k: allow disabling bands via platform data

2014-10-18 Thread Felix Fietkau
Some devices have multiple bands enables in the EEPROM data, even though they are only calibrated for one. Allow platform data to disable unsupported bands. Signed-off-by: Gabor Juhos juh...@openwrt.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 24

[PATCH 06/10] ath9k_hw: do not run NF and periodic calibration at the same time

2014-10-18 Thread Felix Fietkau
It can cause inconsistent calibration results or in some cases turn the radio deaf. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9002_calib.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/ath

Re: [PATCH v3 0/4] add VHT support to minstrel_ht

2014-10-18 Thread Felix Fietkau
VHT_GROUPs) - use common MINSTREL_MAX_STREAMS both for VHT and HT so that we can get rid of the 'MINSTREL_MAX_STREAMS = 3' checks for minstrel_mcs_groups v3: - put module param *vht_only* under CONFIG_MAC80211_RC_MINSTREL_VHT Acked-by: Felix Fietkau n...@openwrt.org -- To unsubscribe from this list

Re: [PATCH 01/10] ath9k_hw: make support for PC-OEM cards optional

2014-10-20 Thread Felix Fietkau
On 2014-10-20 09:57, Sujith Manoharan wrote: Felix Fietkau wrote: diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h index 975074f..7a81f5b 100644 --- a/drivers/net/wireless/ath/ath9k/hw.h +++ b/drivers/net/wireless/ath/ath9k/hw.h @@ -244,13 +244,20

Re: [PATCH 02/10] ath9k_hw: remove support for UB124 tx gain table

2014-10-20 Thread Felix Fietkau
On 2014-10-20 09:58, Sujith Manoharan wrote: Felix Fietkau wrote: -else if (AR_SREV_9340(ah)) -INIT_INI_ARRAY(ah-iniModesTxGain, -ar9340Modes_ub124_tx_gain_table_1p0); Shouldn't the array in ar9340_initvals.h also be removed ? We can do that later (when

Re: [PATCH 03/10] ath9k: fix processing RXORN interrupts

2014-10-20 Thread Felix Fietkau
On 2014-10-20 10:15, Sujith Manoharan wrote: Felix Fietkau wrote: The goto chip_reset is a bit misleading, because it does not actually issue a chip reset. Instead it is bypassing processing of other interrupts and assumes that the tasklet will issue a chip reset. Well, we kill interrupts

Re: iwlwifi: Reason 7 periodic disconnect

2014-10-21 Thread Felix Fietkau
On 2014-10-21 07:02, Emmanuel Grumbach wrote: On Mon, Oct 20, 2014 at 10:29 PM, Laurențiu Nicola lnic...@dend.ro wrote: No, nothing in the DD-WRT syslog. The IP seems to be the one cached by my DHCP client. I also tried various suggestions found on the internet, but nothing helped. Can you

Re: iwlwifi: Reason 7 periodic disconnect

2014-10-21 Thread Felix Fietkau
On 2014-10-21 10:23, Laurențiu Nicola wrote: It's an ASUS RT-N66U running NEWD-2/K3X from r24160. This is a Broadcom based device, so it should behave in the same way as other APs/Routers running the Broadcom drivers. The driver should only send Reason 7 when receiving a PS-Poll, BlockAck,

[PATCH] ath: use CTL region from cfg80211 if unset in EEPROM

2014-10-22 Thread Felix Fietkau
being set too high on the band edges, even if the cfg80211 regdomain is set correctly. Fix this issue by taking into account the DFS region, but only when the EEPROM regdomain is set to default. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath.h | 1 + drivers/net

[PATCH] mac80211: add support for driver tx power reporting

2014-10-22 Thread Felix Fietkau
The configured tx power is often limited by hardware capabilities, channel settings, antenna configuration, etc. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 5 + net/mac80211/cfg.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/mac80211

[PATCH] ath9k_common: always update value in ath9k_cmn_update_txpow

2014-10-22 Thread Felix Fietkau
In some cases the limit may be the same as reg-power_limit, but the actual value that the hardware uses is not up to date. In that case, a wrong value for current tx power is tracked internally. Fix this by unconditionally updating it. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers

[PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

2014-10-22 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath10k/mac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 4670930..bc440dc 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c

Re: [PATCH] ath10k: add SURVEY_INFO_IN_USE for current channel on survey

2014-10-23 Thread Felix Fietkau
On 2014-10-23 09:13, Kalle Valo wrote: Felix Fietkau n...@openwrt.org writes: Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath10k/mac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath

[PATCH v2 10/10] ath9k: use a random MAC address if the EEPROM address is invalid

2014-10-25 Thread Felix Fietkau
Based on OpenWrt patch by Gabor Juhos Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 47f410e

[PATCH v2 04/10] ath9k: clean up debugfs print of reset causes

2014-10-25 Thread Felix Fietkau
Reduce code duplication Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/debug.c | 48 +++--- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k

[PATCH v2 05/10] ath9k: restart hardware after noise floor calibration failure

2014-10-25 Thread Felix Fietkau
When NF calibration fails, the radio often becomes deaf. The usual hardware hang checks do not detect this, so it's better to issue a reset when that happens. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9002_calib.c | 11 ++- drivers/net/wireless

[PATCH v2 06/10] ath9k_hw: do not run NF and periodic calibration at the same time

2014-10-25 Thread Felix Fietkau
It can cause inconsistent calibration results or in some cases turn the radio deaf. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9002_calib.c | 29 +-- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/net

[PATCH v2 07/10] ath9k_hw: start initial NF calibration after PA calibration on AR9003

2014-10-25 Thread Felix Fietkau
This makes the initial NF calibration less likely to fail. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9002_calib.c | 2 ++ drivers/net/wireless/ath/ath9k/hw.c | 6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH v2 02/10] ath9k_hw: remove support for UB124 tx gain table

2014-10-25 Thread Felix Fietkau
UB124 is a USB based reference design not supported by ath9k or ath9k_htc. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/ar9003_hw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9003_hw.c b/drivers/net/wireless/ath

[PATCH v2 09/10] ath9k: allow disabling bands via platform data

2014-10-25 Thread Felix Fietkau
Some devices have multiple bands enables in the EEPROM data, even though they are only calibrated for one. Allow platform data to disable unsupported bands. Signed-off-by: Gabor Juhos juh...@openwrt.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 24

[PATCH v2 08/10] ath9k: add support for endian swap of eeprom from platform data

2014-10-25 Thread Felix Fietkau
On some devices (especially little-endian ones), the flash EEPROM data has a different endian, which needs to be detected. Add a flag to the platform data to allow overriding that behavior Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/eeprom_def.c | 31

Re: [PATCH] mac80211: add support for driver tx power reporting

2014-10-25 Thread Felix Fietkau
On 2014-10-24 16:33, Johannes Berg wrote: On Wed, 2014-10-22 at 17:57 +0200, Felix Fietkau wrote: The configured tx power is often limited by hardware capabilities, channel settings, antenna configuration, etc. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 5

[PATCH v2] mac80211: add support for driver tx power reporting

2014-10-25 Thread Felix Fietkau
The configured tx power is often limited by hardware capabilities, channel settings, antenna configuration, etc. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h| 5 + net/mac80211/cfg.c| 3 +++ net/mac80211/driver-ops.h | 14 ++ net/mac80211

[PATCH 3.18] mac80211: flush keys for AP mode on ieee80211_do_stop

2014-10-27 Thread Felix Fietkau
Userspace can add keys to an AP mode interface before start_ap has been called. If there have been no calls to start_ap/stop_ap in the mean time, the keys will still be around when the interface is brought down. Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/iface.c | 3 --- 1

Re: [PATCH v2 01/10] ath9k_hw: make support for PC-OEM cards optional

2014-10-27 Thread Felix Fietkau
On 2014-10-27 12:40, Sujith Manoharan wrote: Hi, This series looks good to me... Thanks for the review - Felix -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [ath9k-devel] strange MPDU loss pattern

2014-10-27 Thread Felix Fietkau
Hi Seongho, that paper looks quite interesting. Are you planning to publish code/patches for your implementation as well? It would be nice to have dynamic A-MPDU limiting integrated in minstrel_ht. Thanks, - Felix On 26/10/2014 12:14 AM, Seongho Byeon wrote: Hi, I am Ph.d. student in Seoul

Re: MediaTek WiFi hardware support in upstream kernel

2014-10-29 Thread Felix Fietkau
Hi Hackers, Just a quick heads up: I'm working on a new driver for MT7662E/MT7612E, written from scratch. It is already able to bring up the firmware, init the MAC and do basic TX/RX DMA communication with the firmware. I've decided to not integrate it with rt2x00, because I want to avoid dealing

Re: [PATCH 4/6] ath9k: Fix high tx power in multi-chain mode

2014-11-11 Thread Felix Fietkau
On 2014-11-11 08:07, Sujith Manoharan wrote: From: Miaoqing Pan miaoq...@qca.qualcomm.com For multi-chain chips, if the thermometer is switched off for a chain which can be disabled by software(e.g tx_chainmask=0x1), the measured tx power is about 5dB higher than target power. Set

Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers

2014-11-12 Thread Felix Fietkau
On 2014-11-11 08:07, Sujith Manoharan wrote: From: Miaoqing Pan miaoq...@qca.qualcomm.com For AR9340, the correct values for SLP32 registers are present in the initvals, so overriding them is not needed. Signed-off-by: Miaoqing Pan miaoq...@qca.qualcomm.com Signed-off-by: Sujith Manoharan

Re: MediaTek WiFi hardware support in upstream kernel

2014-11-12 Thread Felix Fietkau
On 2014-11-11 12:55, Oleksij Rempel wrote: Am 29.10.2014 um 11:17 schrieb Felix Fietkau: Hi Hackers, Just a quick heads up: I'm working on a new driver for MT7662E/MT7612E, written from scratch. It is already able to bring up the firmware, init the MAC and do basic TX/RX DMA communication

[PATCH 3.18 1/3] ath9k: prevent early IRQs from accessing hardware

2014-11-13 Thread Felix Fietkau
IRQs are suppressed if ah == NULL and ATH_OP_INVALID being set in common-op_flags. Close a short time window between those two. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH 3.18 3/3] ath9k: do not access hardware on IRQs during reset

2014-11-13 Thread Felix Fietkau
Instead of killing interrupts during reset when the first one happens, kill them before issuing the reset. This fixes an easy to reproduce crash with multiple cards sharing the same IRQ. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k

[PATCH 3.18 2/3] ath9k: set ATH_OP_INVALID before disabling hardware

2014-11-13 Thread Felix Fietkau
Closes another small IRQ handler race Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 644552c

[PATCH] mac80211: skip legacy rate mask handling for VHT rates

2014-11-14 Thread Felix Fietkau
The rate mask code currently assumes that a rate is legacy if IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT rates being reported with minstrel_ht. Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 3.18 3/3] ath9k: do not access hardware on IRQs during reset

2014-11-15 Thread Felix Fietkau
On 2014-11-13 18:34, Felix Fietkau wrote: Instead of killing interrupts during reset when the first one happens, kill them before issuing the reset. This fixes an easy to reproduce crash with multiple cards sharing the same IRQ. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n

[PATCH 3/6] mac80211: add tx_status_noskb to rate_control_ops

2014-11-15 Thread Felix Fietkau
This op works like .tx_status, except it does not need access to the skb. This will be used by drivers that cannot match tx status information to specific packets. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 4 net/mac80211/rate.h| 6 +- 2 files

[PATCH 2/6] mac80211: minstrel_ht: move aggregation check to .get_rate()

2014-11-15 Thread Felix Fietkau
Preparation for adding a no-skb tx status path Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c index 62ff7cf

[PATCH 1/6] mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check

2014-11-15 Thread Felix Fietkau
Check the queue mapping earlier, skb-queue_mapping is more likely than skb-data to still be in d-cache. Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/mac80211

[PATCH 5/6] mac80211: minstrel_ht: switch to .tx_status_noskb

2014-11-15 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c index 32b969f..3775b06 100644 --- a/net/mac80211

[PATCH 6/6] mac80211: add ieee80211_tx_status_noskb

2014-11-15 Thread Felix Fietkau
This can be used by drivers that cannot reliably map tx status information onto specific skbs. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 22 ++ net/mac80211/rate.h| 17 net/mac80211/status.c | 116

[PATCH 3.18] mac80211: minstrel_ht: fix a crash in rate sorting

2014-11-18 Thread Felix Fietkau
index from tp_list[-1], which contains uninitialized stack garbage, and then uses the resulting index for accessing the group rate stats, leading to a crash if the garbage value is big enough. Cc: Thomas Huehn tho...@net.t-labs.tu-berlin.de Reported-by: Jouni Malinen j...@w1.fi Signed-off-by: Felix

Re: [PATCH 6/6] mac80211: add ieee80211_tx_status_noskb

2014-11-19 Thread Felix Fietkau
On 2014-11-19 19:38, Johannes Berg wrote: /** + * ieee80211_tx_status_noskb - transmit status callback without skb + * + * This function can be used as a replacement for ieee80211_tx_status + * in drivers that cannot reliably map tx status information back to + * specific skbs. + * + *

[PATCH v2 5/7] mac80211: pass tx info to ieee80211_lost_packet instead of an skb

2014-11-19 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/status.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 9612d89..ba35a44 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -541,10 +541,9

[PATCH v2 3/7] mac80211: minstrel: switch to .tx_status_noskb

2014-11-19 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/mac80211/rc80211_minstrel.c b/net/mac80211/rc80211_minstrel.c index c2b91bf..d51f6b1 100644 --- a/net/mac80211/rc80211_minstrel.c +++ b

[PATCH v2 2/7] mac80211: add tx_status_noskb to rate_control_ops

2014-11-19 Thread Felix Fietkau
This op works like .tx_status, except it does not need access to the skb. This will be used by drivers that cannot match tx status information to specific packets. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 4 net/mac80211/rate.h| 6 +- 2 files

[PATCH v2 1/7] mac80211: minstrel_ht: move aggregation check to .get_rate()

2014-11-19 Thread Felix Fietkau
Preparation for adding a no-skb tx status path Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c index 62ff7cf

[PATCH v2 4/7] mac80211: minstrel_ht: switch to .tx_status_noskb

2014-11-19 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c index 2641dc8..b52996a 100644 --- a/net/mac80211

[PATCH v2 7/7] mac80211: add ieee80211_tx_status_noskb

2014-11-19 Thread Felix Fietkau
This can be used by drivers that cannot reliably map tx status information onto specific skbs. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 20 +++ net/mac80211/rate.h| 18 + net/mac80211/status.c | 54

Re: [RFC 2/3] ath9k: add TX power per-rate per-chain tables

2014-11-20 Thread Felix Fietkau
On 2014-11-20 14:31, Lorenzo Bianconi wrote: Add TX power per-rate per-chain tables for different MIMO modes (e.g STBC) in order to cap the maximum TX power value per-rate in the TX descriptor path. Cap TX power for self generated frames (ACK, RTS/CTS). Currently TPC is supported just by

[PATCH 3.18] mac80211: copy chandef from AP vif to VLANs

2014-11-24 Thread Felix Fietkau
Fixes a crash in nl80211_send_chandef, introduced in commit c12bc4885f4b3bab0ed779c69d5d7e3223fa5003 mac80211: return the vif's chandef in ieee80211_cfg_get_channel() Signed-off-by: Felix Fietkau n...@openwrt.org --- net/mac80211/chan.c | 23 +++ net/mac80211/iface.c | 1

[PATCH 2/2] ath9k: fix BE/BK queue order

2014-11-30 Thread Felix Fietkau
Hardware queues are ordered by priority. Use queue index 0 for BK, which has lower priority than BE. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 1/2] ath9k_hw: fix hardware queue allocation

2014-11-30 Thread Felix Fietkau
-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/mac.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/mac.c b/drivers/net/wireless/ath/ath9k/mac.c index 275205a..3e58bfa 100644 --- a/drivers/net/wireless/ath/ath9k/mac.c

[PATCH] ath5k: fix hardware queue index assignment

2014-11-30 Thread Felix Fietkau
Like with ath9k, ath5k queues also need to be ordered by priority. queue_info-tqi_subtype already contains the correct index, so use it instead of relying on the order of ath5k_hw_setup_tx_queue calls. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net

[PATCH v2 1/3] ath9k: prevent early IRQs from accessing hardware

2014-11-30 Thread Felix Fietkau
IRQs are suppressed if ah == NULL and ATH_OP_INVALID being set in common-op_flags. Close a short time window between those two. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v2 3/3] ath9k: do not access hardware on IRQs during reset

2014-11-30 Thread Felix Fietkau
Instead of killing interrupts during reset when the first one happens, kill them before issuing the reset. This fixes an easy to reproduce crash with multiple cards sharing the same IRQ. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/main.c | 14

[PATCH v2 2/3] ath9k: set ATH_OP_INVALID before disabling hardware

2014-11-30 Thread Felix Fietkau
Closes another small IRQ handler race Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index ebbbfc7

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-12 Thread Felix Fietkau
On 2014-12-12 14:21, Johannes Berg wrote: On Wed, 2014-11-19 at 00:14 +0100, Felix Fietkau wrote: +struct txq_info *txq; +atomic_t txq_len[IEEE80211_NUM_ACS]; I think you should consider renaming the latter to txqs_len or so - it doesn't just cover one txq as is be implied

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-12 Thread Felix Fietkau
On 2014-12-12 15:01, Johannes Berg wrote: On Fri, 2014-12-12 at 14:40 +0100, Felix Fietkau wrote: Then again what even sets vif-txq? Shouldn't those be per-AC? Do you really want to mix 'normal' and txq-TX? Are we even using multiple ACs for packets that don't belong to a particular sta

Re: [PATCH] ath: fix incorrect PPB on FCC radar type 5

2014-12-15 Thread Felix Fietkau
On 2014-12-15 19:55, Peter Oh wrote: The minimum number of pulses per burst on FCC radar type 5 is 1. Use this number for correct radar detection. Signed-off-by: Peter Oh p...@qca.qualcomm.com --- drivers/net/wireless/ath/dfs_pattern_detector.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] mac80211: add an intermediate software queue implementation

2014-12-16 Thread Felix Fietkau
On 2014-12-16 00:25, Bartosz Szczepanek wrote: As for drv_wake_tx_queue and ieee80211_tx_dequeue - is it really necessary? There are ieee80211_tx_status and ieee80211_free_txskb already, which can be used to decide from mac80211 level when to dequeue packet. It could be used even in case of

[PATCH 3.19] mac80211: minstrel: reduce size of struct minstrel_rate_stats

2014-12-17 Thread Felix Fietkau
On minstrel_ht, the size of the per-sta struct is almost 18k, making it an order-3 allocation. A few fields inside the per-rate statistics are bigger than they need to be. This patch reduces the size enough to cut down the per-sta struct to about 13k (order-2 allocation). Signed-off-by: Felix

[PATCH v2 3.19] mac80211: minstrel: reduce size of struct minstrel_rate_stats

2014-12-17 Thread Felix Fietkau
On minstrel_ht, the size of the per-sta struct is almost 18k, making it an order-3 allocation. A few fields inside the per-rate statistics are bigger than they need to be. This patch reduces the size enough to cut down the per-sta struct to about 13k (order-2 allocation). Signed-off-by: Felix

Re: [PATCH 3.19] ath9k: fix race condition in irq processing during hardware reset

2015-01-15 Thread Felix Fietkau
On 2015-01-15 10:09, Sujith Manoharan wrote: Felix Fietkau wrote: To fix invalid hardware accesses, the commit ath9k: do not access hardware on IRQs during reset made the irq handler ignore interrupts emitted after queueing a hardware reset (which disables the IRQ). This left a small time

Re: [PATCHv2] ath9k_htc: add adaptive usb receive flow control to repair soft lockup with monitor mode

2015-02-19 Thread Felix Fietkau
On 2015-02-10 11:34, Yuwei Zheng wrote: The ath9k_hif_usb_rx_cb function excute on the interrupt context, and ath9k_rx_tasklet excute on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf

[PATCH 3.19] ath9k: fix race condition in irq processing during hardware reset

2015-01-14 Thread Felix Fietkau
storms. Instead of returning IRQ_NONE when ATH_OP_HW_RESET is set, disable the IRQ entirely for the duration of the reset. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH 4.0] ath9k: disable TPC support again (for now)

2015-03-15 Thread Felix Fietkau
TPC support has been observed to cause some tx power fluctuations on some devices with at least AR934x and AR938x chips. Disable it for now until the bugs have been found and fixed Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/hw.c | 2 +- 1 file changed, 1

Re: [PATCH v2 08/10] mac80211: add max. lossless throughput per rate to rc_stats

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds the new statistic maximum possible lossless throughput to Minstrels and Minstrel-HTs rc_stats (in debugfs). This enables comprehensive comparison between current per-rate throughput and max. achievable per-rate throughput.

Re: [PATCH v2 04/10] mac80211: add new Minstrel-HT statistic output via csv

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds a new debugfs file rc_stats_csv to output Minstrel-HTs statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com --- ---

Re: [PATCH v2 03/10] mac80211: add new Minstrel statistic output via csv

2015-03-17 Thread Felix Fietkau
On 2015-02-13 15:57, Thomas Huehn wrote: This patch adds a new debugfs file rc_stats_csv to output Minstrels statistics in a common csv format that is easy to parse. Signed-off-by: Thomas Huehn tho...@net.t-labs.tu-berlin.de Signed-off-by: Stefan Venz ikstrea...@gmail.com ---

[PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
latency. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 77 ++ net/mac80211/driver-ops.h | 17 ++ net/mac80211/ieee80211_i.h | 14 net/mac80211/iface.c | 26 +++ net/mac80211/main.c

Re: [PATCH v3] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
On 2015-03-17 12:24, Johannes Berg wrote: On Tue, 2015-03-17 at 11:21 +0100, Felix Fietkau wrote: @@ -1257,6 +1284,8 @@ struct ieee80211_vif { u8 cab_queue; u8 hw_queue[IEEE80211_NUM_ACS]; +struct ieee80211_txq *txq; This is just one txq, the mcast one? Perhaps that should

Re: [PATCH 16/18] ath9k: use REG_RMW and rmw buffer in ath9k_hw_4k_set_gain

2015-03-20 Thread Felix Fietkau
On 2015-03-20 13:38, Oleksij Rempel wrote: it is possible to reduce time needed for this function by rplacing REG_WRITE with REG_RMW (plus dummy 0) and putt all commands in same buffer. Signed-off-by: Oleksij Rempel li...@rempel-privat.de --- drivers/net/wireless/ath/ath9k/eeprom_4k.c |

Re: [PATCH 18/18] ath9k: use REG_RMW and rmw buffer in ath9k_hw_def_set_gain

2015-03-20 Thread Felix Fietkau
On 2015-03-20 13:38, Oleksij Rempel wrote: Signed-off-by: Oleksij Rempel li...@rempel-privat.de --- drivers/net/wireless/ath/ath9k/eeprom_def.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/eeprom_def.c

Re: [PATCH v3 08/10] mac80211: add max. lossless throughput per rate to rc_stats

2015-03-21 Thread Felix Fietkau
On 2015-03-17 18:29, Thomas Huehn wrote: This patch adds the new statistic maximum possible lossless throughput to Minstrels and Minstrel-HTs rc_stats (in debugfs). This enables comprehensive comparison between current per-rate throughput and max. achievable per-rate throughput.

Re: [PATCH v2] mac80211: add an intermediate software queue implementation

2015-03-16 Thread Felix Fietkau
On 2015-03-16 08:25, Emmanuel Grumbach wrote: Hi Felix, Sorry, but I saw one small typo :) [snip] + +/** + * ieee80211_tx_dequeue - dequeue a packet from a software tx queue + * + * @hw: pointer as obtained from ieee80211_alloc_hw() + * @txq: pointer obtained from .add_tx_queue()

[PATCH v4] mac80211: add an intermediate software queue implementation

2015-03-17 Thread Felix Fietkau
latency. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 78 ++ net/mac80211/agg-tx.c | 42 + net/mac80211/driver-ops.h | 12 + net/mac80211/ieee80211_i.h | 24 ++ net/mac80211/iface.c | 19

[PATCH 4.0] ath9k: fix tracking of enabled AP beacons

2015-03-12 Thread Felix Fietkau
setup. To fix tracking of enabled beacons, convert cur_conf-enable_beacon to a bitmask of enabled beacon slots. Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/wireless/ath/ath9k/beacon.c | 20 drivers/net/wireless/ath/ath9k/common.h

Re: [PATCH v4 0/10] Improve Minstrels Minstrel-HTs common code base statistics

2015-03-24 Thread Felix Fietkau
. Acked-by: Felix Fietkau n...@openwrt.org -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v6] mac80211: add an intermediate software queue implementation

2015-03-27 Thread Felix Fietkau
latency. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 79 ++ net/mac80211/agg-tx.c | 44 + net/mac80211/driver-ops.h | 12 + net/mac80211/ieee80211_i.h | 21 net/mac80211/iface.c | 21

Re: [ath9k-devel] AR9462 problems connecting again..

2015-02-24 Thread Felix Fietkau
On 2015-02-25 07:14, Jouni Malinen wrote: On Tue, Feb 24, 2015 at 06:54:47PM +0100, Thomas Hühn wrote: Currently Minstrel_HT just skips EAPOL packets for its rate sampling on non-mrr chips by testing: (info-control.flags IEEE80211_TX_CTRL_PORT_CTRL_PROTO) Yeah, I noticed that when going

[PATCH v7] mac80211: add an intermediate software queue implementation

2015-03-27 Thread Felix Fietkau
latency. Signed-off-by: Felix Fietkau n...@openwrt.org --- include/net/mac80211.h | 79 ++ net/mac80211/agg-tx.c | 44 + net/mac80211/driver-ops.h | 12 + net/mac80211/ieee80211_i.h | 21 net/mac80211/iface.c | 23

Re: [PATCH v4] mac80211: add an intermediate software queue implementation

2015-03-18 Thread Felix Fietkau
On 2015-03-18 20:41, Johannes Berg wrote: + * The driver is expected to release its own buffered frames and also call + * ieee80211_tx_dequeue() within that callback. Perhaps that should read The driver is expected to release its own buffered frames (if any) and request the remaining

Re: [PATCH v4] mac80211: add an intermediate software queue implementation

2015-03-18 Thread Felix Fietkau
On 2015-03-18 21:07, Johannes Berg wrote: On Wed, 2015-03-18 at 21:03 +0100, Felix Fietkau wrote: On 2015-03-18 20:41, Johannes Berg wrote: + * The driver is expected to release its own buffered frames and also call + * ieee80211_tx_dequeue() within that callback. Perhaps that should

[PATCH 1/2] bcma: use absolute base for SoC GPIO pins

2015-04-15 Thread Felix Fietkau
On some BCM5301x ARM devices, user space still needs to control some system GPIO pins for which no driver exists. This is a lot easier to do with a predictable GPIO base. Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/bcma/driver_gpio.c | 19 ++- 1 file changed, 10

[PATCH 2/2] bcma: enable 32 GPIO pins for BCM4707

2015-04-15 Thread Felix Fietkau
Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/bcma/driver_gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bcma/driver_gpio.c b/drivers/bcma/driver_gpio.c index 9b8d9bf..5f6018e 100644 --- a/drivers/bcma/driver_gpio.c +++ b/drivers/bcma/driver_gpio.c @@ -226,6 +226,7

Re: [PATCH 1/2] bcma: use absolute base for SoC GPIO pins

2015-04-15 Thread Felix Fietkau
On 2015-04-15 16:33, Rafał Miłecki wrote: On 15 April 2015 at 15:07, Felix Fietkau n...@openwrt.org wrote: @@ -235,16 +235,17 @@ int bcma_gpio_init(struct bcma_drv_cc *cc) } /* -* On MIPS we register GPIO devices (LEDs, buttons) using absolute GPIO -* pin

  1   2   3   4   5   6   7   >