On 03/19/2018 07:10 AM, Alexey Roslyakov wrote:
> Hi Arend,
> I appreciate your response. In my opinion, it has nothing to do with
> SDIO host, because it defines "quirks" in the driver itself.
It is not clear to me from your patch series whether the problem is that:
- the SDIO device has a speci
On 04/17/2018 06:49 PM, gree...@candelatech.com wrote:
> From: Ben Greear
>
> This is similar to ETHTOOL_GSTATS, but it allows you to specify
> flags. These flags can be used by the driver to decrease the
> amount of stats refreshed. In particular, this helps with ath10k
> since getting the fir
On 09/19/2016 04:09 AM, Arend van Spriel wrote:
> This series consist of:
> * fixes for several issues found by Coverity.
> * ignore 802.11d configuration if not supported in firmware.
> * remove worker from netdev callback.
Thanks for doing this, can you also provide the coverity id when
relevant
sure if we actually care about any kind of initial, value, but if we don't,
then the fix should be fairly obvious.
Thanks!
Florian Fainelli (4):
brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain
brcmsmac: Free packet if dma_mapping_error() fails in dma_rxfill
brcmsmac: Fix in
Signed-off-by: Florian Fainelli
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index c4
struct ieee80211_rts::ra is only ETH_ALEN wide, yet we attempt to copy 2
* ETH_ALEN, which will potentially overrun the destination buffer.
Reported-by: coverity (CID 145657)
Fixes: 5b435de0d7868 ("net: wireless: add brcm80211 drivers")
Signed-off-by: Florian Fainelli
---
drivers/ne
CID 146011)
Fixes: 5b435de0d7868 ("net: wireless: add brcm80211 drivers")
Signed-off-by: Florian Fainelli
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/stf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/stf.c
In case dma_mapping_error() returns an error in dma_rxfill, we would be
leaking a packet that we allocated with brcmu_pkt_buf_get_skb().
Reported-by: coverity (CID 1081819)
Fixes: 67d0cf50bd32 ("brcmsmac: Fix WARNING caused by lack of calls to
dma_mapping_error()")
Signed-off-b
On 07/19/2016 02:20 AM, Arend Van Spriel wrote:
> + Bob
>
> On 19-7-2016 1:24, Florian Fainelli wrote:
>> Hi,
>>
>> This patch series addresses several coverity issues, they all seemed relevant
>> to me.
>
> Hi Florian,
>
> Been a while so ni
On 07/19/2016 03:38 AM, Arend Van Spriel wrote:
> On 19-7-2016 1:24, Florian Fainelli wrote:
>> struct ieee80211_rts::ra is only ETH_ALEN wide, yet we attempt to copy 2
>> * ETH_ALEN, which will potentially overrun the destination buffer.
>
> NACK - this is intentional. Have
On 07/19/2016 11:21 AM, Arend Van Spriel wrote:
> On 19-7-2016 18:41, Florian Fainelli wrote:
>> On 07/19/2016 02:20 AM, Arend Van Spriel wrote:
>>> + Bob
>>>
>>> On 19-7-2016 1:24, Florian Fainelli wrote:
>>>> Hi,
>>>>
>>>&
On 07/19/2016 12:36 PM, Arend Van Spriel wrote:
> On 19-7-2016 20:30, Florian Fainelli wrote:
>> On 07/19/2016 11:21 AM, Arend Van Spriel wrote:
>>> On 19-7-2016 18:41, Florian Fainelli wrote:
>>>> On 07/19/2016 02:20 AM, Arend Van Spriel wrote:
>>>>>
doesn't conflict with what's already in net-next...
For the entire series:
Acked-by: Florian Fainelli
Thanks a lot for doing that.
>
> arch/mips/cavium-octeon/octeon-platform.c | 4
> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1
From: Russell King
drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration
of function 'try_module_get' [-Werror=implicit-function-declaration]
Add linux/module.h to iscsi_target_login.c.
Signed-off-by: Russell King
Reviewed-by: Bart Van Assche
---
drivers/target/iscsi
From: Russell King
drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing
pointer to incomplete type 'struct fixed_phy_status'
Add linux/phy_fixed.h to fman_memac.c
Signed-off-by: Russell King
---
drivers/net/ethernet/freescale/fman/fman_memac.c | 1 +
1 file changed,
From: Russell King
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected
declaration specifiers or '...' before string constant
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition
has no type or storage class
drivers/net/ethernet/cavium/liquidio/lio_
From: Russell King
drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status'
isn't known
drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed'
isn't known
drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has
initializer but
time difference is noticable.
Tested-by: Vivien Didelot
Reviewed-by: Florian Fainelli
Signed-off-by: Russell King
---
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
include/net/dsa.h | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88
From: Russell King
drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to
incomplete type 'struct mii_bus'
drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of
function 'phy_start' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broad
From: Russell King
octeon-platform.c can not be built as a module for two reasons:
(a) the Makefile doesn't allow it:
obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o
(b) the multiple *_initcall() statements, each of which are translated
to a module_init() call when a
From: Russell King
Fix these errors reported by the 0-day builder by replacing the
linux/export.h include with linux/module.h.
In file included from include/linux/platform_device.h:14:0,
from drivers/net/wireless/ath/ath5k/ahb.c:20:
include/linux/device.h:1463:1: warning: data d
From: Russell King
Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc
code:
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put':
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration
of function 'module_put' [-Werror=implicit-f
From: Russell King
drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of
declaration
drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of
struct-union-enum-specifier
drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface
drivers/net/ethernet
From: Russell King
drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration
drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of
struct-union-enum-specifier
drivers/net/usb/lan78xx.c:394:33: sparse: got interface
drivers/net/usb/lan78xx.c:403:1: sparse: Expected ; at
Hi all,
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
unnecessary dependency for quite a large amount of the kernel. There's
very little which actually requires definitions from phy.h in net/dsa.h
- the include itself only wants the declaration of a couple of
structures an
From: Russell King
net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or
'...' before string constant
MODULE_LICENSE("GPL v2");
^~~~
Add linux/module.h to fix this.
Signed-off-by: Russell King
---
net/core/netprio_cgroup.c | 1 +
1 file change
On 02/08/2017 08:11 AM, Kalle Valo wrote:
> David Miller writes:
>
>> From: Florian Fainelli
>> Date: Tue, 7 Feb 2017 15:02:53 -0800
>>
>>> I'm hoping this doesn't conflict with what's already in net-next...
>>>
>>> David, this
On 02/10/2017 10:51 AM, David Miller wrote:
> From: Kalle Valo
> Date: Thu, 09 Feb 2017 16:10:06 +0200
>
>> Florian Fainelli writes:
>>
>>>>> If not, for something like this it's a must:
>>>>>
>>>>> drivers/net/wireles
Hi,
(sorry for the cross post)
I am at v4.14-12995-g0c86a6bd85ff and just met the following, attached
is my .config file. Is this a known problem? Thanks!
[1.798714] cfg80211: Loading compiled-in X.509 certificates for
regulatory database
[1.809390] [ cut here ]
[
On 11/22/2017 10:42 AM, Johannes Berg wrote:
> On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote:
>> + Johannes
>>
>> >>> BUG_ON(!sig->digest);
>> BUG_ON(!sig->s);
>
> I *think* this is the same bug that was reported before, then this
> should fix it:
>
> https://git.kernel.
On 11/23/2017 06:24 AM, Johannes Berg wrote:
> On Wed, 2017-11-22 at 15:07 -0800, Florian Fainelli wrote:
>> On 11/22/2017 10:42 AM, Johannes Berg wrote:
>>> On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote:
>>>> + Johannes
>>>>
>>>&g
one may need
> to add the right algorithms.
>
> Reported-by: Florian Fainelli
> Signed-off-by: Johannes Berg
Tested-by: Florian Fainelli
Thanks for the quick fix!
> ---
> net/wireless/Kconfig | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git
Le 01/05/18 à 17:09, Dan Williams a écrit :
> Quoting Mark's original RFC:
>
> "Recently, Google Project Zero discovered several classes of attack
> against speculative execution. One of these, known as variant-1, allows
> explicit bounds checks to be bypassed under speculation, providing an
> arb
On 02/04/2018 10:58 AM, Chris Vine wrote:
> I probably should have copied this to the relevant kernel wireless
> mailing lists. Anyway, here it is.
>
> As a further datum point, the b43 driver works fine with the 4.15.0-rc3
> kernel. So something seems to have changed between that and 4.15.0.
D
On 18/11/15 11:19, Hauke Mehrtens wrote:
> On 11/18/2015 03:45 PM, Kalle Valo wrote:
>> Part of reorganising wireless drivers directory and Kconfig. Note that I had
>> to
>> edit Makefiles from subdirectories to use the new location.
>>
>> Signed-off-by: Kalle Valo
>> ---
>
> I would prefer to r
On 02/02/15 14:06, Peter Oh wrote:
>
> On 02/02/2015 11:47 AM, Johannes Berg wrote:
>> On Mon, 2015-02-02 at 11:36 -0800, Peter Oh wrote:
>>> On 02/02/2015 11:22 AM, Johannes Berg wrote:
>> You basically have the following sequence:
>>
>> iowrite()
>> ioread()
>>
>> If you
On 10/10/2017 12:35 PM, Jes Sorensen wrote:
> On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> While this isn't harmful, to me this looks like pointless patch churn
> for zero g
On 06/02/2017 10:22 AM, Peter S. Housel wrote:
> An earlier change to this function (3bdae810721b) fixed a leak in the
> case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the
> glob_skb buffer, used for emulating a scattering read, is never used
> or referenced after its contents are c
Broadcom BCM53573 SoCs actually have 32 GPIOs, and not 16.
Fixes: 3f37ec79dd21 ("bcma: support BCM53573 series of wireless SoCs")
Signed-off-by: Florian Fainelli
---
drivers/bcma/driver_gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bcma/driver_gpio.c b/dr
On 06/30/2017 02:37 PM, Rafał Miłecki wrote:
> On 30 June 2017 at 21:02, Florian Fainelli wrote:
>> Broadcom BCM53573 SoCs actually have 32 GPIOs, and not 16.
>>
>> Fixes: 3f37ec79dd21 ("bcma: support BCM53573 series of wireless SoCs")
>> Signed-off-by: F
40 matches
Mail list logo
